maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #51498 from codecat/fix-triple-click

Browse source 
Triple click in text editor now uses last mouse position for validity
This commit is contained in:
Rémi Verschelde 2021-08-11 23:44:55 +02:00 committed by GitHub
parent 18fb585b74 408401a642
commit 7188cb6012
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
scene/gui/text_edit.cpp
View file

@ -2246,7 +2246,10 @@ void TextEdit::_gui_input(const Ref<InputEvent> &p_gui_input) {
selection.selecting_column = col;
}
if (!mb->is_double_click() && (OS::get_singleton()->get_ticks_msec() - last_dblclk) < 600 && cursor.line == prev_line) {
const int triple_click_timeout = 600;
const int triple_click_tolerance = 5;
if (!mb->is_double_click() && (OS::get_singleton()->get_ticks_msec() - last_dblclk) < triple_click_timeout && mb->get_position().distance_to(last_dblclk_pos) < triple_click_tolerance) {
// Triple-click select line.
selection.selecting_mode = SelectionMode::SELECTION_MODE_LINE;
_update_selection_mode_line();
@ -2256,6 +2259,7 @@ void TextEdit::_gui_input(const Ref<InputEvent> &p_gui_input) {
selection.selecting_mode = SelectionMode::SELECTION_MODE_WORD;
_update_selection_mode_word();
last_dblclk = OS::get_singleton()->get_ticks_msec();
last_dblclk_pos = mb->get_position();
}
update();

1
scene/gui/text_edit.h
View file

@ -308,6 +308,7 @@ private:
String lookup_symbol_word;
uint64_t last_dblclk = 0;
Vector2 last_dblclk_pos;
Timer *idle_detect;
Timer *click_select_held;