Merge pull request #51228 from timothyqiu/inspector-update

Disable save button when Inspector is not editing anything
This commit is contained in:
Rémi Verschelde 2021-08-04 09:28:56 +02:00 committed by GitHub
commit 7eedc2c348
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -408,22 +408,12 @@ void InspectorDock::update(Object *p_object) {
current = p_object; current = p_object;
if (!p_object) { const bool is_object = p_object != nullptr;
open_docs_button->set_disabled(true); const bool is_resource = is_object && p_object->is_class("Resource");
object_menu->set_disabled(true); const bool is_node = is_object && p_object->is_class("Node");
warning->hide();
search->set_editable(false);
editor_path->clear_path();
return;
}
bool is_resource = p_object->is_class("Resource");
bool is_node = p_object->is_class("Node");
object_menu->set_disabled(false);
search->set_editable(true);
editor_path->enable_path();
object_menu->set_disabled(!is_object);
search->set_editable(is_object);
resource_save_button->set_disabled(!is_resource); resource_save_button->set_disabled(!is_resource);
open_docs_button->set_disabled(!is_resource && !is_node); open_docs_button->set_disabled(!is_resource && !is_node);
@ -431,6 +421,14 @@ void InspectorDock::update(Object *p_object) {
resource_extra_popup->set_item_disabled(resource_extra_popup->get_item_index(RESOURCE_COPY), !is_resource); resource_extra_popup->set_item_disabled(resource_extra_popup->get_item_index(RESOURCE_COPY), !is_resource);
resource_extra_popup->set_item_disabled(resource_extra_popup->get_item_index(RESOURCE_MAKE_BUILT_IN), !is_resource); resource_extra_popup->set_item_disabled(resource_extra_popup->get_item_index(RESOURCE_MAKE_BUILT_IN), !is_resource);
if (!is_object) {
warning->hide();
editor_path->clear_path();
return;
}
editor_path->enable_path();
PopupMenu *p = object_menu->get_popup(); PopupMenu *p = object_menu->get_popup();
p->clear(); p->clear();