Merge pull request #53026 from kleonc/texture-preview-updating-3x

This commit is contained in:
Rémi Verschelde 2021-09-24 23:15:12 +02:00 committed by GitHub
commit 86944daafd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 10 deletions

View file

@ -62,6 +62,25 @@ void TexturePreview::_notification(int p_what) {
}
}
void TexturePreview::_update_metadata_label_text() {
Ref<Texture> texture = texture_display->get_texture();
String format;
if (Object::cast_to<ImageTexture>(*texture)) {
format = Image::get_format_name(Object::cast_to<ImageTexture>(*texture)->get_format());
} else if (Object::cast_to<StreamTexture>(*texture)) {
format = Image::get_format_name(Object::cast_to<StreamTexture>(*texture)->get_format());
} else {
format = texture->get_class();
}
metadata_label->set_text(itos(texture->get_width()) + "x" + itos(texture->get_height()) + " " + format);
}
void TexturePreview::_bind_methods() {
ClassDB::bind_method(D_METHOD("_update_metadata_label_text"), &TexturePreview::_update_metadata_label_text);
}
TexturePreview::TexturePreview(Ref<Texture> p_texture, bool p_show_metadata) {
checkerboard = memnew(TextureRect);
checkerboard->set_stretch_mode(TextureRect::STRETCH_TILE);
@ -78,16 +97,8 @@ TexturePreview::TexturePreview(Ref<Texture> p_texture, bool p_show_metadata) {
if (p_show_metadata) {
metadata_label = memnew(Label);
String format;
if (Object::cast_to<ImageTexture>(*p_texture)) {
format = Image::get_format_name(Object::cast_to<ImageTexture>(*p_texture)->get_format());
} else if (Object::cast_to<StreamTexture>(*p_texture)) {
format = Image::get_format_name(Object::cast_to<StreamTexture>(*p_texture)->get_format());
} else {
format = p_texture->get_class();
}
metadata_label->set_text(itos(p_texture->get_width()) + "x" + itos(p_texture->get_height()) + " " + format);
_update_metadata_label_text();
p_texture->connect("changed", this, "_update_metadata_label_text");
// It's okay that these colors are static since the grid color is static too.
metadata_label->add_color_override("font_color", Color::named("white"));

View file

@ -44,8 +44,11 @@ private:
TextureRect *checkerboard = nullptr;
Label *metadata_label = nullptr;
void _update_metadata_label_text();
protected:
void _notification(int p_what);
static void _bind_methods();
public:
TextureRect *get_texture_display();