maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Update mesh AABB when software skinning is used

Browse source 
Not updating the mesh properly can cause rendering issues in some cases,
like shadows not updating properly.
This commit is contained in:
PouleyKetchoupp 2021-09-27 11:56:58 -07:00
parent dd0ee48728
commit 941cff4157
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
scene/3d/mesh_instance.cpp
View file

@ -390,6 +390,9 @@ void MeshInstance::_update_skinning() {
RID skeleton = skin_ref->get_skeleton(); RID skeleton = skin_ref->get_skeleton();
ERR_FAIL_COND(!skeleton.is_valid()); ERR_FAIL_COND(!skeleton.is_valid());
AABB aabb;
bool first_vertex = true;
VisualServer *visual_server = VisualServer::get_singleton(); VisualServer *visual_server = VisualServer::get_singleton();
// Prepare bone transforms. // Prepare bone transforms.
@ -499,11 +502,20 @@ void MeshInstance::_update_skinning() {
tangent = transform.basis.xform(tangent_read); tangent = transform.basis.xform(tangent_read);
} }
} }
if (first_vertex) {
aabb.position = vertex;
first_vertex = false;
} else {
aabb.expand_to(vertex);
}
} }
visual_server->mesh_surface_update_region(mesh_rid, surface_index, 0, buffer); visual_server->mesh_surface_update_region(mesh_rid, surface_index, 0, buffer);
} }
visual_server->mesh_set_custom_aabb(mesh_rid, aabb);
software_skinning_flags |= SoftwareSkinning::FLAG_BONES_READY; software_skinning_flags |= SoftwareSkinning::FLAG_BONES_READY;
} }