maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #29831 from YeldhamDev/range_changed_signal_fix

Browse source 
Fix Range's "changed" signal emitting with a value even if binded to emit none
This commit is contained in:
Rémi Verschelde 2019-06-17 11:05:28 +02:00 committed by GitHub
parent b5459d9f0a 98d0c99652
commit 9b30b9d010
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
scene/gui/range.cpp
View file

@ -63,7 +63,7 @@ void Range::Shared::emit_value_changed() {
void Range::_changed_notify(const char *p_what) {
emit_signal("changed", shared->val);
emit_signal("changed");
update();
_change_notify(p_what);
}
@ -79,6 +79,7 @@ void Range::Shared::emit_changed(const char *p_what) {
}
void Range::set_value(double p_val) {
if (shared->step > 0)
p_val = Math::round(p_val / shared->step) * shared->step;
@ -303,22 +304,27 @@ bool Range::is_ratio_exp() const {
}
void Range::set_allow_greater(bool p_allow) {
shared->allow_greater = p_allow;
}
bool Range::is_greater_allowed() const {
return shared->allow_greater;
}
void Range::set_allow_lesser(bool p_allow) {
shared->allow_lesser = p_allow;
}
bool Range::is_lesser_allowed() const {
return shared->allow_lesser;
}
Range::Range() {
shared = memnew(Shared);
shared->min = 0;
shared->max = 100;