maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #37295 from SkyLucilfer/AndroidExportValidation

Browse source 
Validate supported architectures when exporting to Android
This commit is contained in:
Rémi Verschelde 2020-04-13 13:56:48 +02:00 committed by GitHub
parent 5247fdb3f3 7fcd13575e
commit d4b211bb3d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
platform/android/export/export.cpp
View file

@ -1932,6 +1932,7 @@ public:
ImageLoader::load_image(path, launcher_adaptive_icon_background_image);
}
Vector<String> invalid_abis(enabled_abis);
while (ret == UNZ_OK) {
//get filename
@ -1977,6 +1978,7 @@ public:
bool enabled = false;
for (int i = 0; i < enabled_abis.size(); ++i) {
if (file.begins_with("lib/" + enabled_abis[i] + "/")) {
invalid_abis.erase(enabled_abis[i]);
enabled = true;
break;
}
@ -2016,6 +2018,13 @@ public:
ret = unzGoToNextFile(pkg);
}
if (!invalid_abis.empty()) {
String unsupported_arch = String(", ").join(invalid_abis);
EditorNode::add_io_error("Missing libraries in the export template for the selected architectures: " + unsupported_arch + ".\n" +
"Please build a template with all required libraries, or uncheck the missing architectures in the export preset.");
CLEANUP_AND_RETURN(ERR_FILE_NOT_FOUND);
}
if (ep.step("Adding files...", 1)) {
CLEANUP_AND_RETURN(ERR_SKIP);
}