maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #21239 from Calinou/fix-assetlib-download-crash

Browse source 
Fix occasional crash when downloading assets from the Asset Library
This commit is contained in:
Rémi Verschelde 2018-08-21 00:06:33 +02:00 committed by GitHub
parent d88d0d457d dd4fe8588b
commit d8032dfdd5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
editor/plugins/asset_library_editor_plugin.cpp
View file

@ -421,7 +421,16 @@ void EditorAssetLibraryItemDownload::_notification(int p_what) {
int cstatus = download->get_http_client_status();
if (cstatus == HTTPClient::STATUS_BODY) {
status->set_text(vformat(TTR("Downloading (%s / %s)..."), String::humanize_size(download->get_downloaded_bytes()), String::humanize_size(download->get_body_size())));
if (download->get_body_size() > 0) {
status->set_text(
vformat(
TTR("Downloading (%s / %s)..."),
String::humanize_size(download->get_downloaded_bytes()),
String::humanize_size(download->get_body_size())));
} else {
// Total file size is unknown, so it cannot be displayed
status->set_text(TTR("Downloading..."));
}
}
if (cstatus != prev_status) {