Rémi Verschelde
ecbaa6e8a0
Fix potential divisions by 0 reported by MSVC
...
The `TextEdit` one was indeed a potential bug.
The `PCKPacker` one seems to be a false positive, it's already in a
`for` loop that depends on `files.size()`.
(cherry picked from commit ca4e4506db
)
2020-05-25 17:55:07 +02:00
Jóhannes Gunnar Þorsteinsson
6322c783a3
Add apply method to SpinBox
2020-02-28 12:49:01 -05:00
Rémi Verschelde
227a81c119
Range: Properly bind value emitted by 'changed' signal
...
This was fixed in the `master` branch by removing the value in #29831 ,
but for `3.1` we preserve compatibility, even if redundant with
'value_changed'.
Fixes #35395 .
2020-01-21 09:25:08 +01:00
Gwyneth Lowe
7a9eb587fd
Correct typo that broke custom selected font color
...
Change several font_selected_color to font_color_selected; the actual name of the override
(cherry picked from commit 7142064110
)
2019-11-12 13:09:35 +01:00
Paulb23
8148732bd1
Fix TextEdit cursor.column having a negative value
...
(cherry picked from commit 1d55207fd2
)
2019-11-12 13:09:35 +01:00
qarmin
1d2aaa447e
Fix RichLabelText::_process_line crash
...
(cherry picked from commit 685451967c
)
2019-11-12 13:09:35 +01:00
qarmin
8423d98e1c
Fix crash with get_keywords_color
...
(cherry picked from commit 8d993f6357
)
2019-11-12 13:09:35 +01:00
bruvzg
dce7311aa5
Fix third and fourth level (AltGr / ⌥ modifier) keys input in LineEdit.
...
(cherry picked from commit 63d8dc0920
)
2019-11-12 13:09:35 +01:00
Tomasz Chabora
e66122e0bf
Fixed get_item_at_position being weird
...
(cherry picked from commit 59f403de0b
)
2019-11-12 11:47:55 +01:00
Paulb23
909a1cced8
Fix text_edit drawing incorrect chars when syntax highlighting enabled
...
(cherry picked from commit a8a0392c12
)
2019-11-12 11:26:14 +01:00
PouleyKetchoupp
9360b23544
Fixed crash when pressing down key on empty Tree
...
Fixes #33554
(cherry picked from commit 47a4ca0022
)
2019-11-12 08:41:00 +01:00
Cameron Reikes
15be90bbf3
Same method when redrawing as when theme changed
...
(cherry picked from commit c123a8c4f5
)
2019-11-08 15:48:19 +01:00
ternvein
82f65f5b92
FIX: Tabs text translation
...
(cherry picked from commit 118940e7c5
)
2019-11-08 15:48:18 +01:00
Michael Alexsander Silva Dias
5d1697b78f
Fix 'TabContainer' not updating its tab titles when locale is changed
...
(cherry picked from commit a242bf464a
)
2019-11-08 15:48:18 +01:00
ternvein
605dbffe93
FIX: WindowDialog title translation
...
(cherry picked from commit efc8314516
)
2019-11-08 15:48:18 +01:00
Michael Alexsander Silva Dias
f915d69e05
Update WindowDialog title when translation changes
...
(cherry picked from commit 06a890f7a3
)
2019-11-08 15:48:18 +01:00
Rémi Verschelde
b70788b4ad
PopupMenu: Fix missing text/xl_text when using add_shortcut
...
Use macros to ensure that `text`, `xl_text` and `id` are always set
using the same logic.
Fixes #25519 .
Also fixes up #26914 when `p_id == -1` handling was only added for a
couple methods instead of all of them.
(cherry picked from commit 58dd5d0c78
)
2019-11-08 15:48:18 +01:00
Michael Alexsander Silva Dias
cd1bb5d3db
Make 'TabContainer' update when icon/title is changed
...
Fixes #28655 .
(cherry picked from commit 37f4d51a75
)
2019-09-26 14:48:35 +02:00
xDGameStudios
6b07e4b535
Fixed optional idx argument in add_item (OptionMeny & PopupMenu)
...
(cherry picked from commit ffc5f360e8
)
2019-09-26 14:32:01 +02:00
Carsten Klein
693f3c9d62
Call minimum_size_changed() on redo/undo if expand_to_text_length is true
...
Fixes #28241
(cherry picked from commit da2a0a3814
)
2019-09-24 09:00:45 +02:00
Michael Alexsander Silva Dias
660acc3913
Fix 'LineEdit' offset limit not accounting for the right/clear icon width
...
Fully fixes #28242 .
(cherry picked from commit ac1c523989
)
2019-09-24 09:00:45 +02:00
Michael Alexsander Silva Dias
8e7f5c8628
Fix 'LineEdit' contents not ending before the clear button if no right icon was set
...
Fixes #28242 .
(cherry picked from commit d84acb98d0
)
2019-09-24 09:00:45 +02:00
Rémi Verschelde
fc18d637a8
Fix -Wimplicit-fallthrough warnings from GCC 8
...
Adds `FALLTHROUGH` macro to specify when a fallthrough is intentional.
Can be replaced by `[[fallthrough]]` if/when we switch to C++17.
The warning is now enabled by default for GCC on `extra` warnings level
(part of GCC's `-Wextra`). It's not enabled in Clang's `-Wextra` yet,
but we could enable it manually once we switch to C++11. There's no
equivalent feature in MSVC for now.
Fixes #26135 .
(cherry picked from commit fc370b3feb
)
2019-09-24 09:00:45 +02:00
qarmin
3b703d6707
Small fixes, mostly dupicated code
...
(cherry picked from commit 856a8226a5
)
2019-09-24 09:00:45 +02:00
Paul Trojahn
f5def1329e
Support UTF-8 in TextEdit and LineEdit navigation
...
This allows jumps over whole non ASCII words with Ctrl+Left/Right in
a LineEdit or TextEdit.
Fixes #25681
(cherry picked from commit 8851e16f75
)
2019-09-24 09:00:44 +02:00
Emmanuel Barroga
45e4f467e7
Fix ProgressBar Wrong Value with Border
...
Closes : #30969
The FG rectangle of the progressbar is incorrect when dealing with a non-zero border. This issue stems from wrong order of operations when drawing the rectangle: int p = r * get_size().width - mp;
(cherry picked from commit 7db96e22dd
)
2019-09-24 09:00:44 +02:00
Rémi Verschelde
4764e17970
Revert "Added the ability to change the default cursor property for the RichTextLabel component."
...
This reverts commit 4fda05e15f
.
2019-04-23 16:01:16 +02:00
groud
4be1343f3c
Enhance tree scrolling when dragging
...
(cherry picked from commit 14a901e88f
)
2019-04-20 22:00:35 +02:00
Robear Selwans
96222dedb5
Fixed an issue where changing the default_cursor on the RichTextLabel's meta_hover_ended caused the entire project to crash
...
(cherry picked from commit 84dfb3ff2d
)
2019-04-20 20:09:57 +02:00
Hugo Locurcio
67dc8cf252
Use the editor theme's accent color for 2D/3D selections and rotations
...
(cherry picked from commit d59b210aec
)
2019-04-06 21:18:20 +02:00
marxin
4889c65922
Fix -Wnon-virtual-dtor warnings.
...
Example of the warning:
./core/script_language.h:198:7: warning: 'class ScriptCodeCompletionCache' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
(cherry picked from commit f9f2413e69
)
2019-04-03 17:01:04 +02:00
Paulb23
4eefd2d581
Fixed not deselecting when clearing lineedit.
...
(cherry picked from commit bfba1e36bc
)
2019-04-03 17:00:45 +02:00
K. S. Ernest (iFire) Lee
804b68c981
Fix scaling issue for texture button focus texture.
...
(cherry picked from commit 1971c09e5e
)
2019-04-01 11:14:34 +02:00
qarmin
5650c1ecde
Fix inspector update after changing anchor via buttons
...
(cherry picked from commit 8b391b9ab0
)
2019-04-01 11:13:20 +02:00
Robear Selwans
4fda05e15f
Added the ability to change the default cursor property for the RichTextLabel component.
...
(cherry picked from commit b852a7a854
)
2019-04-01 11:10:04 +02:00
Bojidar Marinov
964152ed71
Fix cursor going to start while editing GraphNode's title
...
Fixes #26816
2019-03-10 12:22:15 +02:00
Rémi Verschelde
e28e849012
Merge pull request #21534 from volzhs/fix-scrollcontainer-size
...
Precise size calculation of ScrollContainer
2019-03-07 14:19:43 +01:00
Juan Linietsky
5f079e2ef9
-Make tileset and meshlibrary edit in a separate inspector, fixes #26671
...
-Made relationship lines appear based on theme settings, not previous hack
-Fix drawing of relationship lines (was broken)
-Fix double initialization of theme settings
2019-03-06 12:12:42 -03:00
Rémi Verschelde
4ab4ff67ff
Merge pull request #26642 from DrMoriarty/check_cursor_line
...
Check cursor line and column
2019-03-05 22:57:55 +01:00
Vasiliy Makarov
a3d9b7d916
Check cursor line and column
...
Added a trivial check if cursor.line and cursor.column are valid.
Fix #26245
2019-03-05 18:27:37 +03:00
Michael Alexsander Silva Dias
a292d1fefb
Fix general issues with filesystem-related UI components in the editor
2019-03-05 10:12:06 -03:00
Juan Linietsky
6b8b1cabae
Add a warning when using plain Container, as many users seem to misunderstand what this is.
2019-03-03 16:00:56 -03:00
Juan Linietsky
51b80f6857
Fixed some crashers, closes #26393
2019-03-01 17:24:57 -03:00
Rémi Verschelde
994bdc9adc
Merge pull request #26140 from karliss/meta-item
...
Use correct meta item in rich text.
2019-03-01 18:16:27 +01:00
Justin Vesper
079ed007c8
Fixed wrong method binding in control
...
Control.get_parent_area_size() is now bound to
Control::get_parent_area_size() instead of Control::get_size()
2019-03-01 14:16:19 +01:00
Bojidar Marinov
a7b564db6e
Fix minimum size of ProgressBar-s
...
Was a leftover from 0a1c1c660f
.
Fixes #21633 .
2019-02-27 15:56:49 +02:00
Bojidar Marinov
8dad5f1e10
Update controls when a stylebox or icon override changes; change to CONNECT_REFERENCE_COUNTED
...
Also, cleanup unnessesary calls to update() and NOTIFICATION_THEME_CHANGED.
Fixes #25904 .
2019-02-25 17:42:38 +02:00
Michael Alexsander Silva Dias
52abab5aa7
Make 'SplitContainer' update drawing only if actually needs to
2019-02-22 10:12:39 -03:00
Michael Alexsander Silva Dias
f2f09f00b7
Fix 'SplitContainer's showing their handles when they shouldn't
...
Fixes #25735 .
2019-02-21 23:01:30 -03:00
Kārlis Seņko
05f5774592
Use correct meta item in rich text.
...
Prevent incorrect static cast and unnecesarry meta_hover_ended/started
events.
2019-02-22 00:23:05 +02:00