maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
godot/core
History
Fabio Alessandrelli 5262d1bbcc Fix marshalls size checks. 
Yesterday, when playing around with my network code, I realized there is
a security issue in decode_variant, at least when decoding PoolArrays.
Basically, the size of the PoolArray is encoded in a uint32_t, when
decoding it, that value is cast to int when comparing if the packet is
actually that size causing numbers with MSB=1 to be interpreted as
negative thus always passing the check. That same value though, is used
as uint32_t again to resize the output vector.  For this reason, sending
a malformed packet with declared type PoolByteArray and size of 2^31(+x)
causes the engine to try to allocate 2+GB of pool memory, causing the
engine to crash.
2018-07-28 21:21:19 +02:00
..
bind Change ".." punctuation for "..." in editor strings (#16507) 2018-06-05 21:42:33 +02:00
helper Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
io Fix marshalls size checks. 2018-07-28 21:21:19 +02:00
math Vector3::round, Vector2::round & Vector2::ceil methods were added. 2018-06-01 18:08:29 +02:00
os Mono: Allow loading mscorlib from resources. 2018-06-13 11:57:40 +00:00
allocators.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
array.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
array.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
class_db.cpp Hand-merge API hash fixes #18514 2018-04-29 20:44:48 +02:00
class_db.h Added all missing VisualServer bindings 2018-02-19 22:13:44 +01:00
color.cpp Revert "Fix bad color to HTML conversion. Alpha channel was added before RGB." 2018-01-16 10:22:22 +01:00
color.h -Remove color operator clamping, which is unnecesary. Fixes #15184, fixes #14686. 2018-01-12 00:08:32 -03:00
color_names.inc Add missing map.h include in color defs 2017-01-15 12:51:47 +01:00
command_queue_mt.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
command_queue_mt.h Fix various valgrind reported uninitialized variable uses 2018-03-01 21:06:31 +01:00
compressed_translation.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
compressed_translation.h Fix typos with codespell 2018-02-22 12:17:06 +01:00
core_string_names.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
core_string_names.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
dictionary.cpp Add Dictionary::erase_checked(key) method 2018-07-28 16:06:30 +02:00
dictionary.h Add Dictionary::erase_checked(key) method 2018-07-28 16:06:30 +02:00
dvector.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
dvector.h Style: Format code with clang-format 6.0.1 2018-07-18 16:37:23 +02:00
engine.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
engine.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
error_list.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
error_macros.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
error_macros.h Fix typos with codespell 2018-02-22 12:17:06 +01:00
func_ref.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
func_ref.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
global_constants.cpp Fix typos with codespell 2018-02-22 12:17:06 +01:00
global_constants.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
hash_map.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
hashfuncs.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
image.cpp add condition check in Imgae::create(...) 2018-05-13 21:59:22 +02:00
image.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
input_map.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
input_map.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
int_types.h Update copyright statements to 2018 2018-01-01 14:40:47 +01:00
list.h Fix typos in code and docs with codespell 2018-01-18 22:01:42 +01:00
make_binders.py Added all missing VisualServer bindings 2018-02-19 22:13:44 +01:00
map.h Fix typos with codespell 2018-02-22 12:17:06 +01:00
message_queue.cpp Fix typos with codespell 2018-02-22 12:17:06 +01:00
message_queue.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
method_bind.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
method_bind.h Fix typos in code and docs with codespell 2018-01-18 22:01:42 +01:00
method_ptrcall.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
node_path.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
node_path.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
oa_hash_map.h Fix typos in code and docs with codespell 2018-01-18 22:01:42 +01:00
object.cpp Bind many more properties to scripts 2018-01-12 00:58:14 +02:00
object.h Make sure PropertyHint matches in the VisualScript editor. 2018-01-15 22:19:54 +01:00
ordered_hash_map.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
packed_data_container.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
packed_data_container.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
pair.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
path_remap.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
path_remap.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
pool_allocator.cpp Fix typos with codespell 2018-02-22 12:17:06 +01:00
pool_allocator.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
print_string.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
print_string.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
project_settings.cpp Fix non working action names containing whitespaces 2018-04-28 17:04:20 +02:00
project_settings.h Improve error reporting of ProjectSettings::setup() 2018-02-22 12:19:28 +01:00
ref_ptr.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
ref_ptr.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
reference.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
reference.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
register_core_types.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
register_core_types.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
resource.cpp Make cyclic resource inclusion error message more helpful 2018-01-18 18:35:24 +01:00
resource.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
rid.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
rid.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
ring_buffer.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
safe_refcount.cpp Fix inconsistencies and typos in argument names 2018-02-04 20:10:13 +01:00
safe_refcount.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
script_debugger_local.cpp Mono: Implement stack info for errors and exceptions 2018-01-09 17:19:03 +01:00
script_debugger_local.h Mono: Implement stack info for errors and exceptions 2018-01-09 17:19:03 +01:00
script_debugger_remote.cpp Fix debugger focus stealing 2018-07-08 15:39:15 +02:00
script_debugger_remote.h Fix debugger focus stealing 2018-07-08 15:39:15 +02:00
script_language.cpp Bind many more properties to scripts 2018-01-12 00:58:14 +02:00
script_language.h Mono: Avoid invalid class names. 2018-04-15 00:48:11 +02:00
SCsub add NoCache wrapper to Command 2018-06-22 14:42:14 +02:00
self_list.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
set.h Fix typos with codespell 2018-02-22 12:17:06 +01:00
simple_type.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
sort.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
string_buffer.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
string_buffer.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
string_builder.cpp fixed crash with StringBuilder 2018-01-20 15:26:58 +01:00
string_builder.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
string_db.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
string_db.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
translation.cpp Add locale renames for Hebrew and Indonesian on Windows 2018-02-19 22:27:19 +01:00
translation.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
type_info.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
typedefs.h Make _ALWAYS_INLINE_ and _FORCE_INLINE_ equivalent 2018-07-27 17:14:22 +02:00
ucaps.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
undo_redo.cpp obsolete UndoRedo max_steps; no users identified 2018-01-08 10:57:07 -06:00
undo_redo.h obsolete UndoRedo max_steps; no users identified 2018-01-08 10:57:07 -06:00
ustring.cpp fix API string path 2018-05-13 23:03:48 +02:00
ustring.h Mono: Better versioning and gracefully unloading of Godot API assemblies 2018-02-26 22:36:03 +01:00
variant.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
variant.h Fix typos with codespell 2018-02-22 12:17:06 +01:00
variant_call.cpp Vector3::round, Vector2::round & Vector2::ceil methods were added. 2018-06-01 18:08:29 +02:00
variant_construct_string.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
variant_op.cpp Fix names of Variant operators 2018-04-28 22:56:33 +02:00
variant_parser.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
variant_parser.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
vector.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
version.h Refactor version macros and fix related bugs 2018-02-24 01:34:34 +01:00
vmap.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
vset.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00