We will be progressively moving most code to C#. The plan is to only use Mono's embedding APIs to set things at launch. This will make it much easier to later support CoreCLR too which doesn't have rich embedding APIs. Additionally the code in C# is more maintainable and makes it easier to implement new features, e.g.: runtime codegen which we could use to avoid using reflection for marshaling everytime a field, property or method is accessed. SOME NOTES ON INTEROP We make the same assumptions as GDNative about the size of the Godot structures we use. We take it a bit further by also assuming the layout of fields in some cases, which is riskier but let's us squeeze out some performance by avoiding unnecessary managed to native calls. Code that deals with native structs is less safe than before as there's no RAII and copy constructors in C#. It's like using the GDNative C API directly. One has to take special care to free values they own. Perhaps we could use roslyn analyzers to check this, but I don't know any that uses attributes to determine what's owned or borrowed. As to why we maily use pointers for native structs instead of ref/out: - AFAIK (and confirmed with a benchmark) ref/out are pinned during P/Invoke calls and that has a cost. - Native struct fields can't be ref/out in the first place. - A `using` local can't be passed as ref/out, only `in`. Calling a method or property on an `in` value makes a silent copy, so we want to avoid `in`. REGARDING THE BUILD SYSTEM There's no longer a `mono_glue=yes/no` SCons options. We no longer need to build with `mono_glue=no`, generate the glue and then build again with `mono_glue=yes`. We build only once and generate the glue (which is in C# now). However, SCons no longer builds the C# projects for us. Instead one must run `build_assemblies.py`, e.g.: ```sh %godot_src_root%/modules/mono/build_scripts/build_assemblies.py \ --godot-output-dir=%godot_src_root%/bin \ --godot-target=release_debug` ``` We could turn this into a custom build target, but I don't know how to do that with SCons (it's possible with Meson). OTHER NOTES Most of the moved code doesn't follow the C# naming convention and still has the word Mono in the names despite no longer dealing with Mono's embedding APIs. This is just temporary while transitioning, to make it easier to understand what was moved where.
71 lines
2.4 KiB
C#
71 lines
2.4 KiB
C#
using System;
|
|
using System.Runtime.CompilerServices;
|
|
|
|
// ReSharper disable InconsistentNaming
|
|
|
|
namespace Godot.NativeInterop
|
|
{
|
|
internal static unsafe partial class NativeFuncs
|
|
{
|
|
public static godot_string_name godotsharp_string_name_new_copy(godot_string_name* src)
|
|
{
|
|
godot_string_name ret;
|
|
godotsharp_string_name_new_copy(&ret, src);
|
|
return ret;
|
|
}
|
|
|
|
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
|
public static godot_string_name godotsharp_string_name_new_copy(godot_string_name src)
|
|
=> godotsharp_string_name_new_copy(&src);
|
|
|
|
public static godot_node_path godotsharp_node_path_new_copy(godot_node_path* src)
|
|
{
|
|
godot_node_path ret;
|
|
godotsharp_node_path_new_copy(&ret, src);
|
|
return ret;
|
|
}
|
|
|
|
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
|
public static godot_node_path godotsharp_node_path_new_copy(godot_node_path src)
|
|
=> godotsharp_node_path_new_copy(&src);
|
|
|
|
public static godot_array godotsharp_array_new_copy(godot_array* src)
|
|
{
|
|
godot_array ret;
|
|
godotsharp_array_new_copy(&ret, src);
|
|
return ret;
|
|
}
|
|
|
|
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
|
public static godot_array godotsharp_array_new_copy(godot_array src)
|
|
=> godotsharp_array_new_copy(&src);
|
|
|
|
public static godot_dictionary godotsharp_dictionary_new_copy(godot_dictionary* src)
|
|
{
|
|
godot_dictionary ret;
|
|
godotsharp_dictionary_new_copy(&ret, src);
|
|
return ret;
|
|
}
|
|
|
|
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
|
public static godot_dictionary godotsharp_dictionary_new_copy(godot_dictionary src)
|
|
=> godotsharp_dictionary_new_copy(&src);
|
|
|
|
public static godot_string_name godotsharp_string_name_new_from_string(string name)
|
|
{
|
|
godot_string_name ret;
|
|
using godot_string src = Marshaling.mono_string_to_godot(name);
|
|
godotsharp_string_name_new_from_string(&ret, &src);
|
|
return ret;
|
|
}
|
|
|
|
public static godot_node_path godotsharp_node_path_new_from_string(string name)
|
|
{
|
|
godot_node_path ret;
|
|
using godot_string src = Marshaling.mono_string_to_godot(name);
|
|
godotsharp_node_path_new_from_string(&ret, &src);
|
|
return ret;
|
|
}
|
|
}
|
|
}
|