maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Time to Visualize] Fix Unsaved Changes Badge Appearing After Save & Return (#94529)

Browse source 
* fixed unsaved changes out of sync after save and return
This commit is contained in:
Devon Thomson 2021-03-15 12:51:59 -04:00 committed by GitHub
parent f62478452e
commit 644e08b94f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/plugins/dashboard/public/application/hooks/use_dashboard_container.ts
View file

@ -80,11 +80,7 @@ export const useDashboardContainer = ({
searchSession.restore(searchSessionIdFromURL);
}
// when dashboard state manager initially loads, determine whether or not there are unsaved changes
const incomingEmbeddable = getIncomingEmbeddable(true);
setUnsavedChanges?.(
Boolean(incomingEmbeddable) || dashboardStateManager.hasUnsavedPanelState()
);
let canceled = false;
let pendingContainer: DashboardContainer | ErrorEmbeddable | null | undefined;
@ -137,6 +133,7 @@ export const useDashboardContainer = ({
);
}
setDashboardContainer(pendingContainer);
setUnsavedChanges?.(dashboardStateManager.getIsDirty(data.query.timefilter.timefilter));
})();
return () => {
canceled = true;
@ -151,6 +148,7 @@ export const useDashboardContainer = ({
setDashboardContainer(null);
};
}, [
data.query.timefilter.timefilter,
dashboardCapabilities,
dashboardStateManager,
getIncomingEmbeddable,