maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix Add filter button doesnt close popup after openning (#111917)

Browse source 
Co-authored-by: Su Tran <sutranbmt@gmail.com>
This commit is contained in:
Su Tran 2021-10-26 22:08:03 +07:00 committed by GitHub
parent 3920918d3a
commit 84a3536fe4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/plugins/data/public/ui/filter_bar/filter_bar.tsx
View file

@ -55,6 +55,8 @@ function FilterBarUI(props: Props) {
} }
} }
const onAddFilterClick = () => setIsAddFilterPopoverOpen(!isAddFilterPopoverOpen);
function renderItems() { function renderItems() {
return props.filters.map((filter, i) => ( return props.filters.map((filter, i) => (
<EuiFlexItem key={i} grow={false} className="globalFilterBar__flexItem"> <EuiFlexItem key={i} grow={false} className="globalFilterBar__flexItem">
@ -81,7 +83,7 @@ function FilterBarUI(props: Props) {
const button = ( const button = (
<EuiButtonEmpty <EuiButtonEmpty
size="s" size="s"
onClick={() => setIsAddFilterPopoverOpen(true)} onClick={onAddFilterClick}
data-test-subj="addFilter" data-test-subj="addFilter"
className="globalFilterBar__addButton" className="globalFilterBar__addButton"
> >

1
test/accessibility/apps/filter_panel.ts
View file

@ -24,6 +24,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('a11y test on add filter panel', async () => { it('a11y test on add filter panel', async () => {
await PageObjects.discover.openAddFilterPanel(); await PageObjects.discover.openAddFilterPanel();
await a11y.testAppSnapshot(); await a11y.testAppSnapshot();
await PageObjects.discover.closeAddFilterPanel();
await filterBar.addFilter('OriginCityName', 'is', 'Rome'); await filterBar.addFilter('OriginCityName', 'is', 'Rome');
}); });

4
test/functional/page_objects/discover_page.ts
View file

@ -83,6 +83,10 @@ export class DiscoverPageObject extends FtrService {
await this.testSubjects.click('addFilter'); await this.testSubjects.click('addFilter');
} }
public async closeAddFilterPanel() {
await this.testSubjects.click('addFilter');
}
public async waitUntilSearchingHasFinished() { public async waitUntilSearchingHasFinished() {
await this.testSubjects.missingOrFail('loadingSpinner', { await this.testSubjects.missingOrFail('loadingSpinner', {
timeout: this.defaultFindTimeout * 10, timeout: this.defaultFindTimeout * 10,

1
test/functional/services/filter_bar.ts
View file

@ -199,5 +199,6 @@ export class FilterBarService extends FtrService {
public async selectIndexPattern(indexPatternTitle: string): Promise<void> { public async selectIndexPattern(indexPatternTitle: string): Promise<void> {
await this.testSubjects.click('addFilter'); await this.testSubjects.click('addFilter');
await this.comboBox.set('filterIndexPatternsSelect', indexPatternTitle); await this.comboBox.set('filterIndexPatternsSelect', indexPatternTitle);
await this.testSubjects.click('addFilter');
} }
} }