maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Uncomment missing feature privileges message (#113954) (#114072)

Browse source 
Co-authored-by: Dmitry Shevchenko <dmshevch@gmail.com>
This commit is contained in:
Kibana Machine 2021-10-06 08:45:38 -04:00 committed by GitHub
parent e17077cf0f
commit 895aad24b1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 26 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
x-pack/plugins/security_solution/public/detections/components/callouts/missing_privileges_callout/translations.tsx
View file

@ -56,7 +56,7 @@ export const missingPrivilegesCallOutBody = ({
}: MissingPrivileges) => (
<FormattedMessage
id="xpack.securitySolution.detectionEngine.missingPrivilegesCallOut.messageBody.messageDetail"
defaultMessage="{essence} {indexPrivileges} Related documentation: {docs}"
defaultMessage="{essence} {indexPrivileges} {featurePrivileges} Related documentation: {docs}"
values={{
essence: (
<p>
@ -77,30 +77,23 @@ export const missingPrivilegesCallOutBody = ({
{indexPrivileges.map(([index, missingPrivileges]) => (
<li key={index}>{missingIndexPrivileges(index, missingPrivileges)}</li>
))}
{
// TODO: Uncomment once RBAC for alerts is reenabled
/* {featurePrivileges.map(([feature, missingPrivileges]) => (
<li key={feature}>{missingFeaturePrivileges(feature, missingPrivileges)}</li>
))} */
}
</ul>
</>
) : null,
// TODO: Uncomment once RBAC for alerts is reenabled
// featurePrivileges:
// featurePrivileges.length > 0 ? (
// <>
// <FormattedMessage
// id="xpack.securitySolution.detectionEngine.missingPrivilegesCallOut.messageBody.featurePrivilegesTitle"
// defaultMessage="Missing Kibana feature privileges:"
// />
// <ul>
// {featurePrivileges.map(([feature, missingPrivileges]) => (
// <li key={feature}>{missingFeaturePrivileges(feature, missingPrivileges)}</li>
// ))}
// </ul>
// </>
// ) : null,
featurePrivileges:
featurePrivileges.length > 0 ? (
<>
<FormattedMessage
id="xpack.securitySolution.detectionEngine.missingPrivilegesCallOut.messageBody.featurePrivilegesTitle"
defaultMessage="Missing Kibana feature privileges:"
/>
<ul>
{featurePrivileges.map(([feature, missingPrivileges]) => (
<li key={feature}>{missingFeaturePrivileges(feature, missingPrivileges)}</li>
))}
</ul>
</>
) : null,
docs: (
<ul>
<li>
@ -159,15 +152,14 @@ const missingIndexPrivileges = (index: string, privileges: string[]) => (
/>
);
// TODO: Uncomment once RBAC for alerts is reenabled
// const missingFeaturePrivileges = (feature: string, privileges: string[]) => (
// <FormattedMessage
// id="xpack.securitySolution.detectionEngine.missingPrivilegesCallOut.messageBody.missingFeaturePrivileges"
// defaultMessage="Missing {privileges} privileges for the {index} feature. {explanation}"
// values={{
// privileges: <CommaSeparatedValues values={privileges} />,
// index: <EuiCode>{feature}</EuiCode>,
// explanation: getPrivilegesExplanation(privileges, feature),
// }}
// />
// );
const missingFeaturePrivileges = (feature: string, privileges: string[]) => (
<FormattedMessage
id="xpack.securitySolution.detectionEngine.missingPrivilegesCallOut.messageBody.missingFeaturePrivileges"
defaultMessage="Missing {privileges} privileges for the {index} feature. {explanation}"
values={{
privileges: <CommaSeparatedValues values={privileges} />,
index: <EuiCode>{feature}</EuiCode>,
explanation: getPrivilegesExplanation(privileges, feature),
}}
/>
);