maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

test: 💍 enable URL drilldown test (#88580)

Browse source
This commit is contained in:
Vadim Dalecky 2021-01-18 21:05:29 +01:00 committed by GitHub
parent af7a577b09
commit 89dc4f2e00
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/ui_actions_enhanced/public/drilldowns/url_drilldown/components/url_drilldown_collect_config/url_drilldown_collect_config.tsx
View file

@ -121,6 +121,7 @@ export const UrlDrilldownCollectConfig: React.FC<UrlDrilldownCollectConfig> = ({
<EuiAccordion
id="accordion_url_drilldown_additional_options"
buttonContent={txtUrlTemplateAdditionalOptions}
data-test-subj="urlDrilldownAdditionalOptions"
>
<EuiSpacer size={'s'} />
<EuiPanel color="subdued" borderRadius="none" hasShadow={false} style={{ border: 'none' }}>
@ -131,6 +132,7 @@ export const UrlDrilldownCollectConfig: React.FC<UrlDrilldownCollectConfig> = ({
label={txtUrlTemplateOpenInNewTab}
checked={config.openInNewTab}
onChange={() => onConfig({ ...config, openInNewTab: !config.openInNewTab })}
data-test-subj="urlDrilldownOpenInNewTab"
/>
</EuiFormRow>
<EuiFormRow hasChildLabel={false} fullWidth>

6
x-pack/test/functional/apps/dashboard/drilldowns/dashboard_to_url_drilldown.ts
View file

@ -25,7 +25,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.dashboard.preserveCrossAppState();
});
it.skip('should create dashboard to URL drilldown and use it to navigate to discover', async () => {
it('should create dashboard to URL drilldown and use it to navigate to discover', async () => {
await PageObjects.dashboard.gotoDashboardEditMode(
dashboardDrilldownsManage.DASHBOARD_WITH_AREA_CHART_NAME
);
@ -43,6 +43,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
destinationURLTemplate: urlTemplate,
trigger: 'SELECT_RANGE_TRIGGER',
});
await testSubjects.click('urlDrilldownAdditionalOptions');
await testSubjects.click('urlDrilldownOpenInNewTab');
await dashboardDrilldownsManage.saveChanges();
await dashboardDrilldownsManage.expectsCreateDrilldownFlyoutClose();