maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[UX] Fix long task format (#79509)

Browse source
This commit is contained in:
Shahzad 2020-10-06 18:46:18 +02:00 committed by GitHub
parent 445a7908c1
commit ce2269031a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 46 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
x-pack/plugins/apm/public/components/app/RumDashboard/UXMetrics/KeyUXMetrics.tsx
View file

@ -86,7 +86,7 @@ export function KeyUXMetrics({ data, loading }: Props) {
<EuiFlexItem grow={false} style={STAT_STYLE}>
<EuiStat
titleSize="s"
title={formatToSec(longTaskData?.longestLongTask)}
title={formatToSec(longTaskData?.longestLongTask, 'ms')}
description={LONGEST_LONG_TASK}
isLoading={status !== 'success'}
/>
@ -94,7 +94,7 @@ export function KeyUXMetrics({ data, loading }: Props) {
<EuiFlexItem grow={false} style={STAT_STYLE}>
<EuiStat
titleSize="s"
title={formatToSec(longTaskData?.sumOfLongTasks)}
title={formatToSec(longTaskData?.sumOfLongTasks, 'ms')}
description={SUM_LONG_TASKS}
isLoading={status !== 'success'}
/>

44
x-pack/plugins/apm/public/components/app/RumDashboard/UXMetrics/__tests__/KeyUXMetrics.test.tsx Normal file
View file

@ -0,0 +1,44 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/
import React from 'react';
import { render } from '@testing-library/react';
import * as fetcherHook from '../../../../../hooks/useFetcher';
import { KeyUXMetrics } from '../KeyUXMetrics';
describe('KeyUXMetrics', () => {
it('renders metrics with correct formats', () => {
jest.spyOn(fetcherHook, 'useFetcher').mockReturnValue({
data: {
noOfLongTasks: 3.0009765625,
sumOfLongTasks: 520.4375,
longestLongTask: 271.4375,
},
status: fetcherHook.FETCH_STATUS.SUCCESS,
refetch: jest.fn(),
});
const { getByText } = render(
<KeyUXMetrics
loading={false}
data={{
cls: '0.01',
fid: 6,
lcp: 1701.1142857142856,
tbt: 270.915,
fcp: 1273.6285714285714,
lcpRanks: [69, 17, 14],
fidRanks: [83, 6, 11],
clsRanks: [90, 7, 3],
}}
/>
);
expect(getByText('Longest long task duration 271 ms')).toBeInTheDocument();
expect(getByText('Total long tasks duration 520 ms')).toBeInTheDocument();
expect(getByText('No. of long tasks 3')).toBeInTheDocument();
expect(getByText('Total blocking time 271 ms')).toBeInTheDocument();
expect(getByText('First contentful paint 1.27 s')).toBeInTheDocument();
});
});