maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[APM] fix object path for request url in sample transaction (#28901) (#28966)

Browse source 
* fixes #28899 by using the correct object path to the url `transaction.context.request.url.full`

* [APM] fixed IStickeyProperty.val to be stricter to prevent this bug from happening again
This commit is contained in:
Oliver Gupte 2019-01-18 08:24:46 -08:00 committed by GitHub
parent 1252dd5a9d
commit e14a2e6ae8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/StickyTransactionProperties.tsx
View file

@ -33,7 +33,7 @@ export function StickyTransactionProperties({
const url =
idx(transaction, _ => _.context.page.url) ||
idx(transaction, _ => _.context.request.url) ||
idx(transaction, _ => _.context.request.url.full) ||
'N/A';
const duration = transaction.transaction.duration.us;
const stickyProperties: IStickyProperty[] = [

2
x-pack/plugins/apm/public/components/shared/StickyProperties/index.tsx
View file

@ -21,7 +21,7 @@ import {
} from '../../../style/variables';
export interface IStickyProperty {
val: React.ReactNode | Date;
val: JSX.Element | string | Date;
label: string;
fieldName?: string;
width?: 0 | string;