Commit graph

45963 commits

Author SHA1 Message Date
spalger 86ffd605b2 skip flaky suite (#118272)
(cherry picked from commit a03e12bec0)
2021-11-10 20:44:19 -07:00
spalger 309e47de65 skip flaky suite (#115851) 2021-11-10 20:41:00 -07:00
Kibana Machine ee094ada33
Fix margins for various pending suggestions callouts (#118208) (#118266)
Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>
2021-11-10 21:32:19 -05:00
Kibana Machine 6424da19e5
[Cases] [108671] Fix faulty status api call, if selection is same (#118115) (#118264)
* [Cases] [108671] Fix faulty status api call, if selection is same

* Add unit test to ensure selecting same status message does not call api

Co-authored-by: Kristof-Pierre Cummings <kristofpierre.cummings@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kristof C <kpac.ja@gmail.com>
Co-authored-by: Kristof-Pierre Cummings <kristofpierre.cummings@elastic.co>
2021-11-10 21:17:58 -05:00
Spencer 5b99289c29
[7.16] Remove direct usage of EUI theme vars (#116232) (#118229)
* Remove direct usage of EUI theme vars (#116232)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-ui-shared-deps-src/src/theme.ts
#	src/plugins/discover/public/application/components/discover_grid/discover_grid_document_selection.tsx
#	src/plugins/expressions/public/react_expression_renderer.tsx
#	x-pack/plugins/apm/ftr_e2e/cypress/integration/read_only_user/service_inventory/service_inventory.spec.ts

* commit using @elastic.co

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-10 20:48:19 -05:00
Michael Dokolin c1989b695b
[Reporting] Fix timeouts handling in the screenshotting observable handler (#118186) (#118254) 2021-11-10 19:08:04 -05:00
Kibana Machine 720509a377
[Exploratory view] Show index pattern permission error (#117539) (#118237)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
2021-11-10 17:48:58 -05:00
Kibana Machine 60e7c647fb
[Fleet] Remove force flag from agent instruction (#118099) (#118234)
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
2021-11-10 17:17:55 -05:00
Kibana Machine c47017e1fa
fix addd to case relative (#117487) (#118227)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
2021-11-10 16:48:14 -05:00
Kibana Machine 7ca4a3a666
[7.16] [Fleet] Show callout when EPR unavailable (#117598) (#118082)
* [Fleet] Show callout when EPR unavailable (#117598)

* Update src/core/public/doc_links/doc_links_service.ts

Co-authored-by: Thomas Neirynck <thomas@elastic.co>
2021-11-10 16:17:37 -05:00
Kibana Machine 76fbc4b545
Add missing await (#118171) (#118196)
Co-authored-by: Dmitry Shevchenko <dmitrii.shevchenko@elastic.co>
2021-11-10 15:54:42 -05:00
Kibana Machine e50bc2eded
Removing focusable element in tags badge (#118062) (#118205)
Co-authored-by: ymao1 <ying.mao@elastic.co>
2021-11-10 14:33:13 -05:00
Kibana Machine 6ba3774590
Update web crawler link to lead directly to the crawler page (#118111) (#118200)
Co-authored-by: Vadim Yakhin <yakhin.v@gmail.com>
2021-11-10 14:06:48 -05:00
Kibana Machine 97c5aae511
[Security Solution][Investigations] Fix overlapping tooltips (#117874) (#118188)
* feat: allow to pass `tooltipPosition` to `DefaultDraggable`

* fix: prevent suricata field name and google url tooltips from overlapping

* test: add test for passing the tooltipPosition

* chore: distinguish between type imports and regular imports

* test: update suricata signature snapshots

* test: make sure that suricata signature tooltips do not overlap

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
2021-11-10 12:19:30 -05:00
Davis Plumlee 96463716f8
[Security Solution] Fixes upgrade assistant info for rule preview warnings (#117940)
Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
2021-11-10 11:50:44 -05:00
Kibana Machine 22cb6f0bad
[Lens] Reference lines: fix default value for Interval axis (#117847) (#118183)
* 🐛 Fix the xAccessor computation

*  Add test for fix

* 👌 Integrated feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
2021-11-10 11:39:39 -05:00
Kibana Machine f82874d484
[Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning (#118022) (#118173)
* [Timelion ]Remove usage of ignore_throttled unless targeting frozen indices to avoid deprecation warning

Part of: #117980

* add tests

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
2021-11-10 10:34:06 -05:00
Kibana Machine 46069b6e47
[Observability] [Exploratory View] prevent chart from rerendering on report type changes (#118085) (#118154)
Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
2021-11-10 08:18:23 -05:00
Tiago Costa b9d33ced63
skip flaky suites (#116064) 2021-11-10 13:14:46 +00:00
Kibana Machine 0e081a079f
[User Experience] Add error boundary to prevent UX dashboard from crashing the application (#117583) (#117913)
* wrap UX dashboard into an error boundary (fixes #117543)

* refactor APM root app tests to reuse coreMock

Before this change, the tests for the root application component of the
APM app were manually mocking the `coreStart` objects required to render
the component.

After this change, these tests will now reuse the relevant `coreMock`
methods.

* refactor: fix typo on createAppMountParameters test utility

Co-authored-by: Lucas Fernandes da Costa <lucas.fernandesdacosta@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Lucas F. da Costa <lucas@lucasfcosta.com>
Co-authored-by: Lucas Fernandes da Costa <lucas.fernandesdacosta@elastic.co>
2021-11-10 07:07:05 -05:00
Esteban Beltran d8bdad2692
[7.16] [Security Solution] Fix/host isolation exceptions header (#118041) (#118140)
* [Security Solution] Fix/host isolation exceptions header (#118041)

* Copy changes for host isolation exceptions form

* Fix hasDataToShow condition to show search bar and header

* Remove copy changes from other branch

* commit using @elastic.co
2021-11-10 06:37:09 -05:00
Felix Stürmer bd9188bdd1
Set missing deprecation levels to critical (#117580)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-10 11:35:01 +01:00
Tim Sullivan 672a9c226c
[Reporting] Allow POST URL in Canvas to be copied (#117954) (#118133) 2021-11-10 02:13:25 -05:00
Ryland Herrick ab44f7bb15
[7.16] [SecuritySolution] Fixes deprecated use of Spaces API (#118121) (#118130)
* [SecuritySolution] Fixes deprecated use of Spaces API (#118121)

* Set up our app client in start() instead of setup()

We don't use it during setup, and since the spaces client is now only
available in start(), we need to respond accordingly.

* Move appClientFactory setup back into the setup phase

Albeit in the getStartServices callback, so it's really in the start
phase.

* Use spaces service from start contract in RequestContextFactory

The setup contract variants have been deprecated.

* Remove unused dependency from EndpointAppContextService

It no longer needs the appClientFactory, as that functionality is
provided through securitySolutionRequestContextFactory, which wraps an
instance of that client itself.
# Conflicts:
#	x-pack/plugins/security_solution/server/request_context_factory.ts

* Remove unused var
2021-11-10 01:24:32 -05:00
Tiago Costa b3046e0aaa skip flaky suite (#98562) 2021-11-09 21:46:29 -08:00
Brian Seeders c884f81351 skip flaky suite (#89397) 2021-11-09 21:45:03 -08:00
Kibana Machine 2a869a8226
[dev docs] Add WSL setup guide (#109670) (#118127)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
2021-11-09 22:45:20 -05:00
Tiago Costa c2d7fe50dd
[7.16] chore(NA): moves disk_cache and repository_cache bazel flags from common to specific commands (#118037) (#118080)
* chore(NA): moves disk_cache and repository_cache bazel flags from common to specific commands (#118037)

# Conflicts:
#	.bazelrc.common

* commit using @elastic.co
2021-11-09 19:19:01 -05:00
Kibana Machine 2bd281973e
[Security Solution][Endpoint][Admin] Update empty state description text (#117917) (#118104)
Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
2021-11-09 19:01:13 -05:00
Kibana Machine 1f808644ff
[ci] Cleanup Bazel cache config (#118070) (#118101)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-11-09 17:59:56 -05:00
Kibana Machine eaf76b25c0
unskip copy to space test (#118005) (#118060)
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
2021-11-09 22:44:04 +00:00
Kibana Machine 66b1682ada
[CI] Add firefox and accessibility tasks to the flaky test suite runner (#118036) (#118092)
Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
2021-11-09 16:47:47 -05:00
Kibana Machine dd119d001c
[7.16] [SecuritySolution][Detections] Fixes rule status migration when alertId is not a string (#117962) (#118040)
* [SecuritySolution][Detections] Fixes rule status migration when alertId is not a string (#117962)

## Summary

Resolves https://github.com/elastic/kibana/issues/116423, and adds an e2e test catching this behavior as we can't test via the migration test harness since the `siem-detection-engine-rule-status` SO isn't exposed within the SO Manager UI.

Also adds note with regards to changes necessary once core issue https://github.com/elastic/kibana/issues/115153 is resolved. See https://github.com/elastic/kibana/pull/114585/files#r729620927. Note: existing `find_statuses`/`find_rules` integration tests will fail once fixed, so no additional tests necessary. 



### Checklist

Delete any items that are not applicable to this PR.

- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

* Fixes typecheck in test

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
Co-authored-by: Garrett Spong <garrett.spong@elastic.co>
2021-11-09 21:15:25 +00:00
Michael Olorunnisola efbceb8441
[Security Solution][Investigations] - Swap count and histogram order (#117878) (#118073) 2021-11-09 21:11:32 +00:00
Kibana Machine 01e563c61b
[Lens] Reference line: fix overlapping areas (#117722) (#118061)
* 🐛 Fix bug with overlap

*  Add tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
2021-11-09 20:48:37 +00:00
Kibana Machine 5ee15c397f
[Security Solution] Copy changes for host isolation exceptions form (#118021) (#118068)
Co-authored-by: Esteban Beltran <academo@users.noreply.github.com>
2021-11-09 20:45:47 +00:00
Kibana Machine 0502ce54e4
Update telemetry filter list for Security Solution (#117995) (#118057)
* Add failing test condition.

* implement filter list condition.

Co-authored-by: Pete Hampton <pjhampton@users.noreply.github.com>
2021-11-09 20:04:42 +00:00
Yuliia Naumenko 0338110677
Merged upstream/master (#118051) 2021-11-09 19:48:10 +00:00
CJ Cenizal 6ec614ebe0
Improve Clean Repository error message. (#117947) (#118039)
# Conflicts:
#	x-pack/plugins/snapshot_restore/server/routes/api/repositories.ts
2021-11-09 19:01:53 +00:00
Kibana Machine c04bce3330
[SECURITY] Remove flakiness on SpacesPopoverList renders a search box (#117888) (#118030)
* wip to figure out flakyness

* clean up

* fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
2021-11-09 18:14:39 +00:00
Michael Dokolin 6a7569c15c
[Expressions] Fix expressions execution abortion to prevent performance issues (#117714) (#117999)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-09 16:55:21 +00:00
Kibana Machine 836a3f495a
[Uptime] Ping redirects - add retry logic (#117363) (#118018)
* add retry logic and focus test

* unfocus tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
2021-11-09 16:43:50 +00:00
Walter Rafelsberger 304911b33b
[ML] APM Correlations: Fix usage in load balancing/HA setups. (#115145) (#118004)
- The way we customized the use of search strategies caused issues with race conditions when multiple Kibana instances were used for load balancing. This PR migrates away from search strategies and uses regular APM API endpoints.
- The task that manages calling the sequence of queries to run the correlations analysis is now in a custom React hook (useFailedTransactionsCorrelations / useLatencyCorrelations) instead of a task on the Kibana server side. While they show up as new lines/files in the git diff, the code for the hooks is more or less a combination of the previous useSearchStrategy and the server side service files that managed queries and state.
- The consuming React UI components only needed minimal changes. The above mentioned hooks return the same data structure as the previously used useSearchStrategy. This also means functional UI tests didn't need any changes and should pass as is.
- API integration tests have been added for the individual new endpoints. The test files that were previously used for the search strategies are still there to simulate a full analysis run, the assertions for the resulting data have the same values, it's just the structure that had to be adapted.
- Previously all ES queries of the analysis were run sequentially. The new endpoints run ES queries in parallel where possible. Chunking is managed in the hooks on the client side.
- For now the endpoints use the standard current user's esClient. I tried to use the APM client, but it was missing a wrapper for the fieldCaps method and I ran into a problem when trying to construct a random_score query. Sticking to the esClient allowed to leave most of the functions that run the actual queries unchanged. If possible I'd like to pick this up in a follow up. All the endpoints still use withApmSpan() now though.
- The previous use of generators was also refactored away, as mentioned above, the queries are now run in parallel.
Because we might run up to hundreds of similar requests for correlation analysis, we don't want the analysis to fail if just a single query fails like we did in the previous search strategy based task. I created a util splitAllSettledPromises() to handle Promise.allSettled() and split the results and errors to make the handling easier. Better naming suggestions are welcome 😅 . A future improvement could be to not run individual queries but combine them into nested aggs or using msearch. That's out of scope for this PR though.
2021-11-09 17:01:01 +01:00
Kibana Machine db0d42a45a
adjust yaxis mode according to field format (#117646) (#118011)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
2021-11-09 15:25:29 +00:00
Kibana Machine d2b4da90b0
[Uptime] Fix regression in logging queries on inspect (#117124) (#117908)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
2021-11-09 15:24:30 +00:00
Kibana Machine d5a4c4b53a
[Observability] [Exploratory View] adjust popover placement (#116471) (#117210)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
2021-11-09 15:19:01 +00:00
Kibana Machine f49e91487b
[Uptime] increase timeout and clear mocks for UptimeDatePicker flaky test (#117346) (#117417)
Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
2021-11-09 15:10:03 +00:00
Kibana Machine a38ea90e4d
[Discover][Context] Fix selecting another surrounding document (#117567) (#117997)
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
2021-11-09 13:49:39 +00:00
Aleh Zasypkin 556d227414
Always call forceLogout first in the test cleanup code. (#117555) (#117990) 2021-11-09 13:13:49 +00:00
Diana Derevyankina a3dd583d21
[TSVB] Fix reappearing of hidden series on refresh and styles loading (#117311) (#117986)
* [TSVB] Fix reappearing of hidden series on refresh and styles loading

* Add functional test

* Update condition and move loading component to another file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-09 12:30:31 +00:00