Commit graph

41914 commits

Author SHA1 Message Date
Dario Gieselaar 012f1c199b
[APM] Run precommit tasks sequentially (#96551)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-09 08:57:13 +02:00
Nathan Reese ec070d34ed
[Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert (#96633)
* [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert

* tslint

* instead of forcing refresh on getIdsAndTitles, update index pattern service to add saved object to cache when index pattern is created

* simplify title check

* revert unneeded changes

* tslint

* api doc updates

* fix functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 20:08:10 -06:00
Steph Milovic 17b460d58d
[Security Solution] [Cases] Small UI bugfixes (#96511) 2021-04-08 18:36:46 -06:00
Yuliia Naumenko b54d5fc909
[Actions UI] Changed PagerDuty action form UI to fill payload fields according to the API docs for Resolve and Acknowledge events. (#96363)
* [Actions UI] Changed PagerDuty action form UI to fill payload fields according to the API docs for Resolve and Acknowledge events.

* fixed test

* fixed test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 17:21:26 -07:00
Davey Holler 0bf57a2447
App Search: Result Component Updates (#96184)
* Starting work on result component

* Write tests

* Fix types

* Cleanup

* Fix type errors

Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 15:51:39 -07:00
ymao1 71ed148cfe
[Alerting] Preconfigured alert history index connector (#94909)
* Adding preconfigured alert history index

* Adding functions to build alert history document

* Adding functions to build alert history document

* Moving index template creation to plugin start

* Adding unit tests

* Adding unit tests

* Adding unit tests

* Simplifying

* Revert "Merge branch 'master' of https://github.com/elastic/kibana into alerting/default-es-index-schema"

This reverts commit 957c333aa4, reversing
changes made to 4b1b78761e.

* Reverting some changes

* Reverting some changes

* Adding index override

* Updating UI with index override

* Only allow indexOverride for preconfigured alert history connector

* Handling preconfigured connector id clashes

* Cleanup

* UI unit tests

* Fixing default schema shown in UI

* Fixing functional tests

* Adding functional test

* Fixing functional tests

* Adding docs and link to docs

* Adding config to docker allowlist

* Fixing wrong typescript operator

* Changing default for config to false

* Cleanup

* Adding note about index privileges to docs

* Fixing i18n

* PR fixes

* PR fixes

* PR fixes

* PR fixes - wording

* PR fixes

* Fixing unit and functional tests

* Fixing types check

* ES -> Elasticsearch

* Moving files

* Adding kibana- to beginning of prefix

* Namespacing alert data within schema with kibana

* Fix i18n

* Updating docs

* Fixing unit tests

* Fixing doc links

* Fixing types check

* PR fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 18:18:44 -04:00
Spencer 3336db0baa
[uiSettings/theme/version] override label to aid KBN_OPTIMIZER_THEMES discovery (#96069)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 15:13:39 -07:00
Nick Peihl 0fdb533ed6
[docs] Link troubleshooting info for Elastic Maps Service (#96231) 2021-04-08 17:48:13 -04:00
Jean-Louis Leysens cbc0fa0289
[Ingest Pipelines] Add generated copy for all processors (#95507)
* - minor refactor of 'description' -> 'typeDescription' for
  generic processor descriptions
- added initial pass of generated descriptions for all processors

* fix i18n

* added wrapping div and title to description and changed default description to appear as placeholder

* reworked the description width and overflow styling

* only show the text title on hover when we are not showing the text input

* fixed a number of minor issues with using values as though they are strings and doing better serialization

* slight optimisation to scss

* - implement copy feedback
- clean up a lot of uses of "target_field = field". it is better
  to not show these
- made "replacement" a required field on gsub (which it was not)

* revert the previouis validation as empty values are acceptbale for the replacement text

* - updated the copy per feedback and fixed a missing i18n.translate
- slight update to SCSS classes to not have unused class

* Added an empty string field validator that accepts spaces so that
the KV processor value and field split fields accept " "

* replace use of HTML "title" with EuiToolTip

* remove unused variable and import

* implemented feedback; removed if from default descriptions and other minor updates

* update default description of foreach to always display

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 23:43:38 +02:00
Kaarina Tungseth cf7fdecdfe
[DOCS] Adds principal associated to keytab file (#96498)
* [DOCS] Adds principal associated to keytab file

* Update docs/user/security/authentication/index.asciidoc

Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>

* Review comments

Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
2021-04-08 16:35:59 -05:00
Brian Seeders 65dc108575
[CI] Don't retry steps after a build has been aborted or timed out (#96600) 2021-04-08 17:33:34 -04:00
dmlemeshko aab675b1ba
[loa testing] wait 60 sec b/w simulations (#96612)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 23:07:08 +02:00
Tre 9ec466e5a1
[QA] Add saved objects info svc (#96364)
Add svc and fn to return saved object types in a given index,
defaulted to ".kibana" index.
2021-04-08 14:46:52 -06:00
Quynh Nguyen 4a54188355
[ML] Add commonly used ranges to date picker (#96501) 2021-04-08 14:18:03 -05:00
gchaps 767567fb47
[DOCS] Updates advanced settings doc (#93968)
* [DOCS] Updates advanced settings doc

* [DOCS] Edits advanced settings doc

* [DOCS] Updates descriptions per review comments

* Clarify that TSVB setting is dependent on the other setting

* Update docs/management/advanced-options.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Update docs/management/advanced-options.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Update docs/management/advanced-options.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* Update docs/management/advanced-options.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
2021-04-08 12:11:47 -07:00
Andrew Goldstein e871e84365
[Security Solution] Fixes the Read Less button rendering below the fold (#96524)
## [Security Solution] Fixes the `Read Less` button rendering below the fold

Fixes issue <https://github.com/elastic/kibana/issues/95295> where the `Read Less` button in the Event Details flyout is rendered below the fold when an event's `message` field is too large, per the `Before` and `After` screenshots below:

### Before

![before](https://user-images.githubusercontent.com/4459398/113962310-aa463e80-97e4-11eb-93f9-f4a90bd250f6.png)

_Before: The `Read Less` button is not visible in the `Event details` flyout above_

### After

![after](https://user-images.githubusercontent.com/4459398/113962433-e9748f80-97e4-11eb-8f46-835eb12ea09d.png)

_After: The `Read Less` button is visible in the `Event details` flyout above_

In the _After_ screenshot above, the long `message` is rendered in a vertically scrollable view that occupies ~ one third of the vertical height of the viewport. The `Read Less` button is visible below the message.

### Desk Testing

Desk tested on a 16" MBP, and at larger desktop resolutions in:

- Chrome `89.0.4389.114`
- Firefox `87.0`
- Safari `14.0.3`
2021-04-08 12:50:31 -06:00
Thom Heymann 4af344a9b0
Improved role management error handling for partially authorized users (#96468)
* Role management: Gracefully handle underprivileged users

* Removed redundant condition
2021-04-08 19:44:57 +01:00
Jonathan Budzenski 869fd9355a skip a11y spaces tests. #77933, #96625 2021-04-08 13:36:45 -05:00
Dominique Clarke 06e01c20e7
[Uptime] Remove Location map from Uptime monitor details page (#96517)
* remove LocationMap from Uptime Monitor details
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 14:29:51 -04:00
Jonathan Budzenski 91e1acd98d skip flaky test blocking snapshot promotion. #96515 2021-04-08 13:23:05 -05:00
Jonathan Budzenski 128ed7f676 skip flaky a11y test 2021-04-08 12:39:15 -05:00
Larry Gregory 5b1ce4d2e3
Docs: getting started with Kibana Security (#94158)
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Gail Chappell <gail.chappell@elastic.co>
2021-04-08 13:36:29 -04:00
Sandra Gonzales f56a646b8e
[Metrics UI] change composite.size of snapshot ES query to improve speed (#95994)
* change composite.size of snapshot query to improve speed

* use value from kibana config to set compositeSize, clean up unused config properties

* fix test

* change config name

* fix reference
2021-04-08 13:36:15 -04:00
Quynh Nguyen d904f8d1bb
[ML] Add Anomaly charts embeddables to Dashboard from Anomaly Explorer page (#95623)
Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 12:22:52 -05:00
Quynh Nguyen 955c46ba5e
[ML] Add ML plugin contract mocks (#96265)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 12:15:27 -05:00
Quynh Nguyen 2582522c66
[ML] Stabilize Anomaly Explorer embeddable functional tests (#96421)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 11:08:45 -05:00
Jonathan Budzenski 879af7f14b skip flaky test. #77933 2021-04-08 11:05:13 -05:00
Walter Rafelsberger 6b4becfe02
[ML] Data Frame Analytics: Don't allow user to pick an index pattern or saved search based on CCS. (#96555)
Data Frame Analytics does not support cross-cluster search. This PR fixes the SourceSelection component to not allow a user to select a CCS index pattern or a saved search using a CCS index pattern.
2021-04-08 17:46:45 +02:00
Sébastien Loix c9d19fd43b
[ILM] Fix frozen phase min_age (de)serialization (#96544) 2021-04-08 16:41:27 +01:00
Mikhail Shustov 0d62e11736
Document SO migrations enableV2 and batchSize config options (#96290)
* document SO batchsize and migrationsv2 enablement options

* use refs by name

* Update docs/setup/settings.asciidoc

Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

* apply Lukes suggestion

* add a note that migrations.enableV2 will be removed soon

* document migrations.retryAttempts

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
2021-04-08 11:23:36 -04:00
spalger afc1fd022e skip entire fleet_api_integration suite to unblock es promotion (#96515) 2021-04-08 08:14:01 -07:00
Caroline Horn 8658ef49d8
[K8] Continuing to fix the KQL bar styles (#96264) 2021-04-08 11:06:47 -04:00
Stratoula Kalafateli 158932e377
[Visualizations] Fixes chart visibility on Safari small screens (#96276)
* [Visualizations] Fix chart visibility on Safari small screens

* Fix safari bug without changing the chrome behavior

* fix layout inconsistencies across browsers

Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 18:03:55 +03:00
Kevin Qualters de8ba08ac0
[Security Solution][Rac][Tgrid] Use correct prop name for disabling timeline context menu button (#96453)
* Use correct prop name for disabling timeline context menu button

* Update usages of disabled to isDisabled on EuiIconButton

* Update failing snapshot and tests looking for old prop
2021-04-08 10:44:31 -04:00
Uladzislau Lasitsa e3f31ea9ad
[Visualize] Allows editing broken visualizations caused by runtime fields changes (#94798)
* Add possibility to open visualization when saved field doesn't exists anymore

* Fix tests

* Fix some remarks

* Remove unneeded code

* Fix tests

* Fix tests

* Fix some remarks

* Fixed problem with double error popover in visualizations

* Fix CI

* Fix type

* Fix API docs

* Don't show error popup for error related to runtime fields

* Fix some remarks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 17:29:57 +03:00
Thomas Watson 5d54e2990b
Update developer docs for upgrading Node.js (#96422) 2021-04-08 08:50:23 -05:00
Jonathan Budzenski 02ba7c4543
[kbn-ui-shared-deps] Remove outdated polyfills (#96339) 2021-04-08 08:49:13 -05:00
Pete Harverson 75e4aeedbc
[ML] Excludes metadata fields from jobs caps fields service response (#96548) 2021-04-08 14:16:31 +01:00
Yulia Čech 0316787ead
[Remote clusters] Cloud deployment form when adding new cluster (#94450)
* Implemented in-form Cloud deployment url input

* Fixed i18n files and added mode switch back for non-Cloud

* Added cloud docs link to the documentation service, fixed snapshot tests

* Fixed docs build

* Added jest test for the new cloud url input

* Added unit test for cloud validation

* Fixed eslint error

* Fixed ts errors

* Added ts-ignore

* Fixed ts errors

* Refactored connection mode component and component tests

* Fixed import

* Fixed copy

* Fixed copy

* Reverted docs changes

* Reverted docs changes

* Replaced the screenshot with a popover and refactored integration tests

* Added todo for cloud deployments link

* Changed cloud URL help text copy

* Added cloud base url and deleted unnecessary base path

* Fixed es error

* Fixed es error

* Changed wording

* Reverted docs changes

* Updated the help popover

* Deleted unneeded fragment component

* Deleted unneeded fragment component

* Updated tests descriptions to be more detailed

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 14:18:18 +02:00
ymao1 03a51f4eec
[Alerting] Update feature privilege display names (#96083)
* Updating feature display names

* Updating feature display names
2021-04-08 07:47:29 -04:00
Dario Gieselaar bfc940c146
[APM] Extract server type utils to package (#96349) 2021-04-08 13:26:43 +02:00
Dima Arnautov d9ef5c28d5
[ML] Fix switches positioning on the Transform and DFA wizards (#96535)
* [ML] fix edit runtime mapping switch positioning

* [ML] fix transform wizard switches
2021-04-08 07:10:52 -04:00
Anton Dosov 7984745a9d
Don't trigger auto-refresh until previous refresh completes (#93410) 2021-04-08 13:00:11 +02:00
hardikpnsp d39701fc97
[Telemetry] enforce import export type (#96487)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 06:37:01 -04:00
Mike Côté 81ba969cfa
Skip rendering empty add action variables button as disabled (#96342)
* Skip rendering empty add action variables button

* Fix jest tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 05:24:16 -04:00
spalger f9317281d1 skip suite blocking es promotion (#96515) 2021-04-08 02:09:29 -07:00
Justin Ibarra bc14f2415d
[Detection Rules] Resolves regression where Elastic Endgame rules would warn about unmapped timestamp override field (#96394)
related to https://github.com/elastic/detection-rules/pull/1082

## Summary

Endgame promotion rules in Kibana/7.12 are at version 5 and have timestamp_override defined (which should not be). These same rules are at version 4 in the detection-rules repo 7.12 branch and kibana/master and timestamp_override is not defined. These updates are targeted for 7.12.1

There most likely was an issue with the maze of backports and interlaced updates.

To fix the rules, they need to be reconciled across:

detection-rules 7.12 & main
kibana 7.12.1 and master
bump detection-rules/7.12 to v6 -> PR to kibana/master -> backport to 7.12.1
### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2021-04-07 23:53:02 -06:00
Shahzad 391e92ead3
[Exploratory view] Use index patterns for formatting (#96280) 2021-04-08 07:16:23 +02:00
Ross Wolf 93965343e5
[Fleet] Install security_rule assets as saved objects (#95885)
* [Fleet] Install security_rule assets as saved objects

* Add security-rule to update_assets.ts

* Update UUIDs for security_rule asset

* Change .type to match the saved object type not the asset type

* Add saved object mapping for security-rule

* Make SO non-hidden

* Fix SO mapping for security-rule

* Make security-rule a non-hidden asset
2021-04-08 00:52:10 -04:00
Garrett Spong d5b3829210
[Security Solution][Detections] Fixes Closing Alerts Cypress Test (#96523)
## Summary

As identified in https://github.com/elastic/kibana/pull/96505#issuecomment-815392671, this fixes the flakiness in the `Closing alerts` cypress test. Method used was to just delete the rule after the initial batch of alerts were generated. Alternatively we could add a function for disabling the rule (didn't see one in there), but the outcome is the same, no more alerts generated while the test is being performed. 🙂 

> Passing locally, though upon further inspection, this test is definitely going to be flakey as it's checking counts on alerts as they move through different states and there are new alerts that keep coming in (hence the count mis-match in the above failure). Potential fixes would be to use an absolute daterange to after the first round of alerts were generated, or just stop generating alerts before performing the alert state changes.


##### Before:
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/113952824-ae1d9500-97d3-11eb-9021-6737544b9c50.png" />
</p>


##### After:

<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/113958216-ed50e380-97dd-11eb-9d22-d1c6aafc97d2.png" />
</p>
2021-04-08 00:25:47 -04:00