Commit graph

35170 commits

Author SHA1 Message Date
Joe Portner
0149c65221
lodash 4.17.15 -> 4.17.19 (#73122) 2020-07-28 10:56:29 -04:00
Brian Seeders
8648063b10
[CI] Harden Slack notifications (#73361) 2020-07-28 10:52:28 -04:00
Mikhail Shustov
4ede075681
[KP] fix doc generation for platform code (#73407)
* fix doc generation for platform code

* terminate process if type build failed

* update types
2020-07-28 16:51:23 +02:00
Felix Stürmer
cdb1c0d9a4
[Logs UI] Check for presence of data instead of presence of indices in overview page fetchers (#73101)
This causes the "has data" check for the observability overview page to not only check for the presence of log indices but also of log entries.
2020-07-28 16:44:27 +02:00
Toby Sutor
56609049cb
32 characters requirement for xpack.reporting.encryptionKey (#72594)
Similar to https://github.com/elastic/kibana/pull/72593 document that the string needs to be at least 32 characters long.
2020-07-28 09:35:08 -05:00
Toby Sutor
f87d97b629
32 characters requirement for xpack.reporting.encryptionKey (#72593)
Similar to https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html#general-alert-action-settings is a 32 character minimum length required for xpack.reporting.encryptionKey
2020-07-28 09:35:00 -05:00
Stratoula Kalafateli
0dbfde4f4d
[Functional Tests] Increase the timeout on getting the legend value on timeseries (#73279) 2020-07-28 17:34:40 +03:00
Shahzad
330c966f4f
[Uptime] Reduce miscellaneous uptime bundle size (#70632)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 16:30:58 +02:00
Gidi Meir Morris
f4104743e3
[Alerting] Control Alerts Management via feature controls & privileges (#72029)
This PR removes the alerting and actions ui privileges (alerting:show, actions:show, etc...) and instead relies on the standard Kibana feature control model to decide whether management displays the Alerts Management section under management.
2020-07-28 15:20:24 +01:00
Andrew Goldstein
dca4a23597
[Security Solution] Full screen fixes for Timeline based views (#73421)
## Full screen fixes for Timeline based views

- Fixes an issue where sometimes, Global navigation is hidden until the page is scrolled when exiting full screen mode
- Improves performance by adding an intent delay before showing the draggable wrapper hover menu
- Removes an unnecessary CSS transition

### Sometimes, Global navigation is hidden until the page is scrolled when exiting full screen mode

Sometimes, after exiting `Full screen` mode in a page, for example, the `Detections` page, the global navigation, e.g. `Overview Detections Hosts...` is hidden until the page is scrolled.

To reproduce:

1) Navigate to the `Detections` page
2) Click the `Full screen` button in the table
3) Without scrolling the full screen view, click the `Exit full screen` button

**Expected result**
- [x] The global navigation e.g. `Overview Detections Hosts...` is visible above the search bar, per the screenshot below:

![correct-global-navigation](https://user-images.githubusercontent.com/4459398/87717870-571bef80-c76e-11ea-8b7b-1850094326b3.png)

4) Once again, click the `Full screen` button in the table
5) This time, expand an event, which will scroll the view
6) Once again, click the `Exit full screen` button

**Expected result**
- [x] The global navigation e.g. `Overview Detections Hosts...` is visible above the search bar

**Actual result**
- [ ] Sometimes, the global navigation e.g. `Overview Detections Hosts...` is **not** visible until the page is scrolled
2020-07-28 08:09:35 -06:00
Gidi Meir Morris
5e8e01fd0f
removed ESO migration from alerting (#73420)
This PR removes the use of ESO migration from alerting as we do not actually need this until the RBAC work lands, which should be 7.10.
This allows us to concentrate the challenges of introducing RBAC into one single release which hopefully will help us better mitigate potential regressions.
2020-07-28 15:00:41 +01:00
Jonathan Buttner
fb4ee91f0c
[Security Solution][Resolver] Fix resolver isStart event bug (#73357)
* Check if category is array

* Adding more tests and renaming to isStart

* Handling the case where start is not at the front
2020-07-28 09:55:57 -04:00
Dario Gieselaar
19532fc439
[APM] Optimize traces overview (#70200)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 15:53:23 +02:00
MadameSheema
49846834eb
[SIEM] Unskips and fixes Cypress tests (#73322)
* removes not needed configuration

* fixes events columnts tests

* unksips persisten timeline test

* fixes failing test

* skips events test since need more time for investigation

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 15:23:05 +02:00
Marco Liberati
8c710aae3a
[ Functional test ] Increase the waiting time for the filter bar request (#73424) 2020-07-28 14:21:24 +02:00
Angela Chuang
7a10077776
[Security Solution] Template unit tests (#72399)
* add unit test for failure cases

* add unit tests

* update wording

* fix error when update template without ttid or ttversion

* fix unit test

* add comment

* review

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 12:53:36 +01:00
Shahzad
b5a920d8c9
[Uptime] Convert kuery bar to ts (#70310)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 13:50:02 +02:00
Larry Gregory
09b11b61f0
Introduce reserved ml privilege for the apm_user role (#72266)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 07:44:37 -04:00
Christos Nasikas
46fb8475f3
[Security Solutions] Show popovers inside modals (#73264) 2020-07-28 14:38:14 +03:00
MadameSheema
12d5b8d2f9
executes cypress tests when there is a change in parts of alerting team code we use (#73256) 2020-07-28 13:13:01 +02:00
Liza Katz
95668d4baa
[Search] add server logs (#72454)
* improve test stability

* logs and scope search function

* uncomment

* fix ts

* ts

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 13:00:16 +03:00
MadameSheema
1c791f39da
[SIEM][Timelines] Updates timeline template callout text (#73334)
* updates timeline template callout text

* fixes typo in constant

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 10:48:14 +02:00
Mikhail Shustov
c0826a3273
Fix App status flaky test (#72853)
* wait for link to be updated

* await, please!

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 10:37:37 +02:00
Stratoula Kalafateli
5ea28702f6
[Functional Tests] Increase the timeout when locating the tableview] (#73243) 2020-07-28 11:15:58 +03:00
Anton Dosov
abfda1f792
Use "Apply_filter_trigger" in dashboard drilldown (#71468)
* attach dashboard drilldown to apply filter trigger

* fix types

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 09:57:04 +02:00
Anton Dosov
9b570a9bf1
fix dashboard index pattern race condition (#72899)
* fix dashboard index pattern race condition

* improve

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 09:46:36 +02:00
Stratoula Kalafateli
a696f6c79b
[Functional Tests] Increase waitTime for timelion to fetch the results (#73255)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 10:29:47 +03:00
Stratoula Kalafateli
7b29ecf0b5
[Functional Tests] Fix flakiness on TSVB chart on switching index patterns test (#73238) 2020-07-28 10:29:33 +03:00
MadameSheema
281c76767b
updates cypress to v4.11.0 (#73327)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-28 09:23:28 +02:00
Phillip Burch
cc84ee3185
[Metrics UI] Saved views bugs (#72518)
* Add test for logs and metrics telemetry

* wait before you go

* Remove kubenetes

* Fix type check

* Add back kubernetes test

* Remove kubernetes

* Don't allow deleting default default view.

* Fix bug with duplicate loads of data.

Because the load data function takes options.source and the source of options can change, we need to remove it from deps

* Remove unused variable

* Reload when loadData function is changed

* Don't send the request immediately

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 21:28:39 -05:00
Jen Huang
82d7e7db69
[Ingest Manager] Convert select agent config step to use combo box (#73172)
* Initial pass at using combo box instead of selectable for agent configs

* Hide agent count messaging if fleet isn't set up

* Fix types

* Fix i18n

* Fix i18n again

* Add comment explaining styling

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 19:21:41 -07:00
Jen Huang
5af2c1080a
Exclude version from package config attributes that are copied, add safeguard to package config bulk create (#73128)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 19:21:14 -07:00
Garrett Spong
765c2d1ad3
[Security Solution][ML] Updates siem group name to security (#73218)
## Summary

Resolves https://github.com/elastic/kibana/issues/69319

Updates `siem` grouping to `security`, and enables cloudtrail module, fixing mis-match between the newly updated modules (https://github.com/elastic/kibana/pull/71696).


<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/88444121-b6b27480-cdd8-11ea-886a-9b4cadbaede8.png" />
</p>

<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/88444181-16108480-cdd9-11ea-9fba-aff1e4c38da3.png" />
</p>


Also updates all module icons to be consistent:

Auditbeat (Before/After):
<p align="center">
    <img width="260" src="https://user-images.githubusercontent.com/2946766/88592057-9a9e1580-d01a-11ea-97bb-d1096a4ae85f.png" /><img width="300" src="https://user-images.githubusercontent.com/2946766/88592020-8b1ecc80-d01a-11ea-8f2d-aa5cba94924e.png" />
</p>

Packetbeat (Before/After):
<p align="center">
    <img width="260" src="https://user-images.githubusercontent.com/2946766/88592205-e18c0b00-d01a-11ea-9553-9c87527c600b.png" /><img width="300" src="https://user-images.githubusercontent.com/2946766/88592270-f8caf880-d01a-11ea-94a8-5428d2c6ddea.png" />
</p>

Winlogbeat (Before/After):
<p align="center">
    <img width="260" src="https://user-images.githubusercontent.com/2946766/88592286-fff20680-d01a-11ea-87dd-4150debc988c.png" /><img width="300" src="https://user-images.githubusercontent.com/2946766/88592351-2021c580-d01b-11ea-863f-efd26d0105ab.png" />
</p>



- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [X] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials
  - Working w/ @benskelker on updated ML Jobs & nomenclature
2020-07-27 19:52:28 -06:00
Kevin Qualters
8c52d39b9e
[Security Solution] Show proper icon for termination status of all processes (#73235)
* Show proper icon for termination status of all processes

* Add basic test for isProcessTerminated selector
2020-07-27 20:34:08 -04:00
Michael Olorunnisola
ef83e772ca
[Security Solution][Resolver] Show origin node details in panel on load (#73313)
* show origin node details in panel on load

* added comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 20:03:23 -04:00
Steph Milovic
ddff1c9ab9
[Security solution] Threat hunting test coverage improvements (#73276) 2020-07-27 17:50:46 -06:00
Yara Tercero
94ed783cae
[Security Solution][Exceptions] - Update exception item comments to include id (#73129)
## Summary

This PR is somewhat of an intermediary step. Comments on exception list items are denormalized. We initially decided that we would not add `uuid` to comments, but found that it is in fact necessary. This is intermediary in the sense that what we ideally want to have is a dedicated `comments` CRUD route. 

Also just note that I added a callout for when a version conflict occurs (ie: exception item was updated by someone else while a user is editing the same item).

With this PR users are able to:
- Create comments when creating exception list items
- Add new comments on exception item update

Users will currently be blocked from:
- Deleting comments
- Updating comments
- Updating exception item if version conflict is found
2020-07-27 18:19:16 -04:00
Constance
57997beed8
[Enterprise Search] Error state UI tweaks to account for current Cloud SSO behavior (#73324)
* Do not disable the Launch App Search button on the error page

- so users always have access to App Search

* Add troubleshooting steps that mention user authentication

- more info can be found in setup guide

* Tweak styling/spacing on troubleshooting steps

* Copyedits (thanks Chris!)
2020-07-27 15:06:42 -07:00
Spencer
157fb097a9
[dev/build/docker_generator] convert to typescript (#73339)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-07-27 14:31:02 -07:00
Nathan L Smith
5a47218971
[APM] Fix focus map link on service map (#73338)
The link was including `serviceName` from the `urlParams` so it was linking to the wrong service. Overwrite the service name so the link is correct.

Fixes #72911.
2020-07-27 16:24:45 -05:00
liza-mae
88aebc9fe1
Remove ca cert path for cloud testing (#73317) 2020-07-27 15:10:33 -06:00
Scotty Bollinger
2ae470e897
Add Kea.js support to Enterprise Search plugin (#72160)
* Add Kea packages

- kea and kea-waitfor

* Add Kea declarations and types

Hopefully TypeScript support coming soon from author

* Add Kea to entry point

* Add logic for overview

* Update components to use Kea

* Fix a couple of tests that weren’t getting complete coverage

* Remove kea-waitfor

Turns out we don’t need it

* Remove unused declaration

* Update x-pack/plugins/enterprise_search/public/applications/workplace_search/components/overview/overview_logic.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Update x-pack/plugins/enterprise_search/public/applications/workplace_search/components/overview/overview_logic.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Update x-pack/plugins/enterprise_search/public/applications/workplace_search/components/overview/__mocks__/overview_logic.mock.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Update x-pack/plugins/enterprise_search/public/applications/workplace_search/components/overview/overview_logic.test.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* [Opinionated] Remove extra actions defs

- they're already being defined in IOverviewActions, so no need to repeat them

* DRY out a new reusable/generics IKeaLogic/Listeners interface

- Multiple logic files can now do IKeaListeners<SomeLogicActions> and not have to declare their own IListenerParams!

+ bonus IKeaSelectors just for consistency

* DRY out Kea reducers definitions to generics interface

* [Refactor] Improve KeaReducers generic to actually type-check/check key names

- Typescript will now throw an error if you put in a key name that isn't declared in your actions/values interface
- default & new states now will be type checked!! 🎉

* [Refactor] Update selectors() and listeners() to also check types and keys

* [Refactor] Move param defs to bottom of file instead of inline

- so that inline definitions mostly focus on type checks, and more boilerplate defs are DRYed out
- I played around with 2.1 obj definitions and got terrible results here :(

* Update tests and remove selectors per code review

* Remove last statsColumns instance

* Remove last instance of hideOnboarding

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Constance Chen <constance.chen.3@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 16:04:10 -05:00
Justin Kambic
1c690c68af
[Uptime] Increase timeout in attempt to fix skipped a11y test (#73078)
* Increase timeout in attempt to fix skipped a11y test.

* Temporarily only run uptime tests for faster flaky testing.

* Uncomment other test suites.

* Unskip test and delete comment.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 15:39:52 -04:00
Nathan L Smith
f23359c099
[APM] Fix license management URL (#73294)
The URL to license management has changed, so update our links, both in the prompt on the Service Map, and in the app-wide expired license message.

Use `useKibanaUrl` in both places and update that hook to make the `hash` argument optional, since many apps don't use a hash now.

I looked for a more reliable way to get the URL for that app but couldn't come up with anything. I'd appreciate any suggestions if there's a better method.
2020-07-27 14:20:26 -05:00
Alison Goryachev
7c24a61c43
Make ingest node pipelines api tests more robust (#73289) 2020-07-27 15:19:42 -04:00
Marshall Main
34fd7b301d
Increase limit on exception items to 10k (#73117)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 14:17:19 -04:00
Jonathan Buttner
867a672c7a
[Security Solution] Use docker for endpoint tests (#73092)
* Copying api integration tests into their own directory

* Removing api integration tests and using ingest docker image

* Fixing typo

* Fixing type errors and empty string and reenabling tests

* Rebuilding docs

* Renaming url override variable

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 14:13:50 -04:00
Spencer
dd4796cfdd
Remove karma (#73126)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-07-27 11:07:58 -07:00
Spencer
d66cc3515c
[canvas] migrate tests away from karma (#73121)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 10:43:18 -07:00
Poff Poffenberger
6631a296ef
[Canvas] Fix top left elements being automatically selected on workpad page loads (#72121)
* Fix top left elements being automatically selected on workpad page loads

* Remove unnecessary code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 12:18:33 -05:00