Dario Gieselaar
0275331514
Add @elastic/apm-ui as code owner of APM NP plugin ( #55674 )
2020-01-23 13:44:55 +01:00
Sébastien Loix
2cc9ed6dec
[Mappings editor] Accommodate legacy index templates ( #55388 )
2020-01-23 17:59:26 +05:30
Pierre Gayvallet
071db79a00
ApplicationService: emit from currentAppId$ in legacy mode ( #55536 )
...
* emit currentAppId$ in legacy mode
* fix karma tests
* fix karma json structure
* flip if/else
* filter undefined from currentAppId$
2020-01-23 12:37:37 +01:00
Felix Stürmer
4bd329e589
[Logs UI] Fix base path in tutorial URLs ( #55459 )
...
This fixes the way the base path is prepended to several tutorial URLs, which broke with #52867 .
fixes #55350
2020-01-23 12:27:52 +01:00
Pierre Gayvallet
a75436d93e
Run SO migration after plugins setup phase. ( #55012 )
...
* change setClientFactory api to setClientFactoryProvider
* cleanup and add test for service
* change the signatures of SO start/setup
* fix registerCoreContext by accessing stored start contract reference
* move migration inside `start`
* adapt and add service tests
* add doc and export new types
* adapt plugins code
* update generated doc
* better core access
* address some review comments
* remove parametrized type from SavedObjectsClientFactory, use KibanaRequest instead
* add logs when starting and ending so migration
* fix KibanaRequest imports
* NITs and review comments
* fix alerting FTR test
* review comments
2020-01-23 10:41:21 +01:00
Jean-Louis Leysens
9fc0d4ca4b
[Console] Styling for split panel ( #55530 )
...
* Update z-index on output panel
* Add z-index setting to console input too
2020-01-23 10:24:29 +01:00
Alexey Antonov
4a8542f859
browser[SEVERE] webpack: A component is changing an uncontrolled input of type %s to be controlled ( #55323 )
...
* browser[SEVERE] webpack: A component is changing an uncontrolled input of type %s to be controlled.
Closes : #41017
* fix PR comments
* fix PR comment
2020-01-23 12:21:50 +03:00
Sébastien Loix
111d0db7e3
[Mappings editor] Add missing parameters to object & nested ( #55152 )
2020-01-23 14:15:28 +05:30
Tiago Costa
2b66759dc7
fix(NA): allow plugins index to be a ts file in kbn-plugin-helpers ( #55194 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-23 02:30:32 +00:00
Garrett Spong
90e3bb0a62
[SIEM] [Detection Engine] All Rules fixes ( #55641 )
...
## Summary
This PR addresses bugs outlined in https://github.com/elastic/kibana/issues/54935
Including:
* Add Risk Score column
* Remove Method column
* Fixes `Showing Events` on Alerts table
* Fixes Tag overflow
* Shows Tags/Filters
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~
### For maintainers
- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~
2020-01-22 18:33:34 -07:00
Frank Hassanabad
da5710dac6
[SIEM][Detection Engine] Reworks actionClient to work with new platform
...
## Summary
* Changes action client to use new platform from their changes
* Removes unit tests not needed
* Updates unit tests that need updating
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~~
### For maintainers
~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )
2020-01-22 18:17:28 -07:00
Xavier Mouligneau
4348a34da9
[SIEM] Detections bugs ( #55626 )
...
* Fix permissions
* Fix selection of event type on timeline
* add link to rule name
* add filter in data provider
* Add rule status in saved object
* Fix reset field browser
* fix swallow error on creation of prepackaged rules
* fix test
2020-01-22 19:51:54 -05:00
gchaps
31c2a89827
[DOCS] Updates index template example ( #55601 )
2020-01-22 13:45:39 -08:00
Mike Côté
bc70c99c79
Add legacy support for actions client ( #55604 )
2020-01-22 16:26:34 -05:00
Nathan Reese
89e90648d6
[Maps] use higher resolution icons with larger fixed sizes ( #55596 )
...
* [Maps] use higher resolution icons with larger fixed sizes
* [Maps] use higher resolution icons with larger fixed sizes
2020-01-22 16:09:11 -05:00
Mike Côté
2e6f821d3f
Add xpack_main as a dependency in a few tests ( #55602 )
2020-01-22 15:36:24 -05:00
Brian Seeders
179dba2deb
Skip flaky test
2020-01-22 14:17:01 -05:00
Spencer
375f0b42a7
[csp] allow blob styles when running from source ( #54991 )
...
* [csp] allow blob styles when running from source
* update kbn/pm dist
* add kibanaServer service to saml_api_integration suite
* use common naming
* attempt to use env.packageInfo instead of IS_KIBANA_DISTRIBUTABLE const
* remove mock, clone rules before modifying
* pass env where necessary
* update core api docs
* make env optional in HttpConfig
* add tests for CspConfig changes, base header on this.rules
* fix test snapshot
* make env optional in HttpConfig too
* remove CspConfig.DEFAULT and make env a required constructor arg
* update csp_usage_collector tests
* update core api docs
* fix test name
* rename headerChangedFromDefault back to rulesChangedFromDefault
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 11:32:09 -07:00
Thomas Neirynck
003d6e9eed
[Maps] Disable add layer button when flyout is open ( #54932 )
2020-01-22 13:22:22 -05:00
Gil Raphaelli
773b0ed15d
allow env setting for xpack.apm.serviceMapEnabled ( #55476 )
2020-01-22 13:11:43 -05:00
James Gowdy
cc2f58a698
[ML] Corrects categorization message level ( #55573 )
2020-01-22 17:14:43 +00:00
MadameSheema
14269faa3a
[SIEM] Refactor to make Cypress tests more readable ( #54907 )
...
* extracts methods to tasks
* uses cypress api for assertions
* updates readme
2020-01-22 18:13:49 +01:00
Gidi Meir Morris
838d7ba213
migrate Actions to Kibana platform ( #55026 )
...
Migrates the Actions plugin from Legacy on to the Kibana Platform.
2020-01-22 17:08:54 +00:00
Paul Tavares
e2230d5d86
[Endpoint] FIX: Increase tests sleep
default duration back to 100ms ( #55492 )
...
Revert `sleep()` default duration, in the saga tests, back to 100ms in order to prevent intermittent failures during CI runs.
Fixes #55464
Fixes #55465
2020-01-22 11:55:41 -05:00
Larry Gregory
5d501411e1
Role Mappings - change default 'realm' field option to 'realm.… ( #55555 )
2020-01-22 11:18:22 -05:00
Yuliia Naumenko
5b641b706b
[Alerting] Exposed actionGroups in alertTypeRegistry API ( #55495 )
...
* Exposed actionGroups in alertTypeRegistry API
* Fixed functional tests
2020-01-22 08:16:51 -08:00
Dmitry Lemeshko
ff2bfe9146
[code search] removing test config and page object ( #55273 )
...
* [code search] delete PO and test config
* remove import
* remove from export
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 17:05:44 +01:00
patrykkopycinski
320b608315
[SIEM] Implement 7.6 Aggregated Feedback ( #55347 )
2020-01-22 16:52:55 +01:00
Daniil Suleiman
bda48391a8
Remove the VisEditorTypesRegistryProvider ( #55370 )
...
* Remove the VisEditorTypesRegistryProvider
* Update the doc
* Resolve conflicts in legacy.ts
2020-01-22 18:45:41 +03:00
Thomas Neirynck
a8674e6663
[Maps] Do not clear non-ordinal fields when modifying field-settings in tooltips or sort-order ( #55483 )
2020-01-22 10:37:28 -05:00
Victor Martinez
7436eb6c58
[build] Override org.label-schema Docker labels ( #53817 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 09:06:15 -06:00
Joe Reuter
4515cb1e55
Fix missing labels on certain axes and label filter configurations ( #47563 )
2020-01-22 15:59:56 +01:00
Joe Reuter
7c40a24fcc
Tutorial migration ( #54910 )
2020-01-22 15:31:11 +01:00
Alison Goryachev
7b145bffa0
[Watcher] Add support for additional watch action statuses ( #55092 )
2020-01-22 08:35:18 -05:00
Walter Rafelsberger
07d1dac0da
[ML] Fix entity controls update. ( #55524 )
...
Fixes an issue where the options in the internal state of the EntityControl component wouldn't update after a prop change. This had the effect that after a job change via the job selector, the entity control dropdown would stay empty.
2020-01-22 14:28:28 +01:00
James Gowdy
d47d20e758
[ML] Fixing ML's watcher integration ( #55439 )
2020-01-22 13:09:58 +00:00
Pete Harverson
b8b1c0283d
[ML] Fixes permissions checks for data visualizer create job links ( #55431 )
...
* [ML] Fixes permissions checks for data visualizer create job links
* [ML] Edits to permissions check following review
* [ML] Revert unintentional additions
2020-01-22 13:07:07 +00:00
Jean-Louis Leysens
b8d35105c7
[SearchProfiler] Move out of legacy ( #55331 )
...
* Initial move of searchprofiler into new platform directory, lots of things need testing
* Whitespace, clean up types and remove unused files
* First iteration of end-to-end plugin working
- Updated license check to only check for presence of basic license (not search profiler as a feature
- Updated the payload: removed types from validation
- Also added README in public regarding the location of styles
* Added extractProfilerErrorMessage function to interface with new error reporting from profiler endpoint
* Fix paths to test_utils
* Update I18n for search profiler
* Fix react hooks ordering bug with license status updates and fix test (wait for first license object before rendering)
* Added index.ts file to common in searchprofiler route
Marked types and values as internal
Removed unnecessary "async" from function
Update import to not use "src" alias
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 13:58:18 +01:00
Jean-Louis Leysens
d23d8f0afd
Restore 200 OK + response payload for save and delete endpoints ( #55535 )
2020-01-22 13:52:53 +01:00
Devin W. Hurley
e828a12954
[SIEM] [Detection Engine] Log time gaps as failures for now ( #55515 )
...
* log a failure to failure history if time gap is detected. stop-gap solution until a feature is fully fleshed out to report this and future messaging / monitoring.
* write date the gap warning occurred in the last_failure_at field, along with the status_date field.
2020-01-22 07:50:32 -05:00
Mikhail Shustov
3e69ea5f01
[NP] KibanaRequest provides request abortion event ( #55061 )
...
* add aborted$ observable to KibanaRequest
* complete observable on request end
* update docs
* update test suit names
* always finish subscription
* address comments
2020-01-22 13:34:35 +01:00
Shahzad
c6f9eff9f6
[Uptime] Ping List Disable expand row if no body present ( #54898 )
...
* update ping list
* update snap
* updated body
* update snaps
* fix i18n
* updated translation
* updated tests
2020-01-22 10:55:04 +01:00
Daniil Suleiman
ed04b17e0e
Move test utils inside the input_control_vis ( #55169 )
...
* Move test utils to an appropriate folder
* Change imports
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 12:41:33 +03:00
Sébastien Loix
1f10da865a
[Mappings editor] Add missing relations parameter ( #55003 )
2020-01-22 15:02:39 +05:30
Ben Skelker
34333aa1fd
fixes typos ( #55521 )
2020-01-22 10:29:54 +02:00
Dima Arnautov
5e711e423a
[ML] Fix counters and percentages for array fields on the Data visualizer page ( #55209 )
...
* [ML] update data visualizer endpoint to check doc counts
* [ML] fix mock for cardinality tests
* [ML] use actual field name for agg filtering instead of safeFieldName
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 07:08:58 +01:00
Frank Hassanabad
b5c6c9a3e3
[SIEM][Detection Engine] Tags being turned into null
...
## Summary
Test:
1.) Add a tag to a new rule
2.) Activate the rule
3.) Ensure the tag does not go away
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~~
### For maintainers
~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )
2020-01-21 21:56:35 -07:00
The SpaceCake Project
31e6a3b75a
rules part deux ( #55507 )
...
cuts and metadata additions
2020-01-21 22:59:33 -05:00
Lisa Cawley
ccbb2863e7
[DOCS] Add tip for using elasticsearch-certutil http command ( #55357 )
2020-01-21 18:54:54 -08:00
Frank Hassanabad
8f0c413ef5
[SIEM][Detection Engine] Critical blocker, fixes schema accepting values it should not ( #55488 )
...
## Summary
* This fixes the schema accepting values the UI cannot handle at this point with severity. It's best to just set it to a small fixed enumeration of values.
* From feedback from people the values should have more defaults and be more consistent in the schema so gave defaults for `from`, `to`, and `interval`.
* Removed dead query examples that cannot happen because immutable cannot be set by end users anymore
* Changes the version and other sections to be integer only and not allow floats
* Added unit tests
### Checklist
Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.
~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility )~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md )~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation ) was added for features that require explanation or tutorials~~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility ) were updated or added to match the most common scenarios
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist )~~
### For maintainers
~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )~~
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process )
2020-01-21 19:02:28 -07:00