Commit graph

29526 commits

Author SHA1 Message Date
spalger f634877b62 skip failing suite (#52969) 2019-12-12 18:12:44 -07:00
spalger 5fa9b1f0cc skip flaky suite (#48236) 2019-12-12 17:10:55 -07:00
Thomas Neirynck fe44595523 [Maps] Move field-meta implementation to style property (#52828)
* improve clarity

* rename for clarity

* feedback

* add comment

* remove debug statements
2019-12-12 16:19:06 -07:00
Bhavya RM 4765ed0fa1
A11y base tests (#51893)
a11y base tests
2019-12-12 17:20:55 -05:00
Spencer 7e822c5df5
[renovate] disable rebaseConflictedPrs (#52932) 2019-12-12 14:24:59 -07:00
Frank Hassanabad 98c54e8d51
[SIEM][Detection Engine] Adds a tags service and optimizes alert_id lookups
## Summary

* Adds a tags services for use by UI's that want to get a list of all the unique tags that are on all of the rules just like an aggregation
* Removes the horribly inefficient `alert_id` look up that was a full alert scan and instead uses an internal structure that it augments to the tags for fast `alert_id` look ups.
* Adds unit tests for the tags and internal structure tags
* Updates other unit tests

Usage for the UI:

```sh
GET /api/detection_engine/tags
```

or shell script:
```sh
./get_tags.sh
```

Returns:

```sh
[
  "tag_1",
  "tag_2"
]
```

Testing:
Ensure that the internal structure does not leak when doing any of these script/API calls
  * ./get_tags.sh
  * ./post_rule.sh ./rules/queries/query_with_tags.json
  * ./update_rule.sh ./rules/queries/query_with_tags.json
  * ./delete_rule.sh
  * ./find_rules.sh
  * ./find_rule_by_filter.sh "alert.attributes.enabled:%20true"
  * ./find_rule_by_filter.sh "alert.attributes.tags:tag_1"

Caveat:

You can do filter searches against tags that have the double underscore such as:

```sh
./find_rule_by_filter.sh "alert.attributes.tags:%20__*"
```

But that shouldn't be a big problem and more than likely no one will be naming something with double underscores.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2019-12-12 13:41:13 -07:00
Chris Davies f3813556ec
[Lens] Modify merge tables to use the same logic as auto date (#52931) 2019-12-12 15:35:37 -05:00
Chris Cowan 617c8d589a
[Metrics UI] Add AWS Metricsets to Inventory Models (#49983)
* Adding initial code for EC2

* Removing obsolute files; Adding EC2;

* Removing currentTimerange and replacing it with currentTime; Timerange will now be calcuated on the server

* Fixing AWS.s3 with Metrics Explorer

* Auto calculating timerange and interval based on metricset.period

* Adding S3 metricset

* Inital addition of RDS metrics

* Adding SQS and fixing a few things

* Fixing typescript error

* Adding RDS; Adjusting fields for S3; adding new formatter

* Return 60 seconds by detault

* Fixing types

* Removing i18n

* Fixing tests

* Fixing translations

* Fixes from merge

* Removing IDX from code not covered by #52354

* fixing tests

* Adding controls for crossliking; consolidating display name

* remove obsolete import

* Adding drop_last_bucket_support to TSVB models

* Changing type

* Fixing value per type

* remvoing obsolete translation

* Removing duplicate lines

* Removing icons from switcher

* Reducing boilerplate in Toolbar Items

* Changing file name
2019-12-12 13:17:30 -07:00
Tim Sullivan 31a6b5013d
[Reporting/Screenshots] add error for no shared items found on the page (#52022)
* [Reporting/Screenshots] add error for no shared items container found on the page

* wording adjustment
2019-12-12 12:58:11 -07:00
Josh Dover 2d3698972b
Add getStartServices API (#50231) 2019-12-12 13:21:35 -06:00
Melissa Alvarez deee1c08e9
[ML] DF Analytics creation: ensure advanced editor can be validated when empty (#52831)
* Check for undefined analysis config before validating

* update tests
2019-12-12 12:05:31 -07:00
Melissa Alvarez 0cd5bb0ca9
[ML] DF Analytics: create classification jobs results view (#52584)
* wip: create classification results page + table and evaluate panel

* enable view link for classification jobs

* wip: fetch classification eval data

* wip: display confusion matrix in datagrid

* evaluate panel: add heatmap for cells and doc count

* Update use of loadEvalData in expanded row component

* Add metric type for evaluate endpoint and fix localization error

* handle no incorrect prediction classes case for confusion matrix. remove unused translation

* setCellProps needs to be called from a lifecycle method - wrap in useEffect

* TypeScript improvements

* fix datagrid column resize affecting results table

* allow custom prediction field for classification jobs

* ensure values are rounded correctly and add tooltip

* temp workaroun for datagrid width issues
2019-12-12 12:02:04 -07:00
Bill McConaghy 79a8528646
fixing CODEOWNERS file (#52919) 2019-12-12 13:41:10 -05:00
Walter Rafelsberger af1a876f21
[ML] Color Range Legend component (#52794)
Introduces ColorRangeLegend, a reusable component to display a color range legend to go along with color coded table cells or visualizations such as heatmaps.
2019-12-12 19:16:32 +01:00
spalger 065ca6e041 skip flaky suite (#36011) 2019-12-12 11:13:06 -07:00
Spencer c8b42f09de
require yarn 1.21.1 to avoid binary planting vuln (#52899) 2019-12-12 10:15:23 -07:00
Matthias Wilhelm 85aea35c94
Deangularize and typescriptify ui/saved_object (#51562) 2019-12-12 17:35:22 +01:00
Wylie Conlon 06eeb59da3
[Lens] Fix sort crash (#52694) 2019-12-12 11:22:27 -05:00
Maja Grubic c5bf708c55
[Dashboard] Add visualization from dasbhoard empty screen (#52670)
* [Dashboard] Add visualization from dasbhoard empty screen

* Fixing linting errors

* Fixing i18n error

* Fixing unit test that was causing typecheck failure
2019-12-12 16:07:25 +00:00
Brian Seeders 1489c32a1d
Print out agent debugging links during CI (#52812) 2019-12-12 10:58:18 -05:00
patrykkopycinski 0c6516f1bc
Add babel-plugin-styled-components to webpack config (#52862) 2019-12-12 16:29:59 +01:00
Jean-Louis Leysens 21334e7b15
[Console] Fix load from remote (#52814)
* Fix load remote state

* Clean up variable usage, add comment, move forceRetokenize to private method

* Optimize sequence of checking hash on initial load
2019-12-12 16:15:39 +01:00
Thomas Watson 0279eb7b1c
Ensure APM agent config file path respects CWD (#52880) 2019-12-12 16:05:00 +01:00
Pedro Luiz Cabral Salomon Prado 4be168ce27 [Watcher] Removed overwritten property (#49998) 2019-12-12 10:03:10 -05:00
Luke Elmers 2caf640d48
[Data Plugin]: Remove export * for common code from public/server index files (#52821) 2019-12-12 08:00:44 -07:00
Thomas Watson f8ba2fdd78
Hide stderr git output during APM agent configuration (#52878) 2019-12-12 16:00:07 +01:00
Rudolf Meijering 45563b2574
Polish migration.md (#52764)
* Polish migration.md
 - Added saved objects legacy vs NP docs
 - Moved some data plugin docs into the right table
 - added table for server-side plugin services and added the features plugin

* Missing backticks
2019-12-12 15:27:52 +01:00
Chris Davies ba2e2588a3
Change ajax_stream to use new-line delimited JSON (#52797) 2019-12-12 09:18:09 -05:00
Joe Reuter 860be3c3eb
Stabilize dashboard save modal functional test (#52761) 2019-12-12 13:36:14 +01:00
Matthias Wilhelm 989a349ba8
[Discover] Place tooltip at bottom of filter button (#52720)
This prevents a hover conflict that makes filtering out value impossible in the last column
2019-12-12 08:31:55 +01:00
Marta Bondyra a05fef269a
Disable/enable filter with click+shift on a filter badge (#52751) 2019-12-12 06:57:27 +01:00
Nathan L Smith e488d9b02a
[APM] Make client-side routes static (#52574)
* [APM] Make client-side routes static

Turn `getRoutes` back into `routes` so we can just import it.

Checking for the service map being enabled isn't really necessary since we don't have any links to those routes and the backend routes are already flagged.
2019-12-11 21:45:46 -06:00
Aaron Caldwell 3d10370138
[Maps] Get basic structure of NP client shim in place (#52551)
* Move ui routes init to separate file

* Add index and general maps plugin template

* Add legacy shim. Pass uimodules in as legacy service

* Move ts-ignore

* Fix N/A ts error on uiModules

* Point index file toward legacy file. Minor NP additions
2019-12-11 19:14:30 -07:00
Dmitry Lemeshko 7ae5e7170a
update chromedriver to 79 (#52784) 2019-12-12 01:34:09 +01:00
gchaps db2d4bdf11
[DOCS] Adds example of assigning roles in Reporting (#52757)
* [DOCS] Adds example of assigning roles in Reporting

* [DOCS] Updates reporting security doc with review comments

* [DOCS] Incorporates review comments in reporting doc
2019-12-11 16:03:12 -08:00
Nathan Reese 5014f21cf4
Add instructions for setting up remote clusters needed for CCS and CCR (#52796)
* Add instructions for setting up remote clusters needed for CCS and CCR

* clean up
2019-12-11 16:38:15 -07:00
Jonathan Budzenski 618764355e
[docs] max-old-space-size (#52310)
* [docs] max-old-space-size

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/setup/production.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* _max_

* Update docs/setup/production.asciidoc

Co-Authored-By: Tyler Smalley <tylersmalley@me.com>

* max example

* move comma

* Update production.asciidoc
2019-12-11 17:36:55 -06:00
Chris Roberson 802423da89
[Monitoring] Fix 7.5 cloud test issues (#51781)
* Fix cloud test issues

* We don't have to skip for cloud
2019-12-11 16:34:32 -05:00
Nathan Reese eb8c0e33dd
[Maps] clean up source settings (#52644)
* [Maps] clean up source settings

* update es_search_source editor

* geo grid source

* pew pew source

* fix i18n

* doc updates for changing UI

* docs re-wording

* use correct image name

* update snapshot

* review feedback
2019-12-11 13:53:58 -07:00
Alexey Antonov e3f3dd15ba Fix ts types for AggType folder (#50049) 2019-12-11 13:51:37 -07:00
Nathan L Smith e0f155be31
[APM] Refactor core and plugin context (#52353)
* [APM] Refactor core and plugin context

Change the plugin to use a context that exposes:

```
export interface ApmPluginContextValue {
  config: ConfigSchema;
  core: AppMountContext['core'];
  packageInfo: PackageInfo;
  plugins: ApmPluginSetupDeps;
}
```

This replaces the `PluginContext` and `usePlugins` that were added with the NP shim, and the `KibanaCoraContext` and `useKibanaCore` from the observability plugin.

Remove the observability plugin since it's not being used anywhere else.
2019-12-11 14:49:51 -06:00
Melori Arellano 7a1db7f23b
[DOCS]Clarify that by default server.host only allows local connections (#52802)
* [DOCS]Clarify that by default server.host only allows local connections

* Update docs/setup/access.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/setup/settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/setup/settings.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
2019-12-11 13:22:45 -07:00
patrykkopycinski c6336c384b
Bump react-router (#52445) 2019-12-11 21:19:35 +01:00
Nathan Reese 9c203613db
[Maps] MapEmbeddable setLayerList (#52573)
* [Maps] MapEmbeddable setLayerList

* review feedback
2019-12-11 13:19:20 -07:00
Spencer 7ba47eebbf
[euiUtils] fix unnecessary useEffect dep (#52782) 2019-12-11 12:49:15 -07:00
Nathan Reese a50d3781af
[Maps] fix tooltips for CCS (#52793) 2019-12-11 12:39:04 -07:00
Christiane (Tina) Heiligers 3bb48e67c0
Fixes the link to advanced settings in the telemetry opt-in notice banner (#52699)
* Prepends base path to the link to advanced settings in the telemetry opt-in notice banner from all apps
2019-12-11 12:18:37 -07:00
Tim Sullivan 711b44b7fb
[Reporting/NP Migration] Remove server.expose of ExportTypeRegistry (#50973)
* [Reporting/NPMigration] typescriptify ExportTypeRegistry, remove from server.expose

* Minor routes registration cleanup

* move the ETR test file

* Re-pack the route registration, reduce LOC changes

* add EnqueueJobFn type

* Fix usage collector test

* remove a throw error used for development/debugging

* fix imports error

* Fix execute job tests

* wip test fixes

* test fixes for real

* fix more tests

* fix diffs

* Add TODOs about the ExportTypesRegistry.register unwrap the factory functions.

* really make headlessbrowserdriver required as an execute job factory option

* fix tests

* Use constants for license type keywords
2019-12-11 12:11:07 -07:00
Frank Hassanabad f53e1a9dbd
[SIEM][Detection Engine] Adds privileges API endpoint
## Summary

Adds a privileges API endpoint for the UI and people to query to check to see if their namespaced index is going to have the correct privileges or not.

Usage:

Testing:

Set up your user name and password to a test space for the CLI. Give whatever permissions
you want for restricted access to the test-space user, test-space role, and the test-space actual 
space to ensure everything works out as expected.

```sh
export ELASTICSEARCH_USERNAME=test-space
export ELASTICSEARCH_PASSWORD=(passwword)
export SPACE_URL=/s/test-space
```

Then use it like so

API:
```sh
GET /api/detection_engine/privileges
```

CLI:
```sh
./get_privileges.sh
```

Return will be something like this:

```sh
{
  "username": "test-space",
  "has_all_requested": false,
  "cluster": {
    "monitor_ml": true,
    "manage_ccr": false,
    "manage_index_templates": true,
    "monitor_watcher": true,
    "monitor_transform": true,
    "read_ilm": true,
    "manage_api_key": false,
    "manage_security": false,
    "manage_own_api_key": false,
    "manage_saml": false,
    "all": false,
    "manage_ilm": true,
    "manage_ingest_pipelines": true,
    "read_ccr": false,
    "manage_rollup": true,
    "monitor": true,
    "manage_watcher": true,
    "manage": true,
    "manage_transform": true,
    "manage_token": false,
    "manage_ml": true,
    "manage_pipeline": true,
    "monitor_rollup": true,
    "transport_client": true,
    "create_snapshot": true
  },
  "index": {
    ".siem-signals-test-space": {
      "all": false,
      "manage_ilm": true,
      "read": false,
      "create_index": true,
      "read_cross_cluster": false,
      "index": false,
      "monitor": true,
      "delete": false,
      "manage": true,
      "delete_index": true,
      "create_doc": false,
      "view_index_metadata": true,
      "create": false,
      "manage_follow_index": true,
      "manage_leader_index": true,
      "write": false
    }
  },
  "application": {}
}
```

Example permissions that work for managing all signal indexes across all spaces so that the user in question can create it for each space:

<img width="1274" alt="Screen Shot 2019-12-10 at 4 48 19 PM" src="https://user-images.githubusercontent.com/1151048/70579132-f63f8f80-1b6c-11ea-86f7-204fd2163cea.png">

Example permissions that work for managing only a specific signal index:
<img width="1234" alt="Screen Shot 2019-12-10 at 3 49 24 PM" src="https://user-images.githubusercontent.com/1151048/70579185-11aa9a80-1b6d-11ea-8a33-311e85ce5dc9.png">
 
Example permissions that work for an end user using signals across all spaces:
<img width="1229" alt="Screen Shot 2019-12-10 at 3 49 41 PM" src="https://user-images.githubusercontent.com/1151048/70579233-31da5980-1b6d-11ea-8b3a-85703ebcc57f.png">

Example permissions that work for an end user using signals for a a specific index:
<img width="1234" alt="Screen Shot 2019-12-10 at 3 49 24 PM" src="https://user-images.githubusercontent.com/1151048/70579259-43bbfc80-1b6d-11ea-94c1-8bbc65e621b2.png">


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2019-12-11 11:52:11 -07:00
Dmitry Lemeshko 7658e9c631
FTR: add 'throttle' option to cli (#33241)
* [ftr/cli] add throttling option

* [ftr/cli] add headless option, fix test
2019-12-11 19:41:25 +01:00