Commit graph

28841 commits

Author SHA1 Message Date
Larry Gregory
45617f0bbe
Adding NP spaces plugin to CODEOWNERS (#49963) 2019-11-01 15:37:38 -04:00
Mike Côté
2b6bd2f01e
Return referenced by count with each action on the find API (#49104)
* Initial work

* .kibana index configurable, NP ready implementation

* Fix broken jest tests

* Fix broken functional tests

* Add functional test

* Cleanup actions_client.test.ts
2019-11-01 15:15:54 -04:00
Mike Côté
bfdf61714e
Add ability to name alerts (#49035)
* Ability to name alerts

* Fix RawAlert TypeScript interface

* Update docs
2019-11-01 13:35:17 -04:00
Melissa Alvarez
568b8d3992
[ML] DF Analytics Regression results: Ensure error handling and table sort works correctly (#49929)
* add error handling for regression jobConfig fetch

* fix sorting change causing blank table by removing table render timeout

* Add label to table for number of docs obtained

* parameterize searchSize in documents fetched text
2019-11-01 12:12:01 -04:00
Gidi Meir Morris
128948c2a7
[task-manager] Improves messaging on errors due to inline scripts being disabled (#49860)
This PR detects when claiming tasks fails due to inline scripts being disabled in Elasticsearch and improves the message reported in the Kibana log.
2019-11-01 15:30:04 +00:00
Justin Kambic
f479f1e925
Add assertCloseTo calls to prevent off-by-one errors in unit tests for backend adapter. (#49928) 2019-11-01 11:02:54 -04:00
renovate[bot]
491ecf5865 Update dependency @elastic/charts to ^13.5.12 (#49874) 2019-11-01 09:45:23 -05:00
Aaron Caldwell
cf03665b98
[File upload] Switch to index pattern service shim (#49893)
* Switch to index pattern service shim

* Fix test breaking due to unrelated import in same file

* Move mock and require out of before call to top of file since they're not directly test-related

* Some minor cleanup

* One more thing...
2019-11-01 07:47:13 -06:00
Maryia Lapata
dbc9a52fd8
[Visualize] Centralize dependencies in kibana_services.ts (#49293)
* Centralize dependencies for Visualize  plugin

* Centralizing dependencies in editor and embeddable

* Remove unused deps, move imports

* Fix dangerouslyGetActiveInjector

* Move loading directive to kibana_services.ts

* Fix exceptions

* Get rid of injectI18n; fix chrome method invocation

* Update unit tests

* Fix TS

* Move data and Embeddable import

* Import VISUALIZE_EMBEDDABLE_TYPE directly

* Fix deps
2019-11-01 11:24:31 +03:00
Thomas Neirynck
90ddbfd9d4
[Maps] Ensure the query-object is populated (#49917) 2019-10-31 17:41:41 -04:00
Jean-Louis Leysens
e38501500e
[SearchProfiler] SearchProfiler to NP (#48795)
* Added the following components:

- highlight details (with render test)
- searchprofiler tabs
- (wip) profile tree
- (wip) shard details

* First iteration of ProfileTree component (needs render test)

* Remove space

* ProfileTree render test

* Add profile tree test to git index

* First iteration of editor component with render test

* First iteration of nearly functional public

* Fix highlight_details_flyout render test

* Move NP directory to public and fix import issue created by directly importing FormattedMessage

* Rendering and looking more normal

* Fix type issues and fix a11y for ace editor

* Added ability to do profile requests again and render into UI (styling WiP)

* Fix props in editor test

* Added empty tree placeholder component (with test), moved styling around into individual files (wip)

* Fix path

* Lots of style updates and added util for determining visible children (+test)

* Re-add missing badge and make it slightly wider (otherwise 100.00% cuts off to 100.0...)

* Delete legacy public!

* SCSS refactor + fix for re-rendering editor

* UI and server updates after license checks

* [skip ci] Add server np_ready code

* fix i18n

* Re-enable error annotations

* Minor UX improvements (focus editor after failed request and no tabindex for textarea without active license)
Added some spaces to make code more readable

* Removed xpackMain from ServerShim
Updated use of notifications -> notifications.toasts from np core setup
Removed TODO for using core.application.register (not available for legacy apps)

* Added placeholder component for loading state and implemented useReducer

* Refactor actions

* Changes after PR feedback:
- TS for unsafe utils test fixtures
- Safer use of .selfTime (no more NaN)
- Sentence case where applicable
- Cleaned up TODOs
- Fix styling issue with percentage on badges of profile tree
- Refactor name of profile hook (now useRequestProfile)
- Fixed copy paste issue in highlight flyout `Total time` -> `Self time`
- Restyled the profile button to be fill and not take up the full horizontal space
- Removed the `Type` input from the profiler query section

* Removed .type from backend and cleanup translations

* Disable responsive UI layout for now

* Remove buggy error annotation code

* - Refactored percentage badge to own component
- Updated styles after testing on IE11
- Updated styles after testing on Safari
- Chrome and FF worked on this commit

* Update missing i18n and fix use ace ui keyboard hook

* Update useEffect dependencies array for editor component

* Use absolute path to dev tools app (to fix CI)

* Remove file extensions

* Re-add missing data-test-subj
2019-10-31 22:23:17 +01:00
Wylie Conlon
6db835c8fb
[Lens] Fix bug with switching from subtype to subtype (#49915) 2019-10-31 17:14:40 -04:00
Spencer
96297ffae6
update elasticsearch to 16.5.0 (#49911) 2019-10-31 13:15:09 -07:00
Lisa Cawley
0d45daf6d4
[DOCS] Removes Extend your use case section (#49812) 2019-10-31 12:18:07 -07:00
Thomas Neirynck
479177a3ca
[Maps] Introduce typed styles (#49803) 2019-10-31 14:06:14 -04:00
Maja Grubic
559ac840c5
[Discover] EUI-fication of the filters (#48452)
* New filter UI

* Prototype of functionality

* EUIFication of filters in Discover

* Adding tests for field_selector component

* Replacing FieldSelector with EuiForm components

* Adding more discover field search tests

* Removing console statement

* Fixing failing functional test

* Removing obsolete snapshot

* design tweaks for filter popover

* use compressed style inputs

* Changing selectors to be EuiButtonGroup

* Removing unnecessary if statement

* Getting rid of ts-ignore warning
2019-10-31 17:53:40 +00:00
Søren Louv-Jansen
f4f43f5ad7
[APM] Remove redundant, custom typescript helpers (#49884)
Replace StringMap with Record<P, Q>
Remove unused IndexAsString
Remove custom Omit
2019-10-31 18:50:28 +01:00
Nathan Reese
70c05830ab
[Maps] data load event handlers (#49373)
* [Maps] data load event handlers

* update readme featuresCount to reflect variable name

* fix exception with EMS_TMS onDataLoadEnd

* wrap featuresCount in resultMeta object so different layer types can return different results
2019-10-31 11:05:29 -06:00
Melissa Alvarez
6f464ad0d2
[ML] DataFrame Analytics: Regression results view (#49667)
* enable analytics table view link for regression jobs

* add results table component

* can filter for training/testing

* add search functionality to table

* move shared types to analytics types file

* anchor isTraining,predicted,actual columns to left.

* ensure search string persists in search bar input

* show jobStatus badge in results view

* add jobType, status badge to outlier exploration page

* update exploration tests
2019-10-31 13:02:21 -04:00
Vadim Dalecky
75f31130f0
Dashboard container (#49600)
* feat: 🎸 create dasboard embeddable NP plugin, move panel action

* refactor: 💡 pass in getFactories() fn to "replace" action

* refactor: 💡 move dashboard container actions to NP

* refactor: 💡 remove action files from dashboard container in LP

* refactor: 💡 move dashboard grid to NP plugin

* refactor: 💡 move Embeddable SASS to the NP

* refactor: 💡 move dashboard container panel to NP

* refactor: 💡 move dashboard container viewport to NP

* refactor: 💡 move dashboard constant to constants file

* refactor: 💡 move dashboard_continaer file to NP

* refactor: 💡 move dashboard_container_factory.tsx to NP

* chore: 🤖 disable injected React components

* feat: 🎸 fill in NP plugin

* feat: 🎸 move expand panel action to NP

* feat: 🎸 move replace action panel to NP

* feat: 🎸 move dashboard_contaienr to NP

* chore: 🤖 delete LP dasboard container plugin shim

* chore: 🤖 delete LP dashboard_embeddable_container plugin

* chore: 🤖 point translations to the NP plugin

* test: 💍 re-enable dashboard container tests

* chore: 🤖 fix TypeScript type errors

* chore: 🤖 fix more TypeScript tyeps

* test: 💍 fix import in .js test

* feat: 🎸 use <SavedObjectFinder> in dashboard container

* feat: 🎸 add full screen button to dashboard container

* fix: 🐛 execute Chrome hiding only once

* chore: 🤖 put back temporary type substitutions

While moving this plugin file-by-file those types were not available

* chore: 🤖 revert back kibana_react imports

* fix: 🐛 address review comments
2019-10-31 17:56:39 +01:00
Aaron Caldwell
869e0c0fbf
Add buffer to chunk size to prevent risk of oversize post requests (#48595) 2019-10-31 10:30:57 -06:00
Justin Kambic
b4ecd5ab91
[Core] Add different request lib to telemetry_analytics in place of $http (#49671)
* Add axios to telemetry_analytics in place of .

* Remove axios in favor of fetch.
2019-10-31 12:05:38 -04:00
Kaarina Tungseth
ded8950559
[DOCS] Canvas embeddable workpads (#45027)
* [DOCS] New Canvas snapshots documentation

* Changes from 1-Oct meeting

* Some tweaks

* Added beta tag

* Fixes to images

* Comments from Gail and Tim

* New images

* Final changes
2019-10-31 10:45:43 -05:00
Thomas Neirynck
a7dfc8feca
[Maps] Reuse constants when registering feature (#49862) 2019-10-31 11:37:51 -04:00
Spencer
5fa99d47ee
use a custom wrapper around chance with longer defaults to avoid conflicts (#49653)
* use a custom wrapper around chance with longer defaults to avoid conflicts

* fix a reference to chance

* fix another reference to chance service
2019-10-31 07:09:32 -07:00
Nathan Reese
616911cb51
[Maps] fix removal of multi fields for tooltip field selection (#49816) 2019-10-31 07:46:12 -06:00
sainthkh
faa48d591d eslint no-restricted-path false positive: bug caused by dir names that start with "index". (#46544)
* index* to index.{ts,tsx}

* Added test.

* Added invalid test.

* Added js.
2019-10-31 12:40:53 +02:00
Daniil Suleiman
9e00c78f4c
[Vis: Default editor] Create number_input with numeric value required (#48117)
* Created number_input with numeric value required

* Remove extra license

* Make value be possibly null
2019-10-31 11:27:57 +03:00
Dima Arnautov
c885f3c9ff
[ML] Improve processing of groups in data recognizer wizard (#49310)
* [ML] add support for job overrides

* [ML] disable Save button for invalid form, add translation

* [ML] add a tooltip for edit button

* [ML] fix IE flex layout issue

* [ML] conditionally set jobOverrides to the request payload

* [ML] remove hideCloseButton

* [ML] fix applyJobConfigOverrides

* [ML] processArrayValues

* [ML] check deeper arrays

* [ML] PR remarks

* [ML] check for an empty value
2019-10-31 08:54:20 +01:00
Dmitry Lemeshko
d5831e832b FTR: fix "DevToolsActivePort file doesn't exist" error on star… (#48874) 2019-10-30 22:18:46 -07:00
Justin Kambic
616ec1ece4
[Uptime] Add zero monitors down heading (#48257)
* Add zero down heading.

* Create new heading component for snapshot.

* Add tests and cases for no monitors.
2019-10-30 21:22:08 -04:00
Spencer
c78973b3ae
[canvas] avoid progress reporting in other webpack execution (#49802) 2019-10-30 15:45:31 -07:00
Thomas Neirynck
f7d2c1520c
[Maps] Introduce Agg Source (#49782)
This removes duplication from geogrid, pewpew and term-sources by introducing a top-level agg-source class.
2019-10-30 17:41:49 -04:00
Brian Seeders
6468e794fc
Flaky test runner improvements/fixes (#49367)
* Allocate multiple flaky test runner agents as executions grow

* WIP support for deleting kibana install dir during CI

* Add setup script for testing scripts

* Add REMOVE_KIBANA_INSTALL_DIR=1 to flaky test runner

* Change flaky test runner worker processes from 8 to 12
2019-10-30 17:24:28 -04:00
Kerry Gallagher
7cbe1df1a4
[Logs UI] Improve data structures / access / formatting for the log rate results page (#49158)
* Refactor data structures and data formatting

* Handle the "unknown" partition scenario in a more robust way

* Remove temporary fix for the ML link URLs

* Change Results to LogRateResults
2019-10-30 20:33:08 +00:00
Justin Kambic
7964221cd6
[Uptime] Add pagination functional test (#47633)
* Remove depdency on legacy interface.

* Remove custom interface, use common breadcrumb type.

* Add HTML template for app react entry point.

* Update app props.

* Add constant for react app entry point.

* Remove dependency on legacy capabilities provider.

* Delete legacy kibana framework adapter.

* Add New Platform adapter, reference in startup code.

* Remove dependency on legacy capabilities function.

* Delete reference to obsolete interface.

* Fix busted types in new adapter.

* Add new plugin class, delete old bootstrap code.

* Update routing/functional tests.

* Provide default for potentially-undefined value.

* run x-pack-ciGroup6 40 times

* Reinsert firefox skip tag.

* Update functional tests to work with newly-merged fixtures.

* Add functional test for pagination.

* Update obsolete test snapshots.

* Return CI to normal.

* Return CI to normal.

* Fix broken test expect.

* Fix type-related issue in test and update snapshot.
2019-10-30 16:19:52 -04:00
liza-mae
56c32a24fd
Enable visual tests (#47861)
* Enable visual tests

* Uncomment visual tests jobs

* More testing - use dev token and only run visual tests

* Fix dev token

* Fix token again

* Skip infra tests

* Set style of table

* Try setting discover sample size

* Fix Jenkinsfile

* Remove login_page test from config (it skipped but failing)

* Remove line

* Prep to merge, revert token and update Jenkinsfile

* Try skipping at Security level, instead of removing from config
2019-10-30 14:19:40 -06:00
Justin Kambic
3fee427fa4
Add HOC for wrapping snapshot histogram component. (#49268) 2019-10-30 16:05:34 -04:00
Steph Milovic
c72faebccd
[SIEM] fix bug that fails to match index patterns with leading wildcard (#49735) 2019-10-30 13:59:03 -06:00
Garrett Spong
5fc42f5b21
[SIEM] Fixes maps filter on array property to use single property value instead of array value (#49706)
## Summary

Resolves https://github.com/elastic/kibana/issues/49534

Filtering on an array property within the map tooltip now uses the single property value instead of the array value. Ended up not showing more than 1 item as part of the `DefaultFieldRenderer` because of this open issue (https://github.com/elastic/ingest-dev/issues/474) which causes layout of subsequent items to be off.

<img width="715" alt="Screen Shot 2019-10-29 at 21 28 32" src="https://user-images.githubusercontent.com/2946766/67826918-c6906880-fa93-11e9-9c88-cbf85672ad99.png">


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2019-10-30 13:38:13 -06:00
Felix Stürmer
019ee9220d
[Logs UI] Fix log rate analysis tab title and route (#49646)
This aligns the log rate analysis tab title with the requirements. It also changes the sub-route from `analysis` to `log-rate` and performs some additional cleanup in anticipation of the soon-to-be-added category analysis tab. The page redirects from `/logs/analysis` to `/logs/log-rate` to reduce confusion in the build candidates.

fixes #49198
2019-10-30 20:01:33 +01:00
Aleh Zasypkin
27c464e35d
Fix link to OpenID Connect Elasticsearch guide from the Kibana OpenID Connect docs. (#49731)
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
2019-10-30 19:40:29 +01:00
Lisa Cawley
2589441527
[DOCS] Fixes link to Kibana monitoring documentation (#49528) 2019-10-30 10:49:46 -07:00
Nathan L Smith
3d9665d21c
[APM] Error stack trace improvements (#49254)
* some error stuff

* add new modules

* more stuff

* revert change to database

* Fix type check and test

* Replace stacktrace with stack trace

* update i18n and snapshots

* Updates based on feedback

* Updates based on @formgeist's feedback

* Remove unused import
2019-10-30 12:41:50 -05:00
Devin W. Hurley
1631900aa6
Replace Scroll query with Search After query (#48844)
* replaces scroll with search_after query. This fixes one issue where too many scroll contexts were being created and blocking queries from running on elasticsearch. Search_after fixes that.. I think there are still issues around task manager dropping new tasks because it runs out of available workers. Bulk Index is still a very slow process. Using search_after doesn't seem to be any faster than scroll, but it does keep this from blowing up ES.

* updates sortId type to match SearchResult type of string[]

* utilizes track_total_hits to know when to end the search_after query.. with scroll the query just would return 0 hits but with search_after we are constantly getting new data with no specified point to end it. Also this updates the search query to include the filter as my original search was not including that. big bug.

* type guard for acquiring total value from search response

* removes property leftover from rebasing with master

* removes defunct getFilter function. the filter is now being passed in from the params in signals_alert_type

* removes unused imports

* parameterizes default index for bulk index request

* adds typeof to do type guarding in lieu of extra function

* removes unused TotalValue import, removes optional requirement from size type property and unions undefined, adds size as parameter to rest signal routes

* no idea what happened here

* adds franks test from review - will update with more tests

* adds BulkResponse type, updates logic for when first search result for reindexing is empty

* fixes type error after introducing new logic for when first search result is empty
2019-10-30 13:35:04 -04:00
Matt Bargar
1dcec9d210
Add nested field support to KQL (#47070)
This PR adds a new syntax to KQL for querying nested fields.

Nested fields can be queried in two different ways:

Parts of the query may only match a single nested doc (bool inside nested). This is what most people want when querying on a nested field.
Parts of the query may match different nested docs (nested inside bool). This is how a regular object field works but nested fields can be queried in the same way. Although generally less useful, there are occasions where one might want to query a nested field in this way.
The new KQL syntax supports both.
2019-10-30 13:07:43 -04:00
James Gowdy
636fa27107
[ML] Fixing some of the eslint rule breakages in ML (#49716) 2019-10-30 16:38:08 +00:00
Angela Chuang
3c1e649e67
[SIEM] fix incorrect inspected query for kpi network (#49695)
* fix incorrect inspected query for kpi network

* update mock data
2019-10-30 12:24:10 -04:00
Liza Katz
0118bdec29
Pass overlays service to createFilterAction (#49736)
* Pass overlays service to createFilterAction

* Changed import path
2019-10-30 18:21:11 +02:00
Walter Rafelsberger
0e341b2088
Fix CODEOWNERS. (#49740)
Fixes the format of the CODEOWNERS file to ping both ML-UI and ES-UI team for the transform plugin. Having the same path twice for each team ignored the second rule. This update has the path only once with both teams on the same line.
2019-10-30 09:12:17 -07:00