Commit graph

28841 commits

Author SHA1 Message Date
Tim Sullivan 0e9b576b6f
[Reporting] Convert main Reporting index to TS (#49129)
* [Reporting] Convert main Reporting index to TS

* fix typo that broke build

* fix type file import

* fix the ts imports for build
2019-11-14 07:29:49 -07:00
Liza Katz 6219cfdc16
Moved filter generator ⇒ NP (#50118)
* Moved filter generator to NP

* Deleted unused test

* Fixed browser test + fix to discover actions

* Added jsdcos
2019-11-14 16:26:58 +02:00
Peter Pisljar 4f888196b7
remove angular from Vis (#50402) 2019-11-14 07:34:20 -05:00
Anton Dosov b5a0d4b03d
Add test for implicitly fixed #45150 (#50284)
#45150 appeared in 7.3 and disappeared in 7.4
2019-11-14 13:08:50 +01:00
ffknob 6a6fc51bf8 [ML] sets truncateText to true for the 'Latest timestamp' column (#50004)
* sets truncateText to true for the 'Latest timestamp' column

* Truncates the creation time at the analytics panel
2019-11-14 11:31:58 +00:00
Marta Bondyra 9aca58966d
feat: replace autocomplete for exists operator from ':*' to ': *' (#50293) 2019-11-14 12:22:39 +01:00
Dima Arnautov f24497745b
[ML] Fix escape special characters for Lucene query language (#50494)
* [ML] avoid special characters escaping for Lucene query language

* [ML] unit test

* [ML] init the callback at the higher scope
2019-11-14 12:07:59 +01:00
Liza Katz 3eea7284ef
Move query utils ⇒ NP (#49636)
* Move query utils to NP

* Updated Query imports

* A few import fixes

* Fix import

* Fix docs
2019-11-14 13:06:36 +02:00
MadameSheema cbc1c7d52f
fixes inspect tests (#50510) 2019-11-14 10:51:25 +01:00
Joe Reuter 62d035390e
Shim dev tools (#49349) 2019-11-14 10:38:44 +01:00
Jean-Louis Leysens d43c5c618c
[Rollup] Fix for clone job workflow (#50501)
* First iteration of fix for clone job workflow

* Second iteration of fix, previous had race condition :gasp:

* Slight revision to logic and added test for wizard with rollup job after index pattern changed
2019-11-14 10:12:18 +01:00
Cauê Marcondes 57d090f2f8
Empty message "No data available" for Labels and User metadata sections missing (#49846)
* Adding missing data message when sections are required

* refactoring test

* fixing unit test
2019-11-14 08:48:33 +01:00
Cauê Marcondes 353619b6aa
[APM] Duration by Country map doesn't take transactionName into account (#50315)
* filtering country map by transaction name

* filtering country map by transaction name

* filtering country map by transaction name
2019-11-14 08:47:52 +01:00
Pierre Gayvallet e04adbe34b
Remove react references from core Notifications apis (#49573)
* add reactMount util to kibana_react

(kibana-react) properly export reactMount

* add MountPoint types and utility

* adapt toast API to no longer accept react elements

(toast API) properly export new Toast type

* adapt calls by using reactMount

createNotifications: do not wrap if text

* update generated doc

* add custom snapshot serializer for reactMount

* fix unit tests

fix xpack unit tests

* adapt non-ts calls

* do not add __reactMount__ property in production

* remove string check on createNotifications

* fix typo and small fix using obj spread

* improve react mount snapshot serializer

* simplify convertToEui

* rename reactMount to toMountPoint

* adapt newly added calls

* move mount types to proper file

* use new Mount types for OverlayBanner apis

* fixing typo

* adapt new calls

* use destructured imports
2019-11-14 08:40:14 +01:00
Oliver Gupte cd67addf15
Updated APM Indices endpoints to use the SavedObjectsClient from the legacy request context, and set the apm-indices schema object to be namspace-agnostic
- rename apm-telemetry save object mapping -> apm-services-telemetry (#49994)
- move saved object types and document IDs to constants file
- Updated APM Indices endpoints to use the SavedObjectsClient from the
  legacy request context, and set the apm-indices schema object to be
  namspace-agnostic.
2019-11-13 21:26:22 -08:00
Phillip Burch bc7b7df00d
[Metrics UI] Calculate interval based on the dataset's period (#50194)
* Calculate interval based on the dataset's period

* Remove unused import

* Handle empty data case

* Update x-pack/legacy/plugins/infra/server/utils/calculate_metric_interval.ts

Co-Authored-By: Chris Cowan <chris@chriscowan.us>

* Update x-pack/legacy/plugins/infra/server/routes/metrics_explorer/lib/populate_series_with_tsvb_data.ts

Co-Authored-By: Chris Cowan <chris@chriscowan.us>
2019-11-13 21:59:04 -06:00
Tiago Costa 70c8a14eca
chore(NA): add new platform discovered plugins as entry points to check for dependencies on clean dll tasks (#50610) 2019-11-14 02:59:22 +00:00
Ahmad Bamieh 071656b908
[Telemetry] change of optin status telemetry (#50158)
* initial push

* self code review

* ignore node-fetch type

* usageFetcher api

* user agent metric

* telemetry plugin collector

* remove extra unused method

* remove unused import

* type check

* fix collections tests

* pass kfetch as dep

* add ui metrics integration test for user agent

* dont start ui metrics when not authenticated

* user agent count always 1

* fix broken ui-metric integration tests

* try using config.get

* avoid fetching configs if sending

* type unknown -> string

* check if fetcher is causing the issue

* disable ui_metric from functional tests

* enable ui_metric back again

* ignore keyword above 256

* check requesting app first

* clean up after all the debugging :)

* fix tests

* always return 200 for ui metric reporting

* remove boom import

* logout after removing role/user

* undo some changes in tests

* inside try catch

* prevent potential race conditions in priorities with =

* use snake_case for telemetry plugin collection

* refactors needed to extract cluster uuid based on collection

* refactoring uuid getters

* revert unneeded changes from merge

* finish server/browser fetching

* skip a test  :(

* skip handle_old

* merge master

* fix failing tests
2019-11-14 02:20:27 +02:00
Frank Hassanabad 6f7ca4a4f4
[SIEM][Detection Engine] REST API Additions (#50514)
## Summary

Added these to the create and update API:
* tags - Array string type (default [])
* False positives - Array string type (default [])
* immutable - boolean (default -- false)

Added these instructions to the READM.md
* Added "brew install jq" for all the scripts to work in the scripts folder in README.md
* Added tip for debug logging

Changed these shell scripts: 
* Removed the delete all api keys from the hard_reset script
* Changed the script for converting to rules to use the new immutable flag.

Testing
* Added unit tests for new schema types
* Added ad-hoc test for scripts
* Test ran through the saved searches 

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-11-13 17:13:44 -07:00
gchaps f11f0ff5ab
[DOCS] Removes dashboard-only mode doc (#50441) 2019-11-13 14:57:17 -08:00
ffknob 88aebf07b6 [Filters] Fix operator overflowing out popover (#50030)
* Fixes combo overflow when the selected field is large

* Prettier quotes

* Changes the style class attribute to use Eui calculation and also the
class name to conform to the BEM naming convention

* Lints src/plugins/newsfeed/public/lib/api.test.ts
2019-11-13 17:23:37 -05:00
Mike Côté bff235bf77
Change telemetry optIn to default to true (#50490)
* Change optIn to default to true

* Update snapshot

* Fix eslint errors
2019-11-13 17:10:36 -05:00
Nathan Reese 9212eb2d5f
[Maps] make grid rectangles the default symbolization for geo grid source (#50169)
* [Maps] default grid aggregation source rendering to grid

* Update docs/maps/maps-aggregations.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* add animated gif and text describing the animation

* clean up text

* simply text

* combine link to getting started with previous paragraph
2019-11-13 14:28:51 -07:00
Eli Perelman 6955593d01
Allow registered applications to hide Kibana chrome (#49795)
* Allow registered applications to hide Kibana chrome

* Fix bug in flipped value of application chromeHidden

* Add additional test for app chrome hidden versus chrome visibility

* Rename chromeHidden to chromeless

* Default chrome service app hidden observable to same value as force hidden

* Consolidate force hiding in chrome, add functional tests

* Move chromeless flag to App interface to prevent legacy applications from specifying

* Address review nits to improve separation
2019-11-13 14:57:15 -06:00
Greg Thompson 998b0e6fd6
Upgrade EUI to v14.9.0 (#49678)
* eui to 14.9.0

* euiswitch updtates

* misc snapshot

* x-pack functional fixes

* more euiswitch functional test fixes

* label-less switches for spaces management

* more euiswitch fixes

* telemetry form a11y

* snapshot update

* label updates

* more switch updates

* lint
2019-11-13 14:54:21 -06:00
Chris Cowan 1010f285b3
[Metrics UI] Convert layouts to use React components (#49134)
* Convert layouts to use React compontents

- This PR closes #48808
- Move all files under pages/metrics

* Renaming layout files; Fixing some types; Removing unused types

* Fixing naming issue

* Fixing path

* Fixing i18n stuff

* [Metrics UI] Move toolbars under inventory models

* Fixing imports; wrapping code in useMemo to optimize

* removing unused imports

* Removing prototype page
2019-11-13 15:26:11 -05:00
Lukas Olson 013f3ebe87
[Search service] Add support for ES request preference (#49424)
* Add support for ES preference

* Fix name of test
2019-11-13 13:18:04 -07:00
Tim Sullivan cf435b83ea [Newsfeed/Lint] fix chained fn lint (#50515) 2019-11-13 13:21:30 -06:00
Chris Roberson aca8ddb4f0
[Monitoring] Fix logstash pipelines page in multi-cluster environment (#50166)
* Ensure we pass in the clusterUuid

* Add test
2019-11-13 12:42:40 -05:00
MadameSheema bf8f1306b3
[SIEM] Events viewer fixes (#50175)
* updates KQL_SEARCH_BAR locator

* updates HEADER_SUBTITLE locator

* waits for the events to be loaded
2019-11-13 18:19:25 +01:00
Tim Roes fce52133d8
Upgrade Prettier 1.19 (#50487)
* Upgrade Prettier to 1.19

* Fix new prettier style
2019-11-13 17:00:02 +01:00
Yuliia Naumenko a50dbefb62 [Newsfeed] UI plugin for Kibana (#49579)
* Added base folder structure for Newsfeed plugin

* Added base folders for lib and component

* Added newsfeed button to navigation controls on the right side

* add getApi() to return api data observable (#49581)

* Added flyout base body and provided EuiHeaderAlert component inside the newsfeed plugin

* Moved newsfeed plugin to OSS and added for the styles purpose new folder for legacy plugin 'newsfeed' with the same id to support this

* Added subscribe on fetch newsfeed change

* Add NewsfeedApiDriver class (#49710)

* add NewsfeedApiDriver class

* fix xpack prefix

* add corner case handling

* Added data binding to the ui

* added EuiHeaderAlert style overrides (#49739)

* Fixed due to comments on PR

* add missing fields to NewsfeedItem and FetchResult

* fix templating of service url

* gracefully handle temporary request failure

* Mapped missing fields for data and badge

* Fixed typos issues

* integrate i18n.getLocale()

* allow service url root to be changed in dev mode

* replace a lot of consts with config

* fix flyout height (#49809)

* Add "error" field to FetchResult: Error | null

* simplify fetch error handling

* Do not store hash for items that are filtered out

* add expireOn in case it is useful to UI

* always use staging url for dev config

* unit test for newsfeed api driver

* simplify modelItems

* Fixed eslint errors

* Fixed label translations

* Add unit test for concatenating the stored hashes with the new

* add newsfeed to i18n.json

* Fixed expression error

* --wip-- [skip ci]

* fix parse error

* fix test

* test(newsfeed): Added testing endpoint which simulates the Elastic Newsfeed for consumption in functional tests

* add tests for getApi()

* add tests for getApi

* Added no news page

* fix fetch not happening after page refresh with sessionStorage primed

* test(newsfeed): Added testing endpoint which simulates the Elastic Newsfeed for consumption in functional tests

* Added loading screen

* Small fixes due to comments

* Fixed issue with stop fetching news on error catch

* test(newsfeed): Configure FTS to point newsfeed to the simulated newsfeed endpoit

* Fixed browser error message: Invariant Violation: [React Intl] Could not find required `intl` object. <IntlProvider> needs to exist in the component ancestry.

* Fixed typo issue in label name

* polish the code changes

* Add simple jest/enzyme tests for the components

* honor utc format

* Filter pre-published items

* Fall back to en

* retry tests

* comment clarfication

* Setup newsfeed service fixture from test/common/config

* Added base functional tests for newsfeed functionality

* valid urlroot is for prod

* add documentation for the supported enabled setting

* more urlRoot

* --wip-- [skip ci]

* add the before for fn

* add ui_capabilties test

* update jest snapshot

* Fixed failing test

* finish newsfeed error functional test

* include ui_capability config

* error case testing in ci group 6

* refactor(newsfeed): moved newsfeed api call so that it is done before its use

* code polish

* enabled newsfeed_err test in CI
2019-11-13 08:48:34 -07:00
Liza Katz 4c8afa76d3
Move temporary types in data plugin to common/types. (#50280)
* Move temporary ui imported types in data plugin to common/types.
Remove unnecessary mocks.

* Updated dashboard, discover and visualize mappings - type removal

* Revert "Updated dashboard, discover and visualize mappings - type removal"

This reverts commit 5e931ce62a.
2019-11-13 17:28:21 +02:00
Dario Gieselaar f317c25852
[APM] Use callWithInternalUser for agent configuration endpoin… (#50211)
* [APM] Use callWithInternalUser for agent configuration endpoints

Closes #50050.

* Review feedback

* Use internalClient for agent conf queries only
2019-11-13 15:42:46 +01:00
Corey Robertson 7bb968c554
[Canvas] Fix incompatible ie11 method (#50007)
* Fix incompatible ie11 method

* Comment about origin of polyfill
2019-11-13 08:59:50 -05:00
Artyom Gospodarsky 3a2e865b2f
Move mockFields and mockIndexPatterns to relevant directories (#50012)
* Move mockFields and mockIndexPatterns to relevant directories

* Restructure stubs store

* Remove test code from production files

* Restructure stubs store
2019-11-13 17:26:30 +04:00
James Gowdy 167dd7f5a0
[ML] Server info service refactor (#50302)
* [ML] Server info service refactor

* removing new job defaults

* changes based on review

* renaming all ml server info getter functions

* missed a file
2019-11-13 11:05:49 +00:00
Pierre Gayvallet e6ea2bf16b
Remove internal platform types exports (#50427)
* remove exports of internal core types

* updates documentation

* rename internal types file
2019-11-13 09:30:38 +01:00
Dario Gieselaar 6c3ee583c8
[APM] Document apm_oss.metricsIndices and `apm_oss.sourcemap… (#50312)
Closes #49847.
2019-11-13 08:54:18 +01:00
Ahmad Bamieh 35a5b770d3
[Telemetry] Server side fetcher (#50015)
* initial push

* self code review

* ignore node-fetch type

* usageFetcher api

* user agent metric

* telemetry plugin collector

* remove extra unused method

* remove unused import

* type check

* fix collections tests

* pass kfetch as dep

* add ui metrics integration test for user agent

* dont start ui metrics when not authenticated

* user agent count always 1

* fix broken ui-metric integration tests

* try using config.get

* avoid fetching configs if sending

* type unknown -> string

* check if fetcher is causing the issue

* disable ui_metric from functional tests

* enable ui_metric back again

* ignore keyword above 256

* check requesting app first

* clean up after all the debugging :)

* fix tests

* always return 200 for ui metric reporting

* remove boom import

* logout after removing role/user

* undo some changes in tests

* inside try catch

* prevent potential race conditions in priorities with =

* use snake_case for telemetry plugin collection

* usageFetcher -> sendUsageFrom

* more replacements

* remove extra unused route

* config() -> config

* Update src/legacy/core_plugins/telemetry/index.ts

Co-Authored-By: Mike Côté <mikecote@users.noreply.github.com>

* Update src/legacy/core_plugins/ui_metric/server/routes/api/ui_metric.ts

Co-Authored-By: Mike Côté <mikecote@users.noreply.github.com>

* config() -> config

* fix SO update logic given the current changes

* fix opt in check

* triple check

* check for non boolean

* take into account older settings

* import TelemetryOptInProvider

* update test case
2019-11-13 09:18:57 +02:00
Xavier Mouligneau 59e0a1cba1
[SIEM] Detection engine placeholders (#50220)
* attempt at getting nav working

* fix detection-engine href redirect issue

* rough out basic page routing

* kql placeholder

* update page and panel headers

* rough out card table poc styles

* change HeaderPanel to HeaderSection

* cleanup and unit test updates

* rough out utilityBar poc

* clean up UtilityBar naming and styles

* support popovers in utility bar

* refactor icon side

* UtilityBar unit tests

* remove page tests for now

* adjust routes

* add comment

* cleanup chart

* open/closed signals content toggle

* remove EuiFilterButton icons

* fix misaligned popover button

* add split prop for HeaderSection

* fleshing out activity monitor table

* update global header to include logo

* fix tests

* correct table types; thanks Garrett!

* LinkIcon comp poc

* fix bugs, errors, tests

* rm import

* table cleanup

* correct merge errors

* switch All Rules to EuiBasicTable

* expand table types and values

* fleshing out all rules table

* rough out rule details

* move chart to separate comp

* update supplement layout

* example rule fail

* switch to new discover-style search

* add ProgressInline comp

* update unit tests and snapshots

* cleanup

* correct merge weirdness

* move text styles to all subtitle items

* correct invalid nav markup; update tests; cleanup

* fix console errors

* add empty page

* change to EuiButtonEmpty in HeaderGlobal

* overflow popover

* rough out edit layout

* new WrapperPage comp POC

* cleanup

* var for timeline gutter

* tests and snapshots update

* fix type + review + re-arrange code

* adding feature flag + fix route issue

* fix type with unit test

* Removing unused translation
2019-11-12 20:54:31 -05:00
Shahzad 9c38e3ef31
[Uptime] Donut chart loader position centered vertically (#50219)
* added height for snapshot como

* added constant for height
2019-11-13 02:25:08 +01:00
Patrick Mueller 2c49ce74b8
update telemetry banner notice text (#50403)
Simplifies the telemetry banner for customers.
2019-11-12 18:17:23 -05:00
Lukas Olson 573f99054a
Fix aborting when searching without batching (#49966) 2019-11-12 15:16:48 -07:00
Joel Griffith fada20d523
[Telemetry] Remove telemetry splash page and add conditional messaging (#50189)
* Removing tel splash page in UI layer

* Removing more components

* New disclaimer text

* Removing telemetry i18n text

* More i18n text removals

* Snapshot updates

* Snapshot tests + quick links for tel opt-out when possible

* Fixing TS issues in test
2019-11-12 13:47:40 -08:00
Joe Reuter 5c6eb9c6ce Revert chromedriver update (#50324)
* deprecate include_type_name

* include_type_name

* remove doc from mappings

* Updated timelion mapping

* Updated spaces and uptime mapping

* monitoring apm mapping

* Updated more mappings

* 2 more mappings

* Updated reporting mappings after syncing with @gammon

* Revert "update chromedriver dependency to v78 (#49737)"

This reverts commit 4a696b939a.
2019-11-12 15:30:55 -06:00
Liza Katz 19f7e99d3f
Remove deprecated argument include_type_name from ES calls (#50285)
This PR is merged with an error, because these errors happen on master as well. @flash1293 is working on fixing those.

This one should allow us running with the latest es snapshot 



* deprecate include_type_name

* include_type_name

* remove doc from mappings

* Updated timelion mapping

* Updated spaces and uptime mapping

* monitoring apm mapping

* Updated more mappings

* 2 more mappings

* Updated reporting mappings after syncing with @gammon

* Removed deprecated setting
2019-11-12 20:27:37 +02:00
Nathan Reese aa638895ee
[Maps] add settings to maps telemetry (#50161) 2019-11-12 10:25:58 -07:00
Peter Pisljar 253a10696c
remove visualize loader (#46910) 2019-11-12 09:43:51 -05:00
patrykkopycinski 4feb783413
Fix misuse of react-router and react-router-dom (#50120) 2019-11-12 15:33:54 +01:00