Commit graph

24840 commits

Author SHA1 Message Date
Sébastien Loix 12b93bcdd1
[Testbed utils] Readme + chrome extension (#35724) 2019-05-07 09:58:46 +02:00
Pengcheng Xu 7711b652cd
Add extra options when launching Java langserver if JDK's version > 8 (#36100)
* Add extra options when launching Java langserver if JDK's version > 8

* Rename to needModuleArguments

* Add more comments about extra arguments
2019-05-07 15:49:39 +08:00
Josh Dover 8fe1eb2086
[new-platform] Introduce ApplicationService scaffolding and capabilities loading (#35545) 2019-05-06 22:08:25 -05:00
Lisa Cawley c63b2b4ed4
[DOCS] Fixes table format for Asciidoctor (#36130) 2019-05-06 15:41:03 -07:00
igoristic a0bdb538ec
Unmounting react components when a directive is destroyed (#35834) 2019-05-06 17:18:41 -04:00
Larry Gregory dcf5f91784
Feature Controls - remove "grantWithBaseRead" flag (#36121) 2019-05-06 15:57:18 -04:00
Mike Côté 3efaf756d0
Allow any type of saved object to import / export (#34896)
* Modify the relationships API and UI

* Remove type validation on export

* Update relationship test snapshots

* Change relationships table titles

* Change relationships UI to share one table

* Add server side logic to inject meta data into saved objects from plugins

* Manually enable each type of saved object to support

* Use injected vars to determine what types are import / exportable

* Fix some broken tests

* Remove unused translations

* Fix relationships mocha tests

* Remove tests that ensured types are restricted, functionality removed

* Move kfetch logic into separate file

* Add inAppUrl to missing types

* Add tooltip to management table titles that aren't links

* Make relationships screen support filtering by type

* Fix failing tests

* Add refresh support for inAppUrls

* Add error notifications when export API call fails

* Add relationship direction

* Fix broken tests

* Remove graph workspace from import / export

* Use parent / child terminology for relationships

* Use direct relationship terminology

* Flip view / edit logic in saved object management app

* Make config saved object redirect to advanced settings

* Fix broken tests

* Remove unused translations

* Code cleanup

* Add tests

* Add fallback overwrite confirmation object title

* Enforce supported types on import, export and resolve import errors

* Fix broken tests

* Fix broken tests pt2

* Fix broken tests pt3

* Test cleanup

* Use server.decorate to access savedobjectschemas

* Fix some broken tests

* Fix broken tests, add new title to relationships screen

* Fix some broken tests

* Handle dynamic versions

* Fix inAppUrl structure in tests

* Re-use generic canGoInApp

* Fix broken tests

* Apply maps PR feedback

* Apply PR feedback pt1

* Apply PR feedback pt2

* Add savedObjectsManagement to uiExports

* Fix broken tests

* Fix encodeURIComponent implementation

* Merge 403 and unsupported type errors into single error

* Apply suggestion

* Remove import / exportable by default, opt-in instead

* Fix type config to show up properly in the table

* Change config type title and fix tests

* Remove isImportableAndExportable where set to false (new default)

* Remove comments referencing to authorization

* Add unit tests for spaces

* Add unit tests for security plugin

* Change can* signature to be the same as their equivalent function, apply PR feedback

* Cleanup git diff

* Revert "Change can* signature to be the same as their equivalent function, apply PR feedback"

This reverts commit b657ac8fc1.

* Revert "Add unit tests for security plugin"

This reverts commit 6287a8cecf.

* Revert "Add unit tests for spaces"

This reverts commit 2674a9d78f.

* Revert "Remove comments referencing to authorization"

This reverts commit 9618c2cc3a.

* Revert "Merge 403 and unsupported type errors into single error"

This reverts commit 99aea10c0f.

* Add CUSTOM_ELEMENT_TYPE for import / export

* Fix broken tests

* Fix broken tests pt2

* Prevent crashing app when inAppUrl is undefined
2019-05-06 14:44:43 -04:00
Matthew Kime efe1a471c8
github-checks-reporter retry (#36115)
* bump github-checks-reporter for http retry
2019-05-06 13:22:24 -05:00
Aleh Zasypkin 655d40421e
Add "legacy" Encrypted Saved Objects plugin typings. (#36114) 2019-05-06 20:06:07 +02:00
Josh Dover b954dde579
[new-platform] Add lifecycle hooks to legacy platform (#36047) 2019-05-06 12:29:11 -05:00
Rudolf Meijering 92b7cbbb4d
[Core] Fix core api changes exit code (#36053)
* Bump api-extractor to fix missing warning bug

* Fix api-extractor not failing build on api changes

Workaround for upstream bug

* Don't fail build for api-extractor warnings

Warnings like forgotten exports won't fail the build. Instead these
will be added as comments to the api review files. Thus even though
the build won't break, these warnings will show up in code review and
should be fixed by the author.

This is to allow us to merge the workaround for the upstream bugs
without breaking master until we've addressed all the warnings.
2019-05-06 10:15:40 +02:00
WangQianliang 11f8ed644f
fix(code/frontend): no trailing slash in file tree (#36082) 2019-05-06 14:27:35 +08:00
Walter Rafelsberger 79b8c03f34
[ML] Data Frame: Fixes aggs list summary layout. (#36040)
Fixes the layout of the pivot wizard's aggs list summary view.
2019-05-06 08:23:24 +02:00
dave.snider@gmail.com d1b189442c
EUI@10.4.0 (#36085)
* EUI@10.4.0

* Fix TS typing in src/legacy/ui/public/chrome/directives/header_global_nav/components/header.tsx
2019-05-05 21:37:07 -07:00
Clint Andrew Hall fe2cd66c31
[Canvas] Type demodata and pointseries; improve types (#36055)
* [Canvas] Type `demodata` and `pointseries`; improve types

* Fix Pointseries defect

* Remove unnecessary changes
2019-05-03 23:54:04 -04:00
spalger 02dbf2df4e disable flaky test #34038 2019-05-03 18:26:39 -07:00
Robert Monfera 6a06cdd5ee
Fix datatable quick drag issue arising from temporary uninterpretable cursor position (#36018) 2019-05-04 00:57:41 +02:00
Lisa Cawley 6a5a79359d
[DOCS] Fixes ordered list for asciidoctor (#36065) 2019-05-03 15:55:21 -07:00
Fuyao Zhao c41010760e
Run mocha test (for review) (#35924)
* [Code]: Make sure code mocha test could be run on CI

* [Code] fix lsp_service tests

* [Code] fix a problem that process can't exit normal when running gulp

* Ignore cert check for mocha tests

* Don't reuse root
2019-05-03 12:26:41 -07:00
Peter bc90140f8e
enable security plugin in basic (#35891)
enable security on file dataviz and import (ML plugin)

update unit tests

add api test coverage for security in basic

move audit logging to standard+ license level
2019-05-03 11:21:32 -07:00
Dmitry Lemeshko f5bbe82023
adjust tests to pass on Firefox (#35597)
* adjust tests to pass on Firefox

* update feature controls tests to pass on Firefox

* use xpath to search for index pattern
2019-05-03 20:12:15 +02:00
Aleh Zasypkin 2df3880ac7
Introduce Encrypted Saved Objects plugin (#34526) 2019-05-03 17:44:02 +02:00
Joe Reuter bd0641aaa4
reload page on time and refresh setting changes (#36008) 2019-05-03 17:35:41 +02:00
igoristic 3d3e071c6e
Fixed default timestamp sort and added tests (#35640)
* Fixed default timestamp sort and added tests

* Removed duplicate functionality

* Fixed unit tests

* Removed debug code

* Update helpers.js
2019-05-03 11:32:28 -04:00
FrankHassanabad 75043529af
Merge branch 'master' of github.com:elastic/kibana into feature-secops 2019-05-03 09:07:30 -06:00
Matthias Wilhelm f207e5c32a
Add table with conflicting indices in field editor (#35783)
Add table with conflicting indices in field editor to provide info about multi type fields
Add unit test
2019-05-03 16:39:48 +02:00
Walter Rafelsberger 3d21ca348c
[ML] Data Frame: Adds copy-to-clipboard buttons to source index and pivot preview table (#35960) 2019-05-03 15:58:52 +02:00
igoristic 1973b80940
Added the missing reactNodeId to the controller (#35822) 2019-05-03 09:56:19 -04:00
Caroline Horn 748b432df4
Fix Profiler flyout scroll (#35990) 2019-05-03 09:41:50 -04:00
Spencer 1e57e6565c
Revert "Relative cache loader (#35406)" (#36022)
This reverts commit b0e2ab0de9.
2019-05-03 06:15:14 -07:00
Felix Stürmer 0153e59539
[Logs UI] Add customizable columns to source configuration (#34916)
This adds options to customize the columns displayed in the log stream to the source configuration flyout.

relates to #31462
2019-05-03 14:59:43 +02:00
Bill McConaghy 12d5eb76e7
adding console proxy comments (#35971) 2019-05-03 08:36:17 -04:00
Larry Gregory 91b3404d25
[Feature Controls] - Secure Features API (#35841)
* restrict access to Features API

* introduce featureControls.manage capability to control calls to features api

* add snapshots

* rename manage_feature_controls api tag to features

* Revert "introduce featureControls.manage capability to control calls to features api"

This reverts commit addc149193.

* update spaces management to only call APIs if authorized

* handle 404 response when requesting features on role management page

* better variable naming

* remove unnecessary mock

* remove unused code

* remove unnecessary snapshots
2019-05-03 08:05:30 -04:00
Larry Gregory e3130d4959
Role Management - update index fields API to account for removed types (#35986)
* update index fields API to account for removed types

* adds API test
2019-05-03 07:07:27 -04:00
Maryia Lapata 9c8894c705 [Vis: Default editor] EUIficate time interval control (#34991)
* EUIficate time interval control

* Update tests

* Remove empty option, update fix tests

* Bind vis to scope for react component only

* Combine two interval inputs into one EuiCombobox

* Add error message

* Add migration script; remove unused translations

* Update fuctional tests

* Update unit test

* Update tests; refactoring

* Use flow to invoke several functions

* Update test

* Refactoring

* Reset options when timeBase

* Add type for editorConfig prop

* Add placeholder

* Fix lint errors

* Call write after interval changing

* Fix code review comments

* Make replace for model name global

* Revert error catch

* Remove old dependency

* Add unit test for migration test

* Fix message

* Fix code review comments

* Update functional test
2019-05-03 10:44:14 +03:00
Daniil Suleiman b96e316c18
[Vis: Default editor] EUIficate order and size controls (#35134)
* EUIficate order and size controls
2019-05-03 10:38:55 +03:00
Matthias Wilhelm 6b10d02aa1
Initialise correct value of time picker's refresh interval (#35839)
Time pickers's refresh interval state at Discover, Visualize, Dashboard isn't reset when refreshing the page. Furthermore timepicker:refreshIntervalDefaults, editable in 'Advanced settings', is now used as default value

Fix for #34507
2019-05-03 09:29:34 +02:00
Andrew Goldstein 92eede7e19
## Timelines (Top Level) Page and Open Timelines Modal (#35782)
## Timelines (Top Level) Page and Open Timelines Modal

This PR adds a new `Timelines` page and an `Open Timeline` modal for finding and opening saved timelines.

It has `TODO` placeholders / `alert` stubs where @XavierM  will wire it up to persistence via GraphQL in a forthcoming PR.

Thanks to @MichaelMarcialis for the design!

### New `Timelines` page and top-level navigation

![01-timelines-page](https://user-images.githubusercontent.com/4459398/56990470-61929f00-6b52-11e9-9e49-02c1213010ea.gif)

### New `Open Timeline` menu item and modal

![02-open-timeline-modal](https://user-images.githubusercontent.com/4459398/56990486-6d7e6100-6b52-11e9-8aa4-a14984958f43.gif)

### Delete timelines

![03-delete-timelines](https://user-images.githubusercontent.com/4459398/56990533-90107a00-6b52-11e9-9a0a-4ad2abf5da47.gif)

### Updated the style of the notes icon shown in the timeline header and timeline rows

Before:

<img width="1091" alt="04-notes-icon-before" src="https://user-images.githubusercontent.com/4459398/56950590-15fcd880-6af3-11e9-9376-1c4e935b7fec.png">

After:

<img width="1104" alt="05-notes-icon-after" src="https://user-images.githubusercontent.com/4459398/56950610-1eedaa00-6af3-11e9-96ba-df41e97dc7de.png">

### Changed the style of the timeline footer's loading icon from `EuiLoadingChart` to `EuiLoadingSpinner`:

Before:

<img width="208" alt="06-footer-loading-before" src="https://user-images.githubusercontent.com/4459398/56950633-2ca32f80-6af3-11e9-9bba-755e3a9cd351.png">

After:

<img width="221" alt="07-footer-loading-after" src="https://user-images.githubusercontent.com/4459398/56950656-39c01e80-6af3-11e9-900a-4054cb6d8ef7.png">

### Increased the area of the AND drop target in the timeline, and fixed an issue where the timeline drop target would change size while dragging, which caused page reflows:

Before:

![08-timeline-header-before](https://user-images.githubusercontent.com/4459398/56950795-8efc3000-6af3-11e9-8657-22e0abb517ed.gif)

After:

![09-timeline-header-after](https://user-images.githubusercontent.com/4459398/56950831-9d4a4c00-6af3-11e9-847e-fa7ea0cc67cf.gif)

### To run this branch locally with the mock data shown in the gifs:

1. add the following import to `x-pack/plugins/siem/public/pages/timelines/timelines_page.tsx`:

```
import { mockTimelineResults } from '../../mock/timeline_results';
```

2. in `x-pack/plugins/siem/public/pages/timelines/timelines_page.tsx`:

change:

```
searchResults={[]}
```

to:
```
searchResults={mockTimelineResults}
```

3. add the following import to `x-pack/plugins/siem/public/components/open_timeline/open_timeline_modal/index.tsx`:

```
import { mockTimelineResults } from '../../../mock/timeline_results';
```

4. in `x-pack/plugins/siem/public/components/open_timeline/open_timeline_modal/index.tsx`:

change:

```
searchResults={[]}
```

to:

```
searchResults={mockTimelineResults}
```

https://github.com/elastic/ingest-dev/issues/400
2019-05-02 18:04:32 -06:00
Joe Fleming 9dcff2cdc6
chore: consolidate shortcut helpers (#35983)
use a single helper with any collection of modifiers as a second argument
2019-05-02 16:46:58 -07:00
FrankHassanabad c4fbdaa1b0
Fixed the CI build by running the curl instructions
* I ran the integration build
  * I ran the curl command outlined within this test while that was running
  * Took the output and pasted it in here
2019-05-02 16:59:04 -06:00
CJ Cenizal a5fe1f2667
[ILM] Surface shrink action in edit form if it's already been set on the policy (#35987)
* Set PHASE_SHRINK_ENABLED to true if the action has been specified on the phase.
2019-05-02 15:47:14 -07:00
Kerry Gallagher dd6c2e2a2e
"View Surrounding Logs" functionality (#35727)
* Add "View Surrounding Logs" functionality

Move Logs Flyout state from Redux to Hooks

* Cleanup unused imports etc

* Amend for Prettier

* Stop live streaming when a filter is applied

* Change tooltip wording

* Compose functions for props higher in the component hierarchy

* Don't make a request at all without a flyoutId

* Handle no response

* Use TimeKey on document

* Appease Prettier

* Clean up unused props

* Use shared InfraTimeKey fragment

* Add semicolon
2019-05-02 22:39:38 +01:00
Catherine Liu 53ad55cf6f
[Canvas]Feat: Custom Elements (#34140)
* Added custom element routes

    Added context menu to sidebar header

    Added custom element modal

    Added tabs to element_types

    Added handlers for retrieving custom elements

    sidebar header tweaks

    Added edit and delete element controls

    Added a selector for transient.selectedToplevelNodes

    Refactored element event handlers

    Added additional sidebar views

    Fixed adding custom element to workpad

    Converted element_controls to tsx

    Disabled group/ungroup buttons sidebar

    Disabled layer controls in multi_element_settings

    Cleaned up props for element_types

    Added story for element_controls

    Added stories for global_config, group_settings, and multi_element_config

    TSified element_handler_creators

    fixed ts errors

    more tsifying

    Added decorator to element_controls

    Updated stories for custom_element_modal

    Disabled global_config, group_settings, and multi_element_settings stories

    TSified sidebar

    disable layer controls in group_settings

    Removed save element shortcut

    added public/private keywords

    Converted sidebar_header to ts and added stories

Refactored sidebar_header

fix file extension

design cleanup

fix image in edit modal

Fixed ts errors

Update x-pack/plugins/canvas/server/routes/custom_elements.js

Co-Authored-By: cqliu1 <catherineqliu@outlook.com>

Update x-pack/plugins/canvas/server/routes/workpad.js

Co-Authored-By: cqliu1 <catherineqliu@outlook.com>

Reordered args for insertNodes and removeNodes to match corresponding redux actions

Extracted PositionedElement interface

Fixed TS issues

Adjust title and desc lengths

Added comments to props interface

Refactored onClick handlers

more ts

Added types for ast

Switched common/lib/constants back to JS

Added comments

Updated more comments

Removed unused import

Added snapshots

Typed custom_element_service

Fixed ts errors

* Added comments to @ts-ignore's

* Removed custom_element_modal stories

* Added a few more comments

* Update security tests with new canvas-element saved object

* Updated privileges test

* Updated ui_capabilities security_only saved_objects_management test

* Added state interface for CustomElementTypes

* Added state interfaces

* fixed comment

* Removed unnecessary exports
2019-05-02 16:38:46 -05:00
FrankHassanabad bb182c239a
Merge remote-tracking branch 'upstream/master' into feature-secops 2019-05-02 15:13:53 -06:00
Frank Hassanabad 607802f5d7
Remove extra types we added to infra project over time (#35963)
* Our proposed merge back into master should no longer impact this team/project
* During merges from master back into feature-secops we were getting constant conflicts and typing issues where these types would influence other people's types.
* Removed horiztonal bar chart as it is not needed and used anymore and we are replacing it
2019-05-02 14:57:31 -06:00
Clint Andrew Hall 045c8388ca
[Canvas] Added Storybook Mocks + Settings (#35852) 2019-05-02 15:50:02 -04:00
Clint Andrew Hall d2e083a335
[Canvas] Add Types to Functions (#35087)
* Reducing changeset to TS-only

* Update names; fix a few bugs

* Test fixes

* Add browser and server functions

* Update ts-ignore comments; convert pie; break up TS defs

* Convert const to func

* Plot conversion

* Tweaks to documentation

* Fix deleted file

* Fix type errors

* Update yarn.lock

* Address feedback
2019-05-02 14:40:59 -04:00
Chandler Prall d449ff4e3f
Update EUI 10.1.0 -> 10.3.1 (#35970) 2019-05-02 12:27:36 -06:00
Lukas Olson e7b018e5b6
Remove support for time-based interval index patterns (#35173)
* Remove support for time-based interval index patterns

* Remove other unused translations

* Fix setting index

* Check if index is undefined

* Fix test

* Fix tests
2019-05-02 10:31:38 -07:00
Larry Gregory ff46f19d1d
Update archiving dependencies (#35896)
* update tar to latest (4.4.8)

* remove unused bz2 extraction code

* update geckodriver to latest (1.16.2)

* update untar to ensure destination exists
2019-05-02 13:14:10 -04:00