Commit graph

25583 commits

Author SHA1 Message Date
Frank Hassanabad 131e3bf1a2
[SIEM] Change deprecated Buffer method for non-deprecated Buffer method (#38634)
## Summary
  * Added linter rule to prevent us from accidentally adding deprecated node methods
  * Added the new package linter plugin for NodeJS
  * Added unit test for the base 64 encoding for sanity check

Note:
Only the one line of code will be back-ported for the NodeJS fix for 7.2.0. The linter rule will not be back-ported. 

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-06-10 22:15:11 -06:00
Zacqary Adam Xeper faf0f2d770
[DOCS] Update dev env instructions in CONTRIBUTING.md (#38580)
* Update dev env instructions in CONTRIBUTING.md

* s/There is/There are

* Remove excess 'was'
2019-06-10 23:28:29 -04:00
Xavier Mouligneau 53aaa45738
[SIEM] Unexpected results when multiple users favorite a timeline (#38585)
* fix user favorite in timelines tab

* fix filter on only favorite
2019-06-10 21:49:09 -04:00
CJ Cenizal a72c2be7af
Disable CCR and Remote Clusters API integration tests on Cloud, because Cloud has disabled those features. (#38619) 2019-06-10 16:50:38 -07:00
Frank Hassanabad eba00d1d9e
[SIEM] Make _id draggable again but not message (#38603)
## Summary

  * Added simple white list to make message not draggable in plain column renderer
  * Ensured _id was draggable now
  * Added tests to ensure regressions do not happen
  * https://github.com/elastic/ingest-dev/issues/517

Per gifs below, you can add _id to your column name and drag that but cannot drag and drop the message field

id draggable
![draggable_id](https://user-images.githubusercontent.com/1151048/59226371-137cac80-8b90-11e9-9482-fc05bd8c79cf.gif)

Message not draggable
![message-not-draggalbe](https://user-images.githubusercontent.com/1151048/59226444-3e670080-8b90-11e9-9b81-6d0713179ace.gif)

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-06-10 17:23:02 -06:00
chongzhe 4d755722ab
[Code] initial commit for Code doc (#38521) 2019-06-10 16:14:18 -07:00
spalger b7fab4fb4b force cwd for failed_test reporting
(cherry picked from commit 1d12402b5b)
2019-06-10 16:08:30 -07:00
renovate[bot] 6fb7f12bd1 Update dependency pdfmake to v0.1.57 (#38586) 2019-06-10 16:00:25 -07:00
renovate[bot] 228ca2bee9 Update dependency tinymath to v1.2.1 (#38589) 2019-06-10 15:59:44 -07:00
renovate[bot] 4b3915ea74 Update dependency tmp to v0.1.0 (#38590) 2019-06-10 15:59:18 -07:00
Luke Elmers c4d851c1d6
Move interfaces for interpreter types to OSS (#37753) 2019-06-10 16:28:21 -06:00
Larry Gregory ee27bc4083
Feature Controls - Simplify Saved Objects Management UI Capabilities (#38461)
* start simplifying saved objects management UI Capabilities

* update tests

* simplify UI

* address PR feedback

* remove savedObjectsManagement UI Capabilities tests
2019-06-10 18:08:59 -04:00
Yulong 9c36f5e343 [Code] stop respawn process after maxRespawn reached (#38392) 2019-06-10 14:18:05 -07:00
Mengwei Ding b59e4f3afa
[Code] Add LRU Cache to accommodate git repo object for better resource management (#38516)
* [Code] Move getHeadRevision and getDefaultBranch into GitOperations

* Add LRU cache for Repository objects

* clean up Repository for clone and update

* Update unit tests

* more cleanup
2019-06-10 14:00:32 -07:00
spalger 9b071c91db fix JOB_NAME regex 2019-06-10 12:40:17 -07:00
renovate[bot] c6ebda3702 Update dependency rison-node to v1.0.2 (#38453) 2019-06-10 12:28:50 -07:00
renovate[bot] 2b02b3e0e0 Update dependency styled-components to v3.4.10 (#38500) 2019-06-10 12:10:54 -07:00
Matthew Kime 79dc7baea4
d13n PathProvider (#38505)
* d13n PathProvider
2019-06-10 12:48:53 -05:00
Mengwei Ding 4c3e643897
[Code] Force reindex from beginning for index REST API (#38488) 2019-06-10 10:43:39 -07:00
CJ Cenizal 63804cbb09
Update Rollup Jobs API to accommodate change to ES that allows starting a started job and stopping a stopped job. (#38168) 2019-06-10 10:07:24 -07:00
renovate[bot] dcbc880830 Update dependency tabbable to v1.1.3 (#38501) 2019-06-10 08:49:36 -07:00
renovate[bot] f02eca2b62 Update dependency semver to v5.7.0 (#38499) 2019-06-10 08:43:58 -07:00
Justin Kambic 42184bd4dc
[Uptime] [Bug] Update documentation link for location column (#37511)
* Update documentation link for location column.

* Update link.
2019-06-10 11:41:12 -04:00
renovate[bot] 78af9c8890 Update dependency tar to v4.4.10 (#38502) 2019-06-10 08:37:02 -07:00
Spencer 3bc5595ce3
[testFailureReporting] only run on master/version jobs (#38497) 2019-06-10 07:04:32 -07:00
Philipp B 02848e0a22
[Accessibility] Reload saved search link on Discover replaced with <EuiButton> component (#37621)
* Reload saved search link replaced with <EuiButton> components: keyboard accessible and looks like a button.
2019-06-10 15:36:49 +03:00
Pete Harverson b8a13c391a
[ML] Adds check that forecast duration is no more than 3650 days (#38408) 2019-06-10 11:36:15 +01:00
Marco Vettorello 0462440abe
Fix typo in top hit fields filter (#38391) 2019-06-10 10:29:38 +02:00
WangQianliang 27e7863523
fix(code/frontend): should not have empty array as query (#38257) 2019-06-10 15:02:56 +08:00
WangQianliang 2e67d4da5f
fix(code/frontend): remove load project configs (#38264) 2019-06-10 11:41:50 +08:00
Yulong 72085249cc
[Code] fix Code multinode mode can't work when security is enabled (#37597) 2019-06-10 10:30:06 +08:00
Matthew Kime 988b085ee6
Remove Private usage from XPackInfoSignatureProvider (#38507)
* remove Private usage, remove mock session storage usage
2019-06-09 12:12:10 -05:00
Matthew Kime 02ad1cfed4
remove unused injected dependencies (3rd in a series) (#37947)
* remove unused injected dependencies
2019-06-09 08:35:09 -05:00
Matthew Kime f90c7a07bf
remove unused injected dependencies (#38504) 2019-06-09 08:26:06 -05:00
Matthew Kime 9323ae8d73
Remove unused injected dependencies 3b (#36899)
* removing more unused injected dependencies
2019-06-08 22:14:37 -05:00
spalger 0a25d6a795 disable failing test (#38492) 2019-06-08 09:45:37 -07:00
Peter Pisljar c5dcab447f Vislib private removal part4 (#37857)
* removing Private
2019-06-08 08:57:32 -05:00
Joe Reuter 3b46877972
Use actual listing limit in vis listing (#38246) 2019-06-08 10:56:49 +02:00
Yulong 0069df982b
[Code] change the port number before respawn a new lang-server process (#38090) (#38375) 2019-06-08 09:52:40 +08:00
Clint Andrew Hall b6bf87c394
[Canvas][Easy] Fix EUI Issue in Storybook; standardize locations (#38222)
* Fix Storybook

* Organizing folders a bit

* Update snapshots
2019-06-07 19:27:28 -05:00
Spencer bc5cecb85d
[build][quick-fix] don't clean eui (#38483) 2019-06-07 16:44:40 -07:00
spalger 9aaff97be3 disable flaky tests 2019-06-07 15:13:27 -07:00
Chris Cowan d16c394028
[Infra UI] Link to node detail page from Metrics Explorer (#37136)
* [Infra UI] Link to Metrics Detail page from Metrics Explorer for compatible group bys

* Adding test for incompatible group bys

* renaming for clearity

* Changing out SourceQuery for SourceConfiguration

* Fixing tests to ensure link it validated

* Make tests more robust

* Update x-pack/plugins/infra/public/components/metrics_explorer/chart_context_menu.tsx

Co-Authored-By: Felix Stürmer <weltenwort@users.noreply.github.com>

* Adding definite assingment operattors

* Fixing flaky test
2019-06-07 14:41:58 -07:00
Catherine Liu 3c9182f4b1
[Canvas] Clean up expression function definitions (#37305)
* Cleaned up common function defs

    fixed broken tests

    Remove boolean and null as context/arg valid types in lt, lte, gt, and gte

    Added 'function' alias

    Updated comparator tests

    Added neq to options in compare function

    null audit

* Deleted obsolete 'browser' and 'server' functions

* More clean up

* Removed server and browser function i18n strings

* Fixed broken tests

* Addressing feedback

* Removed browser and server from function_help

* Added ts-ignore for constant import

* Fixed help text label

* Fixed font
2019-06-07 14:32:12 -07:00
renovate[bot] 26a98b5f1e Update dependency rsync to v0.6.1 (#38454) 2019-06-07 14:08:39 -07:00
renovate[bot] 46b40d0926 Update dependency simple-git to v1.113.0 (#38456) 2019-06-07 14:07:40 -07:00
Frank Hassanabad fdd4621601
[SIEM] Add build step to find cyclic deps in SIEM project (#38329)
## Summary

* Adds a build step to find cyclic deps and error out in the SIEM project when found as part of a build step.

* Fixes typescript files that have cycles with their constants and types.

You run this like so:

```
cd kibana/x-pack/plugins/siem
node scripts/check_circular_deps.js
```

And get this message:
<img width="846" alt="Screen Shot 2019-06-07 at 11 22 24 AM" src="https://user-images.githubusercontent.com/1151048/59121970-b629f680-8916-11e9-8683-326a881c4725.png">

Or you will get an error with a listing of deps that need to be updated which have cycles in them.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-06-07 14:40:06 -06:00
Spencer 0f5bd4dfcc
Implement renovate config generator (#38369)
* reformat renovate.json5 with json5 cli, add header

* add scripts for rengerating renovate config from ts files

* regenerate renovate config

* verify renovate.json5 is up to date in CI

* add description to the build_renovate_config script

* auto-group types packages

* fix typo

* mention version pinning in doc block

* support disabling renovate for package groups

* scan all package paths for @-types deps

* regenerate renovate config

* regenerate renovate config

* name scoped package regexp

* move some of the new logic out of package_groups.ts

* flatMap in one pass
2019-06-07 13:30:59 -07:00
igoristic 44fc8c91d7
Issue 27126: Added a link to License Management (#37771)
* Added a link to License Management

* Added textAlign to EuiText instead
2019-06-07 16:05:33 -04:00
igoristic 01dccbfb75
Issue 28875: Using i18n instead of injectI18n (#37845)
* Using i18n instead of injectI18n

* Update x-pack/plugins/monitoring/public/components/apm/instance/status.js

Co-Authored-By: Ahmad Bamieh <ahmadbamieh@gmail.com>

* Update x-pack/plugins/monitoring/public/components/table/table.js

Co-Authored-By: Maryia Lapata <mary.lopato@gmail.com>

* Addressed PR code review feedback
2019-06-07 16:01:56 -04:00