Commit graph

32759 commits

Author SHA1 Message Date
Oliver Gupte
16ba937bae
[APM] Client new platform migration (#64046)
* migrate files from legacy path to new plugin path

* update file paths to reflect migrated files

* move minimal legacy client files back to legacy path in order to run kibana

* Completes the full cutover to the new kibana platform removing all shims and legacy adapters.

* Adds APM to ignored list for casing check.

* - moves public/utils/pickKeys.ts to common/utils/pick_keys.ts
- exposes getTraceUrl as a plugin static export of apm/public and updates import in infra
- fixes FeaturesPluginSetup import in apm/public app
- renames get_apm_index_pattern_titles -> get_apm_index_pattern_title
- getApmIndexPatternTitle is now a synchronous getter function
- removes unused comments and xpack.apm.apmForESDescription i18n translations

* Moves automatic index pattern saved object creation from
plugin start to when the Home screen first renders

* removed unnecessary legacy css imports

* fixed ci issues by:
- moving readOnly badge, and help extension setup to occure only
  when apm app is mounted
- registering saved object types
- also moved createStaticIndexPattern from a react useEffect on the
  APM home screen to when the app is mounted
2020-04-30 13:08:50 -07:00
igoristic
59315bc84d
[Monitoring] NP Migration complete client cutover (#62908)
* Final phase before the complete cutover

* NP migration

* lint fix

* More NP stuff

* Moved Stack Monitoring client plugin outside legacy and fixed all tests

* ...

* Removed unused files

* Fix for main links

* Fixed more tests

* Fixed redirect when clicking on SM icon again

* Code review feedback

* Addressed code review feedback

* Fixed return value
2020-04-30 15:59:35 -04:00
Alison Goryachev
6e3791ea12
Ingest Node Pipelines UI (#62321) 2020-04-30 15:52:14 -04:00
Ryland Herrick
b8e0730d0c
[SIEM] NP Plugin dependency cleanup (#64842)
* Remove static src dependencies from kibana.json

We are only importing static code from these plugins, and not consuming
their plugin contracts. For this reason, we can safely remove them from
kibana.json as that imported code will always be included in our own
bundle.

* Make usageCollection an optional dependency

If it's not enabled, we simply use a noop for our tracker call.

* Remove unused plugin contracts

These are only needed when we're actually using them in our codebase.
For request handler contexts, we only need our kibana.json declaration.

* Remove unnecessary try/catch

With the addition of the null coalescing, the only chance for an error
is in usageCollection. However, if the usageCollection contract changes,
we should get a type error long before we see a runtime error.

* Improve typings of our Plugin classes

* passes missing generic arguments to public plugin interface
* passes missing generic arguments to both plugins' CoreSetup types

* Don't re-export core types

Instead, import them from core as needed.
2020-04-30 14:48:37 -05:00
Chris Cowan
0399f70050
[Metrics UI] Add Charts to Alert Conditions (#64384)
* [Metrics UI] Add Charts to Alert Conditions

- Reorganize files under public/alerting
- Change Metrics Explorer API to force interval
- Add charts to expression rows
- Allow expression rows to be collapsable
- Adding sum aggregation to Metrics Explorer for parity

* Adding interval information to Metrics Eexplorer API

* Moving data hook into the expression charts component

* Revert "Adding interval information to Metrics Eexplorer API"

This reverts commit f6e2fc11be.

* Reducing the opacity for the threshold areas

* Changing darkMode to use alertsContext.uiSettings
2020-04-30 11:52:11 -07:00
spalger
c8b9bdd0ec skip flaky suite (#64473) 2020-04-30 11:48:41 -07:00
Marta Bondyra
5887c97d75
[Lens] Allow user to drag and select a subset of the timeline in the chart (aka brush interaction) (#62636)
* feat: brushing basic example for time histogram

* test: added

* refactor: simplify the structure

* refactor: move to inline function

* refactor

* refactor

* Always use time field from index pattern

* types

* use the meta.aggConfigParams for timefieldName

* fix: test snapshot update

* Update embeddable.tsx

removing commented code

* fix: moment remov

* fix: corrections for adapting to timepicker on every timefield

* fix: fix single bar condition

* types

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
2020-04-30 20:36:50 +02:00
Tiago Costa
b93427b7b6
chore(NA): ignore server watch for md and test.tsx files (#64797)
* chore(NA): avoid unnecessary server watches on md and test.tsx files

* chore(NA): include debug log files
2020-04-30 19:35:20 +01:00
Jen Huang
8a304623d4
[Ingest] Agent config settings UI (#64854)
* Remove duplicate donut chart, move used donut chart closer to usage, clean up import paths

* Change delete agent config to only single delete and delete all its associated data sources

* Initial pass at settings tab

* Reuse existing create agent config form instead

* Fix delete api

* Prevent nav drawer from hiding bottom bar (save action area) content

* Remove delete config functionality from list page

* Prevent API from deleting config with agents enrolled

* Fix namespace populating in form

* Display confirmation modal to deploy to agents if agents are detected

* Adjust confirm delete copy

* Fix i18n checks

* Fix type check

* Fix it again

* De-dupe confirm modal

* Fix i18n

* Update agent config info after saving

* Adjust skip unassign from agent config option schema in delete datasource method
2020-04-30 11:12:22 -07:00
Marta Bondyra
fc2f2446eb
fix: fix migration (#64894)
(cherry picked from commit 99b5982f1c)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-30 14:08:30 -04:00
Lee Drengenberg
0efd02b49d
change createIndexPattern to do what it takes to make the indexPatternName* (#64646) 2020-04-30 12:30:06 -05:00
Mikhail Shustov
3442c25b9f
lazy load React components + VegaParser (#64749) 2020-04-30 19:18:07 +02:00
Mikhail Shustov
693a84aace
load SettingsOptions component lazily (#64638)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-30 19:16:31 +02:00
Jonathan Buttner
a7291fa8c8
[EPM] Adding support for nested fields (#64829)
* Allowing nested types to be merged with group

* Adding nested to case and handling other fields

* Cleaing up if logic

* Removing unneeded if statement

* Adding nested type to switch and more tests

* Keeping functions immutable
2020-04-30 13:03:08 -04:00
Josh Dover
9112b6c1f1
Avoid race condition between HttpServer.stop() and HttpServerSetup methods (#64487) 2020-04-30 10:32:26 -06:00
The SpaceCake Project
671d750c03
lookback adjust (#64837)
increase lookback to 15 minutes for latency in endpoint signal rules
2020-04-30 12:28:55 -04:00
Zacqary Adam Xeper
c131cb341b
Refactor action messaging to report on No Data state (#64365) 2020-04-30 10:51:05 -05:00
Mike Côté
d3ba5b5a55
Update event log ILM policy defaults (#64675)
* Initial work

* Update docs

* Add delete phase mention to docs

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-30 11:33:51 -04:00
Wylie Conlon
988b93edca
[Lens] Hide some suggestions in preparation for pie charts (#64740)
* [Lens] Hide some suggestions in preparation for pie charts

* Suggest reordering the X and Break down by axis

* More tweaks
2020-04-30 10:52:10 -04:00
John Schulz
793d6f5689
Always add Manager setup route. Fleet, if enabled (#64859)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-30 10:50:55 -04:00
Nicolas Chaulet
d75328c476
[Ingest] Allow aggent to send metadata compliant with ECS (#64452) 2020-04-30 10:34:44 -04:00
Robert Austin
027c8a8d75
[Endpoint] Remove todos, urls to issues (#64833) 2020-04-30 09:47:43 -04:00
Shahzad
1736005e5e
[Uptime] Remove hard coded value for monitor states histograms (#64396) 2020-04-30 15:45:52 +02:00
Henry Harding
60ef51b912
Feature/send feedback link (#64845)
* use fixed table layout

* add alpha messaging flyout

* Added alpha badge + data streams link

* Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>

* Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>

* Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>

* Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/overview/index.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>

* remove small tags

* change messaging from alpha to experimental

* add period

* remove unused imports

* fixed i18n ids

* add send feedback link to header

* rename "ingest management" to "ingest manager"

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-30 09:28:12 -04:00
James Gowdy
497c5da763
[ML] Moving get filters capability to admin (#64879)
* [ML] Moving get filters capability to admin

* updating test
2020-04-30 14:07:32 +01:00
Mike Côté
b140ad7194
Remove edit alert button from alerts list (#64643)
* Remove edit alert button from alerts list

* Remove unused code

* Cleanup translation files

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-30 08:56:15 -04:00
Sonja Krause-Harder
3c56a8e296
[EPM] Handle constant_keyword type in KB index patterns and ES index templates (#64876)
* Unit-test constant_keyword mapping generation

* Treat constant_keyword as string in kibana index patterns
2020-04-30 12:43:34 +02:00
James Gowdy
21bc46f5af
[ML] Disable data frame anaylics clone button based on permission (#64830) 2020-04-30 11:07:14 +01:00
Anton Dosov
dcc4081bd8
Dashboard url generator to preserve saved filters from destination dashboard (#64767) 2020-04-30 10:34:32 +02:00
Pierre Gayvallet
6e2691358f
add generic typings for SavedObjectMigrationFn (#63943)
* add generic typings for SavedObjectMigrationFn

* change default attributes type to unknown

* update generated doc

* adapt new calls

* update generated doc

* update migration example

* fix merge conflicts
2020-04-30 10:28:14 +02:00
Pierre Gayvallet
aa8cb620bb
Allow to define and update a defaultPath for applications (#64498)
* add defaultPath to `AppBase` and use it in `navigateToApp`

* add removeSlashes util

* adapt `toNavLink` to handle defaultPath

* update generated doc

* codestyle

* add FTR test

* address comments

* add tests
2020-04-30 08:05:16 +02:00
Patrick Mueller
f85b3898f6
[Event Log] add rel=primary to saved objects for query targets (#64615)
resolves https://github.com/elastic/kibana/issues/62668

Adds a property named `rel` to the nested saved objects in the event
documents, whose value should not be set, or set to `primary`.
The query by saved object function changes to only match event documents
with that saved objects if it has the `rel: primary` value.

This is used to limit searching alerting's executeAction event document
with only the alert saved object, and not the action saved object (this
document has an alert and action saved object). The alert saved object
has the `rel: primary` field set, and the action does not.  Previously,
those documents were returned with a query of the action saved object.
2020-04-30 00:27:51 -04:00
Wylie Conlon
4e58d7ae0a
[Lens] Use a size of 5 for first string field in visualization (#64726) 2020-04-29 22:03:41 -04:00
Frank Hassanabad
bcda1096e1
[SIEM][Lists] Removes plugin dependencies, adds more unit tests, fixes more TypeScript types
* Removes plugin dependencies for better integration outside of Requests such as alerting
* Adds more unit tests
* Fixes more TypeScript types to be more normalized
* Makes this work with the user 'elastic' if security is turned off

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-04-29 19:58:27 -06:00
Jen Huang
fba5128bd8
[Ingest] Edit datasource UI (#64727)
* Adjust NewDatasource type to exclude stream `agent_stream` property, add additional datasource hooks

* Initial pass at edit datasource UI

* Clean up dupe code, fix submit button not enabled after re-selecting a package

* Remove delete config functionality from list page

* Show validation errors for data source name and description fields

* Fix types

* Add success toasts

* Review fixes, clean up i18n

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-29 18:03:30 -07:00
Tim Roes
9b65cbd92b
[Lens] Bind all time fields to the time picker (#63874)
* Bind non primary time fields to timepicker

* Fix typescript argument types

* Allow auto interval on all fields

* Remove lens_auto_date function

* Fix existing jest tests and add test todos

* Remove lens_auto_date from esarchives

* Add TimeBuckets jest tests

* Fix typo in esarchiver

* Address review feedback

* Make code a bit better readable

* Fix default time field retrieval

* Fix TS errors

* Add esaggs interpreter tests

* Change public API doc of data plugin

* Add toExpression tests for index pattern datasource

* Add migration stub

* Add full migration

* Fix naming inconsistency in esaggs

* Fix naming issue

* Revert archives to un-migrated version

* Ignore expressions that are already migrated

* test: remove extra spaces and  timeField=\\"products.created_on\\"} to timeField=\"products.created_on\"}

* Rename all timeField -> timeFields

* Combine duplicate functions

* Fix boolean error and add test for it

* Commit API changes

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
2020-04-29 20:10:14 -04:00
Wylie Conlon
a907c9bda5
[Lens] Use suggestion system in chart switcher for subtypes (#64613)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-29 19:14:47 -04:00
Henry Harding
110648258c
Improve alpha messaging (#64692)
* use fixed table layout

* add alpha messaging flyout

* Added alpha badge + data streams link

* Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>

* Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>

* Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>

* Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/overview/index.tsx

Co-Authored-By: Jen Huang <its.jenetic@gmail.com>

* remove small tags

* change messaging from alpha to experimental

* add period

* remove unused imports

* fixed i18n ids

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-29 17:18:51 -04:00
Nicolas Chaulet
6338cef317
[Ingest] Allow to enable monitoring of elastic agent (#63598) 2020-04-29 16:41:59 -04:00
Zacqary Adam Xeper
1669a10441
[Metrics UI] Fix alerting when a filter query is present (#64575) 2020-04-29 15:36:37 -05:00
spalger
2e410d8952 skip flaky suite (#64812) (#64723) 2020-04-29 12:53:06 -07:00
Nathan Reese
d6f0c785d9
[Maps] do not display EMS or kibana layer wizards when not configured (#64554)
* [Maps] do not display EMS or kibana layer wizards when not configured

* default tilemap to empty object instead of array

* fix typo

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-29 13:27:55 -06:00
Tim Sullivan
02ba5fcb13
[Reporting/Test] Convert functional test code to Typescript (#64601)
* Convert the tests to typescript

* remove outdated comment

* fix typescript

* fix "as any"

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-29 12:19:31 -07:00
Lee Drengenberg
f5a8d8e6c2
make inserting timestamp with navigate methods optional with default true (#64655) 2020-04-29 14:05:45 -05:00
Sandra Gonzales
53ff22997a
[EPM] Update UI to handle package versions and updates (#64689)
* link to installed version of detail page

* add latestVersion property to EPM get package endpoint

* add updates available notices

* add update package button

* handle various states and send installedVersion from package endpoint

* fix type errors

* fix install error because not returning promises

* track version in state

* handle unsuccessful update attempt

* remove unused variable
2020-04-29 14:06:08 -04:00
Ryland Herrick
3adab85138
Minimize dependencies required by our telemetry middleware (#64665)
1. we need our redux actions for our telemetry middleware, which:
2. require types from an index file, which:
3. includes all of our model types, and everything involved in them

By moving these types to a separate file and importing _that_instead, we
bypass inclusion of 2 and 3 in our plugin, which equates to ~550kB (of a
total of ~600kB).
2020-04-29 13:01:23 -05:00
Christiane (Tina) Heiligers
1512859e56
[Telemetry] oss api tests (#64602)
* Adds telemetry API tests for oss

* Modifies test expectations to match that within oss

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-29 10:54:19 -07:00
James Gowdy
d8c15f5ad3
[ML] Adding endpoint capability checks (#64662)
* [ML] Adding endpoint capability checks

* adding missing capability checks

* fixing test

* removing commented code

* fixing functional test

* fixing functional tests

* changes based on review

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-29 18:25:48 +01:00
Dmitry Lemeshko
bac638a37e
Update jest config for coverage (#64648)
* set files to track for coverage collection

* increase timeout to 4h

* trying to add detectOpenHandles to avoid worker stuck

* update config

* make config paths more common

* update configs

* update jest oss config

* exclude 'tests' folder for coverage
2020-04-29 20:00:14 +03:00
Ryland Herrick
f8e01bd3a1
[SIEM][NP] Fixes bug in ML signals promotion (#64720)
* Add set-value as an explicit dependency

This is a more robust solution than lodash's set().

* Replace lodash.set() with set-value's equivalent

* Rebuild renovate config

We added set-value to our dependencies.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-29 11:58:46 -05:00