Commit graph

17532 commits

Author SHA1 Message Date
Shaunak Kashyap
17f483a432 Updating EUI to 0.0.55 (#20126) 2018-06-21 16:21:33 -07:00
Tim Sullivan
ab4f76bfed
Separate bulk upload behavior from CollectorSet (#19691) (#20129)
* Separate bulk upload behavior from CollectorSet

 - takes out a lot of behavior from CollectorSet and moves it to a class called BulkUploader
 - simplifies kibana monitoring init by taking out the indirection that startCollectorSet / createCollectorSet had
 - removes start() method from CollectorSet and calls the collector objects' init() functions from CollectorSet.register()
 - removes cleanup method from collectorSet since that was doing work for bulk uploading

* remove cleanup and fetchAfterInit methods

* test for bulk_uploader class

* improve test for collector_set

* fix reporting

* expose collectorSet if there actually is a collectorSet

* comment for enclosed function

* make collectorSet creation/expose unconditional, bulkUploader more conditional

* fix collector_set tests

* lifecycle events

* stab at collectorSet error logging from the API call

* clean up comments

* clean up comments

* fix BulkUploader mocha test

* check kibanaCollectionEnabled config before registering bulk upload and the plugin status listeners

* no singleton timer object

* just log a warning if bulk uploader start called twice

* normal quotes

* check if bulk is enabled inside of the _fetchAndUpload method

* log for stopping bulk stats

* call bulkUploader.start with the collectorSet object

* call bulkUploader.start with the collectorSet object

* roll back change for module scoped variable

* oops I broke init

* init and logging: if / elseif / elseif

* remove unnecessary check/log

* help log

* remove redundant, use data.filter.map

* use xpackInfo.onLicenseInfoChange not xpackMainPlugin.status.on('green')

* help logging

* fix unit test

* remove handler that stops upload when connection is lost
2018-06-21 15:03:29 -07:00
Tiago Costa
1bb5dd1c11
[6.x][DOCS] Steps to get kibana running after upgrading to 6.3.0 with an old x-pack installation (#20100)
* docs(kbn-20086): steps to get kibana running after upgrading to 6.3.0 with an old x-pack installation.

* docs(kbn-20086): updated text for docs related with 6.3.0 upgrade.

* docs(kbn-20086): change wording from docs text.
2018-06-21 17:16:50 +01:00
Pete Harverson
2fd19e36b0
[ML] Fix alignment of text in job wizard remove split button (#20118) (#20121) 2018-06-21 15:20:32 +01:00
Justin Kambic
343e5c200d Fix capitalization typo for className attribute. (#20104) 2018-06-21 10:07:15 -04:00
Pete Harverson
66a73ddcff
[ML] Add missing aria-label attribute to various components (#20117) (#20119) 2018-06-21 14:09:24 +01:00
Tim Roes
9ba0689dcd
[6.x] Replace spy panels by Inspector (#16387) | Fix one inspector test (#20072) (#20076)
* Replace spy panels by Inspector (#16387)

* Add Inspector feature

* So long, and thanks for all the fish, spy panel

* Fix several functional tests

* Fix unit tests

* Fix spy panel button tests

* Replace old spy panel documentation

* Disable test temporarily until we have dashboard triggers

* Enter edit mode for dark theme test

* Fix some more functional tests

* Fix more functional tests

* More test fixing

* Fix more functional tests

* Allow opening the inspector via loader handler

* Refactor InspectorViewChooser, remove unused CSS

* Remove dead code

* Fix data download button style

* Remove redundant code

* Load inspectorViews for dashboard_viewer

* Extract inspector views to custom core_plugin

* Switch API to TypeScript 🎉

* Design changes

* Remove icons from views

* Design changes

* Improve typings of API

* Add typing to all adapters

* Show loading spinner in request selector

* Rewrite InspectorView to TypeScript

* Fix help text for data view

* Remove deprecated React lifecycle methods

* Embed inspector into dashboard panel actions

* Remove temporary inspector trigger

* Remove old CSS

* Fix dashboard trigger for new panel action

* Add tests for InspectorPanel and DataAdapter

* Produce a hierarchical table if the vis is hierarchical

* Remove allowJs option again

* Add missing Apache license headers

* Close inspector on dashboard when navigating away

* Use proper title for dashboard panels

* Fix functional tests

* Skip broken test for now

* Flush view chooser button

* Add request adapter tests

* Skip more tests, broken due to typescript

* Add Request Time description

* Add description for courier request

* Fix tests

* Replace icon by new (not yet released) icon

* Finalize design of inspector

* Remove discover test, that relied on spy panels

* Change API to be properly mockable in tests

* Add aria-live region for request status

* Replace old method in functional tests

* Replace abitrary magic number

* Use object destructuring in vis

* Fix issue with crashing requests view

* Add request time tooltip

* Get request body of correct search source

* Make filter buttons properly keyboard accessible

* Follow Dave's design suggestions

* Remove redundant request from name

* Remove unneeded comments

* WIP raw-formatted values

* Fix filtering issue

* Fix tests and more license headers

* Add data view tests

* Remove search from table

* Fix typos

* Implement review suggestion

* Remove artificial delays for testing

* Fix new panel action structure

* Minor design adjustments

* Fix failing functional test

* Update failing snapshot test

* Implement final wording

* Apply new EUI styling

* Fix closing inspector in tests

* Fix sorting of table

* Align punctuation between tooltips

* Fix test that doesn't exist on master

* Fix one inspector test (#20072)

* Remove file that came accidentally back due to merging

* Fix accidental merge paste

* Fix 6.4 test failures
2018-06-21 11:45:13 +02:00
Spencer
5d29b10412
[6.x] [xpack_main/status] update the plugin status anytime the license changes (#20018) (#20094)
Backports the following commits to 6.x:
 - [xpack_main/status] update the plugin status anytime the license changes  (#20018)
2018-06-20 14:17:35 -07:00
Stacey Gammon
1f4d71176c
sync yarn lock file (#20097) 2018-06-20 16:32:39 -04:00
Chris Earle
e48c7acff5 Remove Duplicated Close button from Flyout (#20055)
This removes the now-duplicated Close button from the `EuiFlyout` now that
EUI automatically adds a close button.
2018-06-20 14:43:33 -04:00
Bill McConaghy
dcb541c0ea
adding data-test-subj to buttons and updating snapshots (#20080) (#20092)
* adding data-test-subj to buttons and updating snapshots

* PR feedback

* updating snapshots
2018-06-20 14:34:49 -04:00
CJ Cenizal
829c48590e
Remove close buttons from Saved Object relationship and Index Management flyouts. (#20043) (#20065) 2018-06-20 07:41:52 -07:00
Peter Pisljar
595e0f8293
fixes filtering on other bucket outside of vislib (#19860) (#20066) 2018-06-20 11:10:18 +02:00
Lisa Cawley
2516f9ecc3
[DOCS] Adds missing breaking change (#20057) 2018-06-19 17:17:08 -07:00
Stacey Gammon
72dc8b31f7
Fix flaky test where modal dialog isn't loaded when enter key is pressed (#20035) (#20051) 2018-06-19 19:22:16 -04:00
Jonathan Budzenski
fe1e88afd3
[build] Remove more files (#19603) (#20054)
* [build] Remove more files

* rename, add ts and tsx
2018-06-19 18:14:08 -05:00
Spencer
20a932e03e
[6.x] [ftr/confirmModal] assert expected state rather than just reading (#20019) (#20022)
Backports the following commits to 6.x:
 - [ftr/confirmModal] assert expected state rather than just reading  (#20019)
2018-06-19 13:11:38 -07:00
Rashmi Kulkarni
3f2b5d5518
ES6 conversion on Console Test (#20009) (#20046)
* ES6 conversion
2018-06-19 12:53:29 -07:00
Shaunak Kashyap
268c28af6c Remove explicit close button (#20044) 2018-06-19 11:15:59 -07:00
Tim Roes
508df9e67e
Update EUI to 0.0.53 (#20005) (#20042)
* Update to EUI 0.0.53

* Remove input vis specific styling

* remove double close button in dashboard add panel flyout (#2)

* Fix functional tests

* fix x-pack snapshots

* EUI 0.0.53 no longer closes combo box when clear btn is pressed (#3)
2018-06-19 18:57:42 +02:00
Pete Harverson
a04ace91a1
[ML] Fix overflowing content in anomalies table cells (#20029) (#20040) 2018-06-19 16:49:40 +01:00
Tim Roes
eecfe552ac
Fix prop fail in MetricVisValue (#19991) (#20041) 2018-06-19 17:42:52 +02:00
Stacey Gammon
edb6b8d460
Typescriptify dashboard redux code (#19857) (#20038)
* Typescriptify dashboard redux code

* Address code review comments

* minor fixes

* move all type dependencies to dev
2018-06-19 11:11:01 -04:00
Tim Roes
593296b5e4
Skip flaky test for now (#20033) (#20034) 2018-06-19 14:07:54 +02:00
Justin Kambic
b01dc53a9d [Monitoring] [Logstash] Add Config View (#18597)
* Patch ConfigView changes from x-pack-kibana to OSS Kibana.

* Remove old css.

* Update style for queue statement.

* WIP modifying based on designer feedback.

* Add flatten function and list class.

* Rename functions to be more descriptive.

* WIP checkin. Modify components to handle flattened object list.

* Finish moving flatten logic into classes, add tests.

* Simplify flattening, remove non-native dependency. Add more tests.

* Add defaults to simplify function call.

* Refactor two blocks into a function.

* Begin adapting components for list.

* Add collapse functionality.

* Add expand functionality.

* Nested collapsed elements remain collapsed on parent expansion.

* Style section headers.

* Update Plugin statement styles.

* Add DetailDrawer support.

* Update statement formatting.

* Add stats to plugin element rows.

* Resolve conflicts.

* Remove obsolete code.

* Reorganize code.

* Remove warnings.

* Add PropTypes. Add keys to arrays and iterables.

* Update color for borders/buttons.

* Add stat class. Clean up code.

* Convert plugin statement component from class to function.

* Update queue metrics message.

* Update style to make view more responsive.

* Change section heading size.

* Remove gutter from metrics group.

* Change name "stat" to "metric".

* Remove obsolete export line, simplify declaration, based on PR feedback.

* Add new functional component in place of model class.

* Add PropTypes to several components. Rename a function. Add keys to metrics.

* Convert stateless classes to functional components.

* Prefer ES6 syntax over bindings for Component methods.

* Do not render statement section if there are no statements.

* design cleanup for pipeline viewer

* Update CSS to add min-height to page.

* Rename "elements" to "statements". Delete unused LESS variables.

* Revert naming of "statements" to "elements" for StatementList component.

* Update jest snapshots for DetailDrawer.
2018-06-18 23:43:23 -04:00
Nathan Reese
5be1989c52
Migrate dashboard save error from old toast message to new EUI toast (#19956) (#20003)
* Migrate dashboard save error from old toast message to new EUI toast

* save function does not need to exist on  anymore

* account for error in onSave

* update clone

* lint errors
2018-06-18 16:25:13 -06:00
liza-mae
cdbb3ed0d0
Make timelion tests less flaky (#19996) (#20010)
* Update sleeps in timelion tests

* Add comment
2018-06-18 14:06:32 -06:00
Spencer
8a7ed713fd
[6.x] [npm] upgrade to RxJS 6 (#18885) (#20006)
* [npm] upgrade to RxJS 6 (#18885)

This PR upgrades RxJS to version 6 and switches to a fork of `stream-to-observable` which includes an updated version of `any-observable` that supports RxJS 6 until https://github.com/jamestalmage/stream-to-observable/pull/10 is merged. The primary change in this version of RxJS is the movement of stream operators from `Obersable.prototype` to the `rxjs/operators` module. Some of the operators, like `catch` and `do`, have been renamed (`catchError`, and `tap`). The Obsevable factories have also been moved from static methods on the `Observable` class to named exports of the root `rxjs` module. Some of those factories have also changed slightly, like `fromEvent` which now emits arrays if the event handler is called with multiple arguments.

```js
// import the Rx namespace to get the Observable factories
import * as Rx from 'rxjs';
// import the operators as named imports
import { map, tap, switchMap } from 'rxjs/operators';
```

* [rxjs/dev-utils] fix old operator usage

* [rxjs/dev-utils] remove one more old operator
2018-06-18 12:47:51 -07:00
Spencer
63fd1f5ae6
[build][optimize] don't rely on env for build-based decisions (#19972) (#20007)
There are several cases where we want to do different things in the
optimizer based on whether we are running in the distributable version
of Kibana or running from source. Historically we have handled this by
relying on the env, but as we start to prebuild things, like TypeScript
and soon SCSS, we actually need to know if the version of Kibana running
was a result of the build process or not. To address this the src/utils
module now exports a constant: `IS_KIBANA_DISTRIBUTABLE`. This constant
will be based on the build.distributable flag being set in Kibana's
package.json, which is done automatically in the build process.
2018-06-18 12:46:58 -07:00
Larry Gregory
e8cc31a9c0
Add plugin disclaimer (#19989) (#19997)
Adds a disclaimer to the Known Plugins section of our documentation, which notes that we do not evaluate them.
2018-06-18 13:53:15 -04:00
Søren Louv-Jansen
34375fd433
[APM] Fix JSON in Watcher assistant (#19987) (#19999) 2018-06-18 19:49:17 +02:00
Tim Sullivan
e4abda8593
[Saved Objects Client] Return info about what was missing in the 404 (#19868) (#19973)
* [Saved Objects Client] Return info about what was missing in the 404 error

* update api integration tests

* fix another test
2018-06-18 09:35:17 -07:00
wispxjtu
e10379ed9b Code example miss single quotes (#19783) 2018-06-18 11:11:53 -05:00
Tim Roes
d7289defec
Fix broken migration for old gauge format (#19853) (#19990)
* Fix broken migration for old gauge format

* Fix broken unit tests

* Assume Metric as default
2018-06-18 17:15:49 +02:00
Tim Roes
996b42ae99
Allow overwriting filters when adding via queryFilter (#19754) (#19985)
* Allow overwriting filters

* Add another test
2018-06-18 15:49:31 +02:00
Felix Stürmer
b4806a0f77
[6.x] [Context view] Incrementally increase context time window (#16878) (#19986)
Backports the following commits to 6.x:
 - [Context view] Incrementally increase context time window  (#16878)
2018-06-18 15:45:45 +02:00
Andrew Wilkins
e78e8a4464
[APM] Add Go agent tutorial (#19980) (#19982)
Add Go to the APM client tutorials.
2018-06-18 17:26:22 +08:00
Nathan Reese
0d47476ccd
fix gaps in sample flight data (#19912) (#19971) 2018-06-15 21:21:22 -06:00
Tim Sullivan
4a3609ae30
[Monitoring] Improve User Experience of Enabling Monitoring Collection (#19451) (#19969)
* [Monitoring/No Data] Show a "still waiting" link after 19s

* minor bug fix: spinner if _interval_ updating

* update "we tried"

* some wording changes on activating / trying to activate monitoring

* cancel the setTimeout when component gets unmounted

* more wording tweaks

* update snapshot
2018-06-15 16:13:34 -07:00
Rashmi Kulkarni
bffe876587 ES6 conversion on Management Tests (#19870) 2018-06-15 14:28:59 -07:00
lcawl
ec15213b97 [DOCS] Adds links in breaking changes 2018-06-15 12:15:35 -07:00
Tiago Costa
392af2882c
chore(NA): remove node version validator from git pre-commit hook script. (#19950) (#19955) 2018-06-15 19:53:57 +01:00
Tyler Smalley
2d16733928 Handle configured path.data for Keystore location (#19916)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-06-15 08:40:53 -07:00
James Gowdy
ab0337aa7f
[ML] Removing rules from APM module (#19932) (#19936) 2018-06-15 14:18:53 +01:00
Aleh Zasypkin
51736c95e7
[6.x] Do not rely on native setTimeout in the promise service tests. (#19934) 2018-06-15 12:59:37 +02:00
Nathan Reese
55f125483d
kibana logo, wrap li in ul (#19838) (#19929)
* kibana logo, wrap li in ul

* set aria-label to home instead of logo
2018-06-14 17:55:50 -06:00
Nathan Reese
b820bcfffc
set timeout for timelion search requests (#19711) (#19809)
* set timeout for timelion search requests

* stub out server.config for mocha testing

* test timeout set

* arrow functions
2018-06-14 16:01:20 -06:00
Nathan Reese
8eae3702a3
clean-up sample data text (#19902) (#19924)
* clean-up sample data text

* remove duplicate text in toast since name includes 'sample' and 'data'
2018-06-14 15:43:55 -06:00
Søren Louv-Jansen
3b05d78273
Bump backport (#19910) (#19922) 2018-06-14 22:28:58 +02:00
Bill McConaghy
02e95ef4f8
upping xpack version of brace to the latest which should bring us to one version of it in the bundle. (#19897) (#19901) 2018-06-14 14:44:19 -04:00