Commit graph

25453 commits

Author SHA1 Message Date
Xavier Mouligneau
2177267ebc
fix math (#38132)
* fix math

* add unit test

* review I
2019-06-06 07:18:34 -04:00
Rudolf Meijering
ea9721ad13
[Core] Rewrite saved objects in typescript (#36829)
* Convert simple files to TS

* Fix jest tests

* Rename saved_objects_client{.js => .ts}

* WIP saved_objects_client

* saved_objects repository{.js => .ts}

* includedFields support string[] for type paramater

* Repository/saved_objects_client -> TS

* Fix tests and dependencies

* Fix saved objects type errors and simplify

* saved_objects/index saved_objects/service/index -> ts

* Fix saved objects export test after switching to typed mock

* Workaround type error

* Revert "Workaround type error"

This reverts commit de3252267eb2e6bf56a5584d271b55a7afdc1c53.

* Correctly type Server.savedObjects.SaveObjectsClient constructor

* saved_objects/service/lib/index.{js -> ts}

* saved_objects/service/lib/scoped_client_provider{js -> ts}

* Typescriptify scoped_client_provider

* Fix x-pack jest imports

* Add lodash/internal/toPath typings to xpath

* Introduce SavedObjectsClientContract

We need a way to specify that injected dependencies should adhere to the
SavedObjectsClient "contract". We can't use the SavedObjectsClient class
itself since it contains the private _repository property which in TS is
included in the type signature of a class.

* Cleanup and simplify types

* Fix repository#delete should return {}

* Add SavedObjects repository test for uncovered bug

Test for a bug in our previous js implementation that can lead to data
corruption and data loss.

If a bulkGet request is made where one of the objects to fetch is of a type
that isn't allowed, the returned result will include documents which have the
incorrect id and type assigned. E.g. the data of an object with id '1' is
returned with id '2'. Saving '2' will incorrectly override it's data with that
of the data of object '1'.

* SavedObject.updated_at: string and unify saved_object / serializer types

* Cleanup

* Address code review feedback

* Don't mock errors helpers in SavedObjectsClient Mock

* Address CR feedback

* CR Feedback #2

* Add kibana-platform as code owners of Saved Objects

* Better typings for SavedObjectsClient.errors

* Use unknown as default for generic type request paramater

* Bump @types/elasticsearch

* Fix types for isForbiddenError

* Bump x-pack @types/elasticsearch
2019-06-06 10:49:13 +02:00
Oliver Gupte
d43ee7fe3d
[APM] Moves the APM index creation from server startup (#37965)
* [APM] Closes #37499 by moving the APM index creation from server startup
to savedObject request for the index pattern. It first checks if the
index pattern is saved, if not it creates it.

* [APM] provide more meaninful status codes in the default error handler
2019-06-06 00:10:57 -07:00
Andrew Goldstein
8666c96fdf
## [SIEM] Disables Timeline Provider Mutations While Loading Data (#38185)
## Summary

* Fix: disables dropping a new data provider provider on the timeline, deleting an existing data provider, or choosing an action from the data provider context menu while the timeline is loading data to prevent draggable errors, like the one pictured in the screenshot below:

![draggable-error](https://user-images.githubusercontent.com/4459398/58996789-ebb7ce00-87b6-11e9-9490-47a0df6f89ab.png)

* Fix: the timeline settings icon appears too close to the `Refresh` button:
### Before (Chrome)

![timeline-gear-before](https://user-images.githubusercontent.com/4459398/58997030-e6a74e80-87b7-11e9-86df-cb67592e63a7.png)

### After (Chrome)

<img width="1679" alt="timeline-gear-after-chrome" src="https://user-images.githubusercontent.com/4459398/58997064-1ce4ce00-87b8-11e9-9ffb-0f412e0018ad.png">

### After (Firefox)

<img width="1672" alt="timeline-gear-after-firefox" src="https://user-images.githubusercontent.com/4459398/58997113-4f8ec680-87b8-11e9-9b52-dc8a13d51361.png">

### After (Safari)

<img width="1680" alt="timeline-gear-after-safari" src="https://user-images.githubusercontent.com/4459398/58997169-911f7180-87b8-11e9-8186-0ff31e41ad53.png">

### After (IE 11)

<img width="1354" alt="timeline-gear-after-ie11" src="https://user-images.githubusercontent.com/4459398/58997306-40f4df00-87b9-11e9-844d-b12c7e16f7cb.png">

* Fix: the `Open Timeline` modal is showing bulk-delete actions

### Before (Chrome)

![open-timeline-before](https://user-images.githubusercontent.com/4459398/58997349-700b5080-87b9-11e9-8299-7dbeccbd8ff9.png)

### After (Chrome)

<img width="1008" alt="open-timeline-after" src="https://user-images.githubusercontent.com/4459398/58997381-9af5a480-87b9-11e9-9909-2d68bd5ff2c3.png">

* Fix: action icons on the `Timelines` page and `Open Timelines` modal are not aligned with the counts

### Before (Chrome)

<img width="1552" alt="all-timelines-before" src="https://user-images.githubusercontent.com/4459398/58997554-659d8680-87ba-11e9-868c-d92ad72f44b8.png">

### After (Chrome)

<img width="1550" alt="all-timelines-after" src="https://user-images.githubusercontent.com/4459398/58997656-d8a6fd00-87ba-11e9-9038-c0ca464f8c4d.png">

* Fix: Changed the title text of the fields browser from `Select Fields` to `Customize Columns`

### Before (Chrome)

<img width="910" alt="fields-browser-before" src="https://user-images.githubusercontent.com/4459398/58997616-a4334100-87ba-11e9-9cd8-02ed9d265bf2.png">

### After (Chrome)

<img width="910" alt="fields-browser-after" src="https://user-images.githubusercontent.com/4459398/58997691-fa07e900-87ba-11e9-8cd9-6412d2cef8f0.png">

https://github.com/elastic/ingest-dev/issues/471
2019-06-06 00:42:31 -06:00
Garrett Spong
7049fa0e67
[SIEM] Removing draggability from message field (#38166)
## Summary

Currently, searching the `message` field within Timeline will not function properly, so in effort to prevent the user from searching with it, this PR removes the areas where `message` is draggable, which includes:

* Host Events Table
* Host Details Events Table
* Timeline Renderers
* Timeline Event Details

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2019-06-06 00:07:53 -06:00
Frank Hassanabad
670f90d4c8
[SIEM] Changes out event.severity for message in timeline and fixes sorting bug (#38158)
## Summary

  * Change out event.severity for message in timeline
  * Fixed critical crash where you should not be able to sort on timeline columns that are not aggregatable
  * https://github.com/elastic/ingest-dev/issues/513
  * https://github.com/elastic/ingest-dev/issues/496

Error toaster fixes:
<img width="348" alt="Screen Shot 2019-06-05 at 1 59 01 PM" src="https://user-images.githubusercontent.com/1151048/58986428-97065a00-879a-11e9-8ff9-003ac29f6d9e.png">

What the timeline looks like with severity replaced with message:
<img width="883" alt="Screen Shot 2019-06-05 at 1 55 19 PM" src="https://user-images.githubusercontent.com/1151048/58986459-a71e3980-879a-11e9-8144-f16f055bd53d.png">

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-06-06 00:05:40 -06:00
Yulong
4d41e58d0e
[Code] improve setup guide (#38218) 2019-06-06 13:54:34 +08:00
Clint Andrew Hall
33c08f4e20
[Canvas] Localize Function Errors (#37381)
* [Canvas] Localize Function Errors

* Update test

* Fix enum usage
2019-06-06 00:06:57 -05:00
Tiago Costa
f111b5c9e4
chore(NA): declare kbn-babel-preset as peer dependency for kbn plugin helpers. (#37710) 2019-06-06 04:53:20 +01:00
Steph Milovic
8b1b29550c
[SIEM] Additional Overview Network & Hosts metrics (#38005)
[SIEM] Additional Overview Network & Hosts metrics (#38005)
2019-06-05 20:36:58 -06:00
Yulong
a65577c3c3
[Code] fix another path problem on windows (#38072) 2019-06-06 10:03:29 +08:00
Nick Peihl
152866ea79
Fix sample data functional test (#38184) 2019-06-05 18:17:54 -07:00
Michael Marcialis
78f87d81e8
[SIEM] Beta badge on overview page (#38161)
* add beta badge to overview header

* update test

* updates snapshot
2019-06-05 20:54:04 -04:00
Jen Huang
6eb5049c9c
Fix i18n issues (#38169) 2019-06-05 17:45:56 -07:00
Mengwei Ding
2b85a090d9
[Code] Improve the document search highlights for non-english query (#38154) 2019-06-05 17:39:49 -07:00
Mengwei Ding
93ac0f97f9
[Code] search functional test to cover file typeahead query case insensitive (#38012) 2019-06-05 17:38:42 -07:00
Christiane (Tina) Heiligers
84b595e49f
KQL in TSVB (#36784)
* Squashed commit of the following:

commit 0cff8243a99ff23421c3cbb15d62b26332a31e21
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Mon May 20 16:16:15 2019 -0700

    Adds ignore_lobal_filter YesNo component back

    Deletes fixtures file

commit e54e1690c9c46e2de5e747d14030a7e27e74c138
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Mon May 20 14:39:21 2019 -0700

    squash-merges adding KQL with the full QueryBar and SavedObject migrations

Debugging

Adds filter defaults

Updates index pattern for the QueryBar on componentDidUpdate

squash-merges adding KQL with the full QueryBar and SavedObject migrations required

Adds ignore_lobal_filter YesNo component back

Deletes fixtures file

Updates migration test number

* Changes QueryBar to QueryBarInput in TimeseriesPanelConfigUi

Replaces QueryBar with QueryBarInput in Timeseries

Changes QueryBar to QueryBarInput in TSVB Metric

Changes QueryBar to QueryBarInput in other TSVB visualisation editors

Removes async from componentWillMount

changes indexPattern to indexPatternObject in series and table query request processors

* Squashed commit of the following:

commit 2c3107963cff20b2d24323fddfaf80c848b86848
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 15:15:06 2019 -0700

    Cleans up comments

commit 943150d4b9b71183e9d5b26c95449ea4519aad4c
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 14:09:53 2019 -0700

    Cleans up parser check more

commit d31de88525595720556440ae71515f5772774eaa
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 14:01:02 2019 -0700

    Cleans up parser check

commit b592071b1d939ec2df9b9c921d57a22dac54e703
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 13:16:55 2019 -0700

    skips server call on invalid kuery queries

Cleans up

Deletes duplicate migration function

Adds 's' to split_by_filters method

Resolves issues after rebase

* Removes quotes around index pattern strings passed into fetch_index_patterns, adds comments on reasoning

* queryBar to queryBarInput

Adds transformFilterStringToQueryObject back to visualizations migrations that was lost during rebase

* Deletes unused code

* Fixes migrations test

* compiles visualizations migrations for version 7.3.0

* temporary change to query_bar_input fetch_index_patterns file

formatting

Includes code from PR#37413

Clean up

* Formatting

* Uses series index pattern when override_index_pattern is selected and an index pattern is provided

* Removes empty object as alternative to localStorage

* Removes handelQueryChange from where it is not needed

* extracts retrieval of the default query language from uiSettings into a helper method

* Resolves some PR comments

* Handles Query Error from an invalid syntax query

* Converts string queries into objects with kuery as the language in saved_objects data for ecommerce, flights and logs TSVB visualizations

* Deletes unused translation items

* Adds optional id prop to the query_bar_input and makes the screenTitle optional

* Updates [eCommerce] Sold Products per Day

* Removes screenTitle from component QueryBarInput

* Wraps index pattern strings in a double quote to allow for names such as 'logstash-*'
2019-06-05 16:06:01 -07:00
Josh Dover
02ff1adcbd
[new-platform] Simplify the frontend integration with the legacy platform (#37734) 2019-06-05 17:46:03 -05:00
Luke Elmers
5095b43de3
ui settings mocks: mock observables' return values. (#37584) 2019-06-05 16:39:13 -06:00
Brandon Kobel
76724766d9
Updating stringstream to 0.0.6 (#38155) 2019-06-05 15:33:07 -07:00
CJ Cenizal
8365c3baa2
Skip Index Manamgent API integration tests that are inapplicable to Cloud, when they are run on Cloud. (#38045) 2019-06-05 15:25:52 -07:00
Fuyao Zhao
f0b9f07fb4
[Code]: unassociate html with typescript langserver (#38150) 2019-06-05 15:20:44 -07:00
Wylie Conlon
5a628272b3
Fix discover not using an index pattern when 2 are created (#38053) 2019-06-05 17:11:40 -04:00
Corey Robertson
4038859c6d
Move shimming of workpad CSS to only happen on fetch (#38117) 2019-06-05 15:54:14 -04:00
Nathan Reese
99994fb864
[Maps] replace FormattedText with FormattedMessage (#38016)
* [Maps] replace FormattedText with FormattedMessage

* fix Capitalization
2019-06-05 13:13:48 -06:00
Ahmad Bamieh
abbd6f3535
Allow headers config to propagate in callAsCurrentUser (#34610)
* add telemetry query source when hitting monitoring indexes

* allow headers to pass through

* Update src/core/server/elasticsearch/scoped_cluster_client.ts

* fixes from bill code review

* split test cases

* fix functional test

* check if issue from intersect function

* more debug

* check for duplicate values instead

* code review updates

* remove mockClear
2019-06-05 21:28:05 +03:00
Luke Elmers
1e016a62a9
Fix broken filtering on metric visualizations. (#38029) 2019-06-05 11:48:30 -06:00
Justin Kambic
e3e7501236
Remove "common" options from SDP that have a 0ms difference between end and start time. (#37395) 2019-06-05 13:44:14 -04:00
Vitali Haradkou
a7dedb63d5
[TSVB] [AT] implement new test cases for time series formatter (#37506)
* implement new test cases for time series formatter
2019-06-05 18:13:04 +03:00
Nick Peihl
77272ab040
Use production EMS manifest (#38050) 2019-06-05 07:54:05 -07:00
Dmitry Lemeshko
27e219e20b
functional tests/firefox wait for loading after page refresh (#38082) 2019-06-05 16:52:48 +02:00
Ryan Keairns
858215caf9
default shape aspect ratio to false (#38030) 2019-06-05 09:26:07 -05:00
Clint Andrew Hall
fbd7e890cf
[Canvas] Interpreter type conversion (#37300)
* Move Expression types to OSS.

* Add interfaces for KibanaContext and KibanaDatatable types.

* Convert esaggs expression function to TypeScript.

* Clean up KibanaDatatable and KibanaContext types.

* Convert functions to use new Interpreter types

* Update ArgumentString-related types to simply be TypeString.

* Rename types.ts to index.ts so types can be imported at the top level.

* Update ArgumentString-related types to simply be TypeString.

* Rename types.ts to index.ts so types can be imported at the top level.

* Remove unused code from arguments types.

* Convert x-pack imports of OSS plugins from relative to absolute.

* Fix esaggs import.

* Addressing self feedback
2019-06-05 09:25:06 -05:00
Tiago Costa
162e13dbdf
Relative cache loader (#36131)
* chore(NA): first efforts to enable cache-loader relative paths and disable babel-register cache. chore(NA): allow to use cache-loader results everywhere as a persistent cache.

* chore(NA): last change to support cache loader across envs.

* fix(NA): cache-loader config generator function scope.

* refact(NA): static cache config for dll compiler.

* chore(NA): support for force writable cache flag. use built assets for cache on distributable.

* chore(NA): update cache-loader to last version. fix(NA): logic bug with force writable cache flag.

* chore(NA): move optimize cache to built_assets.

* chore(NA): relative paths for sourcemap configurations.

* chore(NA): remove redudant check for process.env var.

* refact(NA): simplify double negated expression.

* chore(NA): remove webpack prefix from devtoolModuleFilenameTemplate.

* chore(NA): rename cache write force flag to KBN_CACHE_LOADER_WRITABLE.

* chore(NA): readd babel register cache.

* chore(NA): change .cache to .ui_bundles_cache

* chore(NA): change .ui_bundles_cache to cache/ui_bundles

* chore(NA): update gitignore with .babel_register_cache.json

* chore(NA): rollback devtool module filename template to asbolute resource path.

* chore(NA): apply cache-loader patch.
2019-06-05 15:17:56 +01:00
Brandon Kobel
b78aba3298
Updating mixin-deep to 1.3.1 (#38057) 2019-06-05 06:40:52 -07:00
Mike Côté
9aa2ca8465
Fix URLs from displaying too long in saved objects management UI (#37987)
* Fix URLs from displaying too long

* Add encodeURIComponent
2019-06-05 09:38:14 -04:00
James Gowdy
8bdecb0f36
[ML] Fix for constant polling of deleting job tasks (#38013)
* [ML] Fix for constant polling of deleting job tasks

* fixing comment
2019-06-05 14:05:25 +01:00
Justin Kambic
21de9bc1d1
[Uptime] [Bug] Disable integration links for apps that are not present (#37284)
* Add tests and checks for disabled/enabled integration link.

* Add empty state if all integrations are unavailable.

* Fix broken type.
2019-06-05 08:42:16 -04:00
Justin Kambic
1080dc4cc9
Remove deprecated feature from elasticsearch queries. (#37995) 2019-06-05 08:40:24 -04:00
Mike Côté
a537aaed6b
Update import saved objects API docs to use curl examples (#37997)
* Remove copy as curl

* Update import docs to use curl examples
2019-06-05 07:49:47 -04:00
Mike Côté
9772ab5cd8
Fix export saved objects API docs (#37991) 2019-06-05 07:47:21 -04:00
Pete Harverson
4a3034de49
[ML] Fixes loading of Single Metric Viewer if partition field is text (#37975)
* [ML] Fixes loading of Single Metric Viewer if partition field is text

* [ML] Fix failing test and edit translations for cardinality check

* [ML] Edits to fields_service.js following review
2019-06-05 12:02:03 +01:00
Silvia Mitter
d8b0368c5e
[apm] update index pattern (#37866)
related to https://github.com/elastic/apm-server/pull/2239
2019-06-05 11:49:57 +02:00
WangQianliang
84f258aad8
fix(code/frontend): should not polling status if import repo not succeed (#37955) 2019-06-05 17:22:37 +08:00
WangQianliang
7b1e72aafa
fix(code/frontend): improve regexp that matches the container of a symbol (#37856) 2019-06-05 17:14:15 +08:00
Joe Reuter
4c80466d23
Add error handling to expression runner (#37968) 2019-06-05 10:31:06 +02:00
WangQianliang
61d4e085b4
fix(code/frontend): catch structure generating error in saga (#37957) 2019-06-05 14:59:10 +08:00
Pengcheng Xu
64be596fb1
[Code] fix url and encoding for java langserver on Windows (#38064) 2019-06-05 13:59:53 +08:00
Fuyao Zhao
3d3dc04018
[Code]: Use more robust way to handle url (#38060) 2019-06-04 22:00:15 -07:00
Yulong
6057340112
[Code] fix hover in monaco-editor 0.17 (#37964) 2019-06-05 10:12:35 +08:00