Commit graph

28882 commits

Author SHA1 Message Date
Daniil Suleiman 2339e28279
Generate a static parser, move tests to vis_type_timelion (#55299) (#55401)
* Use generated parser, move tests to vis_type_timelion

* Remove legacy tests

* Create a grunt task for generating a parser
2020-01-22 12:43:01 +03:00
Joe Reuter f84ac08225
Migrate session storage short url handling (#55021) (#55393) 2020-01-22 09:16:47 +01:00
Dima Arnautov 14cd8e21f8
[ML] Fix counters and percentages for array fields on the Data visualizer page (#55209) (#55518)
* [ML] update data visualizer endpoint to check doc counts

* [ML] fix mock for cardinality tests

* [ML] use actual field name for agg filtering instead of safeFieldName

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 08:44:59 +01:00
Frank Hassanabad 97e6ae502b
[SIEM][Detection Engine] Tags being turned into null (#55516)
## Summary

Test:

1.) Add a tag to a new rule
2.) Activate the rule
3.) Ensure the tag does not go away

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-21 23:28:47 -07:00
The SpaceCake Project 81177fbb37
rules part deux (#55507) (#55512)
cuts and metadata additions
2020-01-22 00:25:47 -05:00
Frank Hassanabad e748b7c798
[SIEM][Detection Engine] Critical blocker, fixes schema accepting values it should not (#55488) (#55505)
## Summary

* This fixes the schema accepting values the UI cannot handle at this point with severity. It's best to just set it to a small fixed enumeration of values.
* From feedback from people the values should have more defaults and be more consistent in the schema so gave defaults for `from`, `to`, and `interval`.
* Removed dead query examples that cannot happen because immutable cannot be set by end users anymore
* Changes the version and other sections to be integer only and not allow floats
* Added unit tests

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-21 21:56:03 -07:00
Michail Yasonik 12f0c95cac
[7.x] Grouped Kibana nav (#53545) (#55496)
Adds concept of `category` to nav links, grouping them by this in the side nav
2020-01-21 22:45:10 -05:00
Tim Sullivan 1043489bbf
Chore/remove once per server (#49426) (#55500)
* [Reporting/np-k8] Remove several oncePerServer usages

* ts fixes 1

* ts fixes 2

* more ts fixes

* more ts fixes

* more ts fixes

* ts simplification

* improve ts

* remove any type for jobParams and define JobParamsSavedObject and JobParamsUrl

* ts simplification

* Fix ts

* ts simplification

* fix ts

* bug fix

* align with joels pr

* Move get_absolute_url to not use oncePerServer

* Two more removals of oncePerServer

* Final once-per-server removals

* AbsoluteURLFactory => AbsoluteURLFactoryOptions

* Fix absolute_url util

Co-authored-by: Joel Griffith <joel@joelgriffith.net>
2020-01-21 20:31:02 -07:00
Xavier Mouligneau bfe9b45a55
[SIEM] Detections create prepackage rules (#55403) (#55503)
* update extra action on rule detail to match design

* remove experimental label

* allow pre-package to be deleted + do not allow wrong user to create pre-packages rules

* Additional look back minimum value to 1

* fix flow with edit rule

* add success toaster when rule is created or updated

* Fix Timeline selector loading

* review ben doc + change detectin engine to detection even in url

* Succeeded text size consistency in rule details page

* fix description of threats

* fix test

* fix type

* fix internatinalization

* adding pre-packaged rules

* fix bug + enhance ux

* unified icon

* fix i18n

* fix bugs

* review I

* review II

* add border back
2020-01-21 21:54:55 -05:00
Patrick Mueller b4f15c6346
Adds event log for actions and alerting (#45081) (#55486)
initial code for event log

see issue https://github.com/elastic/kibana/issues/45083
2020-01-21 20:24:33 -05:00
Tim Sullivan 03cf52161d
[Reporting/Migration] ReportingSetup, LegacySetup (#54198) (#55441)
* ReportingSetup, LegacySetup

* fix ts
2020-01-21 17:38:53 -07:00
Frank Hassanabad 0373fd46ca
[SIEM][Detection Engine] Fixes critical blocker where signals on signals are not operating (#55479)
## Summary

This fixes halting, infinite creation of signals, and cyclic issues with signals when they are reflected on their own index. Without this fix, you could get a user who looks back at a signals index as both their input and output index and forever generates new signals forever and ever and ever until the heath death of the universe. 

* Changes the data structure to support parent and ancestors
* Adds a check for the parent and ancestors
* Adds README.md and in-depth testing of cyclic concepts
* Adds README.md and in-depth testing of depth levels of signal concepts
* Added unit tests for both use cases
* Removed extra console.log statement found in the code base

Follow the two README.md's included for testing and explanation of how it works.

See `test_cases/signals_on_signals/depth_test`
See `test_cases/signals_on_signals/halting_test`

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-21 17:04:41 -07:00
Frank Hassanabad ddb1ca02e7
[SIEM][Detection Engine] Critical blocker, adds need REST prefix for cloud (#55481)
## Summary

* Adds needed `/` to the beginning of cloud requests from Kibana -> ES

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-21 17:04:18 -07:00
Thomas Neirynck fca83a67c8
[File upload] Enforce file-type check in file dialog (#55063) (#55449) 2020-01-21 16:37:03 -05:00
Eli Perelman 09c2b8eccd
[skip-ci] Update migration guide to add rendering service example (#54744) (#55466)
* Update migration guide to add rendering service example

* Address review nits

* Address nits

* Add chromeless apps to TOC
2020-01-21 15:22:53 -06:00
Nick Partridge 2fcac071b5
De-angularize vis tooltips (#54954) (#55432)
* Remove angular dependencey from vis/tooltip
* Move tooltip logic into vislib
* Remove and fix all ngMock refs in vislib tests
* Add numeral to renovate config
* Add vis_type_vislib to codeowners
* Move vis_legend into vislib and fix errors
* vis_type_vislib/public imports to be only top-level
2020-01-21 15:03:34 -06:00
Aleh Zasypkin 0c62eba3b7
[7.x] Re-enable Kerberos + anonymous access test. (#55407) 2020-01-21 21:26:59 +01:00
Kaarina Tungseth cc452ed4bb
[DOCS] Updates to heat map page (#55097) (#55461) 2020-01-21 14:11:49 -06:00
patrykkopycinski ce349622f3
[SIEM] Fix Detections page breadcrumbs (#55173) (#55448) 2020-01-21 20:48:12 +01:00
James Gowdy 3abcab9cc7
[ML] Fixing categorization wizard example results (#54924) (#55437)
* [ML] Fixing categorization wizard example results

* moving validation results to class

* cleaning up category analyzer types

* small tweaks

* removing commented out code

* fixing string ids

* small refactor

* improving validation messages

* fixing types

* updating message text

* fixing typo

* adding privileges error

* updating privilege message

* changes based on review

* removing old warning message

* fixing translations

* renaming enum
2020-01-21 19:13:01 +00:00
James Gowdy cc1bde9cb7
[ML] Adding missing job groups to recognizer wizard (#55392) (#55411) 2020-01-21 19:12:39 +00:00
Joe Portner e107aae433
Update Monitoring plugin's Elasticsearch configuration (#55119) (#55435)
* Fix Monitoring plugin Elasticsearch SSL config

Plugin now allows "keystore" and "truststore" values in its
config schema as the documentation currently states.
Plugin also now reads PEM and PKCS12 files off of the filesystem
before attempting to create an Elasticsearch client.

* Add missing Elasticsearch config deprecations

Several Elasticsearch config deprecations were overlooked for
monitoring-specific Elasticsearch settings.
2020-01-21 14:11:59 -05:00
Liza Katz 0be6024fe4
Clean up search service (#53766) (#55434)
* deprecate msearch

* Missing export

* adjust tests, revert loading method of esaggs/boot

* getInjectedMetadata

* Fix jest tests

* update default strategy abort test

* notice update

* Allow running discover errors test independently

* Remove batchSearches

* Detect painless script error

* don't show notifications for aborted requests

* Fix jest tests

* Restore loader indicator

* Decreace loading count on error

* update search test

* Trigger digest after fetching fresh index patterns

* Revert isEqual

* accurate revert

* Return full error details to client from search endpoint

* Re-throw AbortError from http when user aborts request.

* fix typo

* typo

* Adjust routes jest test

* Restore msearch using a separate es connection

* typescript fixes

* set http service mock

* Move es client to dat aplugin, for follow up PR

* Add karma mock

* krma mock

* fix tests

* ts

* Pass in version dynamically

* add headers to esClient host

* Restored fetch soon test
Use tap for loadingCount side effects

* Cleanup search params

* Cleanup search params test

* Revert "Cleanup search params"

This reverts commit ca9dea01d5.

* Revert "Cleanup search params test"

This reverts commit 30b9478612.

* Revert code to use old es client until  #44302 is resolved

* Revert changes to getPainlessError

* Fix jest test

* Refactor esClient to trigger loadingIndicator

* fixing tests

* use esClient from searchService

* git remove comment

* fix jest

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 20:58:56 +02:00
Justin Kambic 6654461e6f
[Uptime] Fix flaky uptime overview page test (#54767) (#55417)
* Fix flaky uptime overview page test.

* Increase timeout for url checks.

* Prefer standard `retry.try` to custom retry implementation.

* Remove unneeded symbol.

* Remove unnecessary type annotation.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 13:33:19 -05:00
Dima Arnautov b115f2f5ef
[ML] Formatting for additional timing and model size stats (#55062) (#55414)
* [ML] formatting for additional timing and model size stats

* [ML] roundToDecimalPlace only average search time

* [ML] adjust functional tests

* [ML] remove debug tag, fix assert value

* [ML] check for no decimal place

* [ML] fix functional tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 19:06:05 +01:00
Tim Sullivan 1cb96c2136
[7.x] [Reporting] Define shims of legacy dependencies (#54082) (#55134)
* [Reporting] Define shims of legacy dependencies (#54082)

* simplify serverfacade definition

* simplify requestfacade definition

* use the shim

* makeRequestFacade

* requestFacade

* import sorting

* originalServer

* reduce loc change

* remove consolelog

* hacks to fix tests

* ServerFacade in index

* Cosmetic

* remove field from serverfacade

* add raw to the request

* fix types

* add fieldFormatServiceFactory to legacy

* Pass the complete request object to sec plugin

* Fix test

* fix test 2

* getUser takes a legacy request

* add unit test for new lib

* add getRawRequest to pass to saved objects method

* update test snapshot

* leave a TODO comment for type import

* variable rename for legacy id

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* update legacy to fix ts errors

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 11:04:02 -07:00
Lisa Cawley a8ac40b191
[DOCS] Removes coming tag (#55420) 2020-01-21 08:31:39 -08:00
Kaarina Tungseth c556ceeb8c
[DOCS] Added to Add a field column definition (#55116) (#55236) 2020-01-21 10:06:10 -06:00
Joe Reuter f1a148c538
Migration: Separate legacy and index entrypoint (#54124) (#55391) 2020-01-21 16:26:50 +01:00
Nathan Reese 3b3009b426
[Maps] fix warning about missing key in react element (#55372) (#55394) 2020-01-21 10:25:53 -05:00
patrykkopycinski 4fd777a8d7
[SIEM] Update ml_conditional_links cypress tests (#55373) (#55383) 2020-01-21 15:36:39 +01:00
Aleh Zasypkin d57c7b7bbb
[7.x] Migrate Management views to Kibana Platform plugin (#55382) 2020-01-21 15:23:11 +01:00
Mikhail Shustov 9272e43701
Expose fatalErrors API from the Start contract (#55300) (#55374)
* Expose FatalErrors from the Start contract.

This API is intended to be used for runtime as well.

* update docs

* update data plugin snapshot to fix tests

* address comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 14:23:05 +01:00
Sébastien Loix 5122ac32e5
[Mappings editor] Add missing max_shingle_size parameter to search_as_you_type (#55161) (#55366) 2020-01-21 16:25:07 +05:30
Liza Katz 3070f0bb7c
[BUG] Data fetching twice on discover timefilter change (#55279) (#55368)
* Fix bug #54887
 - Filters are not only fetch once on timefilter change
 - Make sure that discover doesn't fetch data when a disabled filter is changed
 - Support compareFilters on an array of filters.
 - Added tests to compare filters
 - Exctracted sortFilters and added tests to it.

* code review + FilterCompareOptions

* Remove sort by

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 12:25:45 +02:00
Alejandro Fernández 8d8d3a009f
[Logs UI] Fix z-index of logs page toolbar (#54469) (#55346)
* Fix z-index of logs page toolbar

* Extract `FixedDatePicker` from log setup page, and use it in the stream page

* Clean unused import

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 10:50:17 +01:00
Gidi Meir Morris 1f1a0da400
removes CTA from Task Manager info message (#55334) (#55343)
removes CTA from Task Manager info message
2020-01-20 22:39:34 +00:00
James Gowdy 732d76e974
[ML] Fixing missing job_type in job messages search (#55330) (#55335) 2020-01-20 17:41:39 +00:00
Shahzad 6f249ea4db
update local (#55177) (#55318) 2020-01-20 18:32:09 +01:00
Shahzad d31dea3215
fix commonly used ranges uptime (#54930) (#55320) 2020-01-20 18:31:44 +01:00
Walter Rafelsberger 6c87958eb2
[ML] Correctly pass on severity value to anomaly explorer charts. (#55207) (#55328)
- Fixes passing on the severity value correctly to anomaly explorer charts. The wrong value of undefined being passed down caused anomaly markers not showing up.
- This bug surfaced that the severity value was never applied to filter multi-bucket anomalies which is now also fixed by this PR.
- Adds a check if topInfluencers is an array.
2020-01-20 17:04:50 +01:00
Walter Rafelsberger 7e365acbf9
[ML] Single Metric Viewer: Fix job check. (#55191) (#55325)
Fixes switching via navigation to Single Metric Viewer from Anomaly Explorer for a job which isn't supported in the Single Metric Viewer.
2020-01-20 17:00:32 +01:00
Pierre Gayvallet ac386b313c
Show error page when accessing unavailable app (#54656) (#55317)
* display not found page instead of throwing an error when accessible unavailable app

* move types to public folder

* fix types import

* remove updater from start app

* remove unnecessary await
2020-01-20 16:19:11 +01:00
Mike Côté 285a20112b
Re-enable mute all test now that API is no longer flaky (#55172) (#55239)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-20 09:53:22 -05:00
James Gowdy 64f6670128
[ML] Improving job wizards with datafeed aggregations (#55180) (#55313)
* [ML] Improving job wizards with datafeed aggregations

* picking all agg keys for fields

* function move and rename
2020-01-20 14:46:24 +00:00
Mikhail Shustov 0d10f0e956
remove flaly assetion. a license presence tested anyway (#55289) (#55307) 2020-01-20 15:03:07 +01:00
Marcin Tojek 493f60f1c3
Add Kibana tutorial for IBM MQ metrics (#54900) (#55293)
* Add Kibana tutorial for IBM MQ metrics

* Change IBM MQ logo

* Logo minified

* Add screenshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-20 14:37:07 +01:00
patrykkopycinski 3e6c1e063f
[SIEM] Use proper icons on Detections view (#55215) (#55297) 2020-01-20 14:01:44 +01:00
Anton Dosov f6c882eb23
[State Management] Remove AppState from edit_index_pattern page (#54104) (#55294)
Replaces AppState in edit_index_pattern with state containers and state syncing utils.
In addition makes tab navigation on edit_index_pattern work with browser's undo history
2020-01-20 13:49:47 +01:00
Marcin Tojek 3f93f48532
Fix: invalid translation referenced (#54901) (#55296) 2020-01-20 13:22:48 +01:00