Commit graph

15826 commits

Author SHA1 Message Date
Spencer
252024df52 [fix/UiSettings] ignore certain errors (#13079)
* [SavedObjectClient] emit detectable errors

* [uiSettingsService] consume new SavedObjectsClient errors

* [SavedObjectsClient] expose errorTypeHelpers as such

* [elasticsearch/tests] recreate error for each test

* [http] wait for elasticsearch plugin to be ready

* [shortUrl/tests] ensure that create request responds with 200

* [shortUrl] use errorTypeHelpers to filter errors

* [uiSettings/savedObjectsClientStub] stub errorTypeHelpers

* [SavedObjectsClient/errors] expose error module so tests can make errors

* [shortUrl/tests] use actual SavedObjectsClient errors

* [uiSettings/savedObjectsClientStub] use actual errors lib

* [SavedObjectsClient] use decorate instead of "wrap"

* [server/routes/uiSettings] refactor routes to forward Boom errors from uiSettings

* [uiSettings] colocate routes and service

* [testUtils/esTestCluster] use more standard api style

* [testUtils/es] add createCallCluster util

* [testUtils/esTestCluster] add getters for client/callCluster

* [es/healthcheck] ensure that healtcheck stops when server is stopped

* [uiSettings/routes] add param/payload validation

* [uiSettings/routes] add tests that verify error behaviors

(cherry picked from commit 8a64872ecb)
2017-08-08 17:57:07 -07:00
Spencer
f66daee862 [es/healthcheck] ensure that healthcheck stops when server is stopped (#13201)
(cherry picked from commit 924548864d)
2017-08-08 15:18:24 -07:00
Matt Bargar
1ee023afa8 Make filter pills keyboard accessible (#13331) (#13392)
Fixes #12639

It's now possible to tab to each filter's actions and interact with them via the keyboard.

In order to get the actions to show/hide on both mouse hover and action focus I had to create a new filter-pill component that could manage a bit of state to track whether the user was interacting with a given pill or not.
2017-08-08 17:03:36 -04:00
Stacey Gammon
b97f84968c Show full screen option even when write controls are hidden (#13247) (#13384) 2017-08-08 13:27:22 -04:00
Stacey Gammon
abf9def02d Create the concept of embeddableHandlers (#12146) (#13386)
* Move dashboard panel rendering logic to each registered type.

* Remove dashboard knowledge of click and brush handlers for visualizations

Move it to the VisualizeEmbeddableHandler.

* merge master with manual changes

* No need to use lodash

* Add EmbeddableHandler base class

* Use correct path to embeddable_handlers_registry

* clean up

* Set visualize scope uiState that is of type PersistedState, otherwise it won't actually be set.

* add retry to loading saved search data

* Fix handleError param and remove unnecessary private param

* Rename savePanelState updatePanel and return the new object rather than mutating the original

* Make ContainerAPI a base class and move the dashboard specific functionality into a new class

* Make api's async and clean up documentation

* Fix panel tests

* Fix bug which broke tests - need to pass container-api to dashboard-panel

* Address code comments

- Rename onFilter to addFilter
- Use angular promises instead of async/await
- fix jsdoc
- rename createChildUiState to getInitialState

* changed the wrong variable name

* no need for async or Promise.reject on interface

* add tests that will fail due to spy pane issue in this PR

* Fix logic with spy pane toggle

There is still a bit of a bug here as mentioned in
https://github.com/elastic/kibana/issues/13340 but it will be fixed
separately as it’s also an issue in master

* Fix failing test
2017-08-08 13:27:12 -04:00
Stacey Gammon
f9894e9a3b Use find service instead of remote (#13296) (#13387)
* Use find service instead of remote which doesn't have built in safety checks for stale elements

* use data-test-subj instead of id

* add missing function and awaits

* Did not realize WebElements could find descendants

Added some extra functionality for this in find and testSubjects
service, and using in the one place it’s required.
2017-08-08 13:26:54 -04:00
Stacey Gammon
0698088fc7 Fix accessibility issues with saved object finder (#13152) (#13371)
* Fix accessibility issues with saved object finder

and use new kui styles

* Dark theme-icy kuiTabs

* Refer to existing dark theme color variables.  Use dark theme hover link color.

* use button instead of div element so no need for kbn-accessible-click

* Add dark theme tab variety to ui framework site, lighten color of background tabs
2017-08-08 09:52:42 -04:00
Tim Roes
ea2a31d2d7 Move build-info to status page (#13341)
* Move build-info to status page
* Remove info property from management section
2017-08-08 12:15:10 +02:00
Lukas Olson
9bdba7c84f Remove highlight query (#13231)
* Change use of all_fields in highlight_query to default_field

* Remove highlight query and option

* Fix tests

* Remove unused setting

* Remove lingering references to all_fields
2017-08-07 13:38:36 -07:00
Stacey Gammon
84a34e333c Fix full screen toggle button when panel is expanded (#13320) (#13362)
* Add failing tests

* Fix style issues with full screen toggle
2017-08-07 13:50:06 -04:00
Felix Stürmer
c888180e73 [6.x] [docs] Add css style guide section on open/closed principle (#13368)
Backports PR #12276
2017-08-07 18:17:40 +02:00
CJ Cenizal
ff66d71e97 Mock out static files when running in Jest (#13315) (#13367) 2017-08-07 09:16:31 -07:00
Spencer
679d8ad738 Add some testSubject helpers (#13305)
* [testSubjects] add getVisibleTextAll() helper

* [testSubjects] add isSelected() and isSelectedAll() helpers

* [testSubjects/setValue] support wrappers around inputs

* [testSubjects] add isEnabled() helper

* fix typo

(cherry picked from commit 8ee85f8fed)
2017-08-04 18:49:44 -07:00
Matt Bargar
b1f6dddf35 Add documentation link to query bar when Kuery is selected (#13300) (#13349)
* Add doc link to kuery bar
2017-08-04 16:54:10 -04:00
Matt Bargar
b187ef98f4 Remove simple_query_string hack now that multi_match supports * (#13285) (#13346) 2017-08-04 16:53:28 -04:00
Peter Pisljar
8f2d2cffea resize was not detected correctly (#13239) 2017-08-04 08:11:21 +02:00
Lukas Olson
8eff313d6a Use ui-select for agg selector (#13292)
* Use ui-select for agg selector

* Fix functional tests

* Fix functional tests

* Fix test

* Fix visualize page object

* Use sortPrefixFirst in agg selector

* Fix unit tests

* Fix unit test

* Use not(.ng-hide) rather than last-child
2017-08-03 15:26:48 -07:00
Thomas Neirynck
1ab9a095aa fix typo 2017-08-03 14:55:35 -04:00
Thomas Neirynck
1998616a08 Improve region map documentation (#13319) 2017-08-03 14:55:35 -04:00
Stacey Gammon
7e5d2c4842 Make sure no one can show the chrome if the default setting is hidden. (#13250) (#13317)
* Make sure no one can show the chrome if the default setting is hidden.

add tests

Fixes https://github.com/elastic/kibana/issues/13040

* Improve variable and function names and fix tests
2017-08-03 13:10:24 -04:00
Tim Sullivan
7e0559f667 [Accessibilty] Make kbn_accessible_click part of autoload/all (#13299)
* [Accessibility] Ensure kbn-accessible-click is part of autoload/all

* remove unecessary kbn_accessible_click imports

* use an index.js file to expose inner directives
2017-08-03 10:02:49 -07:00
Jonathan Budzenski
d1d0290cbc
[visualize spy] Pull index title instead of id (#13254)
* [visualize spy] Pull index title instead of id

* [visualize spy] Check for existence of index before pulling params
2017-08-03 11:32:31 -05:00
CJ Cenizal
0ac9c2fdf2 [6.x] [eslint-config-kibana] 0.9.0 and 0.10.0 (#13318)
* [eslint-config-kibana] Add jest plugin and settings (#13090)
* Add AirBnB linting rules for React best practices. Bump to v0.10.0. (#13259)
2017-08-03 08:49:38 -07:00
Thomas Neirynck
df2e5a655f Visualization accessibility issues (#13226) 2017-08-03 11:32:30 -04:00
Spencer
bb1e1e82e3 [ui/routes] clone defaults before apply (#13295)
* [ui/routes] add failing tests

* [ui/routes] clone defaults before applying them

* Mention issue in related tests

(cherry picked from commit c68c0d6588)
2017-08-02 13:27:07 -07:00
Matt Bargar
060b9e4dfe Add Kuery docs and break search page into subsections (#13074) (#13302)
* Add Kuery docs and break search page into subsections
2017-08-02 16:11:31 -04:00
ytzlax
1ea3f6b6d5 Add Kibana API plugin (#13206) 2017-08-02 12:03:25 -04:00
Nathan Reese
2fb7973ea5 update spy table headers when columns update (#13130) (#13224)
* update paginated table headers with columns update

* remove unneeded sleep

* update getDataTableHeaders to preffered format

* use data-test-subj attribute for functional tests instead of CSS selectors
2017-08-01 20:34:25 -06:00
Spencer
b5f20bc60a [npm] upgrade postcss-loader (#13279)
Needed to get a version that included https://github.com/postcss/postcss-loader/pull/174
(cherry picked from commit 0aa4206d2c)
2017-08-01 18:37:47 -07:00
Tim Sullivan
508d6cb8eb [Framework/Accessibility] Add kuiScreenReaderOnly class (#13133)
* [Framework/Accessibility] Add kuiScreenReaderOnly class

* fix typo

* use GuideLink

* add screen_reader react component and tests

* export KuiScreenReaderOnly

* --wip-- [skip ci]

* fix lint rule

* remove obsolete snapshots
2017-08-01 15:56:12 -07:00
Thomas Neirynck
2d73481f8a ensure we are working with data-series (#13266) (#13273)
This fixes a regression introduced by https://github.com/elastic/kibana/pull/13217.
2017-08-01 18:34:44 -04:00
Matt Bargar
42fb0a504a Send map filters through so it get picked up by both kuery and lucene (#13251) (#13262) 2017-08-01 15:37:16 -04:00
Matt Bargar
2521f83285 Add some functional tests for query language switching (#13036) (#13256)
* Add some functional tests for query language switching
2017-08-01 13:47:04 -04:00
Thomas Neirynck
1e4d4c7753 Exclude stacktrace from error response of Timelion backend (#12973) 2017-08-01 11:46:01 -04:00
Peter Pisljar
555bb70d64 removes :filters from label (#12962) (#13234) 2017-08-01 13:17:55 +02:00
Peter Pisljar
cfd4887c47 in percentage mode tooltip should also show percentages (#13217) (#13238) 2017-08-01 13:17:02 +02:00
Felix Stürmer
4182eba6d9 [6.x] Use version 0.9.0 of eslint-config-kibana (#13183)
Backports PR #13177
2017-08-01 12:00:44 +02:00
Kim Joar Bekkelund
c830f0cd61 Remove @elastic folder from packages/ (#13089)
(cherry picked from commit 5772f56d7a)
2017-07-31 13:59:27 -07:00
Spencer
e396a783fc [server/indexPatterns] expose indexPatternService getter/factory (#13012)
(cherry picked from commit 9389f0b71a)
2017-07-31 12:46:07 -07:00
Chris Roberson
e21c399d71 Update saved objects client usage to attributes instead of _source. Also, fixing an improper "safe" apply usage. (#13223) 2017-07-31 14:43:00 -04:00
Tim Roes
05057e7d50 Fix typos and punctuation in WMS settings (#13146) 2017-07-31 15:52:36 +02:00
Spencer
f3cbc4d2a4 [testUtils/esTestCluster] use more standard api style (#13197)
(cherry picked from commit d36080bca8)
2017-07-28 15:50:46 -07:00
Court Ewing
7ee7cd7d68 test: hard code esApiVersion to master (#13198)
Until elasticsearch.js actually has support for 6.x/6.0 branches, this
needs to just rely on the master apiVersion.

Also, we shouldn't change this esApiVersion in tests unless we are also
changing the value in our elasticsearch plugin proper, otherwise our
tests can accidentally use a different API version than reality.
2017-07-28 17:54:46 -04:00
Chris Cowan
31b3ec2218 Add Checks to Dashboard Context (#13182)
* Fixes #13181 - Check values before adding them to filter

* Adding tests

* Adding check to make sure query is never undefined
2017-07-28 13:38:19 -07:00
Spencer
be008690a3 [esTestConfig] fix esvm directory (#13190)
(cherry picked from commit 7d94bb1240)
2017-07-28 12:38:40 -07:00
Spencer
48bfe7f1a9 Implement esTestCluster test util (#13099)
* [es/tests] remove unused module

* [testUtil/es] add utility for starting es nodes in tests

* [ftr/tests] use esTestCluster util to start es

* [es/tests/routes] use esTestCluster to start own es

* [testUtils/kbnServer] disable uiSettings unless plugins are enabled

* [testUtils/esTestCluster] use standard test es port by default

* [server/http/tests] add esTestCluster to setup

* [test/config] unify es test config into a single module

* [testUtils/esTestCluster] directory is no longer configurable

* [testUtils/esTestCluster] throw when es.start() is called again without es.stop()

* [testUtils/esTestCluster] is* checks should not mutate state

(cherry picked from commit 6748b22d03)
2017-07-28 12:37:10 -07:00
Court Ewing
b39c28ed17 esvm: use branch from package.json (#13149)
Since versions are synced across the stack, the esvm config can use the
same branch configuration as Kibana itself.
(cherry picked from commit 8d5eac959f)
2017-07-28 12:34:33 -07:00
Thomas Neirynck
ae61b99cab Should respect pinned filters (#13019) (#13188) 2017-07-28 14:33:36 -04:00
Thomas Neirynck
4d93c74f10 Region map should respect saved center and zoom (#12883) (#13169) 2017-07-28 11:55:16 -04:00
Thomas Neirynck
181435a039 Save layer setting in the region map UI (#12956) (#13168) 2017-07-28 11:00:24 -04:00