Commit graph

13139 commits

Author SHA1 Message Date
Clint Andrew Hall
2520990e1e
Fix asset in Pitch template (#109742)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-27 16:10:52 -04:00
Kyle Pollich
74f3b76592
[Fleet] Fix upgrade link in Fleet policy table (#110228)
* Fix upgrade link in Fleet policy table

* Ensure upgrade page displays as upgrade even without from prop
2021-08-27 08:08:53 -04:00
Walter Rafelsberger
54a45bba65
[ML] APM Latency Correlations: Fix empty state (#109813)
- Correctly renders the empty chart state when no data is available.
- Hides the "Click drag to select" and trace samples message when the chart shows an empty state to avoid redundant info.
- Adds jest unit tests that would fail with the previously visible loading indicators.
- Fix a bug with cancelling search strategies.
2021-08-27 07:08:50 -04:00
Yaroslav Kuznietsov
d43e9f586b
[Canvas] Fixes Storybook for DatasourceComponent is crashing. (#110180)
* Added mock for `es_service`.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-27 06:58:10 -04:00
Catherine Liu
2e4e0fca4c
Clears resolved arg on embeddable destroy (#109945)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-27 02:46:11 -04:00
Yaroslav Kuznietsov
dde701faaa
[Canvas] ItemGrid refactor. (#110044) 2021-08-27 09:26:55 +03:00
Cauê Marcondes
49e3edf032
[APM] Latency threshold alerts are not being triggered (#110315) 2021-08-26 23:56:14 -04:00
Marshall Main
6d7998e70c
[Security Solution] Fix another reference to ALERT_STATUS (#110376) 2021-08-26 20:29:21 -05:00
Ross Wolf
e64a03677f
[Detection Rules] Add 7.15 rules (#110345) 2021-08-26 19:43:22 -04:00
Dominique Clarke
cf24e6ca76
[User Experience] Search filter input - remove undesired blur (#110314)
* ux filter input - remove undesired blur on input field

* adjust types
2021-08-26 19:01:55 -04:00
Marshall Main
682bc7c771
[RAC] Replace usages of kibana.alert.status: open with active (#109033)
* Replace usages of alert.status: open with active

* Update unit tests

* Add back home.disableWelcomeScreen=true

* Only disable welcome screen within APM ftr config

* Add disableWelcomeScreen option to security solution cypress config

* Fix reference to workflow status

* oops

* Remove duplicate disableWelcomeScreen

* Update README.md

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-26 18:58:44 -04:00
Matthew Kime
8babdc2462
Remove index pattern placeholder advanced setting (#110334)
* remove index pattern placeholder setting

* remove unused translations
2021-08-26 17:55:37 -05:00
Kevin Logan
1986d2dc99
[Security Solution] Add additional advanced policy options for Memory protections (#110288)
* [Security Solution] Add additional advanced policy options for Memory protections
2021-08-26 18:19:23 -04:00
Frank Hassanabad
2859eeb7de
Removed one liner deprecation found with ElasticClient and made it harder to accidently import from the kbn package (#110318)
## Summary

Removes ElasticSearch deprecation and makes it harder to import it from the wrong package. I accidentally exposed a deprecated `ElasticSearch` from a package we do not want to expose and everyone's IDE is suggesting it rather than the correct one from Kibana core.

* Removes the type from the exports within the package
* Fixes the instance that is trying to import it in favor of the correct one.
2021-08-26 17:24:16 -04:00
Davis Plumlee
e093d3bcca
[Security Solution][Exceptions] Allows bulk close on exception to close acknowledged alerts (#110147) 2021-08-26 15:46:59 -04:00
Clint Andrew Hall
12ef3a4e9f
[canvas] Fix element stats (#109770) 2021-08-26 14:07:25 -05:00
Patryk Kopyciński
f310490bc1
[Cases] Fix add Lens markdown plugin UX (#109178) 2021-08-26 14:56:45 -04:00
ymao1
a3d03ecbdf
[Alerting] Remove predefined connectors from rule reference array (#109437)
* Exposing preconfigured connectors through actions setup contract

* Adding stub for migration using preconfigured connectors

* Adding isPreconfigured fn to actions client

* Updating rules client logic to not extract predefined connector ids

* Functional tests

* Adding migration

* Adding functional test for migration

* Adding functional test for migration

* Adding note to docs about referenced_by_count if is_preconfigured

* Fixing functional test

* Changing to isPreconfiguredConnector fn in actions plugin setup contract

* Update docs/api/actions-and-connectors/get_all.asciidoc

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
2021-08-26 14:50:32 -04:00
Pablo Machado
3854d3a586
[RAC] EuiDataGrid pagination (#109269)
* Update T-Grid to use DataGrid pagination

* It also improves the Gtid loading state
* DataGrid pagination makes sure that we display the grid with the proper height.

* Add DataGrid height hack to t-grid

HUGE HACK!!!

DataGrtid height isn't properly calculated when the grid has horizontal scroll.
https://github.com/elastic/eui/issues/5030

In order to get around this bug we are calculating `DataGrid` height here and setting it as a prop.

Please revert this commit  and allow DataGrid to calculate its height when the bug is fixed.

* Apply DataGrid laoding and pagination changes to observability

* Fix cypress tests

* Fix t-grid page render bug on Observability

* some pagination fixes

* hide table when analyzer active

* isolate exported function

Co-authored-by: semd <sergi.massaneda@elastic.co>
2021-08-26 14:41:47 -04:00
Frank Hassanabad
ad01057f90
[Security Solutions][Detection Engine] Removes side car actions object and side car notifications (Part 1) (#109722)
## Summary

Removes the "side car" actions object and side car notification (Part 1). Part 1 makes it so that newly created rules and editing existing rules will update them to using the new side car notifications. Part 2 in a follow up PR will be the migrations to move the existing data. 

The saved object side we are removing usages of is:
```
siem-detection-engine-rule-actions
```

The alerting side car notification system we are removing is:
```
siem.notifications
```

* Removes the notification files and types
* Adds transform to and from alerting concepts of `notityWhen` and our `throttle`
* Adds unit tests for utilities and pure functions created 
* Updates unit tests to have more needed jest mock
* Adds business rules and logic for the different states of `notifyWhen`, and `throttle` on each of the REST routes to determine when we should `muteAll` vs. not muting using secondary API call from client alerting
* Adds e2e tests for the throttle conditions and how they are to interact with the kibana-alerting `throttle` and `notifyWhen`

A behavioral change under the hood is that we now support the state changes of `muteAll` from the UI/UX of [stack management](https://www.elastic.co/guide/en/kibana/master/create-and-manage-rules.html#controlling-rules). Whenever the `security_solution` ["Perform no actions"](https://www.elastic.co/guide/en/security/current/rules-api-create.html
) is selected we do a `muteAll`. However, we do not change the state if all individual actions are muted within the rule. Instead we only maintain the state of `muteAll`:

<img width="2299" alt="ui_state_change" src="https://user-images.githubusercontent.com/1151048/130823045-48a9f34b-db23-44e3-b9ed-cbbb57edc3d6.png">

<img width="1163" alt="no_actions_state_change" src="https://user-images.githubusercontent.com/1151048/130823056-3f8953fa-9433-4973-a2d3-6e11263b9619.png">

Ref:
* Issue and PR where notifyWhen was added to kibna-alerting
  * https://github.com/elastic/kibana/pull/82969
  * https://github.com/elastic/kibana/issues/50077  

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-08-26 13:39:57 -04:00
Clint Andrew Hall
2348ced4c0
[canvas] Handle Timelion errors gracefully. (#109761) 2021-08-26 12:34:52 -05:00
Alejandro Fernández Gómez
754bf980f3
[RAC] Remove alerts from the table if user changes their workflow status (#110227) 2021-08-26 12:59:35 -04:00
Phillip Burch
85e1361ad5
[Stack Monitoring] Remove angular dep from legacy shims (#109132)
* Remove angular dep from legacy shims

* Fix ES lint
2021-08-26 11:16:14 -05:00
Michael Olorunnisola
416d42a22a
[Security Solution][RAC] Refix expand (#110236) 2021-08-26 12:01:28 -04:00
Mark Hopkin
2a05ec9ff5
[Fleet] Don't ignore "index: false" in integration index template (#110234)
* fix: don't ignore index prop when falsey

* test: add unit test for index false
2021-08-26 11:47:11 -04:00
Angela Chuang
602392e88d
[Security Solution] Host details fly out modal is not working in alerts table (#109942)
* fix expanded host and ip panel

* reuse existing links components

* rename

* add unit tests

* add unit tests

* update comment

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-26 11:40:30 -04:00
Joe Portner
695280b756
bulkGet saved objects across spaces (#109967) 2021-08-26 11:26:34 -04:00
Casper Hübertz
dc0c322847
[APM] Bugfix: Increase table columns for latency and throughput (#110187) 2021-08-26 17:21:28 +02:00
Esteban Beltran
0069faf8dd
[Security Solution] Show rule.description when displaying an alert view flyout (#110221) 2021-08-26 11:05:18 -04:00
Alejandro Fernández Haro
bb8ee0ce05
Enable Product check from @elastic/elasticsearch-js (#107663)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-26 15:36:46 +01:00
Gloria Hornero
f806fa2eda
fixes opening alerts test (#110198) 2021-08-26 16:30:58 +02:00
Alexey Antonov
3cc7da8435
[Lens] Inspect flyout should be available in editor mode. (#109656)
* [Lens] Inspect flyout should be available in editor mode.

* fix typo

* add test

* add functional tests for inspector

* toMatchInlineSnapshot -> toMatchSnapshot

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-26 10:18:09 -04:00
Casper Hübertz
85e030249f
[APM] Traces list: Decrease link size and impact indication (#110188)
* [APM] Decrease link size on Traces list

* [APM] Change impact column size to fixed
2021-08-26 15:59:46 +02:00
Esteban Beltran
9a8d40ffad
[Seciurity Solutions] Add additional tests for endpoint middleware (#109792) 2021-08-26 09:41:28 -04:00
Felix Stürmer
137c182761
[RAC] Populate common rule fields in alert helpers (#108679)
Co-authored-by: mgiota <panagiota.mitsopoulou@elastic.co>
2021-08-26 09:19:51 -04:00
Michael Olorunnisola
7d66cf9882
[Security Solution][RAC] Hide filters on case view (#110090) 2021-08-26 09:19:20 -04:00
Esteban Beltran
c113c237f8
[Security solution] Correct memory protections label to memory manipulation protection (#110179) 2021-08-26 13:44:36 +02:00
Ashokaditya
c433893473
Remove onClear on date range picker inputs (#110035)
fixes elastic/kibana/issues/108864

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-26 12:03:39 +02:00
Miriam
652470b900
[APM] Show hostname in JVM view (#109651)
* [APM] Show hostname in JVM view

* [APM] delete no needed param

* [APM] fix linting

* [APM] changes after review

* [APM] changes after review part deux

* [APM] fix snapshot

* [APM] improve guard on api response
2021-08-26 10:21:15 +01:00
Ester Martí Vilaseca
9c922a078c
[Stack monitoring] Add global state context and routeInit component (#109790)
* Add global state to stack monitoring react app

* Add type for state

* Add some todos

* Add route_init migration

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-26 11:03:21 +02:00
Jean-Louis Leysens
9e04d2c5c7
[Reporting/Dashboard] Update integration to use v2 reports (#108553)
* very wip, updating dashboard integration to use v2 reports. at the moment time filters are not working correctly

* added missing dependency to hook

* added tests and refined ForwadedAppState interface

* remove unused import

* updated test because generating a report from an unsaved report is possible

* migrated locator to forward state on history only, reordered methods on react component

* remove unused import

* update locator test and use panel index number if panelIndex does not exist

* ensure locator params are serializable

* - moved getSerializableRecord to locator.ts to ensure that the
  values we get from it will never contain something that cannot
  be passed to history.push
- updated types to remove some `& SerializableRecord` instances
- fixed embeddable drilldown Jest tests given that we no longer
  expect state to be in the URL

* update generated api docs

* remove unused variable

* - removed SerializedRecord extension from dashboard locator params
  interface
- factored out state conversion logic from the locator getLocation

* updated locator jest tests and SerializableRecord types

* explicitly map values to dashboardlocatorparams and export serializable params type

* use serializable params type in embeddable

* factored out logic for converting panels to dashboard panels map

* use "type =" instead of "interface"

* big update to locator params: type fixes and added options key

* added comment about why we are using "type" alias instead of "interface" declaration

* simplify is v2 job param check

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-26 09:53:28 +02:00
Gloria Hornero
de7ae4138d
fixes 'Marking alerts as acknowledged' test (#110032)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-26 08:43:46 +02:00
Scotty Bollinger
a50a87955c
Fix flakey test (#110154) 2021-08-26 01:32:13 -04:00
Patryk Kopyciński
90152edeaa
[Osquery] Fix scheduled query status (#106600) 2021-08-25 18:46:31 -04:00
Tim Sullivan
06c6168d34
[Reporting] Fix ability to export CSV on searched data with frozen indices (#109976)
* use include frozen setting in csv export

* add api integration test

* add fixes

* Update x-pack/test/reporting_api_integration/reporting_and_security/search_frozen_indices.ts

* test polish

* update per feedback
2021-08-25 17:42:39 -04:00
Tiago Costa
36eaf7fd58
chore(NA): enables @babel/plugin-transform-runtime to decrease output size (#109843)
* chore(NA): enables @babel/plugin-transform-runtime to decrease output size

* chore(NA): update @kbn/pm bundle

* chore(NA): missing config on corejs for runtime

* fix(NA): flaky unit test

* chore(NA): update limits file

* chore(NA): remove corejs

* chore(NA): old config files

* chore(NA): update limmits file

* chore(NA): updated yarn lock file

* chore(NA): update limits

* chore(NA): restore original test file

* chore(NA): skip flaky test

* chore(NA): skip another failing test
2021-08-25 22:24:38 +01:00
Nathan L Smith
a8cd0d1e15
Remove EuiCodeEditor from service map stories (#109290)
Replace with Monaco-based `CodeEditor` from kibanaReact.

Fixes #106927.
2021-08-25 15:54:35 -05:00
Kyle Pollich
99071ecbb2
[Fleet] Fix upgrades for packages with restructured inputs (#109887)
* Fix upgrades for packages with restructured inputs

Addresses errors surfaced when testing upgrades from AWS 0.6.1 to 0.10.4.
Namely, when inputs are removed from a package between versions,we were
initially throwing errors for each input in the new package that didn't
exist on the outdated package version. Now, we instead simply skip over
cases like this in which an input no longer exists on the new package version.

* Add basic test cases for restructured packages
2021-08-25 16:50:42 -04:00
renovate[bot]
9eaadd9041
Update dependency @elastic/charts to v34.2.1 (master) (#109678)
* Update dependency @elastic/charts to v34.2.1


Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
2021-08-25 15:34:06 -04:00
Tim Sullivan
4f6ece9237
[Reporting] Add SavedReport class (#109568)
* [Reporting] Add SavedReport class

* add unit test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-25 12:29:30 -07:00