Commit graph

34920 commits

Author SHA1 Message Date
Mikhail Shustov
2771d69c96
[KP] bump es client to rc2 (#72448)
* bump es client to rc2

* update code for new typings
2020-07-20 20:32:46 +02:00
CJ Cenizal
88e8c30e61
Convert ILM remove_lifecycle_confirm_modal component to TS. (#70382)
- Also convert api and api_errors services, and improve typing of http service.
- Fix bug where fatalErrors service was improperly consumed in api_errors.
- Improve typing in Rollup api_errors service, for consistency.
2020-07-20 11:21:03 -07:00
Zacqary Adam Xeper
85d8ec8905
[Metrics UI] Fix Alert Preview Error design (#71005)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-20 13:18:43 -05:00
Melissa Alvarez
a42a6d02fc
add index-pattern link when error contains 'click here' text (#72470) 2020-07-20 13:47:04 -04:00
Frank Hassanabad
8a4daffcfd
[SIEM][Detection Engine][Lists] Adds list permissions (#72335)
## Summary

* Adds list permissions as a feature control to SIEM.
* Separates the controls between two, one of which is `access:lists-all` and the other is `access:lists-read`
* Grants SIEM the ability to utilize both depending on which feature mode the space is in.
2020-07-20 11:00:59 -06:00
Frank Hassanabad
afae94a85e
[SIEM][Detection Engine][Lists] Adds conflict versioning and io-ts improvements to lists (#72337)
## Summary

* Adds conflict versioning by exposing the "_version" from the saved object system. It renames "version" to "_version" so that we can use regular "version" later for versioning things for pre-packaged lists abilities.
* Utilizes `t.OutputOf` in the requests and the data types to give us more correctly types
* Removes the `Identity` utility as that is adding confusion and can confuse vs code rather than improves things
* Removes extra types that were causing confusion which was an idiom from io-ts
* Changes the wording of `Partial` by removing that and instead focuses the request types on either client side or server side at this point.

NOTE: The UI can migrate to holding onto the `_version` and then push it back down when it wants to migrate to using the conflict resolution. If the UI does not push it down, then a value of undefined will be used which is indicating that no conflict errors are wanted.


Output example of posting an exception list:

❯ ./post_exception_list.sh
```ts
{
  "_tags": [
    "endpoint",
    "process",
    "malware",
    "os:linux"
  ],
  "_version": "Wzk4NiwxXQ==",
  "created_at": "2020-07-17T18:59:22.872Z",
  "created_by": "yo",
  "description": "This is a sample endpoint type exception",
  "id": "a08795b0-c85f-11ea-b1a6-c155df988a92",
  "list_id": "simple_list",
  "name": "Sample Endpoint Exception List",
  "namespace_type": "single",
  "tags": [
    "user added string for a tag",
    "malware"
  ],
  "tie_breaker_id": "b789ec05-3e0f-4344-a156-0c0f5b6e2f9c",
  "type": "detection",
  "updated_at": "2020-07-17T18:59:22.891Z",
  "updated_by": "yo"
}
```

Output example of posting an exception list item
❯ ./post_exception_list_item.sh
```ts
{
  "_tags": [
    "endpoint",
    "process",
    "malware",
    "os:linux"
  ],
  "_version": "Wzk4NywxXQ==",
  "comments": [],
  "created_at": "2020-07-17T18:59:30.286Z",
  "created_by": "yo",
  "description": "This is a sample endpoint type exception",
  "entries": [
    {
      "field": "actingProcess.file.signer",
      "operator": "excluded",
      "type": "exists"
    },
    {
      "field": "host.name",
      "operator": "included",
      "type": "match_any",
      "value": [
        "some host",
        "another host"
      ]
    }
  ],
  "id": "a4f2b800-c85f-11ea-b1a6-c155df988a92",
  "item_id": "simple_list_item",
  "list_id": "simple_list",
  "name": "Sample Endpoint Exception List",
  "namespace_type": "single",
  "tags": [
    "user added string for a tag",
    "malware"
  ],
  "tie_breaker_id": "1dc456bc-7aa9-44b4-bca3-131689cf729f",
  "type": "simple",
  "updated_at": "2020-07-17T18:59:30.304Z",
  "updated_by": "yo"
}
```

Output example of when you get an exception list:

❯ ./get_exception_list.sh simple_list
```ts
{
  "_tags": [
    "endpoint",
    "process",
    "malware",
    "os:linux"
  ],
  "_version": "WzEwNzcsMV0=",
  "created_at": "2020-07-17T18:59:22.872Z",
  "created_by": "yo",
  "description": "Different description",
  "id": "a08795b0-c85f-11ea-b1a6-c155df988a92",
  "list_id": "simple_list",
  "name": "Sample Endpoint Exception List",
  "namespace_type": "single",
  "tags": [
    "user added string for a tag",
    "malware"
  ],
  "tie_breaker_id": "b789ec05-3e0f-4344-a156-0c0f5b6e2f9c",
  "type": "endpoint",
  "updated_at": "2020-07-17T20:01:24.958Z",
  "updated_by": "yo"
}
```

Example of the error you get if you do an update of an exception list and someone else has changed it:
```ts
{
  "message": "[exception-list:a08795b0-c85f-11ea-b1a6-c155df988a92]: version conflict, required seqNo [1074], primary term [1]. current document has seqNo [1077] and primary term [1]: [version_conflict_engine_exception] [exception-list:a08795b0-c85f-11ea-b1a6-c155df988a92]: version conflict, required seqNo [1074], primary term [1]. current document has seqNo [1077] and primary term [1], with { index_uuid=\"a2mgXBO6Tl2ULDq-MTs1Tw\" & shard=\"0\" & index=\".kibana-hassanabad_1\" }",
  "status_code": 409
}
```

Lists are the same way and flavor, they encode the _version the same way that saved objects do. To see those work you run these scripts:

```ts
./post_list.sh
./post_list_item.sh
./find_list.sh
./find_list_item.sh
```



### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-07-20 11:00:06 -06:00
Robert Austin
75e4c7a2b7
[Resolver] no longer pass related event stats to process node component (#72435) 2020-07-20 12:40:59 -04:00
spalger
5741a868bc Revert "skip flaky suite (#72146)"
This reverts commit 45a4393459.
2020-07-20 09:32:41 -07:00
Michael Olorunnisola
2094f33537
[Security Solution] Cleanup endpoint telemetry (#71950)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-20 12:28:46 -04:00
Joe Reuter
96d965d4e3
Unskip dashboard embeddable rendering tests (#71824) 2020-07-20 17:55:27 +02:00
Bohdan Tsymbala
d744d18b19
[ENDPOINT] Added unerolling status for host. (#72303)
* Added unerolling status for host.

* Added unenrolling status to frontend tests.
2020-07-20 17:44:17 +02:00
Christos Nasikas
54c3644757
[Alerting][Connectors] Increase the size of the logos (#72419) 2020-07-20 18:35:42 +03:00
Xavier Mouligneau
a62c62e118
[SECURITY] [Timeline] Raw events not displayed (#72387)
* fix nav with no-data

* fix rules action alerts

* fix raw alert event type

* snapshot

* can only use network-only

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
2020-07-20 11:14:50 -04:00
Pete Harverson
66208fb73e
[ML] Fixes display of regression stop stats if one is NaN (#72412) 2020-07-20 16:12:57 +01:00
Jean-Louis Leysens
e5c7e9a474
[Ingest Pipelines] Processor Editor Move Tooltip (#72239)
* first implementation of tooltip

* Add processor tooltip component files

* remove init position from code for now

* colocate on change handler and make code a bit cleaner

* removed document.body.appendChild logic because EuiPortal does that for us

* use correct toggle button api

* added test to check button disabled while editing

* remove cursor not allowed

* simplify logic

* assert if against positive

* remove unused variable

* Remove unused actions const

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-20 17:02:54 +02:00
Kerry Gallagher
11182c8ef7
Fix match phrase and not match phrase comparators (#71850)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-20 15:51:22 +01:00
Liza Katz
6c3b900d11
[Plugin Generator] Generate tsconfig and useDefaultBehaviors (#72040)
* improve test stability

* add a tsconfig file and useDefaultBehaviors

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-20 17:29:28 +03:00
Patryk Kopyciński
7ac5fc4e1f
[Security Solution][Timeline] Fix timeline styling and createFrom beh… (#72152) 2020-07-20 16:14:13 +02:00
Robert Austin
6cf796a4fb
[Resolver] Selector performance (#72380)
* Memoize various selectors
* Improve performance of the selectors that calculate the `aria-flowto` attribute.
* more tests.
2020-07-20 09:38:30 -04:00
Alejandro Fernández Haro
f331cc8b64
[Ingest Manager] Set _meta in the index.mappings (#72026)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-20 13:54:36 +01:00
Nicolas Chaulet
bf89b3cdd2
[Ingest Manager] Do not bumb config revision during config creation (#72270) 2020-07-20 08:53:09 -04:00
James Gowdy
9504c9453b
[ML] Adding missing index pattern name to new job wizards (#72400) 2020-07-20 13:47:18 +01:00
Dima Arnautov
b1edce8050
[ML] improve annotation flyout performance (#72299) 2020-07-20 12:50:09 +02:00
Cauê Marcondes
7976e2bda4
[APM] Testing error rate API and restructuring folders (#72257)
* adding error rate and restructuring tests

* removing console log

* removing console log

* adding error rate and restructuring tests

* fixing TS error

* removing unnecessary files

* removing trial tests
2020-07-20 12:39:26 +02:00
Dima Arnautov
4acdf278dc
[ML] fix charts container width init (#72389) 2020-07-20 12:25:13 +02:00
Christos Nasikas
3442451aac
[Security Solution][Case] IBM Resilient content fixes (#72271) 2020-07-20 13:04:42 +03:00
Tim Roes
ade93f0780
Disable indexing of unnecessary Saved Object fields (#70409)
* Disable indexing of unnecessary SO fields

* Add doc_values

* Add no doc_values to discover saved object

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-20 11:40:39 +02:00
Pierre Gayvallet
b29e8ee9c7
migrate retryCallCluster for new ES client (#71412)
* adapt retryCallCluster for new ES client

* review comments

* retry on 408 ResponseError

* use error name instead of instanceof base check

* use error name instead of instanceof base check bis

* use mockImplementationOnce chaining

Co-authored-by: restrry <restrry@gmail.com>
2020-07-20 10:55:44 +02:00
Matthias Wilhelm
ec4f9d50ba
Migrate and cleanup legacy scss (#69369) 2020-07-20 10:43:12 +02:00
James Gowdy
b39c46eeac
[ML] Disabling secondary auth headers when security is disabled (#72371)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-20 09:30:06 +01:00
Cauê Marcondes
7cee2a6b15
[Observability] Remove app logos (#72259)
* removing app logos

* fixing TS error
2020-07-20 10:25:39 +02:00
Marco Liberati
a28463d82a
Fix float percentiles line chart (#71902)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-20 10:22:05 +02:00
Dmitry Lemeshko
105e3a6c7e
update chromedriver to 84 (#72228)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-18 17:47:53 +02:00
Spencer
ef875cf9fe
[esArchiver] actually re-delete the .kibana index if we lose recreate race (#72354)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-07-17 16:41:52 -07:00
Nathan Reese
dc7db09533
[Maps] convert SavedGisMap to TS (#72286)
* [Maps] convert SavedGisMap to TS

* i18n translate new map title
2020-07-17 16:29:23 -06:00
Lisa Cawley
7aa600bff7
[DOCS] Removes occurrences of X-Pack Security and Reporting (#72302) 2020-07-17 14:53:04 -07:00
Lee Drengenberg
7519c1f8c3
use WORKSPACE env var for stack_functional_integration tests, fix navigate path (#71908)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-17 16:42:56 -05:00
Chris Roberson
f0d3cb96a4
[Monitoring] Fix issue with ES node detail status (#72298)
* Fix issue with ES node detail status

* Add test
2020-07-17 17:15:25 -04:00
Devin W. Hurley
f487867fda
[SIEM] Updates consumer in export_rule archive (#72324) 2020-07-17 17:13:34 -04:00
Spencer
466380e3b6
[kbn/dev-utils] add RunWithCommands utility (#72311)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-07-17 13:53:54 -07:00
Madison Caldwell
5356941f22
[Security Solution][Endpoint][Exceptions] Only write manifest to policy when there are changes (#72000)
* Refactor security_solution policy creation callback - part 1

* Fix manifest dispatch

* Change how dispatches are performed

* simplify manifest types

* Remove unused mock

* Fix tests

* one place to construct artifact ids

* fixing linter exceptions

* Add tests for stable hashes

* Additional testing and type cleanup

* Remove unnecessary log

* Minor fixup

* jsdoc

* type fixup

* Additional type adjustments
2020-07-17 16:51:28 -04:00
Brian Seeders
4c58018d33 skip flaky suite (#72339) 2020-07-17 16:27:25 -04:00
Quynh Nguyen
3cef292bbd
[ML] Fix annotations pagination & change labels from letters to numbers (#72204) 2020-07-17 13:35:25 -05:00
Wylie Conlon
35ff37a434
[Lens] Fix switching with layers (#71982)
* [Lens] Fix chart switching with multiple layers

* Unskip Lens smokescreen test

* Fix types

* Revert <p> change
2020-07-17 14:02:52 -04:00
Nathan Reese
679209b308
[Maps] 7.9 documenation updates (#71893)
* [Maps] 7.9 documenation updates

* more cleanup

* add vector tiles card to tile layers page
2020-07-17 11:38:45 -06:00
Vadim Dalecky
36ff576178
docs: ✏️ add "Explore underlying data" user docs (#70807)
* docs: ✏️ add "Explore underlying data" user docs

* docs: ✏️ improve docs

* docs: ✏️ change the way Discover is referred

* docs: ✏️ improve texts in line with review comments

* Update docs/drilldowns/explore-underlying-data.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/drilldowns/explore-underlying-data.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2020-07-17 19:06:54 +02:00
Yara Tercero
1adaa3b76c
[Security Solution][Exceptions] - Remove initial add exception item button in builder (#72215)
## Summary

This PR addresses two issues in the builder:

- **Existing behavior:** if you add a bunch of entries then delete all but one, the indent that shows for when multiple entries exists does not go away
  - **Updated behavior:** if you add a bunch of entries and delete all but one, the indent that shows for when multiple entries exist goes away

- **Existing behavior:** on render of add exception modal, if no exception items exist (or no exception items with entries exist) an `Add Exception` button appears
  - **Updated behavior:** if only one entry exists, the delete button is disabled for that entry; on initial render of the add exception modal, if no entries exist, an empty entry is shown
2020-07-17 12:39:51 -04:00
Stacey Gammon
44fc2a828c
Fix indentation level in code exploration doc (#72274)
* fix indentation level in code exploration doc

* run the script to update the file
2020-07-17 12:04:18 -04:00
Joe Reuter
825c16875e
register graph usage (#72041) 2020-07-17 17:16:28 +02:00
igoristic
39381ca3c8
[Monitoring] Added a case for Alerting if security/ssl is disabled (#71846)
* Added a case for Alerting if security/ssl is disabled

* Code feedback

* Fixed types
2020-07-17 11:13:40 -04:00