Commit graph

1011 commits

Author SHA1 Message Date
Dmitry Lemeshko 2198222f28
run chained_controls on Firefox to catch regression (#43044) 2019-08-09 21:40:34 +02:00
Dmitry Lemeshko 2ebbf1b091
[apps/dashboard] skip part of filtering tests on FF (#43047) 2019-08-09 20:46:28 +02:00
Peter Pisljar 06706b5748 fixes scaling logic to check agg type instead schema (#42574)
* fixes scaling logic to check agg type instead schema

* adding selenium test

* updating jest snapshot

* fixing test

* Change test order

* Fix test order
2019-08-08 18:09:14 +02:00
Matt Bargar f6cb00a6f3
Allow sorting on multiple columns in Discover (#41918)
This commit enables sorting on multiple columns in Discover and in saved search panels on dashboards. The UI is simple and should be familiar based on the way multi-sort works in other common applications like file explorers. Each sortable column has a sort icon indicating which way it is sorted (or unsorted, in the case of two arrows pointing both up and down). Sort priority is determined by which column was clicked most recently, with the most recent being the lowest priority.
2019-08-02 17:18:54 -04:00
Spencer f4e39159dc
[ftr/cheerio] improve cheerio types to include test subject me… (#42534) 2019-08-02 13:08:20 -07:00
Jason Rhodes b230ceb50d
Creates functional test README files (#42389)
* Creates x-pack functional test README

* Adds README to test/functional directory

* Adds link to Functional Test dev guide in x-pack root README
2019-07-31 15:41:15 -04:00
Dmitry Lemeshko 7d61cac2d8
FTR: fix testSubjects.missingOrFail (#42290)
* [services/test_subject] fix missingOrFail

* [services/test_subjects] allowHidden option for missingOrFail

* [page_objects/dashboard_page] wait for euiTable loaded, increase timeout for loading page check
2019-07-31 00:19:15 +02:00
Vitali Haradkou 2dfe167d7d
[TSVB] [Functional] unskip flaky test (#41766)
* unskip flaky test
2019-07-29 15:33:12 +03:00
Maryia Lapata 85f9ef6433
[Vis Editor] EUIfication of agg and agg-group directives (#40866)
* Create default_editor_agg.tsx

* Create default_editor_agg_group

* Apply drag and drop

* Remove unused dragula dependency

* Remove old mocha tests

* Add ts for state

* Update functional tests

* Update touched condition

* Apply styles for accordion button content

* Apply truncate for agg description

* Remove unused styles

* Separate common props

* Move aggGroupNamesMap to agg_group.js

* Update _sidebar.scss

* Pass schemas prop

* Prevent scroll bar and add space

* Remove unused min from stats

* Add OnAggParamsChange type

* Show error as an icon

* Update background color

* Update title size

* Remove Schema.deprecate since it's not used
2019-07-29 13:58:50 +03:00
Daniil Suleiman 91adbfc88b
[Vis: Default editor] EUIficate pie chart options tab (#41901)
* EUIficate pie chart options tab

* Fix tests

* Size titles down to xs

* Use FormattedMessage
2019-07-29 13:03:57 +03:00
Dmitry Lemeshko 044285cb3b
Functional tests: make sure clicked dashboard is opened (#42006)
* [page_objects/dashboard_page] make sure selected dashboard is opened
2019-07-26 15:01:58 +02:00
Dmitry Lemeshko 7df1f41857
Ftr/tsfy doc table (#41710)
* [services/doc_table] tsfy service and use parse dom to get rows

* [services/doc_table] do not pass table element as argument

* [services/doc_table] update service to minimize StaleElementReference cases

* [services/doc_table] add missing access modifier

* [services/doc_table] change getHeaderFields and fix return types
2019-07-25 08:42:04 +02:00
Dmitry Lemeshko 58f2a263d0
[service/remote] check env variable value (#41909) 2019-07-25 08:29:17 +02:00
Meir Meshi db07f13253 Ensure visualizations in percentage mode respect the advanced settings percent format (#39044) 2019-07-23 23:47:27 -06:00
Liza Katz de9d823ad4 Fix autorefresh in visualize editor (#41657) 2019-07-23 22:34:49 -06:00
Tim Roes e1bc154478
GoodBye Notifier (#41663)
* Begin notifier removal

* Remove remaining notifier traces

* Remove dead translations

* Remove Angular from config listener

* Import angular-sanitize explicitly in map
2019-07-23 18:26:50 +02:00
Stacey Gammon a6fd0c3e2f
turn on filtering tests (#41202)
* turn on filtering tests

* run x-pack-firefoxSmoke ciGroup 40 times, run dashboard tests 20 times per job

* Revert "run x-pack-firefoxSmoke ciGroup 40 times, run dashboard tests 20 times per job"

This reverts commit 5ef02cc53ba5085c3f74431cb6ef20be2d876cde.
2019-07-23 12:18:33 -04:00
Liza Katz 4b8913cb53
hide top nav menu in full screen mode of maps and dashboard (#41672)
* hide top nav menu in full screen mode of maps and dashboard

* Fixed dashboard full screen mode and added full screen mode test to maps
2019-07-23 09:31:44 +03:00
Zacqary Adam Xeper 47d9756652
[Logs UI] Make column configurations reorderable (#41035)
* [Logs UI] Make column configurations reorderable

* Improve typing aand memoize callback

* Guard against index bounds and rename reorderLogColumns

* Fix useCallback memoization

* Add functional test for reordering log columns

* Use browser.keys instead of Key in functional test
2019-07-22 13:47:47 -05:00
Greg Thompson dd63e73fb0
Upgrade EUI to 12.4.0 (#41577)
* eui 12.4.0

* styled-components ts conflict

* update combobox test service to always open on open call

* Revert "update combobox test service to always open on open call"

This reverts commit 43074e6006.

* scroll combobox into view

* scroll before filter
2019-07-22 13:01:25 -05:00
Alexey Antonov 1061f69d45
[TSVB] [Markdown] markdown section do not render after change data parameter (#41576)
* [TSVB] [Markdown] markdown section do not render after change data parameter

* fix grammar
2019-07-22 15:52:07 +03:00
Dmitry Lemeshko 4d884fa448
update dark mode tsvb test (#41618) 2019-07-22 09:41:00 +02:00
Liza Katz b22a28844a
Reactify Top Nav Menu (kbn_top_nav) (#40262)
* kbn top nav in discover

* New top nav in dashboard and vis editor

* Stop using template feature of kbn top nav

* Changed console menu to new directive

* Use search bar in top nav in discover and maps
Support search bar with no filter bar (TS)

* Moved storage instantiation to angular directive

* Make index patterns optional (for timepicker only setup)

* Moved discover result count away from top nav

* Removed unused name attribute in top nav. Use app-name instead.
2019-07-21 14:15:45 +03:00
Spencer c3f31c79fb
[jest] disallow invalid describe calls (#41378)
* [jest] disallow invalid describe calls

* correct other describe calls

* remove unnecessary glob

* cast decribe names to strings

* remove new async describe function
2019-07-18 10:11:33 -07:00
spalger 75391329a0 skip two failing tests (#41453) (#41452) 2019-07-18 06:40:46 -07:00
Dmitry Lemeshko ade8a2f55d
Fix/re enable skipped functional tests (#41238)
* [home/_sample_data] unskip tests

* [visualize/_tsvb_chart] unskip switch index pattern test

* unskip nodes filter test

* run specific groups 10x times

* Revert "run specific groups 10x times"

This reverts commit ad7302f33f.
2019-07-18 11:58:49 +02:00
Lee Drengenberg 236bc83947
fix deleteAllVisualizations() (#41062) 2019-07-16 14:49:48 -05:00
Stacey Gammon fbfee1e973
Stabilize createNewDashboard testfunction (#41008)
* This function will be flaky if the page is still loading and newItemButton does not exist but will soon.

* Skip only the other flaky test, this PR should fix the one
2019-07-15 17:38:04 -04:00
Dmitry Lemeshko e9194d75ef
[services/web_element_wrapper] update clearValue function to fix Firefox tests (#41117)
* [services/web_element_wrapper] update clearValue function

* fix flaky test #40670
2019-07-15 22:50:13 +02:00
Michail Yasonik 8b6df179a5
Adds capability to show percentages for data table columns (#39572)
* Bring table vis params styles inline with others

* Add percentage column option to table vis

* fixup! Add percentage column option to table vis

* fixup! Add percentage column option to table vis
2019-07-15 13:01:18 -07:00
spalger f0e7b9e5b9 skip flaky suite (#41088) (#41087) 2019-07-15 08:35:03 -07:00
Dmitry Lemeshko df9d8e6f5d
FTR: upgrade chromedriver to 75 (#40791)
* ftr: update services to support chromedriver 75

* [services/webdriver] add browser logging

* update comment for W3C scrolling bug
2019-07-12 19:49:51 +02:00
Stacey Gammon 66b99ecbed
Use embeddable v2 (#39126)
* Final Embeddable API V2 PR

* fix: import discover embeddable scss file

* address code review comments

* Add a functional test that would have caught the bug... will look to add a unit version once I discover the error.

* Fix bug cause by async loading calls and changes to parent input while child is being created. added jest test

* remove outdated readme in dashboard folder

* need to always refresh dashboard container, not just when "dirty"

* add a wait, this issue started appearing right when I added this to the test

* Remove test that kills kibana ci so it's not a blocker. jest test was added for this scenario

* fix issues when panel is added then removed before it completes loading

* fix logic error with maps embeddable and isLayerTOCOpen
2019-07-12 13:31:43 -04:00
Dmitry Lemeshko 9f9d0dcbb8
WebElementWrapper: Retry WebDriver atomic calls (#40423)
* [services/lib/web_element_wrapper] use Generics in replyCall

* [services/lib/web_element_wrapper] remove redundant return types

* [services/lib/web_element_wrapper/] set retryCall timeout to 200 ms

* [services/find] explcitly pass element to have locator===null by default

* use static method to create WebElementWrapper

* missed a couple uses

* move some values to constants

* remove some unnecessary type info
2019-07-12 13:47:26 +02:00
Spencer 3e1afa347b
[visualize] wait for save to complete before proceeding (#40916) 2019-07-12 05:32:46 -06:00
spalger 57e959ef0e skip flaky test (#40670) 2019-07-11 14:22:40 -07:00
spalger 3a13b7ce23 skip flaky test (#40458) 2019-07-11 13:33:31 -07:00
Thomas Neirynck 6ae5b56df6
[Maps] show dialog to save map when leaving app (#40215) 2019-07-11 08:28:49 -04:00
Spencer 415e3bca27
[ts] upgrade to 3.5.3 (#40228)
* [ts] upgrade to 3.5.2

* [ts] run from cwd so that relative paths are correct

* move eslint-disable-line comment into jsx attribute

* autofix eslint violations

* avoid generic type, it's not necessary and problematic

* make elasticsearch.cluster optional, many instances don't have them

* remove invalid prop

* expand AllowUnknownProperties to cleanly handle arrays

* esfilter values can sometimes be an array of strings

* allow exception objects to have unknown properties

* define accumulator as a boolean

* fix return type

* return a 404 if beat isn't found after update

* use Object.values for better types

* define return type of get() call

* define value type for Set

* define return value of get()

* define State property type

* use less get(), so ts can infer types

* define Set item type

* map state type

* make default_operator optional, since it's not always defined

* remove seemingly unused prop

* define return type of get() fn

* define inner type for state

* don't define base types are objects with index signatues

* regenerate public api docs

* make indices privileges optional too

* remove unnecessary index-signature from Exception interface

* use variadic _arg instead

* [core/plugin] use Record<string, any> rather than {}

* replace a couple more instances of {}

* revert some unnecessary changes

* remove unused types

* [reporting] output, payload, and meta are required properties

* bump to latest patch version
2019-07-10 12:26:23 -07:00
Dmitry Lemeshko e9f84ae83d
[ftr] replace getProperty with getAttribute (#40358)
* [ftr] replace getProperty with getAttribute

* fix failing tests

* [services/pipeline_editor] revert change
2019-07-04 21:18:14 +02:00
Spencer a95ae8c037
[prettier] upgrade to 1.18.2 (#40229)
* [prettier] upgrade to 1.18.2

* autofix prettier violations
2019-07-03 12:36:44 -07:00
Spencer 868c7125c6
[ftr/common] remove defaultIndex check (#39714) 2019-07-02 14:47:08 -07:00
spalger 0f5bfc0fce disable fully skipped suite (#40173) 2019-07-02 12:22:18 -07:00
spalger 8a6ac547a8 disable flaky test (#40173) 2019-07-02 09:07:46 -07:00
Nathan Reese 251e164e89
[Maps] replace legacy map visualizations with maps in sample data dashboards (#35997)
* merge with master

* fix functional test expect

* set custom labels for term joins and geo grid aggregations for sample data maps
2019-07-02 09:53:32 -06:00
Spencer a8fc3619ca
[ftr/browser] poll for logs and stream them (#40098) 2019-07-02 07:47:20 -07:00
Maryia Lapata c0c905f886
[Vis Editor] EUIfication of agg-params directive (#39502)
* Create DefaultEditorAggParams

* Create state for aggPrams

* Add useEffect when params were updated

* Move angular logic to agg.js

* Validation with from

* Working validation

* Change error message

* Rename AggParamReactWrapper to DefaultEditorAggParam and move

* Move schema editor to agg.js

* Migrate orderAgg control

* Migrate sub_metric

* Migrate sub_agg control

* Remove config from props

* Remove agg_params.html

* Remove unused agg_select and styles

* Add TS for agg.params object

* Update functional tests

* Create useUnmount custom hook

* Move useUnmount effect to agg-params

* Rename func getFormTouched to isInvalidParamsTouched

* Remove extra setValidity call

* Move setTouched into useEffect in field.tsx

* Refactor isInvalidParamsTouched function

* Rename validity to valid

* Remove describeErrors() and inline error strings

* Replace Object.keys with Object.entries

* Fix interval for rollup date histogram

* Update parameters when aggType changed

* Remove unused safe_make_label

* Remove unused translations

* Skip failed mocha tests. They will be updated in a separate PR

* Include schema errors into validation flow
2019-07-02 12:53:09 +03:00
spalger 0922772b70 skip flaky test (#39927) 2019-06-28 15:46:43 -07:00
Peter Pisljar 444bafbe0e
updating metricvis interpreter func arguments (#34532) 2019-06-28 05:44:43 +02:00
Dmitry Lemeshko 3ded411527
Update functional tests to run faster and pass locally (#39557)
* [shakespeare] adjust verification to pass in both headless/head runs

* [services/visualizations/pie_chart] speedup tests with timeout decrease

* [services/dashboard/expectations] speedup tests with timeout decrease
2019-06-26 07:41:35 +03:00