Commit graph

25793 commits

Author SHA1 Message Date
Tiago Costa 28fca42374
Update node options Initialization on our scripts (#40302) (#43358)
* chore(NA): update node options initilization on our scripts

* chore(NA): re-export NODE_OPTIONS instead of re-setting on vars

* chore(NA): missing doc comment
2019-08-15 17:30:07 +01:00
Matt Bargar f40aa17df6
Migrate legacy sort arrays on saved searches (#43038) (#43234)
With my multi sort PR I changed the sort property on saved searches to contain a nested array. Discover and Dashboard were backwards compatible with the old format but it turns out the nested array caused issues for CSV export. Instead of trying to support single and two dimension arrays everywhere, this PR simply adds a migration for saved searches in 7.4 and updates our sample data sets so that we can always expect sort objects to be two dimensional arrays. I also cleaned up the backwards compatibility code in Discover and Dashboard.
2019-08-15 12:26:14 -04:00
Dario Gieselaar 838bb39442
[7.x] [APM] Local UI filters (#41588) (#43336)
* Add snapshot tests for query search params

* Use projections to fetch data

* Add configuration and aggregations for local filters

* Add endpoints for local filters

* UseLocalUIFilters hook

* Parse Local UI filters from URL params

* LocalUIFilters component

* TransactionTypeFilter

* replace useServiceTransactionTypes with useTransactionTypes

* Support transactionType for trace projection/api

* Configure Local UI Filters

* Use units instead of hardcoded px

* Fix i18n error

* Remove unused labels from translation files

* Update URL of API integration test for transaction_types API call

* Revert "replace useServiceTransactionTypes with useTransactionTypes"

This reverts commit bae7fa44a0fc1ace0b498cc78626fabb2d310437.

* Revert "Support transactionType for trace projection/api"

This reverts commit 2edb32cf04ca2c38885c457ba57ce0a1547fd199.

* Remove transaction type filter for traces,error groups

* Address review feedback

* Don't clone in mergeProjection; add tests

* Address review feedback

* Revert transaction_types API path in functional tests

* More review feedback

* More review feedback:

- Add transactions projection
- Merge traces/transaction groups projections

* Don't persist local UI filters in HistoryTabs

* Move projections to server folder

* Move transactionName into options

* Use pod name instead of pod uid
2019-08-15 12:37:02 +02:00
Aleh Zasypkin d106a4b3a9
[7.x] Add TLS client authentication support. (#43317) 2019-08-15 08:48:04 +02:00
Mikhail Shustov c63218ce5d
cleanup http config in legacy paltform for migrated params (#42818) (#43274)
* cleanup http config in legacy paltform for migrated params

* add comments
2019-08-15 08:45:26 +02:00
Maryia Lapata f5adc2c1eb
[Vis: Default editor] EUIficate Panel Setting tab (#42828) (#43277)
* EUIficate pointe-series and grid

* Apply TS

* Show grid on a panel

* Remove extra space

* Add TS

* Use BasicOptions

* Adjust func test

* Add dataTestSubj prop to SelectOption

* Use id instead of data-sest-subj

* Disable show x-axis lines when there is histogram agg

* Add tooltip for disabled 'Show x-axis lines' config

* Remove extra space
2019-08-15 07:45:00 +03:00
Ahmad Bamieh 4d042b8d1c
[7.x] [telemetry] add spacesEnabled config back to xpack_main… (#43323)
* add spacesEnabled config back to xpack

* move some variables back to xpack_main

* fix import path
2019-08-15 07:44:12 +03:00
Melissa Alvarez 8d76e57b50
[ML] Adds DF Transform Analytics list to Kibana management (#43151) (#43321)
* disable job link if ml not enabled in space

* add analytics table in managment page

* update css for analytics table

* only show ML section if license if trial/platinum

* remove actions column for analytics list in KM

* fix typescript error on columns

* update props interface for analytics table

* plain text instead of disabled link if not enabled in space
2019-08-14 20:59:13 -04:00
Court Ewing 3cef0219ab
[csp] Telemetry for csp configuration (#43223) (#43313)
We collect the boolean configurations which can be derived by any
end-user of Kibana by making any HTTP request. Since the rules
configuration involves strings that can leak identifiable information,
we only collect whether the rules have been changed from their defaults.
2019-08-14 19:53:29 -04:00
Bill McConaghy 04489a3a85
fixing issue with dashboard csv download (#42964) (#43316)
* fixing issue with dashboard csv download

* fixing test fixture to match new sort storage format for saved searches

* fixing sort in additional fixtures
2019-08-14 18:38:00 -04:00
Andrew Goldstein a9652cb482
[SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (#42804) (#43315)
This PR contains enhancements to the `Cypress` end-to-end (e2e) testing support in the SIEM app, as discussed with @spalger

Note: this PR depends on test refactorings in https://github.com/elastic/kibana/pull/42766

Cypress tests may now be run against a remote Elastic Cloud instance
(override `baseUrl`), interactively or via the command line.

Credentials are specified via `kibna.dev.yml` or environment variables.

Run tests on the command line (override `baseUrl` and pass credentials via
the `CYPRESS_ELASTICSEARCH_USERNAME` and `CYPRESS_ELASTICSEARCH_PASSWORD`
environment variables), via command line.

Reports are configured to include:

- An HTML report, suitable for e-mail notifications
- Screenshots
- Junit reports (for integration with Kibana CI)
- Videos (optional)

Reports generated when `Cypress` tests are run on the command line are output
to the `target` directory, which follows specific conventions used by the
Kibana CI process:

* Any directory under `target` that begins with `kibana-`, e.g. `kibana-siem` will be uploaded as an artifact to a bucket
* Junit reports are picked up from the `target/junit` directory

The artifacts generated by running `Cypress` tests on the command line conform to the above conventions.

An HTML report (e.g. for email notifications) is output to:

```
target/kibana-siem/cypress/results/output.html
```

Screenshots of failed tests are output to:

```
target/kibana-siem/cypress/screenshots
```

The Kibana CI process reports `junit` test results from the `target/junit` directory.

Cypress `junit` reports are generated in `target/kibana-siem/cypress/results`
and copied to the `target/junit` directory.

Videos are disabled by default, but can optionally be enabled by setting the
`CYPRESS_video=true` environment variable:

```
CYPRESS_video=true yarn cypress:run
```

Videos are (optionally) output to:

```
target/kibana-siem/cypress/videos
```

The full details and instructions for running Cypress tests are in the
`siem/cypress/README.md`, which was updated to reflect the changes
in this in this PR, but in a nutshell, you may run tests interactively with
the following (new) environment variables:

```sh
cd x-pack/legacy/plugins/siem
CYPRESS_baseUrl=http://localhost:5601 CYPRESS_ELASTICSEARCH_USERNAME=elastic CYPRESS_ELASTICSEARCH_PASSWORD=<password> yarn cypress:open
```

Running the command line version of the tests, which will output
the reports described above, is a similar experence:

```sh
cd x-pack/legacy/plugins/siem
CYPRESS_baseUrl=http://localhost:5601 CYPRESS_ELASTICSEARCH_USERNAME=elastic CYPRESS_ELASTICSEARCH_PASSWORD=<password> yarn cypress:run
```

https://github.com/elastic/siem-team/issues/435
https://github.com/elastic/siem-team/issues/437

- regen yarn.lock
2019-08-14 16:36:30 -06:00
Søren Louv-Jansen f3391bd05c
[7.x] [APM] Fix missing RUM url (#42940) (#43021)
* [APM] Fix missing RUM url (#42940)

* [APM] Fix missing RUM url

* Reduce to single conditional branch

* Fix test

* Add tests for `url.full` and `error.page.url`

# Conflicts:
#	x-pack/legacy/plugins/apm/public/components/app/ErrorGroupDetails/DetailView/StickyErrorProperties.test.tsx
#	x-pack/legacy/plugins/apm/public/components/app/ErrorGroupDetails/DetailView/StickyErrorProperties.tsx

* Fix missing import and `isHandled`
2019-08-14 22:26:57 +02:00
James Gowdy 580b1bb566
[ML] Adding bucket span estimator to new wizards (#43288) (#43308)
* [ML] Adding bucket span estimator to new wizards

* disabling next button when estimating

* fixing population
2019-08-14 21:25:06 +01:00
Matthias Wilhelm 99141c009e
Restore discover histogram selection triggering fetch (#43097) (#43286)
* Listen to timefilter fetch event to start fetching

* Improve functional test to catch error
2019-08-14 22:09:33 +02:00
Stacey Gammon 5eb8cfb243
Per panel time range (#43153) (#43297)
* Per panel time range

* Added tests and fixed lack of await check for incompatibility

* Remove a couple more unneccessary `anys`
2019-08-14 15:20:59 -04:00
Jason Rhodes fc997b9518
[Logs UI] Create ML module for log analysis (#42872) (#43261)
* Add ml module with hard-coded timestamp field

* Fix data_recognizer test

* Parameterize the bucket span normalization

* Remove max agg which will be specified during setup

The overrides are recursively merged and therefore additive. Therefore
we can't specify the timestamp agg here, because it could not be
overridden later with a different field and agg name. It needs to be
solely specified at setup time.
2019-08-14 14:36:47 -04:00
Phillip Burch a1359a2263
Sentence case copy changes (#43215) (#43281)
* Change casing for options and labels to be sentence case

* More sentence-case copy changes

* Fix min and max capitalization
2019-08-14 13:18:46 -05:00
spalger 24cb351e41 disable flaky tests (#43017)
(cherry picked from commit c65b9752cb)
2019-08-14 11:13:16 -07:00
James Gowdy dcec0603c9
[ML] Adding post create job options (#43205) (#43289)
* [ML] Adding post create job options

* adding toasts

* fixing toast string

* tweaking continue job function

* updating ids

* removing ts-ignore
2019-08-14 18:54:35 +01:00
liza-mae 17178e88e0
Fix percy target branch for PRs (#43160) (#43292)
* Fix percy target branch for PRs

* Add debug logging

* Try diff branch name

* Use PR_TARGET_BRANCH instead

* renable visReg jobs

* parse target branch from `branch_specifier`

* rename debugging print out

* set `PERCY_BRANCH` and `PERCY_TARGET_BRANCH`

* log PERCY_TARGET_BRANCH

* cleanup error messages
2019-08-14 11:53:01 -06:00
Ahmad Bamieh 5adf0f1c97 [7.x] [i18n] .i18nrc file as the source of truth and enhance tooling (#39774) (#43284)
* merge conflicts

* add inspector path
2019-08-14 13:47:01 -04:00
Marjorie Jones 1326d58de5
[DOCS] Enhance Infrastructure UI section of Kibana docs (#42937) (#43278)
* Update index.asciidoc

More tidying up

* Partial commit, still very much work in progress

* Work in progress

* More partial changes

* More partial changes

* Yet more changes

* More changes to infrastructure section

* Some more tidying up of topics.

* More changes, adjusting links, proof-reading etc.

* Some review comments from @bmorelli25 and @gchaps

* Another review change

* Adding redirect for deleted bookmark

* More review changes

“application” is “app” apparently in this context

* Review comments from Brandon
2019-08-14 18:11:57 +01:00
Chris Cowan c42c0b9f49
[Infra UI] Add APM to Metadata Endpoint (#42197) (#43280)
* [Infra UI] Add APM to Metadata Endpoint

- Adds APM feature to metadata
- Closes #42167
- Based on #41836

* migrating to new http api
2019-08-14 09:40:48 -07:00
Walter Rafelsberger 053fbb70db
[ML] Data frame transforms: Fix getting nested properties. (#43262) (#43273)
- Fixes a regression where values were not properly extracted from nested objects.
- Moves inline code we had to solve this to a utility function getNestedProperty(). Kibana's idx is a lodash-get replacement with TypeScript support. However, it requires that you'd know the accessor up front, it doesn't work with dynamic string values. getNestedProperty() allows you to pass a string like lodash-get, but it uses idx on the inside so you still get TypeScript support.
2019-08-14 17:42:30 +02:00
Marjorie Jones b8fa391e0e
[DOCS] Update metrics-explorer.asciidoc (#40898) (#42434)
* Update metrics-explorer.asciidoc

Partial commit. Adding missing chapter title and tidying up the tutorial a bit.

* Update metrics-explorer.asciidoc

Addressing review comments from @bmorelli25.
Also changed "drop-down" to "dropdown" to meet style guide and added link for reference to KBL.

* Addressing review comments from @simianhacker and @gchaps.
2019-08-14 15:55:36 +01:00
Kerry Gallagher 015116980d
[Logs UI] Add log analysis tab (#42931) (#43253)
* Add empty analysis tab

* Add ml capabilities check

* Add job status checking functionality

* Add a loading page for the job status check

* Change types / change method for deriving space ID / change setup requirement filtering check

* Use new structure

* Change tab syntax

* i18n translate message prop

* Fix import
2019-08-14 11:41:15 +01:00
Walter Rafelsberger 9f0b7ce998
[ML] Data frame analytics: Hook unit tests. (#43199) (#43250)
- moves use_create_analytics_form.ts inside a use_create_analytics_form directory to be able to split up the large file
- moves code related to the plain reducer function from ``use_create_analytics_form.tsto its own filereducer.ts`
- adds unit tests for use_create_analytics_form.ts and reducer.ts.
- Changes the button and modal header text from 'Create data frame analytics job' to 'Create outlier detection job'.
2019-08-14 11:31:57 +02:00
Yulong c8d247cc84
[Code] make ctag lang server embed (#43170) (#43242)
* [Code] add an abstraction for child processes
* [Code] make CTag lang server embed
2019-08-14 15:55:49 +08:00
Yulong e6f450a47b
[Code] fixed lang server install status (#43164) (#43243) 2019-08-14 15:55:27 +08:00
Tiago Costa 08190cbcd4
fix(NA): get dll entries across platforms (#43224) (#43237)
* fix(NA): get dll entries across platforms

* chore(NA): some more improvements
2019-08-14 04:46:42 +01:00
Patrick Mueller cf6c35ae6b
fix schema.nullable() to support non-strings (#42891) (#43236)
The previous implementation of `schema.nullable()` ends up having
a problem - it only works right for `schema.nullable(schema.string())`.
For other types, like `schema.number()` and `schema.boolean()`, a `null`
value passed in does not validate.

I poked around a bit, but "it's complicated".  So, went with the
suggested approach of using a `schema.maybe([V, null])` validation,
which works for number and boolean.

Added some additional tests on the `nullable` type.
2019-08-13 23:23:49 -04:00
CJ Cenizal fad93f96f1
Show requests for creating a follower index and creating/updating an auto-follow pattern in CCR. (#42924) (#43231) 2019-08-13 16:45:35 -07:00
Lukas Olson 2f9a94e86a Abort request to Elasticsearch when browser disconnects (#42764)
* Abort request to Elasticsearch when client disconnects from Kibana server

* Use correct reference to node's abort controller

* Fix tests
2019-08-13 16:34:18 -07:00
CJ Cenizal 31509eea8e
Add request flyout to Remote Clusters. (#42900) (#43222) 2019-08-13 16:28:17 -07:00
Brandon Morelli 8f8cd0d12f
update RUM link (#39940) (#43212) 2019-08-13 15:16:50 -07:00
Nathan Reese 8afa7cd074
[Maps] reposition tooltip when tooltip size changes (#43152) (#43217)
* [Maps] reposition tooltip when tooltip size changes

* review feedback

* fix jest tests

* add check to ensure tooltip state location is still provided
2019-08-13 15:48:36 -06:00
Brandon Kobel a8a715d377
Allowing individual privileges to be excluded from base privileges (#42470) (#43214)
* Excluding code from base privileges

* Allowing individual privileges to be excluded

* Only returning a boolean for directlyAssigned... for space feature privileges

* We are now called directlyAssignedPrivilegeMorePermissiveThanBase

* An even longer and potentially more accurate name

* Fixing KibanaPrivilegeCalculator tests

* Fixing KibanaAllowedPrivilegesCalculator tests

* Adding privilege space table tests

* Updating privilegesFactory tests

* Removing code's usage

* Updating snapshot

* Update x-pack/legacy/plugins/security/public/lib/kibana_privilege_calculator/kibana_feature_privilege_calculator.test.ts

Co-Authored-By: Larry Gregory <lgregorydev@gmail.com>
2019-08-13 14:26:20 -07:00
marcos ramos 44b55275ec Adding proxy settings to exposed env vars 2019-08-13 15:57:04 -05:00
Larry Gregory 20cf5057da
[7.x] Feature Controls docs - removing magic quotes (#43194) (#43202) 2019-08-13 16:52:58 -04:00
Marco Vettorello 152071b5c3
Fix tooltip text overflow (#41703) (#43206) 2019-08-13 21:45:41 +02:00
Tiago Costa a1d8d24906
chore(NA): correctly set kibanaRoot on kibana plugin helpers for new generated plugins (#42616) (#43195)
* chore(NA): correctly set kibanaRoot on kibana plugin helpers for new generated plugins

* chore(NA): support both kibana-extra and plugins dir
2019-08-13 19:10:07 +01:00
Tim Sullivan a59a3888cf
[Reporting] convert generate png/pdf libraries to Typescript (#42801) (#42888)
* convert generate png/pdf to ts

* Reorganize some types exports/imports, fewer any-type
2019-08-13 10:53:15 -07:00
Tim Sullivan ef59d5347d
[Reporting] More Typescripting, minor browser driver refactoring (#42799) (#42883)
* Safe child process refactor

* Refactor install browser

* Convert install.js to Typescript
2019-08-13 10:53:03 -07:00
Patrick Mueller 6187fb6228
Changes references of "fire" to "execute" in actions (#43140) (#43198)
In the actions plugin, references to "fire" have been changed to "execute".  A few changes were also required in alerting.
2019-08-13 13:42:21 -04:00
Andrew Goldstein 1238afc911
[SIEM] Toggle Column / Code Coverage and Cypress (#42766) (#43166)
## Features

-  A `Toggle column` checkbox for adding / removing fields in the timeline offers
an alternative to drag and drop in an expanded event:

![toggle-field](https://user-images.githubusercontent.com/4459398/62572146-4d94c280-b850-11e9-8ff9-5feaca3f305d.gif)

The behavior of the `Toggle field` checkbox in the expanded event is the same
as the checkboxes that appear in the timeline _Fields Browser_.

## Fixes

- Pinned timeline events now use a "filled" styling when pinned instead of rotation, and unpinned events have a higher contrast in dark mode:

Before:

![unpinned-before](https://user-images.githubusercontent.com/4459398/62572175-5b4a4800-b850-11e9-9d4f-317d5abad002.png)

After (unpinned):
![after-unpinned](https://user-images.githubusercontent.com/4459398/62908225-28aebc80-bd34-11e9-9237-8a98c88a6da1.png)

After (pinned):
![after-pinned](https://user-images.githubusercontent.com/4459398/62908230-306e6100-bd34-11e9-9830-45d725bac5b1.png)

- Fixed an issue where the `Copy to Clipboard` icon rendered incorrectly (too
small, and not the right color):

Before:

![copy-to-clipboard-before](https://user-images.githubusercontent.com/4459398/62572224-7452f900-b850-11e9-962c-eef0b96202ff.png)

After:

![copy-to-clipboard-after](https://user-images.githubusercontent.com/4459398/62572240-7f0d8e00-b850-11e9-8b89-7c14bf92e705.png)

- Fixed an issue where a previously invisible control became visible and
occupied additonal row space in the timeline:

Before:

![row-height-before](https://user-images.githubusercontent.com/4459398/62572265-8e8cd700-b850-11e9-9c36-1d74ba0ba6f5.png)

After:

![row-height-after](https://user-images.githubusercontent.com/4459398/62572285-977da880-b850-11e9-8448-7085bbac8da4.png)

- Fixed an issue where the timeline Fields Browser Overlaps Column Headers

Before:

![field-browser-position-before](https://user-images.githubusercontent.com/4459398/62572309-a5332e00-b850-11e9-9b6f-38700d2f48a0.png)

After:

![field-browser-position-after](https://user-images.githubusercontent.com/4459398/62572335-b845fe00-b850-11e9-84f8-4b273f7ef163.png)

## Code Coverage and Cypress Tests

- This PR increases the `jest` unit test coverage for the _Fields Browser_, and
introduces `Cypress` tests for it
- Added new `Cypress` test helpers, configuration, and test refactorings to
support running smoke tests against remote Kibana instances, including
[Elastic Cloud](https://www.elastic.co/cloud)
- Refactored some `Cypress` tests to speed them up and reduce flakyness

https://github.com/elastic/siem-team/issues/380
https://github.com/elastic/siem-team/issues/431
https://github.com/elastic/siem-team/issues/432
https://github.com/elastic/siem-team/issues/433
https://github.com/elastic/siem-team/issues/434
https://github.com/elastic/siem-team/issues/435
2019-08-13 10:48:36 -06:00
Liza Katz 4a5830eb0c
merge (#43192) 2019-08-13 18:28:29 +03:00
Josh Dover 8a244223ca
[7.x] Export missing Context types (#43051) (#43143) 2019-08-13 10:06:34 -05:00
James Gowdy 67e8237ffe
[ML] Fixing spaces feature is disabled check (#43120) (#43182)
* [ML] Fixing spaces feature is disabled check

* removing debug code
2019-08-13 14:57:53 +01:00
Sonja Krause-Harder 70216661ad
[Infra UI] Add AWS metrics to node detail page (#42153) (#43181)
* Add cloudId to metrics graphql query.

* Add server-side TSVB model for aws cpu utilization

* Use cloud id for cloud metrics

* Add AWS layout to host page

* Add cloudId to useMetadata

* Refactor: move aws modules into separate directory

* Add AWS network chart to node details

* Add AWS Overview to node details

* Add aws network packets chart to node details

* Add TODO reference to aws network bytes model

* Add AWS diskio ops to node details

* Add AWS diskio bytes to node details

* Check that cloudId is given when needed

* Use network packets on node details AWS overview

* Remove requires on layout level.

* Fix layout creator type signature.

* Add gaugeMax to layout types
2019-08-13 15:09:27 +02:00
Stacey Gammon 8b1007137c
switch to icon type string instead of node (#43111) (#43126)
* switch to icon type string instead of node. Some EUI components only take the string.

* Fix lint errors

* another type fix
2019-08-13 09:00:49 -04:00