Commit graph

35129 commits

Author SHA1 Message Date
Scotty Bollinger
2ae470e897
Add Kea.js support to Enterprise Search plugin (#72160)
* Add Kea packages

- kea and kea-waitfor

* Add Kea declarations and types

Hopefully TypeScript support coming soon from author

* Add Kea to entry point

* Add logic for overview

* Update components to use Kea

* Fix a couple of tests that weren’t getting complete coverage

* Remove kea-waitfor

Turns out we don’t need it

* Remove unused declaration

* Update x-pack/plugins/enterprise_search/public/applications/workplace_search/components/overview/overview_logic.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Update x-pack/plugins/enterprise_search/public/applications/workplace_search/components/overview/overview_logic.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Update x-pack/plugins/enterprise_search/public/applications/workplace_search/components/overview/__mocks__/overview_logic.mock.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Update x-pack/plugins/enterprise_search/public/applications/workplace_search/components/overview/overview_logic.test.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* [Opinionated] Remove extra actions defs

- they're already being defined in IOverviewActions, so no need to repeat them

* DRY out a new reusable/generics IKeaLogic/Listeners interface

- Multiple logic files can now do IKeaListeners<SomeLogicActions> and not have to declare their own IListenerParams!

+ bonus IKeaSelectors just for consistency

* DRY out Kea reducers definitions to generics interface

* [Refactor] Improve KeaReducers generic to actually type-check/check key names

- Typescript will now throw an error if you put in a key name that isn't declared in your actions/values interface
- default & new states now will be type checked!! 🎉

* [Refactor] Update selectors() and listeners() to also check types and keys

* [Refactor] Move param defs to bottom of file instead of inline

- so that inline definitions mostly focus on type checks, and more boilerplate defs are DRYed out
- I played around with 2.1 obj definitions and got terrible results here :(

* Update tests and remove selectors per code review

* Remove last statsColumns instance

* Remove last instance of hideOnboarding

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Constance Chen <constance.chen.3@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 16:04:10 -05:00
Justin Kambic
1c690c68af
[Uptime] Increase timeout in attempt to fix skipped a11y test (#73078)
* Increase timeout in attempt to fix skipped a11y test.

* Temporarily only run uptime tests for faster flaky testing.

* Uncomment other test suites.

* Unskip test and delete comment.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 15:39:52 -04:00
Nathan L Smith
f23359c099
[APM] Fix license management URL (#73294)
The URL to license management has changed, so update our links, both in the prompt on the Service Map, and in the app-wide expired license message.

Use `useKibanaUrl` in both places and update that hook to make the `hash` argument optional, since many apps don't use a hash now.

I looked for a more reliable way to get the URL for that app but couldn't come up with anything. I'd appreciate any suggestions if there's a better method.
2020-07-27 14:20:26 -05:00
Alison Goryachev
7c24a61c43
Make ingest node pipelines api tests more robust (#73289) 2020-07-27 15:19:42 -04:00
Marshall Main
34fd7b301d
Increase limit on exception items to 10k (#73117)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 14:17:19 -04:00
Jonathan Buttner
867a672c7a
[Security Solution] Use docker for endpoint tests (#73092)
* Copying api integration tests into their own directory

* Removing api integration tests and using ingest docker image

* Fixing typo

* Fixing type errors and empty string and reenabling tests

* Rebuilding docs

* Renaming url override variable

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 14:13:50 -04:00
Spencer
dd4796cfdd
Remove karma (#73126)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-07-27 11:07:58 -07:00
Spencer
d66cc3515c
[canvas] migrate tests away from karma (#73121)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 10:43:18 -07:00
Poff Poffenberger
6631a296ef
[Canvas] Fix top left elements being automatically selected on workpad page loads (#72121)
* Fix top left elements being automatically selected on workpad page loads

* Remove unnecessary code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 12:18:33 -05:00
Jonathan Budzenski
e9fa2f3542
[build] fix chmod errors (#72768)
* inherit data permisions

* tmp add all-platforms flag

* Revert "inherit data permisions"

This reverts commit ce30dd7b3a.

* silent chmod, move to configure sectino

* simplify chown and fix babel cache

* rm empty lines

* Revert "tmp add all-platforms flag"

This reverts commit f1ae815ca9.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 12:15:56 -05:00
Katrin Freihofner
46dcc0bd49
Adds styling changes to uptime overview and details page (#71840)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 19:10:03 +02:00
Pete Harverson
d9a646113c
[ML] Fixes raw data drilldowns for Apache, Nginx, Auditbeat modules (#73280) 2020-07-27 17:36:05 +01:00
Dmitry Lemeshko
25856ed985
[code coverage] add iframe embedded and enterprise search tests (#73267) 2020-07-27 18:12:32 +02:00
Ryland Herrick
b15a0a97f7
[Security Solution][Detections] Adds ip_range and text types to value list upload form (#73109)
* Adds two more types to the value lists form

* Adds `ip_range` and `text` types
* Replaces radio group with select

* Add custom command for attaching a file to an input

This will be used to excercise value list uploads.

* Add some missing test subjects for our value lists modal

* Add cypress test for value lists modal

This exercises the happy path: opening the modal, uploading a list, and
asserting that it subsequently appears in the table.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 10:35:18 -05:00
Paul Tavares
6d4bb9dc0d
[SECURITY_SOLUTION][ENDPOINT] Handle Host list/details policy links to non-existing policies (#73208)
* Make API call to check policies and save it to store
* change policy list and details to not show policy as a link if it does not exist
2020-07-27 11:13:26 -04:00
igoristic
9aa5e1772d
[Monitoring] "Internal Monitoring" deprecation warning (#72020)
* Internal Monitoring deprecation

* Fixed type

* Added if cloud logic

* Fixed i18n test

* Addressed code review feedback

* Fixed types

* Changed query

* Added delay to fix a test

* Fixed tests

* Fixed text

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 11:10:25 -04:00
Angela Chuang
02e3fca772
fix icon type (#73254) 2020-07-27 16:01:03 +01:00
Felix Stürmer
aa45ac89b0
[Logs UI] Return empty result sets instead of 500 or 404 for analysis results (#72824)
This changes the analysis results routes to return empty result sets with HTTP status code 200 instead of and inconsistent status codes 500 or 404.
2020-07-27 16:36:25 +02:00
Nathan L Smith
2a77307af1
[APM] Use core.chrome to set window title (#73232)
I noticed there's a `core.chrome.docTitle.change` method. It can take a string or array of strings and provides its own separator character if given an array.

Replace our setting of `window.document.title` directly in the APM and Observability plugins with using the chrome method.

This changes the title to be, for example, "トランザクション - opbeans-node - サービス - APM - Elastic" instead of "トランザクション | opbeans-node | サービス | APM | Elastic", using " - " as a separator instead of " | ".
2020-07-27 09:22:37 -05:00
Christos Nasikas
bc65c5e160
[Security Solution][Cases] Create useAllCasesModal hook (#72602) 2020-07-27 16:40:02 +03:00
Nathan L Smith
76150a4026
Observability i18n fixes (#72984)
* Format `xpack.apm.percentOfParent` correctly so the transactions page in APM doesn't crash. In English it reads like, "(X% of transaction)". I'm not sure what the intention of the changed translation is, but I've changed it to be the equivalent of "(X% transaction)". A correction to the Japanese form here would be appreciated, but this fixes the crash and gets the message across.
* Format `xpack.infra.logs.customizeLogs.textSizeRadioGroup` correctly. This was not causing the whole logs page to crash, but was causing an error in the JS console.
2020-07-27 08:20:27 -05:00
Nathan L Smith
d3ddcd2027
[APM] APM & Observability plugin lint improvements (#72702)
* [APM] APM & Observability plugin lint improvements

This is a large change, but most of it is automatic `eslint --fix` changes.

* Apply the same ESLint ovderrides in APM and Observability plugins.
* Remove the `no-unused-vars` rule. We can turn on the TypeScript check if needed.
* Check both JS and TS files.
* Add a rule for react function component definitions
* Upgrade eslint-plugin-react to include that rule
2020-07-27 08:18:36 -05:00
Gidi Meir Morris
9d5b1bf20b
simplified buffer tests to reduce flakyness (#73024)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 12:10:16 +01:00
Tim Roes
9c2056d2ea
Remove flaky note from gauge tests (#73240) 2020-07-27 11:58:11 +02:00
Joe Reuter
6a53b0021e
Convert functional vega tests to ts and unskip tests (#72238)
* convert to ts and unskip tests

* relax tests and remove unused imports

* remove test exclusion

* remove inspector test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-27 10:45:23 +02:00
Joe Reuter
122d7fe18f
[Graph] Unskip graph tests (#72291) 2020-07-27 10:44:19 +02:00
Søren Louv-Jansen
9656cbcbe7
Add default Elasticsearch credentials to docs (#72617) 2020-07-27 00:45:52 +02:00
Nathan L Smith
55f55bfb54
[APM] Read body from indicesStats in upload-telemetry-data (#72732)
add for transport request too
2020-07-26 12:41:22 -05:00
John Dorlus
ff9f06b880
The directory in the command was missing the /generated directory and would cause all definitions to be regenerated in the wrong place. (#72766) 2020-07-26 10:04:09 -04:00
Mikhail Shustov
2a82ff9566
[KP] use new ES client in SO service (#72289)
* adapt retryCallCluster for new ES client

* review comments

* retry on 408 ResponseError

* remove legacy retry functions

* use Migrator Es client in SO migration

* update migration tests

* improve ES typings and mocks

* migrate decorate ES errors

* add repository es client

* use new es client in so repository

* update repository tests

* fix migrator integration tests

* declare _seq_no & _primary_term on get response. _source expect to be a string

* make _sourceIncludes and refresh compatible with the client

* add test for repository_es_client

* move ApiResponse to es client mocks

* TEMP: handle wait_for as true for deleteByNamespace

* add tests for migration_es_client

* TEMP: skip test for deleteByNamespace refresh

* pass ignore as transport option in mget

* log both es client and response errors

* fix update method test failures

* update deleteByNamespace refresh settings

es doesn't support 'refresh: wait_for' for `updateByQuery` endpoint

* update repository tests. we do not allow customising wait_for

* do not delegate retry logic to es client

* fix type errors after master merged

* fix repository tests

* fix security solutions code

SO doesn't throw Error with status code anymore. Always use SO error helpers

* switch error conditions to use SO error helpers

* cleanup

* address comments about mocks

* use isResponseError helper

* address comments

* fix type errors

Co-authored-by: pgayvallet <pierre.gayvallet@elastic.co>
2020-07-25 11:59:56 +02:00
Garrett Spong
7f36bd7dcc
[Security Solution][Exceptions] Prevents value list entries from co-existing with non value list entries (#72995)
## Summary

Fixes validation issue where value list exception entries could be added alongside non value list exception entries.


Once a value list operator (`is in list` or `is not in list`) is selected the `nested` button will disable, and subsequent `and`/ `or`'s will only have the value list operators available to them:

<p align="center">
  <img width="400" src="https://user-images.githubusercontent.com/2946766/88323026-d36a8180-ccde-11ea-97f0-16490bf9a671.gif" />
</p>


If a value list is not selected in the first exception entry, all subsequent entries will no longer have the value list operators:
<p align="center">
  <img width="400" src="https://user-images.githubusercontent.com/2946766/88250505-08d28900-cc65-11ea-9a6c-5b869e3d7f7f.gif" />
</p>


Adds validation for empty case to prevent network error when submitted no entries.
Add modal:
<p align="center">
  <img width="400" src="https://user-images.githubusercontent.com/2946766/88299601-c5593880-ccbf-11ea-9468-30796a0f9748.gif" />
</p>

Edit modal:
<p align="center">
  <img width="400" src="https://user-images.githubusercontent.com/2946766/88299609-c7bb9280-ccbf-11ea-943c-836b641d7ae3.gif" />
</p>




### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-07-24 15:50:16 -06:00
Clint Andrew Hall
120ce71171
Return EUI CSS to Shareable Runtime (#72990)
* Add Canvas Styles

* Tree-shaking in EUI omits CSS in the runtime

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-24 15:39:25 -04:00
Uladzislau Lasitsa
46bd08d6d4
Removed useless karma test (#73190) 2020-07-24 16:39:03 +03:00
Paul Tavares
e341eaf84b
[INGEST_MANAGER] Make package config name blank for endpoint on Package Config create (#73082)
* Make package config name blank for endpoint
* Added functional tests on endpoint side
2020-07-24 09:02:23 -04:00
Nicolas Chaulet
680d94c82f
[Ingest Manager] Support DEGRADED state in fleet agent event (#73104) 2020-07-24 08:40:41 -04:00
Christos Nasikas
5aa1211521
[Security Solution][Detections] Change detections breadcrumb title (#73059) 2020-07-24 11:35:10 +03:00
James Gowdy
c0968f5726
[ML] Fixing unnecessary deleting job polling (#73087) 2020-07-24 09:15:23 +01:00
James Gowdy
3883e3e239
[ML] Fixing recognizer wizard create job button (#73025)
* [ML] Fixing recognizer wizard create job button

* updating translations
2020-07-24 09:14:10 +01:00
Sébastien Loix
1329b683de
[Composable template] Preview composite template (#72598)
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-24 07:50:37 +02:00
Andrew Cholakian
c2ad4bf048
[Uptime] Use manual intervals for ping histogram (#72928)
* [Uptime] Use manual intervals for ping histogram

Fixes https://github.com/elastic/uptime/issues/215

Prior to this we'd get too few buckets in some ranges.

* Update test fixtures, remove overly-specific checks

* Remove unused import
2020-07-23 20:02:12 -05:00
Candace Park
47b3a94798
[Security Solution][Endpoint] Task/policy save modal text change, remove duplicate policy details text (#73130)
[Security Solution][Endpoint] updates policy details text
2020-07-23 20:57:54 -04:00
Nathan Reese
5f4b1a3689
[Maps] fix tile layer attibution text and attribution link validation errors (#73160)
* [Maps] fix tile layer attibution text and attribution link validation errors

* clean up jest test

* tslint

* one more tslint
2020-07-23 18:30:42 -06:00
Jonathan Budzenski
8021616e41 skip ingest pipeline api tests
JSON formatting appears to have changed modestly. Tracking at #73170.
2020-07-23 18:41:32 -05:00
Nathan Reese
b5c0d5f250
[maps] fix data driven style properties not working when cloned layer contains joins (#73124)
* [maps] fix data driven style properties not working when cloned layer contains joins

* tslint

* handle case where metrics is not provided

* tslint
2020-07-23 17:20:24 -06:00
Steph Milovic
aec18923da
update discuss link from siem to security (#72886)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-23 17:11:04 -06:00
Corey Robertson
f5a81deadb
Exclude variables from rendered workpad (#72970) 2020-07-23 19:04:23 -04:00
Matthew Kime
5a1972b834
Index patterns on alias - reenable functional tests (#71802)
* reenable test
* nav to management
2020-07-23 17:46:26 -05:00
Kevin Qualters
19127c287e
[Security Solution][Endpoint] Clean up resolver query params on component dismount (#72902) 2020-07-23 18:15:38 -04:00
Robert Austin
bb64666051
[Resolver] Handle duplicate process events (#73123)
In the case that the process creation (or already running) events for a
node have been duplicated in ES, this uses the last one (in response
order.)
2020-07-23 17:45:07 -04:00
Nathan Reese
849bbfdcd5
[maps][docs] add trouble shooting for index not listed (#73066)
* [maps][docs] add troubeshooting for index not listed

* Update docs/maps/trouble-shooting.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/trouble-shooting.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/trouble-shooting.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/trouble-shooting.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/trouble-shooting.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2020-07-23 15:22:54 -06:00