Commit graph

17660 commits

Author SHA1 Message Date
Josh Soref
2b27fb1c5f Fix misspellings (#19981) 2018-06-26 20:17:41 -07:00
Shaunak Kashyap
ad44ae971b
Add a Static Lookup field formatter (#19637)
* Add static lookup field formatter

* Adding field formatter ID to test IDs
2018-06-26 17:07:18 -07:00
Bill McConaghy
61aa89cb64
adding missing data-test-subj and renaming one (#20238) 2018-06-26 20:05:32 -04:00
archana
b03243f5d8
[Functional Tests] Use @kbn/test on Kibana CI (#18967)
* Replace test:api with @kbn/test runTests

* Improve CLI help menu 🆘

* Use --es-from

* Replace jenkins:selenium with kbn-test

* Validate cli args, fixing test in the process

* Clean up some stuff

* Code review fixes

* Explanation for collectCliArgs

* Remove exit codes, they're useless anyway.

* Make markdown vis test pass with dev_mode setting

* Tests

* Remove unneeded export

* Code review: move console logging up to cli.js

* Code review: refactor startServers and runTests to take single options collection

* Code review: Remove all things I am sure we do not use

* Improve tests

* Code review fixes

* Pass created log to runFtr, runElasticsearch, runKibanaServer

* Update --es-from option to --esFrom
2018-06-26 18:08:40 -05:00
Justin Kambic
068c02f1c9
[Pipeline Viewer] [Monitoring] Rename config view to PipelineViewer (#20230)
* Rename config view to PipelineViewer.

* Remove unused className.

* Remove unneeded variable.

* Format file with prettier.
2018-06-26 18:59:18 -04:00
Peter Pisljar
28402d3dfc
Remove Angular from courier request handler (#20032) 2018-06-26 20:41:02 +02:00
Bill McConaghy
dbdbb688de
[console] adding support for autocompletion of template names (#20218)
* adding support for autocompletion of template names

* changing template_id param to template to make it consistent with index and others
2018-06-26 12:51:54 -04:00
Nathan Reese
2341661cd8
Replace timefilter angular service with singleton (#19852)
* use uiSettingsClient instead of angular config service

* replace timefilter service with singleton

* remove all other uses of timefilter service, get timefilter singleton working

* remove Private from brush event

* globalState

* fix timefilter jest test

* clean up rebase artifacts

* lint errors

* another lint error

* fix broken functional test _shared_links

* fix broken mocha test doc.js

* fix service load order breaking status page

* remove Provider from change_time_filter

* another round of mocha test updates

* convert create_brush_handler test to jest

* fix kbnGlobalTimepicker toogle mocha test

* remove _root_search_source - removed in another PR and somehow I added it back during rebase

* better comments around Object.assign and proper js-docs format

* use  so listerners get cleaned up when scope is destroyed

* listen to correct timefilter update event

* update APM to use timefilter singleton

* update angular scope when timefilter changes

* fix APM jest test

* add listenAndDigestAsync to listen.js

* fix apm breadcrumbs jest test

* move diffTime and diffInterval into timefilter

* pass mode to updateFilter to resolve functional test failure

* call registerTimefilterWithGlobalState from APM application

* remove rootScope from kbn_global_timepicker

* use  to subscribe to timefilter in cases where results need to happen in digest async

* spalger review changes

* ensure monitoring timefilter callbacks are executed inside evalAsync

* remove unneeded evalAsync calls around setTime
2018-06-26 10:29:41 -06:00
liza-mae
2acb0265d8
Fix flaky visualize lab mode tests (#20165)
* Update saveSearch method in discover and add wait page loading for advance settings

* Fix spaces
2018-06-26 10:28:15 -06:00
CJ Cenizal
6cbfb97abd
Fix broken SearchRequest clone method and add test. (#20222) 2018-06-26 09:19:57 -07:00
gchaps
e05e0bc0bc
[COPYEDIT] Updates to text in force merge modal in index management (#20134) 2018-06-26 08:04:24 -07:00
Justin Kambic
94d99d63f3
[Monitoring] [Pipeline Viewer] Remove obsolete code (#20122)
* Remove PipelineViewer component, replace with Config Viewer as index export.

* Remove tests for obsolete component.

* Remove obsolete code.

* Remove obsolete CSS.

* Remove old SVG class for graph edges.

* Remove more graph rendering code.

* Remove obsolete properties from graph classes.

* Remove unused constants.

* Remove obsolete keys from subtitle props.

* Fix broken unit tests.
2018-06-26 10:49:11 -04:00
Bill McConaghy
d8c7970840
simplifying logic for showing extend trial and adjusting tests (#20211)
* simplifying logic for showing extend trial and adjusting tests

* PR feedback
2018-06-25 14:38:44 -04:00
Aleh Zasypkin
18037984da
Upgrade rxjs: 6.1.0 ---> 6.2.1. (#20209) 2018-06-25 20:04:19 +02:00
Bill McConaghy
a141087179
[console] Fixing rollover autocomplete (#20167)
* adding body autocomplete for rollover

* adding scope link for settings for rollover autocomplete

* adding additional body autocomplete properties
2018-06-25 12:50:55 -04:00
Nathan Reese
a566312adb
replace SearchSource fetch with fetchAsRejectablePromise (#20130)
* move errorHandler into constructor, replace fetch with fetchAsRejectablePromise

* update existing users of fetch to handle promise rejection
2018-06-25 07:27:12 -06:00
Nathan Reese
a1d44c155e
add isBeta flag to add data module schema (#20049)
* add isBeta flag to add data module schema

* remove changes to packages/kbn-es/yarn.lock

* do not put empty flex item in dom

* update snapshots
2018-06-25 07:11:59 -06:00
Nathan Reese
b32d2fe542
remove unused code metrics executor (#20135) 2018-06-25 07:06:15 -06:00
Bill McConaghy
4a66c2cace
removing custom tokenizer code from console (#20013) 2018-06-25 08:47:46 -04:00
Bill McConaghy
eafcd909a4
fixing issue with autocomplete and slashes at end of url (#20151) 2018-06-25 08:46:28 -04:00
Bill McConaghy
39ac92a1d1
[console] adding generated spec files for xpack endpoints and adjusting code to… (#19928)
* adding generated spec files for xpack endpoints and adjusting code to handle the same override logic

* accounting for non URL documentation values

* fixing issue with incorrect override file

* adding support for unknown parameters in path (assuming they are ids)

* fixing autocomplete for get_categories ml API

* fixing issue with autocomplete for get_overall_buckets

* fixing issue with get_overall_buckets autocomplete

* fixing get_overall_buckets autocomplete issue for reals

* fixing __flag__ in body autocomplete specs

* fixing issue with ml put_datafeed autocomplete

* removing unnecessary overrides for rollup put_job

* fix issue with UrlPatternMatcher

* fixing tests

* fixing typos

* overriding rollup get due to bug in ES specs
2018-06-25 08:44:35 -04:00
Tim Roes
a5810bad98
Add AggTypeFilters to filter out aggs in editor (#19913)
* Add AggTypeFilters to filter out aggs in editor

* Add documentation

* Implement CJ's feedback

* Add link to missing vis variable

* Fix for RxJS 6

* Add babel-core types and fix tests

* Pass index pattern instead of vis

* Fix documentation
2018-06-25 10:34:18 +02:00
Spencer
8fc0fcacc0
[optimizer] allow prod optimizations when running source (#20174) 2018-06-22 14:44:36 -07:00
Justin Kambic
65ce9f0f15
Merge updates from dirty yarn.lock created by 'kbn bootstrap'. (#20169) 2018-06-22 16:44:15 -04:00
Spencer
7f0308b700
[plugin-helpers] use execa so that errors include stdout with helpful info (#20110) 2018-06-22 13:17:10 -07:00
Spencer
d9b31710d0
[dev/precommitHook] log all failures, don't stop at first (#19271) 2018-06-22 12:41:31 -07:00
Shaunak Kashyap
da2da74a08
EUIFication: Grok Debugger (#20027)
* Move <kbn-dev-tools-app> Angular wrapper directive usage into route template

* Move sole directive into new directives folder

* WIP checkin: basic conversion to React components

* Fix sample custom patterns indentation

* Remove custom CSS

* Wrap button in EuiFormRow + define isSimulateDisabled

* Wire up simulate

* Cleanup

* Ace formatting options

* Better styling

* Adding spacing between custom patterns and simulate button

* Fixing form row widths

* Removing form row around button

* Add indentation/newlines in structured output

* Error handling

* Use constants

* Removing no-longer-used code

* Implement syntax highlighting via custom mode

* Making functional tests pass

* Adding trailing comma back

* Removing fixed heights

* Removing unnecessary styles

* Make Event Output form row full width as well

* Wrapping EuiCodeEditors in EuiPanels

* Adding spacer before callout; making spacing around callout consistent

* Clear out custom patterns from request if field is cleared out

* Clear out simulation results before attempting simulation

* Set state with untrimmed value
2018-06-22 11:51:27 -07:00
Rashmi Kulkarni
1ab14f1637
Conversion to ES6 - Discover tests (#20112)
Discover Tests conversion to ES6
2018-06-22 09:38:47 -07:00
Tyler Smalley
3b983e9c22
Include Node.js version in notice file (#20133)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-06-22 07:55:16 -07:00
Stacey Gammon
2c1fcf9604
Typescript-ify screenshot stitcher code in reporting (#20061)
* typescript screenshot stitcher

* Throw an error if the data captured is not of the expected width and height.

* Import babel-core types

* Add babel-core types to x-pack package.json

* Dimensions => Rectangle
2018-06-22 09:18:29 -04:00
Pete Harverson
36d29e4fcc
[ML] Fix link to Single Metric Viewer zoom for sparse data (#20144) 2018-06-22 12:16:17 +01:00
Tyler Smalley
699fb251eb
Adds SCSS support for plugins (#19643)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-06-21 16:25:29 -07:00
Shaunak Kashyap
29f7e4c12b
Updating EUI to 0.0.55 (#20126) 2018-06-21 16:21:10 -07:00
Tyler Smalley
937d14126f
Skip flaky vega test (#20127)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-06-21 13:50:13 -07:00
Tim Sullivan
d0595fdc4b
Separate bulk upload behavior from CollectorSet (#19691)
* Separate bulk upload behavior from CollectorSet

 - takes out a lot of behavior from CollectorSet and moves it to a class called BulkUploader
 - simplifies kibana monitoring init by taking out the indirection that startCollectorSet / createCollectorSet had
 - removes start() method from CollectorSet and calls the collector objects' init() functions from CollectorSet.register()
 - removes cleanup method from collectorSet since that was doing work for bulk uploading

* remove cleanup and fetchAfterInit methods

* test for bulk_uploader class

* improve test for collector_set

* fix reporting

* expose collectorSet if there actually is a collectorSet

* comment for enclosed function

* make collectorSet creation/expose unconditional, bulkUploader more conditional

* fix collector_set tests

* lifecycle events

* stab at collectorSet error logging from the API call

* clean up comments

* clean up comments

* fix BulkUploader mocha test

* check kibanaCollectionEnabled config before registering bulk upload and the plugin status listeners

* no singleton timer object

* just log a warning if bulk uploader start called twice

* normal quotes

* check if bulk is enabled inside of the _fetchAndUpload method

* log for stopping bulk stats

* call bulkUploader.start with the collectorSet object

* call bulkUploader.start with the collectorSet object

* roll back change for module scoped variable

* oops I broke init

* init and logging: if / elseif / elseif

* remove unnecessary check/log

* help log

* remove redundant, use data.filter.map

* use xpackInfo.onLicenseInfoChange not xpackMainPlugin.status.on('green')

* help logging

* fix unit test

* remove handler that stops upload when connection is lost
2018-06-21 13:08:32 -07:00
Justin Kambic
55a43b2805
Fix capitalization typo for className attribute. (#20104) 2018-06-21 10:04:38 -04:00
Pete Harverson
a87c376826
[ML] Fix alignment of text in job wizard remove split button (#20118) 2018-06-21 14:09:09 +01:00
Pete Harverson
c267b4d9e1
[ML] Add missing aria-label attribute to various components (#20117) 2018-06-21 12:21:03 +01:00
John Dorlus
fea9c42d28
[Management] Relationships API test coverage (#19737)
* Added coverage around search and dashboard tests.

* Added tests to check for whether the resource is available. If not, return 404.

* Skipped two tests due to https://github.com/elastic/kibana/issues/19713. Added error handling for relationships API for when no result is found. Return 404.

* Applied patch file per PR.

* Applied Chris patch and tested locally. No failures.

* Removed ajv and utilised joi for schema validation.

* Fixed package.json.

* Copied package.json description from master.

* Reverted package.json and made proper edit.
2018-06-20 15:57:02 -04:00
Stacey Gammon
036d046559
Sync yarn.lock with latest, after running yarn kbn bootstrap on master (#20088) 2018-06-20 14:56:56 -04:00
spalger
53cb1712f4 [kbn-es] update yarn.lock 2018-06-20 11:49:13 -07:00
Spencer
103d71556c
[xpack_main/status] update the plugin status anytime the license changes (#20018)
Fixes #20017 

Currently the xpack_main plugin only sets its status when the elasticsearch plugin changes status, which is a fine signal that the plugin should recheck for the license info, but not the only time it can be updated. At some point recently a race condition became more likely to be triggered, which is detailed in https://github.com/elastic/kibana/issues/20017#issuecomment-398209354 and causes the xpack_main plugin to set its status to red and never return it to green, even after the license info is successfully fetched from Elasticsearch.

To fix this the `XpackInfo` class now exposes the `onLicenseInfoChange(handler)` method which will call the handler whenever the xpack info changes. This way the xpack_main plugin can reflect the current state of the license info in its status and doesn't have to wait for the elasticsearch plugin to change status again.

To test this I recommend running kibana with `--elasticsearch.healthCheck.delay=500` or even `250`, and then starting Elasticsearch after Kibana has started. Without this change Kibana is very likely to attempt a healthcheck between the time that Elasticsearch is "started" and the x-pack license info is completely loaded, triggering the race condition. With this change you should see the xpack info plugin (and all other xpack plugins) go red with a more informative message, and then after the first request or 30 second polling timer, the plugins should go green again.

![screen shot 2018-06-18 at 3 25 47 pm](https://user-images.githubusercontent.com/1329312/41565769-ff032dc0-730c-11e8-978e-3e28ced18448.png)
2018-06-20 11:47:26 -07:00
Chris Earle
75125b49e8
Remove Duplicated Close button from Flyout (#20055)
This removes the now-duplicated Close button from the `EuiFlyout` now that
EUI automatically adds a close button.
2018-06-20 14:42:35 -04:00
Bill McConaghy
aa4cf42b04
adding data-test-subj to buttons and updating snapshots (#20080)
* adding data-test-subj to buttons and updating snapshots

* PR feedback

* updating snapshots
2018-06-20 14:33:48 -04:00
Tim Roes
9f1fd9b93c
Fix one inspector test (#20072) 2018-06-20 14:11:53 +02:00
Tim Roes
2885e871e3
Replace spy panels by Inspector (#16387)
* Add Inspector feature

* So long, and thanks for all the fish, spy panel

* Fix several functional tests

* Fix unit tests

* Fix spy panel button tests

* Replace old spy panel documentation

* Disable test temporarily until we have dashboard triggers

* Enter edit mode for dark theme test

* Fix some more functional tests

* Fix more functional tests

* More test fixing

* Fix more functional tests

* Allow opening the inspector via loader handler

* Refactor InspectorViewChooser, remove unused CSS

* Remove dead code

* Fix data download button style

* Remove redundant code

* Load inspectorViews for dashboard_viewer

* Extract inspector views to custom core_plugin

* Switch API to TypeScript 🎉

* Design changes

* Remove icons from views

* Design changes

* Improve typings of API

* Add typing to all adapters

* Show loading spinner in request selector

* Rewrite InspectorView to TypeScript

* Fix help text for data view

* Remove deprecated React lifecycle methods

* Embed inspector into dashboard panel actions

* Remove temporary inspector trigger

* Remove old CSS

* Fix dashboard trigger for new panel action

* Add tests for InspectorPanel and DataAdapter

* Produce a hierarchical table if the vis is hierarchical

* Remove allowJs option again

* Add missing Apache license headers

* Close inspector on dashboard when navigating away

* Use proper title for dashboard panels

* Fix functional tests

* Skip broken test for now

* Flush view chooser button

* Add request adapter tests

* Skip more tests, broken due to typescript

* Add Request Time description

* Add description for courier request

* Fix tests

* Replace icon by new (not yet released) icon

* Finalize design of inspector

* Remove discover test, that relied on spy panels

* Change API to be properly mockable in tests

* Add aria-live region for request status

* Replace old method in functional tests

* Replace abitrary magic number

* Use object destructuring in vis

* Fix issue with crashing requests view

* Add request time tooltip

* Get request body of correct search source

* Make filter buttons properly keyboard accessible

* Follow Dave's design suggestions

* Remove redundant request from name

* Remove unneeded comments

* WIP raw-formatted values

* Fix filtering issue

* Fix tests and more license headers

* Add data view tests

* Remove search from table

* Fix typos

* Implement review suggestion

* Remove artificial delays for testing

* Fix new panel action structure

* Minor design adjustments

* Fix failing functional test

* Update failing snapshot test

* Implement final wording

* Apply new EUI styling

* Fix closing inspector in tests

* Fix sorting of table

* Align punctuation between tooltips
2018-06-20 11:07:44 +02:00
Peter Pisljar
53e83b5535
fixes filtering on other bucket outside of vislib (#19860) 2018-06-20 08:42:27 +02:00
CJ Cenizal
89e7266853
Remove close buttons from Saved Object relationship and Index Management flyouts. (#20043) 2018-06-19 21:07:18 -07:00
lcawl
92245ac688 [DOCS] Removes 6.0 breaking changes page 2018-06-19 15:16:51 -07:00
Jonathan Budzenski
f40dbd0d26
[build] Remove more files (#19603)
* [build] Remove more files

* rename, add ts and tsx
2018-06-19 15:38:55 -05:00