* [TSVB] Enable string fields for value count aggregation
* fix test title
* Allow all field types for value count aggregation
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* fix template timeline for rule
* fix moving column with linkfield by giving back the browserfield
* leftover from investigate timeline with template from rule
* add visualization for eql sequences in timeline + allow eql investigate to timeline through signal.group.id
* bug fix of column in eventviewer
* review I
* review II
* fix bug - Columns dynamically added to timeline indicate no data
* fix pagination to work as attempted by elastic search
* no tweak on pagination timeline
* fix snapshot
* reset activePage to 0 when changing indexNames
* remove last page when we are not sure if it is really the last page
* update activePage when resetting it by searchParameter
* review bug on the last commit
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Added description to trusted app card.
* Fixed the test and increased the specificity of styling for item details card styles as opposed to using !important.
* Added useMemo.
* Core Telemetry service
* CoreTelemetryService mock
* Add missing config values back, cleanup
* Core usage collector
* HttpConfig path is 'server'
* Fix tests
* CoreTelemetry -> CoreUsageData
* Improve tests / docs
* Fix telemetry_check
* Don't catch fetch function exceptions, let usage collector handle it
* Code review
* Collect saved object index usage data
* Fix tests and telemetry_check
* explicitly import/export usage data types for telemetry_check
* Remove OS data for now, test for SO usage data
* Fix tests
* Polish core docs
* This shouldn't be here
* Update our cross-app links to correctly include Kibana basePaths
- see https://www.elastic.co/guide/en/kibana/master/kibana-navigation.html
- for this change, we need to pass in the `http` lib as another dependency alongside `history` to createHelper
* Update helpers using createHref to pass new expected dependency
- Note that a lot of their createHref tests did not functionally change in output because Kibana mocks an empty basePath ('/') in tests
- Since our other top level pages (settings, credentials, role mappings) aren't yet ready, we'll stick to the same UI for 7.9, only showing the Engines Overview to users
* Upgraded EUI to v29.2.0
* Remove hacks on top of EuiHeaderLink(s)
* Actual update to eui@29.2.0
* Resolve typescript issue when omitting a key over a union
* Resolve nav menu test's expectations
* Fix lint issue
* Update to 29.3.0
* Revert vega snapshot update
I don’t think this was intended to change when I ran the updater
* [ui-shared-deps] strip proptypes from ui-shared-deps production build
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: spalger <spalger@users.noreply.github.com>
* Initial copying of Groups component tree
This commit moves the base component tree from ent-search with the following changes to satisfy pre-commit hooks
- All file names changed to camel_case
- Copyright comment added to the top of each file
- Semicolons and formatting to match Kibana
- Default exports removed from components
- Placeholder keyboard listener functions added to non-interactive elements with click handlers
* Update paths, remove kea typecasting
This commit does the following:
- Updates the paths of the imports
- Removed the need to typecast logic i.e. "as IGroupsLogic" after the Kea hooks
- Fixed a few TypeScript errors with events and return values on functions
- Finally, this commit does away with the ConfirmModal component (was never copied over), as it only wraps 2 EUI components and we decided it was not needed
* Add constants and image
* Update types
- Adds new types
- Moves types needed by server and app to common
* Refactor ContentSection and ViewContentHeader
With the groups components, we needed to add a header action that was right-aligned to ContentSection.
After building what was needed, I realized that the header in the ContentSection was basically a ViewContentHeader with a different sized heading. I refactored ViewContentHeader to have variable sizes and for ContentSection to use that instead.
Also added styles from ent-search
* Add group routes
This is both the server routes and the frontend paths. After conversation with Jonas, we decided to not use the `/org` prefix. Will clean up the other routes as we build out the rest the migration
* Update logic files
This commit converts the logic files for use in Kibana. This includes:
- Using the new Kea 2.2 syntax that uses MakeLogicType to provide types
- Uses the Kibana HttpLogic instead of the rails routes/http
- Adds return types to Actions interfaces
- Adds `path` key to help with debuggin in dev tools
- Removes FashMessages in lieu of separate logic. Because of this, we have to manually clear the flash mesages with listeners where reducers used to do it when the messages were local to the logic file
- Preplaces promises with async/await & try/catch
- Also, in GroupsLogic’s getSearchResults method, we used Kea’s breakpoint functionality and replaced the useDebouce Hook that was used in the component (future commit)
- Uses global lodash per Kibana’s new directive
* Update routers an indexes
This PR configures the routers to work with Kibana
- Updates paths to imports
- Adds top-level styles
For GroupRouter
- Removes AppView
- Use global flash messages
- Remove sidebar and breadcrumbs
* Update GroupOverview
Adds some changes to facilitate the new design for Kibana
- Copy changes
- Layout changes to have buttons inline and not conditionally shown
* Various updates to components
Adds some changes to facilitate the new design for Kibana.
- Remove unnecessary TableHeader
- Adds pencil in lieu of manage button per design
* Update main groups component
A previous commit did this for the components, as the intention was to do this for components in one PR and the others an a separate PR. Unfortunately the build does not pass with all the missing imports.
This commit does the following:
- Updates the paths of the imports
- Removed the need to typecast logic i.e. "as IGroupsLogic" after the Kea hooks
- Fixed a few TypeScript errors with events and return values on functions
- Use global flash messages
- Remove debounces filderValue, as it’s now debounces in logic file
- Remove legacy isCurated props
- Remove legact AppView
* Add sub navigation to main nav
Also removes redundant search link in sidebar
* Update logic file to reset flashmessages correctly
Because we have separated concerns with global flash message state, we now have to manually trigger resets of flash messages with listeners in Kea where we used to be able to use a reducer to listen to changes and reset flash messages.
* Use navigateToUrl for navigation over history.push
Thanks to work by @constance, we can now use the KibanaLogic’s navigateToUrl value to change routes directly from logic files
* Fix failing test
A previous commit removed the redundant Search link from the sidebar nav because of the one in the header. This commit fixes a filing test and now assets on the number of items as the link addresses will be changing as we migrate more components over
* Convert React Router links to our wrappers
* Replace anchors with EuiButtonEmpty
The original pre-commit hooks failed because the anchors didn’t have key handlers. Pleaceholders were added with TODOs and these have been replaced with EuiButtonEmpty, which satisifies the UI needs and passes linting
* Fix a bug where header actions disappearing
There was a bug where changing routes would cause the header action, in the case of Workplace Search the “Go to search application” link, to disappear on route changes.
Turns out that we didn’t need it in the useEffect and that moving it out keeps the unmount from removing the link from the header.
* i18n top-level component and logic files
* i18n for components
* Fix failing test
This was from 3254c6277e
* Fix broken i18n
Had duplicate ids and misnamed value
* Fix a bug where manage group not in Flash message
There is a button that appears in the Flash Message when a new group is added so that the user can navigate to manage the group and, because the order of setting the new group was before the instantiation of the global flashmessages, the button was not appearing. This commit moves the action after the flash message is set.
* Refactor typings
* Refactor ContentSection spacing
The css was not being used and the bottom padding of 44px (xxl + xs spacer) was being generated with spacers. This has been changed to use only CSS
* Remove canCreateInvitations
* Remove hasMessages check rendering FlashMessages
* snake_case telemetry and path
Will convert other paths in a separate PR
* Fix failing tests
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Maps] enable auto fit to bounds by default
* type fixes and functional test fixes
* final tslint fixes
* update jest expect
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
resolves https://github.com/elastic/kibana/issues/79249
The tests that were flaky were capturing a date while the test was running,
and then comparing to a lastExecutionDate field. Most of the time this
worked, but were sometimes out of order because of the way the searches
are done and status changing dynamically. The only current dates we can test
against are really at the very beginning and very end of the tests.
This PR makes the `savedObjectId` parameter optional in the Jira, ServiceNow and IBM Resilient Connectors.
This allows them to execute without this field outside of Alerts, as it is currently populated using the `alertId` which isn't available in other places.
Additionally this adds an optional field in the `Params` Components for all three of the connectors, which allows users to provide a value for the `savedObjectId` field if the so wish.
