Commit graph

23100 commits

Author SHA1 Message Date
spalger 33dc8e6cfd [x-pack/jest/integration] Jest runs setup hook when tests are skipped... 2019-03-11 22:02:38 -07:00
Luke Elmers 08d90d037f
Ensure extra columns are not shown in table vis when showPartialRows:true (#27154) 2019-03-11 21:10:48 -06:00
Spencer 3dadece427 [ci/chromedriver] update chromedriver cache paths to match most recent snapshots 2019-03-11 17:38:06 -07:00
Luke Elmers dad2c0f423
Remove deep clone from courier request handler. (#32806)
We have been deeply cloning the `searchSource.rawResponse` in the courier request handler, in an effort to prevent downstream applications from mutating the response and causing unintended side effects (for example, response data in the inspector will change if rawResponse is mutated).

While this was a sensible preventative measure, it unfortunately created some severe performance problems, particularly when dealing with deeply nested aggregations with a large amount of buckets.

This does the following:

* Stop deeply cloning response data in courier, which earns us some significant performance gains.
* Remove the following cache keys from index patterns which were mutating `searchSource`: $$_flattened, $$_formatted, $$_partialFormatted. They have been replaced with a WeakMap cache that doesn't rely on mutating the source data.
2019-03-11 17:14:33 -06:00
CJ Cenizal 54ebfc1bea
Instrument Index Management with user action telemetry (#32595)
* Fix API endpoint typo indices/clear_caches -> indices/clear_cache.
* Track Index Management index actions.
* Track user actions for opening detail tab and viewing various tabs.
  - Use constants instead of hard-coded strings to identify tabs.
  - Internationalize tab labels.
* Track update settings action.
* Track refresh action.
* Track app load.
2019-03-11 15:55:31 -07:00
Nathan Reese 990a72886f
Add link to Maps docs in Kibana getting started with sample data (#32848)
* Add link to Maps docs in Kibana getting started with sample data

* Update docs/getting-started/add-sample-data.asciidoc

Co-Authored-By: nreese <reese.nathan@gmail.com>
2019-03-11 16:53:54 -06:00
Varun Sharma d301433ca9 Removes Unused react-toggle dependency. (#29086)
* Removes Unused react-toggle dependency.

* PR #29086 Updates yarn.lock
2019-03-11 15:44:23 -07:00
gchaps ab4a6b2980
[Maps][Docs] Updates for Maps Getting Started (#32809)
* [Maps] getting started documentation

* [DOCS] Edits for Maps Getting Started

* [DOCS] Incorporates review comments

* [DOCS] Rewrite section on sample data

* [DOCS] Adds link to add sample data page
2019-03-11 15:40:22 -07:00
Nathan Reese b5c958ea53
[Input controls vis] replace react-input-range with EuiDualRange (#31119)
* [Input controls vis] replace react-input-range with EuiDualRange

* remove unneeded styles

* correctly format I18n with variables

* fix problems with long decimals

* fix one test case

* clean-up error message text, remove extra commas in jest test

* fix bug where values were returned as strings

* use i18n.translate instead of passing formatMessage into isRangeValid

* assert error message in isRangeValid unit test

* changes from node scripts/i18n_check --fix

* remove localization from RangeControl component since it no longer has any text, update snapshots

* another snapshot update

* ensure min and max are not null

* check for value before checking if min/max is null
2019-03-11 16:25:29 -06:00
Casper Hübertz 5664bbe583
[APM] Fixed Error occurrence panel and content (#32808)
* [APM] Fixed styling of Error occurrence panel and content to match the general style.
2019-03-11 21:29:25 +01:00
Spencer f71c091911
temporarily skip flaky test (#32922) 2019-03-11 13:25:01 -07:00
Nathan Reese d324072acc
Remove Dashboard dark theme setion from docs (#32863) 2019-03-11 14:07:34 -06:00
Mike Côté d79f3b5771
Split saved_objects/lib into two folders and separate file per function (#32914) 2019-03-11 16:06:34 -04:00
Peter Goldthorp 2df42f5829 Add a docker run example to Kibana Install doc2 (#32702)
* Add a docker run example to Kibana Install doc2 

See PR #29911

* Update docs/setup/docker.asciidoc

Co-Authored-By: pgoldtho <peter@goldthorp.com>
2019-03-11 20:00:45 +00:00
dave.snider@gmail.com 3ada0259cc
Eui/9.2.1 + better dark mode (#32728)
Updates EUI and makes some dark mode adjustments.
2019-03-11 12:36:06 -07:00
Tim Sullivan 4088c9c1de
[Reporting/fix] include the error object job decryption errors (#32216)
* [Reporting/fix] include the error object in the messages about can't decrypt the job data

+ Prettier fixes

* fix translation string values

* fix i18n

* fix translation files
2019-03-11 11:03:02 -07:00
Luke Elmers 671269ee6a
Add unit tests for embedded_visualize_handler (#32657) 2019-03-11 11:11:53 -06:00
Tim Roes 8b99d78937 Add platform team as core codeowner (#32904) 2019-03-11 12:21:36 -04:00
Hamid 618ab60fe2
[APM] Use correct agent name in instructions (#32896) 2019-03-11 16:49:30 +01:00
Silvia Mitter 49ef5cb923
[APM] update index pattern, add experimental root key (#32185)
* [APM] Add experimental root key to index pattern.

related to https://github.com/elastic/apm-server/pull/1961
2019-03-11 16:28:22 +01:00
Jason Rhodes 63e56963f7
[APM] Fixes various bugs with date picker implementation (#32755)
* Makes sure fromQuery helper properly handles undefined values, adds test

* Adds APM default fallback values to every Kibana link, if no time picker values are currently set

* Changes date picker url updates to push instead of replace in stack

* Fixes bug with chart selection, dragging on charts now updates the URL which triggers all of the date picker updates

* Reverts query param encoding hacks due to fixes in #32732

* Removes unnecessary moment dep in SyncChartGroup

* Updates tests for url changes
2019-03-11 11:00:37 -04:00
Chris Roberson fa51a093b5
Read from api version 7 indices (#32654) 2019-03-11 09:29:17 -04:00
Joe Reuter f935c14dc8 Use embeddable registry in add panel (#31400)
* Prepare control flow to use embeddable factories in add panel

* Rewrite saved object finder and add tests

* Fix usages of new saved object finder

* fix test failures

* fix some functional tests and re-introduce makeUrl

* fix tests

* remove direct hrefs in saved_object_lists

* PR review fixes

* update snapshot

* overwrite width of viz dialog

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.ts

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* fix tests

* review fixes #1

* review fixes #2

* dont use classname in functional test

* remove call to action button prop

* align buttons correctly

* fix tests

* remove debugging statement

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* review fixes #3

* improve filter behavior and enable it for search wizard

* adjust functional tests for new filter behavior

* Change translation id due to string change

* Update Jest snapshot
2019-03-11 12:27:13 +01:00
Pete Harverson 1ebe64fd4d
[ML] Adds anomaly time to aria label for anomalies table actions button (#32777)
* [ML] Adds anomaly time to aria label for anomalies table actions button

* [ML] Update CHinese translation for edited table actions button
2019-03-11 09:44:09 +00:00
Joe Reuter e2e55bc08c fix missing axis labels when changing vertical bar chart to horizontal bar chart (#32628) 2019-03-11 09:44:38 +01:00
Spencer 319921ebfc
[chrome] strip # from hash before updating $location (#32732)
* add functional test to prove regression

* [chrome] strip # from hash before updating $location

* add opt-out level for disabling auto fix, disable in APM
2019-03-10 13:34:56 -07:00
Daniil Suleiman 97f8145fd5
Add ellipsis to TopN table (#30931)
* Add ellipsis to TopN table

* Change max-width calculation from 20% to 35%

* Support window resizing
2019-03-10 23:31:13 +03:00
spalger bbe106aea1 [mgmt/scriptFields] use better assertions to help debug #32862 2019-03-10 12:20:03 -07:00
Clint Andrew Hall 3a784d7584
[canvas] Fix resolved_args sync issue when deleting a page (#32835)
## Summary

(closes #32788)

This PR fixes an issue where the Element Stats panel is not in sync with the workpad.  This is due to `resolved_args` in transient state not reflecting the actual elements on the workpad.  This PR introduces middleware to Redux to ensure `resolved_args` is synced with the `elements` whenever a deletion is detected.

This middleware may be expanded in the future to keep these two collections in sync.
2019-03-09 21:00:37 -08:00
spalger ac5da1ec94 [ci/packer] fix type and skip delete of kibana checkout 2019-03-09 11:03:06 -08:00
spalger 6a0d45ad90 [ci/packer] delete master repo before creating 7.x bootstrap cache 2019-03-09 08:48:46 -08:00
spalger fdffb06881 [ci] remove 7.x bootstrap cache build, running out of disk on workers 2019-03-08 16:07:37 -08:00
Catherine Liu 4b5d7b1d83
[Canvas] Fixes workpad update error for read only users (#32831)
* waits for write permission test before loading workpad

* Adds setRefreshInterval to list of skipped actions in es_persist
2019-03-08 16:26:05 -07:00
Spencer 8d92a940fa
[ts] add script to verify that all ts is in a project (#32727)
Based on #32705 

We currently have TypeScript code that was backported to 7.0, which was backported without issue because it falls outside of any TypeScript projects in 7.0. This means that the pre-commit hooks break on changes to these files, and that they are not getting type checked by the type_check script. To fix this we need to verify that every typescript file in the repository is covered by a tsconfig.json file as part of CI.
2019-03-08 13:51:55 -08:00
Spencer 5f6ff8b4c2
[jest/junit] fix junit reporter (#32686)
Fixes https://github.com/elastic/kibana/issues/32619

With #31825 the reporter contract changed slightly and this updates our custom reporter to fix our junit reports.
2019-03-08 13:46:01 -08:00
spalger 10d27eacbb [ci] build packer cache for other branches 2019-03-08 13:25:16 -08:00
Andrew Cholakian be952c9e35
[Uptime] Add i18n to plugin name in sidebar (#32586)
Fixes https://github.com/elastic/kibana/issues/32052
2019-03-08 15:03:47 -06:00
Spencer 441c3dddbe
[ci] derive bootstrap cache path from base branch, make optional (#32793)
* [ci] derive bootstrap cache path from base branch, make optional

* describe the path we're looking for in warning

* use PR_TARGET_BRANCH, not PR_SOURCE_BRANCH
2019-03-08 12:38:52 -08:00
Spencer ccb3a51f12
[master] [reporting/autoDownload] default to true when not in distributable (#32803) (#32805)
Backports the following commits to master:
 - [reporting/autoDownload] default to true when not in distributable (#32803) (3c3183f)
2019-03-08 12:35:50 -08:00
Clint Andrew Hall 41e68ebbe9
[intepreter][Canvas] Dedupe server functions in batched requests (#32712)
* [intepreter][Canvas] Dedupe server functions in batched requests

* Add and correct tests
2019-03-08 13:15:58 -06:00
Casper Hübertz 9e486077b6
[APM] Design - General layout updates (#32750)
* Remove default background color

* Wrapping graphs and tables in EuiPanel

* Adding titles to Transactions and Errors list tables
2019-03-08 20:09:44 +01:00
Joe Fleming d88f90186e
Fix: show actual errors on failed elements, handle null values from functions (#32600)
Closes https://github.com/elastic/kibana/issues/32356 

This PR fixes two issues.

The first there was an issue filed, #32356:

- Show non-Boom errors instead of asking users to look at server logs
  - Also write the error to the server when asking them to look there

### Before

![](https://user-images.githubusercontent.com/404731/53673728-9368b180-3c46-11e9-912e-7aaff25d3ddf.png)
*If the function failed for some reason, this is all you'd ever see*

### After

![screenshot 2019-03-06 16 24 09](https://user-images.githubusercontent.com/404731/53921029-4d3b9580-402c-11e9-85bf-21ab31e952bc.png)
*Errors are shown to the user*

![screenshot 2019-03-06 16 26 16](https://user-images.githubusercontent.com/404731/53921130-a0154d00-402c-11e9-9cb5-102d360a69f8.png)
*Code errors bubble up correctly as well*

---

The other I didn't bother opening an issue for:

- Fixes issue where functions that return `null` produce an error message
  - `null` is a valid thing to return, it's only `undefined` that causes a problem
  - This was only a problem for server functions that return `null` (currently, none of them do)
  - Introduced in #31298
  - Discovered when I ran into casting problems (see https://github.com/elastic/kibana/issues/32597)

### Before

![screenshot 2019-03-06 16 18 17](https://user-images.githubusercontent.com/404731/53921039-562c6700-402c-11e9-9650-fc51d1f91643.png)

### After

![screenshot 2019-03-06 16 19 01](https://user-images.githubusercontent.com/404731/53921044-5cbade80-402c-11e9-9cde-fdb49334dcd0.png)
2019-03-08 11:48:11 -07:00
Mike Côté 7cf91316ca
Basic server side import API for saved objects (#32158)
* Initial work

* Add overwrite and skip support

* Cleanup and add tests

* Move code into separate files

* Remove reduce

* New API parameters

* Add support to replace references

* Add better error handling

* Add spaces tests

* Fix return type in collectSavedObjects

* Apply PR feedback

* Update jest tests due to jest version upgrade

* Add docs

* WIP

* Split import routes pt1

* Add tests

* Fix broken tests

* Update docs and fix broken test

* Add successCount to _import endpoint

* Make skip by default in resolution API

* Update tests for removal of skips

* Add back support for skips

* Add success count

* Add back resolve import conflicts x-pack tests

* Remove writev from filter stream

* Delete _mock_server.d.ts file

* Rename lib/import_saved_objects to lib/import

* Filter records at stream level for conflict resolution

* Update docs

* Add tests to validate documentation

* Return 200 instead of other code for errors, include errors array

* Change [] to {}

* Apply PR feedback

* Fix import object limit to not return 500

* Change some wording in the docs

* Fix status code

* Apply PR feedback pt2

* Lower maxImportPayloadBytes to 10MB

* Add unknown type tests for import

* Add unknown type tests for resolve_import_conflicts

* Fix tslint issues
2019-03-08 13:18:36 -05:00
Pete Harverson a1a9511446
[ML] Edits data recognizer modules to use KQL in saved objects (#32766) 2019-03-08 16:35:20 +00:00
Caroline Horn 59ad77d5cb
[Vis Editor] Fix geohash checkbox group spacing (#32664)
- And alignment of text in visEditorSidebar__collapsibleTitle
- And size of advanced toggle text
2019-03-08 10:33:23 -05:00
Casper Hübertz 3a3211b72a
[APM] Distribution histogram - Replaced custom tooltip with EuiIconTip (#32753)
* Replaced with EuiIconTip
2019-03-08 16:02:42 +01:00
Søren Louv-Jansen d2e16b5da5
[APM] Improve types for tabs and properties table (#32462)
* [APM] Improve types for tabs

* Update translations

* Rename Tab to PropertyTab

* Add comment about agent names
2019-03-08 10:15:52 +01:00
James Gowdy cc7788d537
[ML] Removing duplicate calendars list in job management (#32647) 2019-03-08 08:03:04 +00:00
Robert Monfera c59db910c3
[Canvas] Fix: lose element selection on page flip (#32111)
* Fix: lose element selection on page flip

* Fix: remove selection in Redux too (PR feedback from Joe)
2019-03-08 07:06:17 +01:00
Mat Schaffer 87f1befd18
Swap defaultAddId with defaultRoute in example config (#28547)
Connected to https://github.com/elastic/kibana/issues/6902
2019-03-08 14:38:31 +09:00