* First pass
* First pass
* Add new routes
* Getting closer
* Remove legacy server code, and other fixes
* Register the plugin with xpack
* Pass a legacy client to telemetry
* Suport callWithInternalUser
* Remove this
* More NP work
* Fix some tests
* Fix broken test
* Move over new telemetry changes, and fix other issues
* Fix TODO item
* Reuse the same schema as elasticsearch module
* Use a singular config definition here
* Disable this for now
* Use the right method
* Use custom config again
* Tweak the config to make this optional
* Remove these
* Remove these unnecessary files
* Fix jest test
* Fix some linting issues
* Fix type issue
* Fix localization issues
* Use the elasticsearch config
* Remove todos
* Fix this check
* Move kibana alerting over
* PR feedback
* Use new metrics core service
* Change config for xpack_api_polling_frequency_millis
* Make sure this is disabled for now
* Disable both
* Update this to the new function
* Tighten up legacy api needs
* Check for existence
* Fix jest tests
* Cleaning up the plugin definition
* Create custom type in our plugin
* Revert this change
* Fix CI issues
* Add these tests back
* Just use a different collector type
* Handle errors better
* Use custom type
* PR feedback
* Fix type issues
* PR feedback
Enables the FT that tests the View inApp functionality.
It addresses an issue that causes a race condition on CI where the ViewInApp button was thought to be enabled when it was, in fact, still disabled.
This meant that the click on the button didn't trigger the handler which, in turn, made the test fail.
* Define minimum license required for each action type (#58668)
* Add minimum required license
* Require at least gold license as a minimum license required on third party action types
* Use strings for license references
* Ensure license type is valid
* Fix some tests
* Add servicenow to gold
* Add tests
* Set license requirements on other built in action types
* Use jest.Mocked<ActionType> instead
* Change servicenow to platinum
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Make actions config mock and license state mock use factory pattern and jest mocks (#59370)
* Add license checks to action HTTP APIs (#59153)
* Initial work
* Handle errors in update action API
* Add unit tests for APIs
* Make action executor throw when action type isn't enabled
* Add test suite for basic license
* Fix ESLint errors
* Fix failing tests
* Attempt 1 to fix CI
* ESLint fixes
* Create sendResponse function on ActionTypeDisabledError
* Make disabled action types by config return 403
* Remove switch case
* Fix ESLint
* Add license checks within alerting / actions framework (#59699)
* Initial work
* Handle errors in update action API
* Add unit tests for APIs
* Verify action type before scheduling action task
* Make actions plugin.execute throw error if action type is disabled
* Bug fixes
* Make action executor throw when action type isn't enabled
* Add test suite for basic license
* Fix ESLint errors
* Stop action task from re-running when license check fails
* Fix failing tests
* Attempt 1 to fix CI
* ESLint fixes
* Create sendResponse function on ActionTypeDisabledError
* Make disabled action types by config return 403
* Remove switch case
* Fix ESLint
* Fix confusing assertion
* Add comment explaining double mock
* Log warning when alert action isn't scheduled
* Disable action types in UI when license doesn't support it (#59819)
* Initial work
* Handle errors in update action API
* Add unit tests for APIs
* Verify action type before scheduling action task
* Make actions plugin.execute throw error if action type is disabled
* Bug fixes
* Make action executor throw when action type isn't enabled
* Add test suite for basic license
* Fix ESLint errors
* Stop action task from re-running when license check fails
* Fix failing tests
* Attempt 1 to fix CI
* ESLint fixes
* Return enabledInConfig and enabledInLicense from actions get types API
* Disable cards that have invalid license in create connector flyout
* Create sendResponse function on ActionTypeDisabledError
* Make disabled action types by config return 403
* Remove switch case
* Fix ESLint
* Disable when creating alert action
* Return minimumLicenseRequired in /types API
* Disable row in connectors when action type is disabled
* Fix failing jest test
* Some refactoring
* Card in edit alert flyout
* Sort action types by name
* Add tooltips to create connector action type selector
* Add tooltips to alert flyout action type selector
* Add get more actions link in alert flyout
* Add callout when creating a connector
* Typos
* remove float right and use flexgroup
* replace pixels with eui variables
* turn on sass lint for triggers_actions_ui dir
* trying to add padding around cards
* Add callout in edit alert screen when some actions are disabled
* improve card selection for Add Connector flyout
* Fix cards for create connector
* Add tests
* ESLint issue
* Cleanup
* Cleanup pt2
* Fix type check errors
* moving to 3-columns cards for connector selection
* Change re-enable to enable terminology
* Revert "Change re-enable to enable terminology"
This reverts commit b497dfd6b6.
* Add re-enable comment
* Remove unecessary fragment
* Add type to actionTypeNodes
* Fix EuiLink to not have opacity of 0.7 when not hovered
* design cleanup in progress
* updating classNames
* using EuiIconTip
* Remove label on icon tip
* Fix failing jest test
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
* Add index to .index action type test
* PR feedback
* Add isErrorThatHandlesItsOwnResponse
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
* Implemented ability to clear and properly validate alert interval
* Fixed due to comments
* Fixed additional request for the last field
* Fixed failing test
* Layers dir up through sources migrated. Kibana services updated
* Create separate init method for plugin setup, leverage in embeddable factory
* Add NP timefilter, http, IndexPatternSelect
* Pull vis color utils into Maps
* Add NP dark mode and toast handling. Some fixes
* Init autocomplete and indexPattern via normal paths
* Test fixes and clean up
* Update index pattern and autocomplete refs. Make getters functions
* Fix remaining broken jest tests
* Update inspector start contract
* Clean up plugin and legacy files. Fix type issues
* Set inspector in plugin start method not external function
* Keep both injected var functions (legacy and NP). Move inspector init back to separate init function
* Add back ts-ignore on NP kibana services import
* update layout
* add utility bars
* add icon
* adding a route for exporting timeline
* organizing data
* fix types
* fix incorrect props for timeline table
* add export timeline to tables action
* fix types
* add client side unit test
* add server-side unit test
* fix title for delete timelines
* fix unit tests
* update snapshot
* fix dependency
* add table ref
* remove custom link
* remove custom links
* Update x-pack/legacy/plugins/siem/common/constants.ts
Co-Authored-By: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
* remove type ExportTimelineIds
* reduce props
* Get notes and pinned events by timeline id
* combine notes and pinned events data
* fix unit test
* fix type error
* fix type error
* fix unit tests
* fix for review
* clean up generic downloader
* review with angela
* review utils
* fix for code review
* fix for review
* fix tests
* review
* fix title of delete modal
* remove an extra bracket
Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Also move the hook use_ui_ace_keyboard_mode.tsx into es_ui_shared
This was defined (and used) in both Console and SearchProfiler.
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [canvas/shareable_runtime] sync sass loaders with kbn/optimizer
* limit sass options to those relevant in this context
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Fix updating of ML rules
* Add a regression test for updating ML Rules
* Allow ML Rules to be patched
And adds a regression unit test.
* Allow ML rule params to be imported when overwriting
* Add a basic regression test for creating a rule with ML params
* Prevent users from changing an existing Rule's type
* boundary test for first alert retrieval
* boundary test for first alert retrieval cleaned up
* redo merge conflict resolving for api test
* redo merge conflict resolving for api test try 2
* updating to current dataset expectations
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
- Fixes regression caused by elastic/elasticsearch#53572.
- Adjusts the TS mappings and code to reflect the newly returned API response.
- Re-enables functional tests.
* WIP trying things.
Add new alert type for Uptime.
Add defensive checks to alert executor.
Move status check code to dedicated adapter function.
Clean up code.
* Port adapter function to dedicated file.
* WIP.
* Working on parameter selection.
* Selector expressions working.
* Working on actions.
* Change anchor prop for popovers.
* Reference migrated alerting plugin.
* Clean up code for draft.
* Add button to expose flyout. Clean up some client code.
* Add test for requests function, add support for filters.
* Reorganize and clean up files.
* Add location and filter support to monitor status request function.
* Add tests for monitor status request function.
* Specify default action group id in alert registration.
* Extract repeated string value to a constant.
* Move test file to server in NP plugin.
* Update imports after NP migration.
* Fix UI bug that caused incorrect location selections in alert creation.
* Change alert expression language to clarify meaning.
* Add ability for user to select timerange units.
* Add code that fixes active item highlighting.
* Add better default value for active index selection.
* Introduce dedicated field number component.
* Add message to status check alert.
* Add tests for context message.
* Formalize alert action group definitions.
* Extract monitor id squashing from context message generator.
* Write test for monitor ID uniqueness function.
* Add alert state creator function and tests.
* Update action group id value.
* Add tests for alert factory and executor function.
* Rename alert context props to be more domain-specific.
* Clean up unnecessary type markup.
* Clean up alert ui controls file.
* Better organize new registration code.
* Simplify some logic code.
* Clean up bootstrap code.
* Add unit tests for alert type.
* Delete temporary test code from triggers_actions_ui.
* Rename a test file.
* Add some comments to annotate a file.
* Add io-ts type checking to alert create validation and alert executor.
* Add translation of plaintext content string.
* Further simplify monitor status alert validation.
* Add io-ts type checking to alert params.
* Update a comment.
* Prefer inline snapshots to more error-prone assertions.
* Clean up and comment request function.
* Rename a symbol.
* Fix broken types in reducer file and add a test.
* Fix a validation logic error and add tests.
* Delete unused import.
* Delete obsolete dependency.
* Fix function call to have correct parameters.
* Fixing some import weirdness.
* Reintroduce accidentally-deleted code.
* Delete unneeded require from legacy entry file.
* Remove unneeded connected component.
* Update flyout controls for new interface and delete connected components.
* Remove unneeded require from app index file.
* Introduce data-test-subj attributes to various components to assist with functional tests.
* Introduce functional test helpers for alert flyout.
* Add functional test arch and a test for alerting UI to ES SSL test suite.
* Add explicit exports to module index.
* Reorganize file to keep interfaces closer to their implementations.
* Move create alert button to better position.
* Clean up a file.
* Update a functional test attribute, clean up a file, rename a selector, add tests.
* Add a comment.
* Make better default alert message, translate messages, add/update tests.
* Fix broken type.
* Update obsolete snapshot.
* Introduce mock provider to tests and update snapshots.
* Reduce a strange type to `any`.
* Add alert flyout button connected component.
* Add alert flyout wrapper connected component.
* Create connected component for alert monitor status alert.
* Clean up index files.
* Update i18nrc file to cover translation in server plugin code.
* Fix broken imports.
* Update test snapshots.
* Prefer more descriptive type.
* Prefer more descriptive type.
* Prefer built-in React propType to custom.
* Prefer simpler validation.
* Add whitespace to clean up file.
* Extract function and write tests.
* Simplify validation function.
* Add navigate to alerting button.
* Move context item inside the items list.
* Clean up alert creation component.
* Update type check parsing and error messaging, and update snapshot/test assertions.
* Update broken snapshot.
* Update README for running functional tests.
* Update functional test service to reflect improved UX.
* Fix broken type that resulted from a mistake during a merge resolution.
* Add spacer between alert title and kuery bar.
* Update the id and name of our alert type because it was never changed from placeholder value.
* Rename alert keys.
* Fix broken unit tests.
* Add aria-labels to alert UI.
* Implement design feedback.
* Fix broken test snapshots.
* Add missing props to unit tests to staisfy updated types.
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Clean up use of ace in autocomplete in public
Remove ace from lib/autocomplete.ts and set up hooking up of ace
in legacy_core_editor. Also remove use of ace mocks in tests.
* Added TODO in lib/kb (console public)
* Server-side cleanup
Refactored the loading of spec into a new SpecDefinitionsService.
In this way, state can be contained inside of the service as much
as possible. Also converted all JS spec to TS and updated the
Console plugin contract so that processors (which alter loaded
spec) happen at plugin "start" phase.
* Fix types
* Small refactor
- Updated naming of argument variable in registerAutocompleter
- Refactored the SpecDefinitionsService to handle binding of
it's own functions
* Public in WiP state, removed all 'ui/' imports
* First iteration of public shimmed and working
* A whole lotta WIP server side
* Server-side to using the NP router + client side changes
Updated the client code to properly encode requests to the
server. Did first E2E test.
Route tests are probably broken, need to fix them.
* Removed unused error wrapping code
* Update client Jest tests
* Add breadcrumbs service mock
* Fix server side Jest tests
* Add helper functions file for server side Jest tests
* Fix API integration tests
* Fixed boolean logic mistake in due to refactor in index mgmt ext.
Also migrated to the a more NP friendly version of index mgmt
extension.
* Remove unused import
* Clean up some cruft and refactor URL variable names
* Fix stringification of body and fix boolean server logic
* Fix mocha
Folder called __tests__ with Jest tests was breaking mocha.
* Refactor to Jest test
* Fix types issues in jest test
* Migrate to new config-schema API
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
