Commit graph

15937 commits

Author SHA1 Message Date
Jonathan Budzenski
3a50fd2efc [docs] Add path.data to setup instructions (#13513)
* [docs] Add path.data to setup instructions

* [docs] Add path.data to rpm and deb table
2017-08-31 10:16:50 -05:00
Jonathan Budzenski
eaf026b49b [docs] Remove .kibana dynamic mappings section (#13671) 2017-08-31 10:07:05 -05:00
Jonathan Budzenski
811a2f2253 [saved objects] Timestamp all documents (#13503) 2017-08-31 09:40:08 -05:00
Tim Roes
301452ffcb Improve accessibility of the visualize editor (#13780)
* Use aria-expanded and better labels for agg collapsables

* Fix all agg options collapsables, fix #12892

* Label all vis editor inputs correctly, fix #11859

* Fix broken functional test
2017-08-31 11:46:02 +02:00
Peter Pisljar
9786e453c3 visual builder should set vis.initialized when ready (#13779)
* tsvb needs to set vis.initialized

* adding visual builder integration test
2017-08-31 08:57:34 +02:00
jerenmb
6dfde4f793 Spelling corrections (#11908) 2017-08-30 10:52:13 -04:00
Stacey Gammon
fa2edcaf20 Investigate flaky add new visualization link test (#13755) 2017-08-30 09:42:04 -04:00
Peter Pisljar
c3c07ef8c4 visualize should wait for visualization to finish initialization (#13742)
* visualize should wait for visualization to finish initialization

* clear timeout on destroy

* fixing based on stacey's review
2017-08-30 08:31:56 +02:00
archana
a01959451b Complete doc on running functional tests (#13035)
* Complete doc on running functional tests

* Update development-functional-tests.asciidoc

* Fix section title
2017-08-29 16:48:57 -05:00
Matt Bargar
3043ee78c8 Check sort:options for Discover default sort order (#13708)
* Check sort:options for Discover default sort order

I went back and forth on a lot of different solutions for this.

Initially I thought it would make sense to just allow users to set a
default saved search in Discover. There were some problems with that
approach though. It would change the default workflow in Discover.
Instead of starting with an unsaved search, users would be editing a
saved search by default. I could see this leading to a lot of
unintentional changes to the default. The settings from the default
saved search also wouldn't carry over to new searches, which I think
would be desirable most of the time.

I also considered adding a new advanced setting for specifying a default
sort field/direction. This kind of setting would make more sense at the
index pattern level though. One field may not be valid across all index
patterns.

So I ended up going with the simplest solution. It solves the issue
identified by the author of the linked issue and nothing more. If a sort
order is specified in the existing sort:options advanced setting, we'll
use that direction when sorting on the index pattern's timestamp field
by default.

Fixes https://github.com/elastic/kibana/issues/5164

* Create a new advanced setting instead of re-using sort:options

* Just pass a default order
2017-08-29 15:42:36 -04:00
Johnny Lim
b6153fa302 Fix extracted Kibana directory names in doc (#13658) 2017-08-29 09:28:22 -07:00
Peter Pisljar
3548a57dcf fix heatmap sizing on dashboard (#13636)
* category axes should be rendered from last to first for heatmap to work correctly

* adding a test
2017-08-29 13:41:56 +02:00
Tim Roes
4ddad1a24b Improve accessibility of visualization view (#13726)
* Use correct aria-label react attribute

* Label TSVB auto apply button, fix #12900

* Create possibility to conditionally disable input-focus directive

* Disable auto focus when creating a new viz, fix #12888

* Fix styling of label in TSVB

* Disable auto focus in visualizations, fix #11856

* Fix disable of auto focus

* Disable auto focus of index selection in vis wizard
2017-08-29 12:22:32 +02:00
Tim Roes
d22f4eec0b Make breadcrumb a heading for screen readers, fix #12885 (#13734)
* Make breadcrumb a heading for screen readers, fix #12885

* Use h2 in vis wizard step 2
2017-08-29 12:05:14 +02:00
Peter Pisljar
68fd903e77 time picker should be displayed only if index pattern has time field (#13640)
* time picker should be displayed only if index pattern has time field

* fixing based on review from lukas
2017-08-29 11:03:01 +02:00
Peter Pisljar
8e52410ff6 custom value axis should not be overriden (#13639) 2017-08-29 10:30:00 +02:00
Matt Bargar
53d81c86ce Fix relative z-index of spy panel and filter editor (#13717)
* Fixes relative z-index of spy panel and filter editor

* Position sidebar above main content so collapser button remains clickable
2017-08-28 17:26:32 -04:00
Chris Cowan
9257f21ba3 Closes #13471 - Change split behavior of gauges and metrics vis (#13583)
* Closes #13471 - Change split behavior of gauges and metrics vis

* removing old css classes
2017-08-28 11:35:03 -07:00
Jonathan Budzenski
25b2937756 Ignore package-lock.json (#13731) 2017-08-28 11:10:59 -05:00
Chris Cowan
d623451e3e Fixes #13010 - Add config to react vis; Adding dateFormat to all visualziations that display dates (#13626) 2017-08-28 09:09:46 -07:00
Matt Bargar
f1ac9e3595 Fix blank index pattern selector in Discover (#13715)
ui-select-match's expression was expecting an IndexPattern object, but
the indexPatternList passed to ui-select-choices contained SavedObject
instances due to the [SavedObjectsClient refactor][1]. This wasn't a
problem most of the time because switching index patterns caused the
entire directive to get destroyed and re-created. However, when the
directive didn't get re-created (for example, when clicking the already
selected pattern) it would result in a blank select box.

Fixes https://github.com/elastic/kibana/issues/13080

[1]: https://github.com/elastic/kibana/pull/12719
2017-08-28 10:59:01 -04:00
trevan
d3f7b0d40d Clamp the centroid to stay within the box boundaries (#13581)
* Clamp the centroid to stay within the box boundaries

If a document has two or more geo fields, then the centroid calculation
will place the centroid in between the two geo fields. This can cause
the centroid to be in the middle of nowhere so clamp it to keep it
closer to where it should be.

* Add geocentroid and clamping tests
2017-08-28 13:48:11 +02:00
Peter Pisljar
185fb4cc1a fixing disabling aggregations (#13686) 2017-08-28 13:10:03 +02:00
Søren Louv-Jansen
52552a93ef Update react 15.6.1 (#13672) 2017-08-28 10:27:51 +02:00
Lukas Olson
19ac99a388 Re-enable filter editor suggestions (#13376)
* Re-enable filter editor suggestions

* Use search instead of include

* Escape query

* Show spinner

* Use include rather than search

* Add additional regex and explanation for parameters

* Add suggestions API test

* Make sure test actually runs

* Use send instead of query

* Fix suggestions API test
2017-08-25 16:38:49 -07:00
CJ Cenizal
e724571426 Use aria-label in TSVB React components, instead of ariaLabel. (#13714) 2017-08-25 15:27:08 -07:00
Spencer
2eae80cd0c Upgrade Angular to 1.6.5 (#13543)
* [angular/$http] remove use of .success() and .error() callbacks

* [angular/$route] remove `!` hash prefix

* [angular] upgrade

* [angular/$timeout] prevent unhandled exception "canceled" logging

* [ui/fancy_form] refactor FormController for compatibility

* [ngModelController] ensure method calls keep context

* [ui/queryBar/tests] attach $elem to DOM so "click" triggers "submit"

* [confirmModalPromise] fix test for rejected promise

* [watchMulti] specifically check watchers array for length

* [typeahead] check for property rather than own keys

* [ui/compat] add initAfterBindingsWorkaround

* [ui/fancyForms] fix _getInvalidModels()

* [fancyForm] add tests that check nested form error counting

* [ui/fancyForms] ensure that submit is blocked properly

* [ui/fancyForms] escalate soft errors on failed submit

* [ui/fancyForms] bind handlers to this in constructor

* [uiBootstrap/tooltip] describe the new error handling

* [ui/confirmModalPromise] use more sinon assertions

* [$http] resp => data before old .success() and .error() handlers

* [indices/createWizard] apply callAfterBindings workarounds
2017-08-25 14:50:11 -07:00
Spencer
8ba33e7eed remove old maps stuff (#13657) 2017-08-25 13:28:57 -07:00
Spencer
f7721fe420 [visualize] Fix agg param race (#13429)
* [visualize/aggConfig] do not rely on the view to reset params

* [vis/editor/aggParams] check for agg and type before accessing
2017-08-25 12:54:36 -07:00
Nathan Reese
5619dbeaa9 Keep current cursor or top line in view when resizing Console to avoid losing user context (#13695)
* keep current cursor or top line in view when resizing to avoid losing user context

* rename variable to more descriptive name

* move state from editor to smart_resize
2017-08-25 12:32:24 -06:00
Nathan Reese
6115d8594d Map filter not set appropriately when spy panel is open (#13678)
* get dimensions from parent elements when map has not height or width

* clean up test variable names
2017-08-25 09:39:43 -06:00
Nathan Reese
51dd98931a Dashboard dark-theme fixes (#13690)
* fix 13421 - filter overlay obscuring saved search table

* fix 13553 - Dashboard dark theme borders in edit mode don't appear
2017-08-25 08:50:38 -06:00
Jonathan Budzenski
38b13c7a67 [console] Don't infer request method (#13694) 2017-08-25 09:41:27 -05:00
Tyler Smalley
3f84c89f03 Changes verbage for opening an existing pattern (#13697)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-08-25 07:18:38 -07:00
Tim Roes
c96481d950 Allow reordering aggregation priority by keyboard (#13635)
* Make aggs sortable by keyboard, fix #11858

* Add keyboard_move tests

* Use $parse instead of creating a child scope

* Use keyCodes from ui_framework
2017-08-25 10:10:59 +02:00
Tim Roes
3b1e1e5a15 Refactor keycode exporting in ui_framework (#13663)
* Refactor keycode exporting in ui_framework

* Replace all uses of ENTER_KEY and SPACE_KEY

* Use ESCAPE instead of ESC universally

* Rename keycodes -> keyCodes

* Replace keyCodes in advanced_row
2017-08-24 21:25:52 +02:00
CJ Cenizal
fcd4ddfb2d [Accessibility] Give kuiTables keyboard-accessible column headers (#13586)
* Make KuiTable headers keyboard-accessible in UI Framework.
* Use flexbox to consistently apply spacing between table header cell text and sort icon.
* Add aria-label attributes to KuiTableHeaderCell, KuiTableHeaderCheckBoxCell, and KuiTableRowCheckBoxCell.
* Update Jest snapshots.
* Update Dashboard listing table with new markup.
* Update Saved Objects tables with new markup.
* Update Settings table with new markup.
* Update Visualize listing table with new markup.
* Remove padding-right for cells containing checkboxes.
* Update sortableColumn directive with new markup.
2017-08-24 11:48:04 -07:00
Thomas Neirynck
741b5d4d8a exclude filter agg from visualizations (#13680) 2017-08-24 12:20:26 -04:00
Chris Roberson
9175137c57 "Create index pattern" wizard. (#13454)
* Create Index Pattern Creation wizard.
- Create a directive for each step in the wizard.
- Reorganize files into conventional folder structure.
- Rename files with more conventional and consistent naming patterns.
- Display indices, partial matches, exact matches.
- Add loading, empty, and success states.
- Add option to include system indices.

* Temp: comment out and mock getIndices functionality.

* Hook up data seaching

* Add for/id connections for form inputs and labels

* Automatically append a wildcard

* Highlight the index pattern in the results

* Ensure we only remove the last character if it's a `*`

* Auto hide index pattern id controls

* Ensure this link is tabbable

* Move the advanced fields down

* Use toggle button

* This shouldn't ever be required

* Revert "This shouldn't ever be required"

This reverts commit b6e31e79308271e7f04ea1d42ce66e32e7aa0612.

* Update based on comments in PR

* Ffew more changes

* Port changes from Tyler's PR, https://github.com/elastic/kibana/pull/13353

* Remove unnecessary file

* Fix broken functional tests

* Copy changes

* Fix functional tests

* Remove loading from the main select, and move to an additional select

* Show help text when loading

* Fix sorting

* Fixing broken functional tests

* Couple changes from PR review

* Ensure input field does not show a red border until touched

* More descriptive and consistent copy
2017-08-24 09:04:28 -04:00
Tyler Smalley
4bbd127626 Removes webpack-directory-name-as-main dependency (#13584)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-08-23 08:21:32 -07:00
Tim Roes
d3a62e85a5 Remove custom keyboard mode in datepicker (#13644) 2017-08-23 16:31:00 +02:00
Court Ewing
7b836f91b2 Shortcut to build asciidocs (#13164)
* Shortcut to build asciidocs

The command to build the Kibana docs using the elastic/docs repo can be
easy to forget, so this script is an easy to way to do it right every
time.

* Configurable docs repo location

For folks that clone the elastic docs repo to a different location than
as a sibling of kibana.
2017-08-23 10:27:34 -04:00
Peter Pisljar
4117520f18 don't hide metric if show labels is false (#13637) 2017-08-23 14:37:46 +02:00
Thomas Neirynck
094587c884 Add interval doc (#13629) 2017-08-22 23:42:36 -04:00
Johnny Lim
8cceb73710 Use "curl -O" for Darwin (#13602) 2017-08-22 17:49:15 -07:00
Nathan Reese
599c8c4220 Upgrade kibana to leaflet 1.x (#12367)
* upgrade leaflet modules to 1.x latest

* fix css for leaflet controls

* update draw options so it is easier to see polygon when drawing

* fix chrome touch issues with closing polygon in leaflet draw

* use canvas renderer

* use leaflet-responsive-popup to avoid tooltip cutoff

* remove radius configuration from leaflet heatmap

* make blur a factor of radius. Set maxZoom to map zoom since new values are calculated per precision

* use _.get to avoid error, cannot read property of undefined

* add cluster size slider

* experiments with image differences

* onload not onLoad

* use canvas dimensions

* compare map canvas to stored PNG of map canvas

* remove pixelmatch from project dependecies

* fix broken test - rounding error

* add expected image tests for geohash layers shaded circles and geohash grids

* bump z-index of vis-spy

* update functional test expected data

* update to leaflet 1.2.0

* revert to leaflet 1.0.3 and update expected data set for map functional tests

* test geohash_layer heatmap in unit test

* update region_map functional test since it can not longer pluck map vectors from DOM

* update documentation
2017-08-22 17:26:30 -06:00
Nathan Reese
0d281a7566 Replace "marked" with "markdown-it" (#13623)
* add markdown functional test

* update markdown vis to use markdown-it

* migrate markdown angular filter to markdown-it

* place other uses of marked and remove dependency

* update breaking changes documenation and set linkify to true
2017-08-22 16:29:40 -06:00
Tim Sullivan
49ba9e8e6e [UI Bundler] Add Aliases for Moment so plugins can use the same instance (#13628) 2017-08-22 09:25:33 -07:00
Matt Bargar
9890d22b13 Disable creation of "exists" filters for scripted fields (#13538)
* Disable exists filter button for scripted fields in doc viewer

* Disabled exists filter button for scripted fields in discover sidebar

* Fix reference to non-existent scope variable
2017-08-22 10:32:35 -04:00
Tim Roes
5514f34354 Show a warning for non accessible charts for screen readers (#13573)
* Show warning for non accessible visualizations, fix 13572

* Mark markdown vis as accessible
2017-08-22 11:24:51 +02:00