* Adding .only clause for testing purposes.
* Removing .only and reenabling test. Also changing back to group 13.
* Removing .only and reenabling test. Also changing back to group 13.
* Removed comment mentioning github issue.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: John Dorlus <silne.dorlus@elastic.co>
* Set up curation search server route
- not really sure which API endpoint to use, hedging my bets
* Set up AddResultLogic
- fairly simple, mostly concerned with flyout behavior & search query
- could likely be reused (or replaced with??) query tester logic in the future
* Add main AddResultFlyout component
- with custom isPromoted / isHidden logic & actions
* Update AddResultButton to open flyout
* Update Curation page to render the flyout
* PR feedback: reset search query on flyout re-open
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* [DOCS] Reformats Dashboard and adds Lens reference
* ⚗️ First trial of Lens FAQ
* Fixes broken title levels
* Link fix
* Fixes tsvb link
* Fixes tsvb link
* [DOCS] Reformats Dashboard and adds Lens reference
* ⚗️ First trial of Lens FAQ
* Fixes broken title levels
* Link fix
* Fixes tsvb link
* Fixes tsvb link
* [Lens] Add drag and drop keyboard navigation docs
* remove unlinked files
* [Lens] tutorial advanced first version
* corrections
* Kaarinas changes
* corrections after CR
* Update docs/user/dashboard/lens-advanced.asciidoc
* 📝 Add more Lens related FAQ
* Updates Lens page
* Update docs/user/dashboard/lens.asciidoc
* drag and drop copy and gif
* some corrections after Wylie's second review
* Review comments
* Final changes
* Update lens-advanced.asciidoc
ordering fixed
* Comment organization
* Final clean up
Co-authored-by: dej611 <dej611@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
Co-authored-by: dej611 <dej611@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
* Speed up spaces tests by letting v2 migrations do less work (#91829)
* Don't mess with v2 migration's index
* Speed up spaces tests by letting v2 migrations do less work
* Add disabled mapping for spaces so that plugin can be disabled
* Add security as codeowners of xpack saved object api integration suite
# Conflicts:
# .github/CODEOWNERS
# packages/kbn-es-archiver/src/lib/indices/kibana_index.ts
# x-pack/test/functional/es_archives/saved_objects_management/spaces_integration/mappings.json
# x-pack/test/saved_object_api_integration/common/fixtures/es_archiver/saved_objects/spaces/mappings.json
* Apply suggestions from code review
* Fix backport for ES _types
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Fix links to the numeral formatting in the advanced settings (#84167)
* Fix a link to the numeral formatting in the index pattern field settings (#84167)
# Conflicts:
# docs/development/core/public/kibana-plugin-core-public.doclinksstart.md
Test was skipped to allow for the promotion of the ES snapshot.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
* updated serialization and deserialization behavior of dissect and gsub processors, also addded a test
* also fix grok processor
* pivot input checking to use JSON.stringify and JSON.parse
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* do not modify connector with the right structure
* review trying to bring back incident to live when we can
* manage custom action
* fix cypress test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
## Summary
Refactoring in progress towards https://github.com/elastic/kibana/issues/90437
Collapse `forceUninstallAgents` into `uninstallAgents` into one function with an option. The pseudocode diff is
```diff
- function uninstallAgents() {
- // filtering logic A
- // side effects A
- }
- function forceUninstallAgents() {
- // filtering logic A
- // side effects B
- }
+ function uninstallAgents({ flag: boolean}) {
+ // filtering logic A
+ // if flag: side effects B
+ // else: side effects A
+ }
```
actually, there is [_one difference_](5564f25383 (diff-ecc3c625f2366949f1723e56b8477f6afb552ccfbcf3a71e0c28b2062fd05195)) in the filtering logic
### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Co-authored-by: John Schulz <john.schulz@elastic.co>
* Set up promoted & hidden documents logic
* Set up result utility for converting CurationResult to Result
* Set up AddResultButton in documents sections
- not hooked up to anything right now, but will be in the next PR
* Add HiddenDocuments section
* Add PromotedDocuments section w/ draggable results
* Update OrganicDocuments results with promote/hide actions
* Add the Restore Defaults button+logic
* PR feedback: key ID
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
This PR addresses an issue where the confirmation modal when removing a content source connector was brokedn. The issue was that the component was not passed the props to render correctly
Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
* use index patterns and search services for autocomplete
* imports
* extend DataRequestHandlerContext
* Catch error if index patterns service can't be created.
* doc
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Liza Katz <lizka.k@gmail.com>
* Replace custom margin style with EuiFlexGroup gutter
* Replace custom padding style with EuiFlexGroup gutter
* Remove custom wrapper around Loading on Overview page (alpha)
* Replace custom range value output with EuiRange's showInput prop
* Remove custom style
I'll refer the correct handling of this to design pass
* Remove "euiPanel--inset" className, as it doesn't do anything in Amsterdam theme
* Remove unused className `euiPanel--noShadow`
We're already using hasShadow={false} prop that does the same
* Remove `euiPanel--outline` className, as it doesn't do anything in Amsterdam theme
* Inline classNames declaration with the goal to remove them later
They don't do anything in Amsterdam theme, but I'm not removing them to keep context for design pass.
* Remove `eui-textNoWrap` className from buttons, as it's already included in button styles
* Remove classNames with no styles attached
* Replace custom padding in content_section with EuiSpacer
* Remove source-row styles
Most of the classNames were redundant and not needed anymore. The ones that were actually used were either replaced with EUI props or deleted, so we could apply EUI styles during design pass.
* Replace source_icon styles with EUI components and props
* Replace source-card icon styles with EUI prop
* Remove className declarations with no styles attached to classes
* Fix tests
* Increase space between source overview panels
* Use smaller icons on source prioritization and connectors pages
* Invert SourceIcon default size and size provided via props
The default size was "xxl", now it's "m". "m" size is default in EUI, so it's more consistent.
* Get rid of as horizontal spacer
Co-authored-by: Vadim Yakhin <yakhin.v@gmail.com>
## Summary
Use the [`consistent-type-imports` lint rule ](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/consistent-type-imports.md) to use `import type ...` where possible
Code-only changes like this were recently added in https://github.com/elastic/kibana/pull/92979, but it was a more manual process. This PR adds an autofixable lint rule which will keep the changes up-to-date and Just Work ™️
# Conflicts:
# x-pack/plugins/fleet/server/services/agents/crud.ts
# x-pack/plugins/fleet/server/services/artifacts/artifacts.ts
# x-pack/plugins/fleet/server/services/artifacts/mappings.ts
# x-pack/plugins/fleet/server/services/artifacts/mocks.ts
# x-pack/plugins/fleet/server/services/index.ts
* persisted validation form state when switching from editor to form
* persist complete form state when switching from json editor
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Validation for the Reporting UI Setting Custom Logo
* add more validations
* check if image is too large
* fix i18n
* clean redundant
* large test strings not necessary
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# x-pack/plugins/reporting/server/plugin.ts
