Commit graph

32419 commits

Author SHA1 Message Date
Joe Reuter 82e048a5fb
add embed flag to saved object url as well (#62926) 2020-04-09 09:28:44 +02:00
Devin W. Hurley 274cb805e1
[SIEM] [Detection Engine] Fixes bug when notification doesn't… (#63013)
Set refresh on bulk create to 'wait_for' when actions are present, so we do not respond until the newly indexed signals are searchable.

* set refresh on bulk create to 'wait_for' when actions are present, so we do not respond until the newly indexed signals are searchable

* fix types in tests
2020-04-08 19:58:50 -04:00
Frank Hassanabad c643148f36
[SIEM][Detection Engine] Fix rule notification critical bugs
## Summary

Fixes critical bugs found during testing of the rule notification.

* Fixes a bug where when you turn on rules quickly such as ML rules you would see these message below. This message can also be seen when you first create a rule with an action notification. This is a race condition with how we update rules multiple times when we really should only update it once and do it before enabling a rule

```
server    log   [12:18:35.986] [error][alerting][alerting][plugins][plugins] Executing Alert "63b828b5-24b9-4d55-83ee-8a8201fe2d76" has resulted in Error: [security_exception] missing authentication credentials for REST request [/_security/user/_has_privileges], with { header={ WWW-Authenticate={ 0="Bearer realm=\"security\"" & 1="ApiKey" & 2="Basic realm=\"security\" charset=\"UTF-8\"" } } 
``` 

* Fixes a bug where we were using `ruleParams.interval` when we should have been using `ruleAlertSavedObject.attributes.schedule.interval`. When changing rule notifications to run daily, weekly, etc.. you would see this exception being thrown:

```
server    log   [21:23:08.028] [error][alerting][alerting][plugins][plugins] Executing Alert "fedcccc0-7c69-4e2f-83f8-d8ee88ab5484" has resulted in Error: "from" or "to" was not provided to signals count query
```

* Fixes misc typing issues found
* Fixes it to where we no longer make multiple DB calls but rather pass down objects we already have.
* Changes the work flow to where we only update, create, or patch the alerting object once which fixes the race condition and improves the backend performance.
* Removes left over unused code
* Applied https://en.wikipedia.org/wiki/Single-entry_single-exit to functions where it made sense and easier to read.


### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-04-08 17:36:20 -06:00
Brittany Joiner 0c35762f27
Add Error Exception Type Column (#59596)
* start of error exception type

* width and link

* removed extra line

* updated snapshot

* updated snapshots

* updated snapshots

* Update snapshots

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Nathan L Smith <smith@nlsmith.com>
2020-04-08 18:08:13 -05:00
eyalkoren da51cc041d
[APM] Agent remote configuration: changes in Java property descriptions (#62282)
* [APM] Agent remote configuration: changes in Java property descriptions

* Removing newlines

* Update snapshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Co-authored-by: Nathan L Smith <smith@nlsmith.com>
2020-04-08 16:56:52 -05:00
Gidi Meir Morris e3bd04fcb0
[Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (#62772)
Removes the Security flyout and instead replaces the Alerting List, Connectors List and Alert Flyout with suitable messaging.
Verifies that a permanent Encryption Key has been configured and if it hasn't displays a suitable warning in place, or along side the TLS warning, as needed.
2020-04-08 22:36:33 +01:00
Dmitry Lemeshko 578e443bdd
FTR: add chromium-based Edge browser support (#61684)
* bump dependency, add edge support in ftr services

* add config files

* fix browser version for msedge

* use npm ms-chromium-edge-driver

* download edge driver aside from session creation

* move dependency to dev

* update dist/index file

* bump edge-driver version

* change type to msedge to match w3c spec

* fix discover tests for Edge

* Revert "fix discover tests for Edge"

This reverts commit 87e7fdd256.

* bump driver version up

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-09 00:08:21 +03:00
Jen Huang 86a2587660
[Ingest] Data source configuration validation UI (#61180)
* Initial pass at datasource configuration validation

* Show error icon and red text at input and stream levels

* Add tests, fix bugs in validation method

* Fix typings
2020-04-08 13:33:51 -07:00
Lee Drengenberg fdb4a37a60
restore empty_kibana after saved objects test (#62951) 2020-04-08 15:33:21 -05:00
Matthew Kime e0a519424f
Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (#62594)
* implement index pattern management plugin in new platform
2020-04-08 15:10:44 -05:00
Josh Dover f84773faed
Add basic StatusService (#60335) 2020-04-08 13:16:32 -06:00
Spencer 369ddff951
[kbn/optimizer] link to kibanaReact/kibanaUtils plugins (#62720)
* [kbn/optimizer] link to data/kibanaReact/kibanaUtils plugins

* depend on normalize-path package

* typos

* avoid loading kibanaUtils and kibanaReact from urls

* update types and tests, now that whole plugin is exported to window

* update snapshot, removed export of `plugins` property

* fix condition, ignore things NOT in data/react/utils

* make es_ui_shared a "static bundle" too

* move kibana_utils/common usage to /public

* convert some more /common usage to /public

* use async-download/ordered-execution for bootstrap script

* fix typo

* remove kibanaUtils bundle

* remove kibanaReact bundle

* Revert "remove kibanaReact bundle"

This reverts commit f14e9ee604.

* Revert "remove kibanaUtils bundle"

This reverts commit a64b2a7f64.

* stop linking to the data plugin

* add comment pointing to async-download info

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 12:15:48 -07:00
Oliver Gupte 184f59447b
[APM] Service map - fixes layout issues for maps with no rum services (#62887)
* Closes #62878 in Service Maps by improving the selection algorithm for root nodes

* Fixes some latent centering issues when navigating in the service map.

* Removes unused imports

* Added layoutstopDelayTimeout to cleanup step
2020-04-08 11:13:39 -07:00
Jen Huang d4f2bd744d
Exclude disabled datasources and streams from agent config (#62869) 2020-04-08 10:45:15 -07:00
Zacqary Adam Xeper 941a4879ae
[Alerting] Fix validation support for nested IErrorObjects (#62833)
* [Alerting] Add validation support for nested IErrorObjects

* Typecheck fix

* Fix recursion crash when errors are strings

* Typecheck fix
2020-04-08 12:40:27 -05:00
Zacqary Adam Xeper cbe479b8bd
[Metrics UI] Invalidate non-count alerts which have no metrics (#62837) 2020-04-08 12:39:59 -05:00
Josh Dover 1c718d6760
Add --filter option to API docs script (#62888) 2020-04-08 11:30:12 -06:00
Nathan Reese 3598b8c44c
[Maps] fix attribution overflow with exit full screen button (#62699)
* [Maps] fix attribution overflow with exit full screen button

* use margin-left instead of padding-left

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 11:24:04 -06:00
Shahzad 8cacbdfaa5
[Uptime]Alerting UI text in case filter is selected (#62570)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 19:23:16 +02:00
Nathan Reese bfdccfdbc5
[Maps] Show create filter button for top-term tooltip property (#62461)
* [Maps] Show create filter button top-term tooltip property

* add missing imports

* update import for NP migration

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 11:22:52 -06:00
spalger 56fa9a5776 skip flaky suite (#59030) 2020-04-08 10:17:05 -07:00
Melissa Alvarez 3e4469c99c
[ML] Analytics: ensure both keyword/text types are excluded for selected excluded field (#62712)
* exclude keyword and text types of field selected for exclusion

* only show keyword type fields of accepted fields for depVar

* make excludes field logic generic

* fix regex to ensure escaped dot. reset regex and mainfield

* ensure cloned jobs get correct excluded fields

* add clarifying comments
2020-04-08 13:13:40 -04:00
Larry Gregory 9d89a4fb49
Support multiple reserved feature privileges (#61980)
* support multiple reserved feature privileges

* update reserved privilege ids

* additional testing

* Add ml_user and ml_admin reserved privileges

* prrevent reserved privilege ids from sttarting with 'reserved_'

* address pr feedback: dedicated reserved privilege type

* re-enable ML test suites

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 13:03:15 -04:00
Yuliia Naumenko 730dcbf638
Implemented actions server API for supporting preconfigured connectors (#62382)
* Implemented actions server API for supporting preconfigured connectors defined in kibana.yaml

* Fixed type check

* Fixed due to comments and extended functional tests

* Fixed tests and renamed connectors

* fixed jest tests

* Fixed type checks

* Fixed failing alert save

* Fixed alert client tests

* fixed type checks

* Fixed language check error

* Fixed jest tests

* Added missing comments and docs

* fixed due to comments

* Fixed json config for preconfigured

* fixed type check, reverted config

* config experiment with json stringify

* revert experiment

* Removed the spaces from connector names in config
2020-04-08 09:54:42 -07:00
Phillip Burch 18c3f75bfb
The theme doesn't exist on props when used from the alerting management screen (#62811) 2020-04-08 11:38:23 -05:00
Tim Sullivan 8d8c41153a
Reporting/fix listing pagination (#62881)
* [Reporting] Fix report table pagination

* update snapshot

* nice little comment
2020-04-08 09:22:06 -07:00
nnamdifrankie 3457dde6f5
[Endpoint] EMT-146: add host status info to the metadata API response (#62876)
[Endpoint] EMT-146: add host status info to the metadata API response
2020-04-08 12:10:00 -04:00
Nathan Reese 2023663104
[Maps] Add date-fields to metrics selection (#62629)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 10:03:37 -06:00
Peter Pisljar 90e6f2ca6d
fixing multiple metrics (#62929) 2020-04-08 16:57:23 +02:00
Yara Tercero 5d34697ea5
[SIEM][Detection Engine] - Update list values in REST interfaces (#62320)
Summary
- #60022
- Follow up on #60171
- Modifies boolean filters to enum of "included" and "excluded"
- Adds operator types of enum "match", "match_all", "list", and "exists"
- Adds values properties to include those for "list"
- DOES NOT FILTER ON THE VALUES JUST YET (That will be a follow on PR)
2020-04-08 10:46:06 -04:00
eyalkoren 1af82c709f
[APM] Agent remote configuration: general settings descriptions (#62276)
* Updates general remote config descriptions

I removed `log_level` from here because it seems it doesn't fit at least the Java, Go and Node agents - see #61821, and it is already deactivated for most others (this doesn't have to be included in this PR though).

* Update general_settings.ts

* Restore log_level definition

* Remove extra spaces

Co-authored-by: Nathan L Smith <smith@nlsmith.com>
2020-04-08 09:34:04 -05:00
Poff Poffenberger d94d7cc719
[Canvas] Fix Canvas-specific storybook after new platform changes (#61876)
* Fix Canvas storybook webpack config

* Temporarily disable workpad export example

* Mock out lib/notify and download_workpad

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 09:20:25 -05:00
Aaron Caldwell 67536e4b3c
Fix issue with license not getting obtained & passed to server… (#62883) 2020-04-08 08:12:37 -06:00
James Gowdy 6b52ce7341
[ML] Adding configurable file size to file data visualizer (#62752)
* [ML] Adding configurable file size to file data visualizer

* updating translated strings
2020-04-08 15:09:56 +01:00
Maja Grubic 4d7cc6dfb7
Removing unused import (#62917)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 14:32:13 +01:00
MadameSheema aa54929fb5
skips 'Sorts by activated rules' (#62924) 2020-04-08 15:14:07 +02:00
Larry Gregory cc9c4113b2
Document sub-feature privileges (#62335)
* documenting sub-feature privileges

* Apply suggestions from code review

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* address PR feedback

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2020-04-08 07:15:31 -04:00
Maryia Lapata 3d6fd68eb2
Get rid of ui/i18n in Discover (#62799) 2020-04-08 12:48:41 +03:00
Daniil Suleiman 314c4f782f
[NP] Vis Default Editor plugin (#62475)
* Move the default_editor to NP

* Fix paths

* Import styles through the visualize

* Other fixes

* Fix ip_ranges exhaustive-deps array

* Fix filters and extend bounds

* Other fixes

* Fix date_ranges tests

* Use useMount on first render

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 12:00:13 +03:00
Mikhail Shustov 267f22c2ee
2Mb --> 53kB (#62781) 2020-04-08 10:21:06 +02:00
Alejandro Fernández Haro 028313a8fe
[Telemetry] Add possibility of registering exclusive collectors for each collection (#62665)
* [Telemetry] Add posibility of regitering exclusive collectors for collections

* [Telemetry] Filter unwanted fields from the kibana.os telemetry payload

* Filter the collectors properly in bulkFetch

* Move "kibana" usage collector from Monitoring to OSS Telemetry

* Remove exclusivity of the "kibana_settings" collector

* Unify "kibana_stats" collector from Monitoring and Legacy

* Remove unused legacy constants

* Proper type for UsageCollectionSetup in monitoring

* Missed one undo

* Add unit tests to the migrated collectors

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-08 09:08:59 +01:00
Peter Pisljar d212102bf5
fixing region map click filter (#61949) 2020-04-08 07:44:23 +02:00
Frank Hassanabad 5218e30487
[SIEM][Detection Engine] Fixes TypeScript types and adds format to time range query
## Summary

* Fixes the Type Script types so we don't have to use non-null-assertions
* Adds null checks where needed
* Changes the time range query to have a format of epoch to avoid mapping issues

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-04-07 19:37:47 -06:00
Tiago Costa 7e3c68bb7a
chore(NA): removes server imports from canvas src plugin (#62783)
* chore(NA): remove server imports from canvas src plugin

* chore(NA): correctly import types for demodata
2020-04-08 00:44:38 +01:00
Paul Tavares eacdbcd4f5
[Endpoint] new AppRootProvider + Policy details tests (#62319)
* Refactor of mocks into own dir ++ added `createAppContextTestRender`
* new AppRootProvider component
* Refactor application `index.tsx` to use `AppRootProvider`
* Add `generatePolicyDatasource()` to EndpointDocGenerator
* Test for policy details
2020-04-07 16:37:15 -04:00
Brandon Morelli 5e1708f884
[APM] docs: add service map information (#62671) 2020-04-07 11:27:02 -07:00
Cauê Marcondes 20dc67df71
[APM] Agent span_frames_min_duration configuration input cannot handle 0 or -1 (#62777)
* changing duration min value for span_frames_min_duration

* adding min property to number field
2020-04-07 20:18:35 +02:00
Yuliia Naumenko a8f84f87af
Improve UX for index document code editor to have similar UX as webhook (#62724)
* Improve UX for index document code editor to have similar UX as webhook's

* Fixed jest tests

* Fixed codestyle issue
2020-04-07 10:56:48 -07:00
Zacqary Adam Xeper 879dadff31
[Metrics Alerts] Dynamically fetch index pattern (#62708)
* Fetch index pattern dynamically from alert executor

* Fix fetching of non-default pattern
2020-04-07 12:55:42 -05:00
Chris Roberson 8ffc08f2f7
[REVERT THE REVERT] [Monitoring] Cluster state watch to Kibana alerting (#62793)
* Revert "Revert "[Monitoring] Cluster state watch to Kibana alerting (#61685)""

This reverts commit f1bd3bdacb.

* Fix i18n error

* Fix test
2020-04-07 13:44:34 -04:00