Commit graph

32419 commits

Author SHA1 Message Date
Cauê Marcondes d70718426f
[APM] Change custom link from EuiListGroupItem to EuiLink (#62742) 2020-04-07 18:39:52 +02:00
Alison Goryachev 406d7550be
[Remote Clusters] Update callout and move server_name field (#62352) 2020-04-07 12:36:13 -04:00
Corey Robertson 2c4cc12b98
Removes Pitch Presentation Template from Canvas (#62688)
* Removes Pitch Presentation Template from Canvas

* Fix test

* Keep translation to not fail i18n
2020-04-07 11:55:06 -04:00
Dmitry Lemeshko 898504dc8f
FTR: Enable w3c for chromedriver (#62542)
* enable w3c for chrome

* update maps tests

* update maps tests

* update common_page

* Revert "update maps tests"

This reverts commit 31f43fd678.

* revert changes to maps tests

* undo after removal

* update expect range to pass on Windows, unskip tests for Firefox

* print out value for discover brushing test

* log first timestamp

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 17:40:27 +03:00
Robert Oskamp b7d05573e7 [ML] Disable functional tests 2020-04-07 16:38:04 +02:00
Sébastien Loix c92289d217
[ILM] Skip failing API integration test (#62779) 2020-04-07 16:32:51 +02:00
Xavier Mouligneau 8eb9fdd6eb
[SIEM] Update beat doc (#61902)
* add new ecs description

* new auditbeat/filebeat description

* update description winlogbeat

* bring back description in pictures

* review I + use ECS doc as last ressource when you do not know the index

* update test

* safety default just in case

* fix functional test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 10:27:11 -04:00
Lukas Olson d1e8d0d6ec
[Search] Properly add slash preceding path in async search (#62722)
* [Search] Properly add slash preceding path in async search

* Fix tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 07:21:28 -07:00
Dario Gieselaar 95505bf1e1
[APM] make sure environment query is correct for service maps… (#62764)
Closes #62207.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 16:17:02 +02:00
Nathan L Smith cd1e11bce6
Add service map icon for rum-js agent type (#62721)
* Add service map icon for rum-js agent type

We previously were only checking for "js-base" as the RUM `agent.name` but it can report either "js-base" or "rum-js", so make that work.

I saw an "opbeans-react" service on a map generated by apm-integration-testing that Gil had running last week. Not sure if that's a newer or older version because I don't see it on apm.elstc.co.

Also clean up the icons storybook a little.

Fixes #62336.

* use isRumAgentName

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 09:08:38 -05:00
Oliver Gupte 30b6d42c42
[APM] Service map - fixes irrelevant services on data refresh (#62750)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 16:06:55 +02:00
Oliver Gupte d565db0dbd
[APM] Service map - Fix taxi edge arrow orientation (#62741)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 16:06:49 +02:00
Dario Gieselaar 6fdd7b4c9b
[APM] Prevent error rate alert trigger from rendering NaN (#62754)
* [APM] Prevent error rate alert trigger from rendering NaN

Closes #62458.

* Use params instead of alertParams
2020-04-07 16:06:13 +02:00
Jonathan Buttner 994aa63e50
[EPM] Store map visualizations from the package registry and use saved object ID (#62059)
* Using saved objects id instead of creating one

* Adding map to list of types

* Fixing typing errors

* Reverting id change

* Reverting asset id

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 08:50:30 -04:00
Patrick Mueller 459d6ec365
[Alerting] for email action, set tls.rejectUnauthorized: false when secure: false (#62380)
resolves https://github.com/elastic/kibana/issues/62372

See the referenced issue for background.  Eventually we will probably have to
have a separate setting for `tls.rejectUnauthorized`, not base it on the
value of the `secure` config property.  But this will likely be useful for
a number of smtp servers used by customers.
2020-04-07 08:30:17 -04:00
Alexey Antonov 008b0fda64
[data.search.aggs] Remove service getters from agg types (#61628)
* [data.search.aggs] Remove service getters from agg types

Part of #60333

* new portion of changes

* pass dependencies to MetricAgg Type through constructor

* update docs

* refactoring buckets

* remove unused mockDataServices

* Remove service getters from metrics

* Some fixes

* remove temporary code

* moved notifications to the getInternalStartServices

* fixed karma lock

* update docs

* Fixed tests

* fix broken CI

* fix PR comment

* fix typo

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com>
2020-04-07 13:39:30 +03:00
Cauê Marcondes fb0d0a5834
fixing APM internationalization (#62757) 2020-04-07 12:27:22 +02:00
Vadim Dalecky afb8d8d7ce
fix: 🐛 correctly create error on no_matching_indices (#61257)
* fix: 🐛 correctly create error on no_matching_indices

* feat: 🎸 improve error type checking

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 12:19:21 +02:00
Tim Roes 3a9e7be8bf
[Lens] Remove all legacy imports (#62596)
* Remove all legacy imports

* Fix import
2020-04-07 11:08:54 +02:00
Jean-Louis Leysens d1911ec843
Add label for ace editor (#62588) 2020-04-07 09:52:22 +02:00
James Gowdy 64f27ca34e
[ML] Show better file structure finder explanations (#62316)
* [ML] Show better file structure finder explanations

* more typescript changes

* changing function format

* fixing some types

* fixing translation id

* fix boom error reporting

* changes based on review

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 08:47:39 +01:00
Tim Roes 8429a8ede9
Fix old pathes in eslintrc (#62580) 2020-04-07 09:24:21 +02:00
Shahzad 355cacff7c
[Uptime] Improve Telemetry test (#62428)
* removed unnecessary filter

* update condition

* added a unit test for mix state

* fix types

* fix type

* updated test

* update

* updates test

* updates tests

* updates tests

* updated type

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 09:19:36 +02:00
MadameSheema 91a0010668
[SIEM] Adds sort rules Cypress test (#62700)
* adds 'singal detection rules' spec

* adds 'Sorts by activated rules' test

* implements 'Sort by activated rules'

* refactors code

* fixes index
2020-04-07 09:19:08 +02:00
Shahzad 2e0d900257
[Uptime]Abstracted 'access:uptime-read' tag into a wrapper for… (#62576)
* abstract access headers

* updated code
2020-04-07 09:16:45 +02:00
Cauê Marcondes 0458626379
fixing bug (#62577) 2020-04-07 09:08:00 +02:00
Nathan Reese dc013cb80f
[Maps] Allow updating requestType for ESGeoGridSource (#62365)
* [Maps] Allow updating requestType for ESGeoGridSource

* re-add import removed from last merge

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 21:27:47 -06:00
Nathan Reese 3f11d9c84b
[Maps] do not show circle border when symbol size is zero (#62644)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 21:26:55 -06:00
Nathan Reese 7882e0c3a8
[Maps] Always show current zoom level (#62684)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 21:26:10 -06:00
The SpaceCake Project b65de27458
bc5 siem rules merge (#62679)
* bc5 rule merge

version changes
field changes to endpoint rules
removed max_signals from 7 rules

* Fixing monitoring i18n (#62715)

* Updates esarchiver test data with the latest rules (#62723)

* Remove CR, only CRLF for rules

* delete two files

for Garrett

* deletes

delete 2 files (for Garrett)

* Revert "deletes"

This reverts commit cc2ac1e05f.

* Revert "Fixing monitoring i18n (#62715)"

This reverts commit 028574037a.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
Co-authored-by: Ross Wolf <31489089+rw-access@users.noreply.github.com>
2020-04-06 20:45:39 -06:00
spalger f1bd3bdacb Revert "[Monitoring] Cluster state watch to Kibana alerting (#61685)"
This reverts commit ab0cc8894a.
2020-04-06 17:05:09 -07:00
liza-mae 29c1aad2bb
Fix visual tests (#62660) 2020-04-06 16:48:37 -06:00
Ahmad Bamieh e16885c3ad
[Telemetry] update crypto packages (#62469)
* update crypto packages

* as type for return value

* get default export

* add if checks

* wrap errors in i18n

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 00:36:15 +03:00
Kaarina Tungseth 809ec97649
[DOCS] Removed references to left (#60807)
* [DOCS] Removed references to left

* Fixed broken build
2020-04-06 15:37:45 -05:00
Aaron Caldwell f80925af97
[Maps] Move layers to np maps (#61877)
* Move layers to new location

* Update layer path refs

* Update np kibana services to cover all required services

* Init np kibana services in legacy plugin. Port init functions to np

* Path updates, supporting file moves, general clean up

* More moves of related files and clean-up of legacy refs

* Path updates. Typescript warning fixes

* Update test paths

* Clean up unused kibana services usage in legacy

* Remove unused http ref

* Test fixes and clean up

* Remove unused snapshots

* Add np service init to embeddables too

* Move validate color picker to NP
2020-04-06 14:01:38 -06:00
Walter Rafelsberger a7b3e5539e
[ML] Fix boolean cell values in analytics table result views and transforms wizard. (#62618)
Fixes the rendering of boolean values in table results views and transforms wizards:
- Fixed: Boolean cells in the transform wizard ended up being empty.
- Fixed: Boolean cells in regression/classification result table would render as Yes/No instead of true/false.
2020-04-06 21:47:15 +02:00
Sandra Gonzales ee02df445b
[EPM] fix /packages response to return older packages (#62623)
* compare package list by name

* use the internal property, adding as saved object attribute

* remove HiddenPackages type
2020-04-06 15:45:11 -04:00
Garrett Spong 0bdcda8f20
[SIEM] Fixes UX issues around prebuilt ML Rules (#62396)
## Summary

This PR fixes a number of UX issues around the new prebuilt `machine_learning` rules when the user does not have the necessary permissions to manage the backing ML Job. Along with https://github.com/elastic/kibana/pull/62383, this ensures there is adequate information for the user determine if a rule is not working because the backing job is not running (and helping to prevent this from occurring). This also includes some requested copy changes, including:

* Renames `Anomaly Detection`  dropdown to `ML job settings`
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/78320279-57c5a880-7526-11ea-8350-647cbba263a4.png" />
</p>

* Updates copy in `ML job settings` dropdown
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/78320473-cc98e280-7526-11ea-8871-e97661ff5f78.png" />
</p>

* Only shows `ML job settings` UI when on `/detections/` routes 
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/78320401-922f4580-7526-11ea-9f97-0ec06526b273.png" />
</p>


### All Rules Changes

* Disables the `activate switch` if user does not have permission to enable/disable jobs
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/78320892-d3742500-7527-11ea-90bb-91fd203480bd.png" />
</p>

* Adds warning toast when attempting to activate via bulk actions (if user does not have permission to enable/disable jobs)
<p align="center">
  <img width="300" src="https://user-images.githubusercontent.com/2946766/78321015-1a621a80-7528-11ea-8ab0-f9fef19240f7.png" />
</p>

### Rule Details Changes
* `Machine Learning job` link now links to ML App with table filtered to the relevant job

* Disables the `activate switch` if user does not have permission to enable/disable jobs
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/78321277-c277e380-7528-11ea-99e9-034970a5054e.png" />
</p>

### Create/Edit Rule Changes

* If the job selected _is not running_, a warning will be displayed to remind the user to enable the job before running the rule. cc @benskelker @MikePaquette -- this okay copy here?
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/78321498-63ff3500-7529-11ea-9b09-a87186cbe0ce.png" />
</p>

Resolves https://github.com/elastic/siem-team/issues/575
Resolves https://github.com/elastic/siem-team/issues/519

### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials 
  - Scheduled time with @benskelker to update docs
- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-04-06 13:44:46 -06:00
MadameSheema 813d6cb796
[SIEM] View signal in default timeline (#62616)
* adds test data

* adds 'View a signal in timeline' test

* implements test

* fixes implementation

* changes view signal for investigate signal
2020-04-06 21:42:43 +02:00
Chris Roberson ab0cc8894a
[Monitoring] Cluster state watch to Kibana alerting (#61685)
* WIP

* Add new alert with tests

* Fix type issues, and disable new alerting for tests

* Fix up the view all alerts view

* Turn off for merging

* Fix jest test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 15:31:01 -04:00
Nicolas Chaulet 0da20fea6a
[Fleet] Move actions to their own saved objects (#62137) 2020-04-06 15:21:39 -04:00
Lisa Cawley 42d7bb0c81
[DOCS] Fixes nesting in APM and spaces API (#62659) 2020-04-06 11:11:56 -07:00
nnamdifrankie 29abe5b81b
[Ingest] EMT-146: agent status impl preparation (#62557)
[Ingest] EMT-146: very light refactor a precursor for endpoint status change
2020-04-06 13:54:21 -04:00
Stacey Gammon dfa083dc60
Prep for embed saved object refactor + helper (#62486) 2020-04-06 13:45:46 -04:00
patrykkopycinski 0ebfe76b3f
[SIEM][Detection Engine] Fix signals count in Rule notifications (#62311) 2020-04-06 19:26:40 +02:00
Christos Nasikas d67f2220b3
[SIEM][CASE] Configuration page tests (#61093)
* Test ClosureOptionsRadio component

* Test ClosureOptions component

* Test ConnectorsDropdown component

* Test Connectors

* Test FieldMappingRow

* Test FieldMapping

* Create utils functions and refactor to be able to test

* Test Mapping

* Improve tests

* Test ConfigureCases

* Refactor tests

* Fix flacky tests

* Remove snapshots

* Refactor tests

* Test button

* Test reducer

* Move test

* Better structure

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 20:22:46 +03:00
Gidi Meir Morris e7a4ca261b
[Event Log] adds query support to the Event Log (#62015)
* added Start api on Event Log plugin

* added empty skeleton for Event Log FTs

* added functional test to public find events api

* added test for pagination

* fixed unit tests

* added support for date ranges

* removed unused code

* replaces valdiation typing

* Revert "replaces valdiation typing"

This reverts commit 711c098e9b.

* replaces match with term

* added sorting

* fixed saved objects nested query

* updated plugin FTs path

* Update x-pack/plugins/encrypted_saved_objects/README.md

Co-Authored-By: Aleh Zasypkin <aleh.zasypkin@gmail.com>

* Update x-pack/plugins/encrypted_saved_objects/README.md

Co-Authored-By: Aleh Zasypkin <aleh.zasypkin@gmail.com>

* remofed validation from tests

* fixed typos

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
2020-04-06 18:02:58 +01:00
CJ Cenizal 4bdbe7356d
Remove ES-UI as code owner of Transform app. (#62556) 2020-04-06 09:49:23 -07:00
Sonja Krause-Harder 2cd86a4c83
[EPM] Refactor expandFields() (#62180)
* Do not modify input array in expandFields()

* Add unit tests for processFields()

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 18:48:18 +02:00
marshallmain 5c8dda2656
[Endpoint] Add pipeline to generator that redirect alerts to alert index (#62512)
* add ingest pipeline to generator script

* make alert index name configurable

* move pipeline name to constant

* update setupOnly flag help text

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 12:41:49 -04:00