* Use header/h tag for tab header, #12861
* Add tabindexes for tables, #12862
* Add for/id pairings, #12863
* Search role, #12868
* Use better descriptions for aria labels, #12865
* Add aria label, #12870
* Button and a tags are already in tab order, removing unnecessary change
* The input field cannot contain the role="search"
* The tabindex needs to be on the element which the click handler
* Remove tabindex and remove the class applying the hover styles - honestly, we can probably make due without any class (using default h2 styles)
* Revert "Remove tabindex and remove the class applying the hover styles - honestly, we can probably make due without any class (using default h2 styles)"
This reverts commit c54ea227889898baef85ee71b3350bbf69ef5d7c.
* Remove the extra code my cat added
* Addressing hidden inputs from #12863
* Remove unnecessary header tag
* Add clarifying comment
* Prevent multiple ids
* [SavedObjectClient] emit detectable errors
* [uiSettingsService] consume new SavedObjectsClient errors
* [SavedObjectsClient] expose errorTypeHelpers as such
* [elasticsearch/tests] recreate error for each test
* [http] wait for elasticsearch plugin to be ready
* [shortUrl/tests] ensure that create request responds with 200
* [shortUrl] use errorTypeHelpers to filter errors
* [uiSettings/savedObjectsClientStub] stub errorTypeHelpers
* [SavedObjectsClient/errors] expose error module so tests can make errors
* [shortUrl/tests] use actual SavedObjectsClient errors
* [uiSettings/savedObjectsClientStub] use actual errors lib
* [SavedObjectsClient] use decorate instead of "wrap"
* [server/routes/uiSettings] refactor routes to forward Boom errors from uiSettings
* [uiSettings] colocate routes and service
* [testUtils/esTestCluster] use more standard api style
* [testUtils/es] add createCallCluster util
* [testUtils/esTestCluster] add getters for client/callCluster
* [es/healthcheck] ensure that healtcheck stops when server is stopped
* [uiSettings/routes] add param/payload validation
* [uiSettings/routes] add tests that verify error behaviors
(cherry picked from commit 8a64872ecb)
Fixes#12639
It's now possible to tab to each filter's actions and interact with them via the keyboard.
In order to get the actions to show/hide on both mouse hover and action focus I had to create a new filter-pill component that could manage a bit of state to track whether the user was interacting with a given pill or not.
* Move dashboard panel rendering logic to each registered type.
* Remove dashboard knowledge of click and brush handlers for visualizations
Move it to the VisualizeEmbeddableHandler.
* merge master with manual changes
* No need to use lodash
* Add EmbeddableHandler base class
* Use correct path to embeddable_handlers_registry
* clean up
* Set visualize scope uiState that is of type PersistedState, otherwise it won't actually be set.
* add retry to loading saved search data
* Fix handleError param and remove unnecessary private param
* Rename savePanelState updatePanel and return the new object rather than mutating the original
* Make ContainerAPI a base class and move the dashboard specific functionality into a new class
* Make api's async and clean up documentation
* Fix panel tests
* Fix bug which broke tests - need to pass container-api to dashboard-panel
* Address code comments
- Rename onFilter to addFilter
- Use angular promises instead of async/await
- fix jsdoc
- rename createChildUiState to getInitialState
* changed the wrong variable name
* no need for async or Promise.reject on interface
* add tests that will fail due to spy pane issue in this PR
* Fix logic with spy pane toggle
There is still a bit of a bug here as mentioned in
https://github.com/elastic/kibana/issues/13340 but it will be fixed
separately as it’s also an issue in master
* Fix failing test
* Use find service instead of remote which doesn't have built in safety checks for stale elements
* use data-test-subj instead of id
* add missing function and awaits
* Did not realize WebElements could find descendants
Added some extra functionality for this in find and testSubjects
service, and using in the one place it’s required.
* Fix accessibility issues with saved object finder
and use new kui styles
* Dark theme-icy kuiTabs
* Refer to existing dark theme color variables. Use dark theme hover link color.
* use button instead of div element so no need for kbn-accessible-click
* Add dark theme tab variety to ui framework site, lighten color of background tabs
* Change use of all_fields in highlight_query to default_field
* Remove highlight query and option
* Fix tests
* Remove unused setting
* Remove lingering references to all_fields
* Use ui-select for agg selector
* Fix functional tests
* Fix functional tests
* Fix test
* Fix visualize page object
* Use sortPrefixFirst in agg selector
* Fix unit tests
* Fix unit test
* Use not(.ng-hide) rather than last-child
* Make sure no one can show the chrome if the default setting is hidden.
add tests
Fixes https://github.com/elastic/kibana/issues/13040
* Improve variable and function names and fix tests
* [Accessibility] Ensure kbn-accessible-click is part of autoload/all
* remove unecessary kbn_accessible_click imports
* use an index.js file to expose inner directives
* [ui/routes] add failing tests
* [ui/routes] clone defaults before applying them
* Mention issue in related tests
(cherry picked from commit c68c0d6588)
* update paginated table headers with columns update
* remove unneeded sleep
* update getDataTableHeaders to preffered format
* use data-test-subj attribute for functional tests instead of CSS selectors
