Commit graph

33680 commits

Author SHA1 Message Date
Robert Oskamp 5377dbb758
[ML] Functional tests - stabilize DFA job creation (#68495)
This PR stabilizes the classification and regression creation tests.
2020-06-09 11:25:59 +02:00
Stratoula Kalafateli 88754d2cb2
[TSVB] Allows the user to change the tooltip mode (#67775)
* Allows the user to select the tooltip mode

* Fix problem on new TSVB and add new field to schema

* Change default value on tooltip dropdown for the focused series option
2020-06-09 10:04:05 +03:00
Tiago Costa e74440b138
chore(NA): skip apis Endpoint plugin Endpoint alert API when data is in elasticsearch (#68613) 2020-06-09 03:50:27 +01:00
Tiago Costa bc5d8c20c1
chore(NA): skip endpoint Endpoint Alert Page: when es has data and user has navigated to the page (#68596) 2020-06-09 03:36:12 +01:00
Frank Hassanabad d99cf75814
[SIEM][Detection Engine] Converts from joi to use io-ts and moves the types to common (#68127)
## Summary
* https://github.com/elastic/siem-team/issues/646
* Converts the detection rules and REST to use io-ts
* Removes their joi counterparts
* Updates all tests to use it
* Fixes a bug with the risk_score that was being sent in as a string from the UI instead of a number
* Fixes a bug within the exactCheck validating where it can now accept null value types for optional body messages.
* Fixes a bug in the FindRoute where it did not send down fields from REST
* Changes the lists plugin to utilize the io-ts types from siem rather than having them duplicated.
* Makes some stronger validations
* Adds a lot of codecs

**Things to look out for:**

* Generic testing to ensure I didn't break something that was not part of the tests.
* Fix for the risk_score from string to number is in:
```
x-pack/plugins/security_solution/public/alerts/components/rules/step_about_rule/index.test.tsx
```
* Fix for the exact check (unit tests are written and added)
```
x-pack/plugins/security_solution/public/alerts/components/rules/step_about_rule/index.test.tsx
```
* Within all the types I added are there any misspelled things or copy-pasta mistakes with strings:
x-pack/plugins/security_solution/common/detection_engine/schemas/types
* Fix for `find_rules_route.ts:58`
```
x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/find_rules_route.ts
```

**Follow on things that this PR doesn't do we need to:**
* Add linter rule to forbid NodeJS code within common section
* The `[object Object]` formatter issues seen in the code such as:
```
// TODO: Fix/Change the formatErrors to be better able to handle objects
'Invalid value "[object Object]" supplied to "note"',
```
* Formatter issues such as: `'Invalid value "" supplied to ""'`
* Remove the hapi server object from lists plugin

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-06-08 19:54:09 -06:00
Tiago Costa e49888f2ec
chore(NA): skip apis Endpoint plugin test metadata api POST /api/endpoint/metadata when index is not empty (#68586) 2020-06-09 01:31:33 +01:00
Jen Huang 299a6026fd
[Ingest Manager] Copy fixes (#68325)
* #68153 Change Elastic integrations to Integrations

* Fix copy casing

* #68152 Update create data source CTA copy

* #68166 Remove icon next to top-level navigation when user is on new Kibana navigation style

* Fix i18n

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 17:16:30 -07:00
Nathan L Smith d1ed207945
APM TypeScript improvements (#68572)
* Add `compilerOptions.noErrorTrunctation` to the tsconfig template
* Remove unused parameters

Not adding `noUnusedParamaters` to the tsconfig since we get too many hits from dependencies when running `tsc`. These do show up in the editor as warnings, though.
2020-06-08 17:56:06 -05:00
Spencer ab226f02ae
[kbn/pm] log levels (#68203)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-06-08 15:53:16 -07:00
Jen Huang b39234ce80
#68163 Make footer messaging sticky to bottom of page (#68327)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 15:20:36 -07:00
Phillip Burch e591aa99d3
Add timestamp context variable (#67482)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 17:16:01 -05:00
gchaps 56ed61e303
[DOCS] Edits titles in Setup section for consistency (#68451)
* [DOCS] Fixes titles in Setup section for consistency

* [DOCS] Fixes to titles and orders of docs in Set up
2020-06-08 14:46:26 -07:00
gchaps de62abbd4e
[DOCS] Fixes typo in Console docs (#68536) 2020-06-08 14:45:55 -07:00
Josh Dover f090775280
Add url overflow handling to KP (#67899) 2020-06-08 15:03:41 -06:00
Jonathan Budzenski 1e45e988e8
[deb/rpm] manage pid folder (#68262)
* [deb/rpm] manage pid folder

This adds a tmpfiles.d configuration file for systemd users, and changes
the path for both systemd and sysv to /var/run/kibana/kibana.pid.  pid
file generation is left unmodified for a future pr.

* cleanup

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 14:25:27 -05:00
Justin Kambic 858523eac6
[Uptime] Edit uptime alerts (#68005)
* Extract store creation to plugin start, add redux providers to alert registration.

* Update unit test.

* Move alert registration to `setup` function.

* Allow external editing of uptime client alert types.

* Move alert initialization back to `start`.

* Clean up interfaces for alert types.

* Add code that will work for settings link even outside uptime app.

* Create new atomic params type for status alerts.

* Update executor params typing to support both alert params types.

* Update snapshot for alert factory function.

* Fix broken types and refresh snapshots.

* Allow edits of filters for monitor alerts.

* Support default parameter value for numTimes.

* Support default parameter values for timerange.

* Modify kuery bar to work for alert edits, fix some filter issues.

* Clean up tests and fix types.

* Fix types and add a test.

* Add callout and validation handling for old alerts while editing.

* Add a test for updated validation function.

* Define window for overview filters fetch action.

* Revert store initialization.

* Make monitor counter function while editing alerts.

* Refresh snapshot.

* Move snapshot count in monitor status alert to callout.

* Add new state for selected filters.

* Add basic functional tests for uptime alert flyouts.

* Fix broken types.

* Update unit tests with mock provider.

* Remove unneeded params from hook.

* Add more unit tests.

* Reducing functional test flakiness.

* Alert flyout controls update url only within Uptime app.

* Extract context interaction to container component, update snapshots.

* Add missing parameter to test file.

* Remove flaky functional test.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
2020-06-08 15:15:47 -04:00
Nathan Reese 891342a76f
[Maps] fix regression in adding TMS layer (#68471)
* [Maps] fix regression in adding TMS layer

* simplify endDataLoad signature

* rename

* review feedback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 13:05:00 -06:00
Spencer 25e71c1096
upgrade npm-run-path (#68539)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-06-08 11:29:09 -07:00
Matthias Wilhelm 23be466c97
[Discover] Replace EuiTooltip by native title for better performance (#68280) 2020-06-08 20:24:54 +02:00
Lukas Olson 8174b5ce29
[Search] Refactor service to register search strategies, not providers (#60342)
* Add async search strategy

* Add async search

* Fix async strategy and add tests

* Move types to separate file

* Revert changes to demo search

* Update demo search strategy to use async

* Add async es search strategy

* Return response as rawResponse

* Poll after initial request

* Add cancellation to search strategies

* Add tests

* Simplify async search strategy

* Move loadingCount to search strategy

* Update abort controller library

* Bootstrap

* Abort when the request is aborted

* Add utility and update value suggestions route

* Fix bad merge conflict

* Update tests

* Move to data_enhanced plugin

* Remove bad merge

* Revert switching abort controller libraries

* Revert package.json in lib

* Move to previous abort controller

* Add support for frozen indices

* Fix test to use fake timers to run debounced handlers

* Revert changes to example plugin

* Fix loading bar not going away when cancelling

* Call getSearchStrategy instead of passing  directly

* Add async demo search strategy

* Fix error with setting state

* Update how aborting works

* Fix type checks

* Add test for loading count

* Attempt to fix broken example test

* Revert changes to test

* Fix test

* Update name to camelCase

* Fix failing test

* Don't require data_enhanced in example plugin

* Actually send DELETE request

* Use waitForCompletion parameter

* Use default search params

* Add support for rollups

* Only make changes needed for frozen indices/rollups

* Only make changes needed for frozen indices/rollups

* Add back in async functionality

* Fix tests/types

* Fix issue with sending empty body in GET

* Don't include skipped in loaded/total

* Don't wait before polling the next time

* Add search interceptor for bulk managing searches

* Simplify search logic

* Fix merge error

* Review feedback

* UI to stop async searches

* Add service for running beyond timeout

* Refactor abort utils

* Remove unneeded changes

* Add tests

* Refactor search service to register strategies directly

* Remove accidental change

* re-generate docs

* Fix merge

* types

* doc

* eslint

* Fix async strategy jest test

* type fix

* Use getStartServices in search strategies

* Code review + snapshot

* eslint

* Type script

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Liza K <liza.katz@elastic.co>
2020-06-08 21:22:09 +03:00
Corey Robertson 16fbbf4345
[Canvas] Tear down history instances (#68277)
* [Canvas] Tear down history instances

* Always create history on Canvas startup

Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 14:11:51 -04:00
Thomas Neirynck 0189ae5c3f
[Maps] Enable gridding/clustering/heatmaps for geo_shape fields (#67886)
Enables heatmap, clusters, and grid layers for index-patterns with geo_shape field. This feature is only available for Gold+ users.
2020-06-08 11:51:04 -04:00
Melissa Alvarez e2f11e9fe9
[ML] DFAnalytics results: ensure ml result fields are shown in data grid (#68305)
* wip: ensure top classes and influencer result col show up correctly

* ensure ml subFields columns are populated
2020-06-08 11:19:01 -04:00
Robert Austin bc3918671c
[security_solution] enable react-hooks/exhaustive-deps (#68470)
* Enable `react-hooks/exhaustive-deps` rule for security_solution
* Disable it anywhere that it would catch an issue
2020-06-08 10:43:10 -04:00
Oliver Gupte 2bedb59c8e
Closes #66867 by adding missing, requried API params (#68465)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 07:30:14 -07:00
Stratoula Kalafateli fcab9745e0
[Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (#67865)
* Update telemetry for visualizations to also count the vis from the past 30 and 90 days

* Also add metrics for the saved visualizations for the past 7 days

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 17:29:20 +03:00
Alejandro Fernández e66eaf74fd
[Logs UI] View in context tweaks (#67777)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 15:49:26 +02:00
Stacey Gammon f89e911f64
Kibana developer examples landing page (#67049)
* Kibana developer examples

* Batch explorer tests should be run in examples config

* Fix tests

* add codeowner for new developer examples plugin & readme cleanup

* Try to frame embeddable wording based on what a developer's goals are.

* Add noopener noreferer, fix bad merge

* Remove bfetch.png

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 09:47:51 -04:00
Joe Portner c29fcbb46b
Bump decompress package version (#68386) 2020-06-08 09:45:06 -04:00
Peter Pisljar de4eaf9ae7
fix #66185 (#66186) 2020-06-08 15:31:14 +02:00
Joe Portner 77ab709976
Bump pdfmake package version (#68395) 2020-06-08 09:19:32 -04:00
Anton Dosov 49171516d7
Unskip embeddables/adding_children suite (#68111)
Giving it another chance *cross fingers* 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 15:01:55 +02:00
Alex Wild 38b9a8db8a
Add embed mode options in the Share UI (#58435) 2020-06-08 14:12:03 +02:00
Cauê Marcondes 00cff3cd7e
Adding key to avoid react warning (#68491) 2020-06-08 13:03:05 +02:00
Tim Roes 09eaa1c57a
Add app arch team as owner of datemath package (#66880)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 11:37:44 +02:00
Cauê Marcondes 07e3c9cb41
[Observability] Landing page for Observability (#67467)
* creating overview page and menu

* styling the home page

* adjusting breadcrumb

* renaming isnt working

* renaming isnt working

* renaming isnt working

* fixing import

* fixing scroll when resize window

* fixing eslint errors

* prepending links

* adding target option

* refactoring

* adding dark mode support

* fixing prettier format

* fixing i18n

* reverting some unnecessary changes

* addressing PR comments

* fixing functional tests

* ordering observability menu

* fixing tests

* addressing PR comments

* fixing test

* fixing scroll

* addressing pr comments

* addressing pr comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 09:07:35 +02:00
patrykkopycinski 48ef260e11
[SIEM] Fix timeline buildGlobalQuery (#68320) 2020-06-06 11:25:12 +02:00
Rudolf Meijering 2559dbe3ba
Optimize saved objects getScopedClient and HTTP API (#68221)
* Create a single repository to be shared by all calls to getScopedClient

* Cache migrator.getActiveMappings to improve createRepository

* Use typeregistry.getAllTypes instead of getRootPropertiesObjects(mappings)

* Don't validate plugin's config every time it's read

* Fix saved_objects_mixin
2020-06-06 01:05:02 +02:00
Thomas Neirynck 77c8aee3cd
[Maps] Fix mb-style interpolate style rule (#68413) 2020-06-05 17:33:38 -04:00
Dmitry Lemeshko 1f99144ef6
update script to always download node (#68421)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-05 23:28:49 +02:00
Xavier Mouligneau e3d88a4f09
[SECURITY SOLEIL] Fix selection of event type when no siem index signal created (#68291)
* fix selection of event type when no siem index signal created

* including the term signal for the old timeline

* fix import path

* Add a specific msg in the inspect modal if we do not have the alert index created

* fix import if eventType is siganl to match it to alert

* forget to update test

* fix signal view

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-05 15:29:16 -04:00
gchaps eaca7ee008
[DOCS] Adds note about configuring File Data Visualizer (#68407) 2020-06-05 11:10:52 -07:00
gchaps 66138a8e71
[DOCS] Adds link from remote clusters to index patterns (#68406) 2020-06-05 11:09:45 -07:00
Tre 5bfd704dd8
[QA] slack notify on failure (#68126) 2020-06-05 10:49:06 -06:00
Robert Austin c98cfda890
upgrade eslint-plugin-react-hooks from 2.3.0 to 4.0.4 (#68295)
* updates `eslint-plugin-react-hooks` from `v2.3.0` to `v4.0.4`. 
* Disable rules on failing lines
2020-06-05 12:43:55 -04:00
Xavier Mouligneau bc7655a80f
moving to jira to a gold license (#67178)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-05 12:34:18 -04:00
gchaps 891e3c585c
[DOCS] Revises doc on adding data (#68038)
* [DOCS] Revises doc on adding data

* Update docs/setup/connect-to-elasticsearch.asciidoc

Co-authored-by: debadair <debadair@elastic.co>

* Update docs/setup/connect-to-elasticsearch.asciidoc

Co-authored-by: debadair <debadair@elastic.co>

* Update docs/setup/connect-to-elasticsearch.asciidoc

Co-authored-by: debadair <debadair@elastic.co>

* Update docs/setup/connect-to-elasticsearch.asciidoc

Co-authored-by: debadair <debadair@elastic.co>

* Update docs/setup/connect-to-elasticsearch.asciidoc

Co-authored-by: debadair <debadair@elastic.co>

* Update docs/setup/connect-to-elasticsearch.asciidoc

Co-authored-by: debadair <debadair@elastic.co>

* Update docs/setup/connect-to-elasticsearch.asciidoc

Co-authored-by: debadair <debadair@elastic.co>

* [DOCS] Minor edits to add data doc

* [DOCS] Incorporated review comments

* [DOCS] Incorporates review comments

* [DOCS] Removes link to advanced settings

Co-authored-by: debadair <debadair@elastic.co>
2020-06-05 09:06:12 -07:00
Søren Louv-Jansen c7353b0b0e
[APM] Add ThemeProvider to support dark mode (#68242) 2020-06-05 17:39:33 +02:00
Robert Oskamp fd1ad4c293
Make welcome screen disabling first action in loginIfPrompted (#68238)
This PR moves the welcome screen disabling in loginIfPrompted to the first position.
2020-06-05 17:39:03 +02:00
Dmitry Lemeshko 5064ae4a4c
[QA] Code coverage: unskip tests, collect tests results, exclude bundles from report (#64477)
* custom nyc configs, run all tests

* copy tests results back to original folder
2020-06-05 09:34:25 -06:00