Commit graph

73 commits

Author SHA1 Message Date
Marco Liberati
53ea09078f
[Lens] Visualization validation and better error messages (#81439)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-04 18:28:00 +01:00
Joe Reuter
fe3b0538ff
[Lens] Categorical color palettes (#75309) 2020-11-04 11:27:52 +01:00
Marta Bondyra
6689167b64
[Lens] Drag within dimension group to reorder (#80547) 2020-11-03 21:18:44 +01:00
Joe Reuter
d8c37fe890
[Lens] Reload on change via history object (#81753) 2020-11-03 14:29:56 +01:00
Devon Thomson
8c1b2157df
[Time to Visualize] Small Attribute Service Fixes (#82072)
* Removed some dashboard-centric wording from the Attribute Service & removed type argument from save method
2020-11-02 11:25:53 -05:00
Joe Reuter
512c35e70b
fix Lens heading structure (#81752) 2020-10-30 11:20:54 +01:00
Michael Marcialis
2a38461817
[Lens] Adjust Lens Visualization Padding in Dashboards (#81911)
* reduce padding on lens visualizations in dashboard

* tweak padding and axes title colors to match lens

* remove faux padding (border) to match lens padding

* update snapshots

* Revert "update snapshots"

This reverts commit c63cf2bf1c.

* update functional test baseline screenshot
2020-10-29 16:52:02 -04:00
Anton Dosov
6deafd06b8
[Search] Use session service on a dashboard (#81297) 2020-10-29 16:43:22 +01:00
Joe Reuter
59662eefd2
[Lens] Add loading indicator during debounce time (#80158) 2020-10-29 16:06:12 +01:00
Marco Liberati
8f92de860c
[Lens] Improved range formatter (#80132)
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2020-10-27 18:08:01 +01:00
Joe Reuter
ea229891f1
fix flaky unit test (#81466) 2020-10-22 17:12:49 +02:00
Joe Reuter
88a9453500
[Lens] Lazy load lens telementry and attribute service (#80479) 2020-10-19 17:21:25 +02:00
Peter Pisljar
c90dabaeba
removing kibana_datatable in favor of datatable (#80548) 2020-10-16 18:46:51 +02:00
spalger
6eeab00944 Revert "removing kibana_datatable in favor of datatable` (#75184)"
This reverts commit 255b865be8.
2020-10-13 08:53:14 -07:00
Peter Pisljar
255b865be8
removing kibana_datatable in favor of datatable` (#75184) 2020-10-13 17:00:38 +02:00
Joe Reuter
cd84ace53d
[Lens] Leverage original http request error (#79831) 2020-10-13 15:17:40 +02:00
Maja Grubic
13059bdd8f
[Refactor] Move AttributeService from Dashboard to Embeddable plugin (#79830)
* [Refactor] Move AttributeService from Dashboard to Embeddable plugin

* Fix wrong import

* Fixing typescript errors

* Make Dashboard a required dependency

* Fixing circular dependency

* Fix label namespace

* Updating docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-12 14:51:39 +01:00
Marta Bondyra
cded1ce5f1
[Lens] Don't debounce visualization settings UI (#79625)
* perf: don't debounce settings menu

* perf: fix performance for settings
2020-10-07 10:17:17 +02:00
Wylie Conlon
2de2c70f75
[Lens] Break long titles into multiple lines (#79580) 2020-10-06 11:50:44 -04:00
Joe Reuter
11886bf51c
[Lens] Add search to chart switcher (#77631) 2020-10-06 17:17:41 +02:00
Stratoula Kalafateli
08a4586b14
[Lens] Navigate from discover to lens (#77873)
* Create lens action and unregister the visualize one

* remove console

* Implement Discover to Lens, wip, missing tests

* Add unit tests

* fix embed lens to empty dashboard functional tests

* fix suggestions on save

* Fix bug on save button, query and filters should be transferred from discover

* Add functional test for the navigation from Discover to Lens

* PR update after code review

* unregister visualize action only if the action exists

* Change the test to not be flaky

* Move suggestions to editor frame and hide the emptyWorkspace for visualize field

* Update ui actions docs

* Add a retry to remove test flakiness

* Fix bug of infinite loader when removing the y axis dimension

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 11:15:41 +03:00
Maja Grubic
989e9c9702
Refactor attribute service (#78414)
* Making saveMethod mandatory in attribute service

* Making unwrap method mandatory

* Making book embeddable respect new attribute service

* Remove savedObjectsClient from attribute service

* Add checkForDuplicateTitle method to book embeddable

* Make options mandatory on attribute service

* Changing Lens attribute service

* Somw more typescript fixes

* Fixing attribute service typescript and tests

* Fixing typescript errors

* Unsetting feature flag

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 08:31:55 +01:00
Marta Bondyra
ce97982522
[Lens] refactor DimensionContainer and fix flyout bug (#79277) 2020-10-05 12:41:09 +02:00
Joe Reuter
b66de2ce1d
improve lens lazy loading (#79292) 2020-10-02 21:50:25 +02:00
Marta Bondyra
fccfad24cb
[Lens] remove test warnings about improper HTML structure (#79251)
* [Lens] remove test warnings about improper HTML structure
2020-10-02 17:18:20 +02:00
Marco Liberati
198c5d9988
[Lens] Fix embeddable title and description for reporting and dashboard tooltip (#78767)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-01 18:02:37 +02:00
Caroline Horn
e248f32111
[Lens] Consistent Drag and Drop styles (#78674)
* Remove wrapping div of DragDrop and pass props to child
* Using EuiHighlight
* Basic styles in for all DnD states
* Fixing dimension button styles
* Fix FieldButton to accept `…rest` props
* A few other minor fixes
* Fixed horizontal scroll of error message
* Quick fix for invalid link
2020-10-01 11:58:23 -04:00
Marta Bondyra
8948811c63
fix: add EuiOutsideClickDetector (#78733)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-01 12:54:48 +02:00
Joe Reuter
dbef60d3f1
[Lens] Reduce initial bundle size (#78142) 2020-09-29 19:00:29 +02:00
Caroline Horn
ba635340be
[Lens] Add a better drag/drop illustration (#78245)
Fixes #76021
2020-09-24 09:46:18 -04:00
Devon Thomson
32abbff685
[Time to Visualize] Lens By Value With AttributeService (#77561)
Used the attribute service to make lens work properly with by value embeddables.
2020-09-23 17:40:52 -04:00
Stratoula Kalafateli
c4eb47a46b
[Lens] Settings panel redesign and separate settings per y axis (#76373)
* wip, redsign the xy axis general settings

* pie chart settings. fix tests, initial implementation

* Fix Internationalization

* Cleanup

* remove unused translations

* Add test to check that right axis is enabled

* fix test

* remove unecessary translation

* Added icons and cleaned up some of the visuals for grouped buttons

* Fix types

* Axis Settings Popover Reusable Component

* Legend Popover Reusable Component

* Cleanup unused translations

* Fix right axis behavior

* Revert yLeftTitle to yTitle to avoid migration

* PR fixes

* identify which axis is enabled

* Change the logic on enabling the y axes popovers

* Adjust axis popover on horizontal bars

* fix failing test and change the logic of fetching the y axis titles

* Simpify the axis title logic, make the toolbar repsponsive, add TopAxisIcon

* Ui Changes on legends popover

* Cleanup and more unit tests

* use groupId instead of index to take under consideration all possible scenarios

* fix gridlines

* Remove ts-ignore from icons and move toolbar button to shared components

* Workspace toolbar wraps on smaller devices

* Tooltip on Toolbar appears only if the button is disabled

* clean up

* Add missing translations

* fix eslint

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-16 11:30:19 +03:00
Wylie Conlon
e9a4555623
[Lens] Remove dynamic names in telemetry fields (#76988)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-15 18:27:39 -04:00
Joe Reuter
63f0cc0519
[Lens] Stack as percentage (#70703) 2020-09-15 11:24:02 +02:00
Caroline Horn
5a2f7ae897
[Lens] Move configuration popover to flyout (#76046)
* Moving to a Flyout implementation
* Fix up inner layout of flyout
* Fix up form rows
2020-09-14 18:23:13 -04:00
Marta Bondyra
0c678ebada
[Lens] Filters aggregation (#75635) 2020-09-10 21:16:07 +02:00
Wylie Conlon
9ca8551cda
[Lens] Drag dimension to replace (#75895)
* [Lens] Drag to replace

* Add jest tests for drag and drop

* Fix bug in dragging to empty

* Hide dragged dimension when drag starts

* Make table metrics required

* Update class names

* Implement styles on non-droppable items

* Replace drag and drop image in docs

* Remove extra specificity

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-04 10:11:41 -04:00
Wylie Conlon
3dea4444b9
[Lens] Remove beta labels (#75574)
* [Lens] Remove beta labels

* Remove translations

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-24 12:07:28 -04:00
Joe Reuter
86f73cb0c2
[Lens] Register saved object references (#74523) 2020-08-21 18:08:25 +02:00
Marta Bondyra
e04e05aa56
[Lens] Fix crash when two layers xychart switches to pie (#75267)
* [Lens] fix crash on two layers and add a functional test with two layers switching to pie chart
2020-08-18 14:27:43 +02:00
Marta Bondyra
626fbc2948
[Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule (#70010) 2020-08-06 10:10:09 +02:00
Marta Bondyra
cf6413ab2f
[Lens] fix chart switching when on VisualizationDimensionEditor (#70689) 2020-08-05 18:25:16 +02:00
Mikhail Shustov
88c0631344
Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091)
* bump @typescript-eslint deps

* update rules

* fix errors in pacakges

* fix src/

* fix x-pack

* fix test

* fix typings

* fix examples

* allow _ as prefix and suffix

* roll back prefix and suffix changes

* add eslint-plugin-eslint-comments

* report unused rules

* remove unused eslint comments from tests

* remove unused eslint comments 2nd pass

* remove unused eslint comments from src/

* remove unused comments in x-pack

* use no-script-url and no-unsanitized/property for ts files

* remove unused eslint comments

* eui/href-or-on-click removed when not complained

* no import/* rules for ts files

* cleanup

* remove the unused eslint-disable

* rollback unnecessary changes

* allow underscore prefix & sufix in type name

* update docs

* fix type error in enterprise search plugin mocks

* rename platform hack __coreProvider --> _coreProvider

* rollback space removal in src/core/public/legacy/legacy_service.test.ts

* fix naming convention in APM
2020-08-05 17:32:19 +02:00
Joe Reuter
5cdd0801b2
fix bug (#72809) 2020-07-23 09:35:36 +02:00
Joe Reuter
3709de64d6
[Lens] Legend config (#70619) 2020-07-22 12:14:59 +02:00
Devon Thomson
9facf416f5
Applying tiny fix from 72532 to main branch (#72533) 2020-07-21 09:56:13 -04:00
Wylie Conlon
35ff37a434
[Lens] Fix switching with layers (#71982)
* [Lens] Fix chart switching with multiple layers

* Unskip Lens smokescreen test

* Fix types

* Revert <p> change
2020-07-17 14:02:52 -04:00
Marta Bondyra
cdbe12ff57
[Lens] XY chart -long legend overflows chart in editor Feature:Lens (#70702) 2020-07-14 22:41:58 +02:00
Caroline Horn
ddd8fa8947
[Lens] 7.9 design cleanup (#71444)
* Fix dimension popover layout and color picker “Auto”

* Created ToolbarButton

* Move disabled help text to tooltip for missing values

* Darker side panel backgrounds

* Adding to .asciidoc about where to put the SASS import

* Moving `SASS` guidelines to STYLEGUIDE.md

* Fix keyboard focus of XY settings popover

* Fix dark mode
2020-07-13 20:06:58 -04:00
Joe Reuter
bbda3f99ef
[Lens] Fitting functions (#69820) 2020-07-03 16:15:06 +02:00