Commit graph

40360 commits

Author SHA1 Message Date
Nathan Reese
57bce4967a
Remove field type filtering from IndexPatternSelect (#97035) (#97302)
* Remove field type filtering from IndexPatternSelect

* remove unused import

* api doc updates

* update jest snapshots

* another fix for jest test

* review feedback

* tslint

* update jest snapshot for changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 16:44:54 -04:00
Matthias Wilhelm
7a14e4d613
[Discover] Unskip doc navigation functional test (#96948) (#97304) 2021-04-15 16:40:21 -04:00
Kibana Machine
1c84ba66c9
[Usage Collection/Cloud Provider] Fix isReady bug (#97279) (#97297)
Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
2021-04-15 20:21:22 +00:00
Kibana Machine
1d09f16f45
Adds Network ML module with four ML jobs for ECS network data (#96480) (#97272)
* network module

adds the network module with four ml jobs for the 7.13 release

* Update datafeed_high_count_network_denies.json

json formatting

* update test

added the security_network module to the list

* renames

module name change to security_network / Security: Network

* formatting

change hyphen char to underscores

* fixes and name changes

fixes to df queries, descriptions. created_by param

* update tests

tests need the security_network module added

* formatting

change hyphens to underscores

* descriptions

format descriptions

* Update datafeed_high_count_network_events.json

indentation fixes

* Update x-pack/plugins/ml/server/models/data_recognizer/modules/security_network/manifest.json

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update x-pack/plugins/ml/server/models/data_recognizer/modules/security_network/ml/high_count_network_denies.json

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update datafeed_high_count_network_events.json

change to a filter

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>

Co-authored-by: Craig Chamberlain <randomuserid@users.noreply.github.com>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2021-04-15 19:38:09 +00:00
Kibana Machine
027ce47f35
[Detection Rules] Remove empty values in threshold.field array for threshold rules (#97111) (#97291)
## Issues
related to https://github.com/elastic/detection-rules/issues/1097
related to https://github.com/elastic/detection-rules/pull/1099

## Summary

`threshold.field` is an array that currently requires at least one value. An empty string `""` was required if no value was supplied. Instead, this needs to be replaced with no string and just an empty array.
### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
2021-04-15 15:20:48 -04:00
Kibana Machine
0d43431138
[Graph] Fix fields clearing within the Editor (#96767) (#97288)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
2021-04-15 19:04:58 +00:00
Phillip Burch
34e0074b20
[Metrics UI] Add anomalies tab to enhanced node details (#96967) (#97285)
* Adapt the anomalies table to work in overlay

* Wire up the onClose function

* Make "show in inventory" filter waffle map

* Remove unused variable

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 14:53:07 -04:00
Kibana Machine
d26c41a690
fix test leak (#97082) (#97281)
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2021-04-15 14:17:32 -04:00
Jean-Louis Leysens
01d2b0f0c5
[ILM] Support max primary shard size rollover field (#96545) (#97283)
* added max primary shard size rollover field

* large-ish refactor of the hot phase component to move the rollover fields to their own components

* added comment

* address i18n issue

* - fixed jest tests
- fixed behaviour to show missing value for rollover
- updated jest snapshots

* added field deprecation component

* added test for whether deprecation icon is visible

* remove unused import, remove type generic from FormSchema

* fixed getting "getFields" from incorrect object

* wip!!!

* - removed FieldDeprecationWarning component and associated tests
- implmented always showing the warning icon and updated the color
- cleaned up test helpers

* - more tightly grouped the numeric inputs with their unit selects
  by reducing the gutter size before defazios feedback
- fixed alignment issue between numeric rollover inputs and their
  unit select field by adding flex-end styling to the groups

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 14:16:32 -04:00
Kibana Machine
3b58233ae6
Harden saved object deserialization (#94842) (#97282)
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
2021-04-15 14:10:31 -04:00
Kerry Gallagher
cb730d3c40
[Logs UI] Provide support for Kibana Index Patterns in the logs source configuration (#96454) (#97274)
* Provide support for Kibana Index Patterns in the logs source configuration

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
2021-04-15 13:50:56 -04:00
Kibana Machine
12d943c8f4
[Security Solutions ] Fixes failed to query DNS data - too_many_buckets_exception (#97069) (#97273)
## Summary

Fixes a bug where on the DNS tab of networks you can get a `too_many_buckets_exception`. Worked through the query with @angorayc and together I think we figured out that the query could be re-written with aggregations in a way to get the same results without having to query a large amount of terms which causes the buckets exception.

Added a e2e test and one way of being able to call bsearch in the e2e when it returns the search is still in progress so we don't have the large query test cause flakiness 🤞 .

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
2021-04-15 13:38:09 -04:00
Kaarina Tungseth
3417548167
[7.x] [DOCS] Adds 7.12.1 release notes (#97119) (#97292)
* [DOCS] Adds 7.12.1 release notes

* Adds coming tag

* Update docs/CHANGELOG.asciidoc

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>

* Review comments

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
2021-04-15 12:23:52 -05:00
Kibana Machine
1e59873c69
[ML] Functional tests - fix transform _nodes API test for cloud (#97240) (#97262)
This PR fixes the transform _node API tests for cloud, where more than one transform node could be available.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
2021-04-15 16:48:59 +00:00
Chris Roberson
0155a16dab
[Alerting] Show more user friendly ES error message when executor fails (#96254) (#97259)
* WIP for ES error parser

* Fix tests

* Ensure the error shows up in the UI too

* wip

* Handle multiple types here

* Fix tests

* PR feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 12:30:10 -04:00
Kibana Machine
b7a4dce1dc
Log if no plugins are installed when listing plugins in cli (#97235) (#97255)
Co-authored-by: Thomas Watson <w@tson.dk>
2021-04-15 16:09:12 +00:00
Kibana Machine
e38aec32a1
Remove blank line at the end of cli plugin list (#97234) (#97252)
Co-authored-by: Thomas Watson <w@tson.dk>
2021-04-15 11:49:44 -04:00
Thomas Neirynck
58d6b24cd1
[Maps] Add cache control to mvt endpoints (#94861) (#97248) 2021-04-15 11:23:56 -04:00
Kibana Machine
44eb20849d
[DocLinks] Update outdated docs (#97217) (#97268)
Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
2021-04-15 11:12:33 -04:00
Kibana Machine
7c2059606b
Index pattern management - fix runtime fields icon (#95117) (#97244)
* account for fields from saved object
* use correct icon for runtime fields

Co-authored-by: Matthew Kime <matt@mattki.me>
2021-04-15 15:06:47 +00:00
Kibana Machine
297a85f97c
[Lens] Open lens in new tab via state transfer (#96723) (#97245)
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
2021-04-15 15:05:54 +00:00
Sandra Gonzales
7ce5d60ba7
[Metrics UI] handle ES query errors in snapshot endpoint, improve UI error messaging (#96871) (#97242)
* handle es errors in snapshot api, show error message as toast danger in UI

* use err.message if no err.body.message

* use updated handleEsError
2021-04-15 10:57:38 -04:00
Kibana Machine
e6c846fa4e
[Uptime] - Synthetics add transfer size, resource size, and status to waterfall flyout (#97042) (#97243)
Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
2021-04-15 10:56:57 -04:00
Kibana Machine
876b6ccfa4
[Lens] Close dimension panel on escape key (#96783) (#97241)
*  Close panel on escape key

* 👌 Stabilize callback ref

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
2021-04-15 10:40:46 -04:00
Kibana Machine
d780532347
[ML] Functional tests - stabilize swim lane pagination test (#97214) (#97239)
This PR stabilizes the swim lane pagination test by adding a retry to the assertion.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
2021-04-15 10:26:36 -04:00
Alexey Antonov
90bddab6f6
[TSVB] fix not populating fields list if "Auto apply" is off (#96298) (#97238)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 10:23:56 -04:00
Kibana Machine
f3530e582b
[Logs UI] Allow for missing properties on ES shard failure responses (#96768) (#97233)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
2021-04-15 09:45:10 -04:00
Maja Grubic
f187515c1a
[Discover] Runtime Fields Editor integration: Add + Delete operation (#96762) (#97231)
* [Discover] Updating a functional test

* [Discover] Support for edit operation

* Fix unit tests

* Fix typescript

* Fixing failing functional test

* Fixing wrongly commented line

* Uncomment accidentally commented line

* Reintroducing accidnetally removed unit test

* Trigger data refetch onSave

* Remove refreshAppState variable

* Bundling observers together

* Clean state before refetch

* Update formatting in data grid

* [Discover] Runtime fields editor : add operation

* [Discover] Updating a functional test

* Adding a functional test

* Fixing package.json

* Reset fieldCount after data fetch

* [Discover] Updating a functional test

* Don't allow editing of unmapped fields

* Add functionality

* Fix issues with mobile display

* Allow editing if it's a runtime field

* Add a functional test

* [Discover] Updating a functional test

* Add functional test

* Remove unnecessary debugger statement

* Add more tests

* Add delete functionality

* Include runtimeFields in doc search

* Add another functional test

* [Discover] Updating a functional test

* Fix failing i18n check

* Fix package.json

* Addressing PR comments

* Addressing design input

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 09:20:08 -04:00
Alexey Antonov
7c259ef914
[TSVB] Fix error handling issue for KQL queries (#97088) (#97227)
* [TSVB] Fix error handling issue for KQL queries

* remove KQLSyntaxError

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 09:03:34 -04:00
Kibana Machine
9ef3a5d8d6
[Exploratory view] Improve/Polish components usage (#96782) (#97221)
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
2021-04-15 08:12:16 -04:00
István Zoltán Szabó
917391849f
[ML] Changes custom rule terminology on the ML UI (#96999) (#97211)
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2021-04-15 11:15:00 +02:00
István Zoltán Szabó
d32d72d028
[ML] Changes text in mean recall tooltip. (#96990) (#97209) 2021-04-15 11:13:01 +02:00
Maja Grubic
e35dc9c9bf
[Discover] Fix redirect from Dashboard (#97098) (#97212)
* [Discover] Fix redirect from Dashboard

* Updating a unit test
2021-04-15 05:07:15 -04:00
Stratoula Kalafateli
88e9372206
[XY Axis] Fixes problem with series being displayed twice (#96773) (#97208)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 04:00:29 -04:00
Alexey Antonov
9099e7fb34
Update VisualizationNoResults component (#97092) (#97177)
* Update VisualizationNoResults component

* update JEST

* fix font size
2021-04-15 03:56:51 -04:00
Tim Sullivan
553f130a63
[7.x] Reporting: Refactor functional tests with security roles checks (#96856) (#97145)
* Reporting: Refactor functional tests with security roles checks (#96856)

* Reporting: Refactor functional tests with security roles checks

* consolidate initEcommerce calls

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/reporting_api_integration/reporting_and_security/index.ts

* fix ts
2021-04-15 03:38:54 -04:00
Kibana Machine
e282cfe201
[Fleet] Fleet server onboarding UI (#96867) (#97207)
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
2021-04-15 03:37:51 -04:00
Candace Park
45a680d2b6
[Security Solution][Endpoint][Admin] Fix policy details test warning (#97182) (#97203) 2021-04-15 02:45:48 -04:00
Kibana Machine
9b326c67c9
chore(NA): moving @kbn/utility-types into bazel (#97151) (#97199)
* chore(NA): moving @kbn/utility-types into bazel

* chore(NA): solve ts config errors

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
2021-04-14 23:38:45 -04:00
Kibana Machine
b338c69e28
[Fleet] Rename force to revoke agent unenroll APIs (#97041) (#97196)
## Summary

 - fcbc9d9 Rename `force` param to `revoke` for `/agents/{agent_id}/unenroll` & `/agents/bulk_unenroll`
 - 03b9b90 Add new `force` param

See https://github.com/elastic/kibana/issues/96873 for background

<table>
  <thead>
    <tr>
      <td rowspan="2"></td><td colspan="2">Unenroll Agent</td><td rowspan="2">Revoke API Keys</td>
    </tr>
    <tr>
      <td>Regular</td><td>Hosted</td></td>
    </tr>
  </thead>
  <tr><td colspan="4"><strong>Rename <code>force</code> to <code>revoke</code></strong></td></tr>
  <tr><td>Current <code>force=false|undefined</code></td><td></td><td></td><td></td></tr>
  <tr><td>Proposed <code>revoke=false|undefined</code></td><td></td><td></td><td></td></tr>
  <tr><td>Current <code>force=true</code></td><td></td><td></td><td></td></tr>
  <tr><td>Proposed <code>revoke=true</code></td><td></td><td></td><td></td></tr>
  <tr><td colspan="4"><strong>Change <code>force</code> param </strong></td></tr>
  <tr><td>Proposed <code>force=false|undefined</code></td><td></td><td></td><td></td></tr>
  <tr><td>Proposed <code>force=true</code></td><td></td><td></td><td></td></tr>
  <tr><td>Proposed <code>force=true</code> & <code>revoke=true</code></td><td></td><td></td><td></td></tr>
</table>

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

### Changes required for consumers
Any call to `/agents/{agent_id}/unenroll` & `/agents/bulk_unenroll` which passes the `force` param should change to `revoke` to maintain the current behavior.

Co-authored-by: John Schulz <john.schulz@elastic.co>
2021-04-14 21:33:10 -04:00
Bhavya RM
9aeec426d8
Test user for maps test verifying sample data maps (#96109) (#97195)
test user for sample maps test & removing geoall_writer_role from add layer
2021-04-14 21:29:41 -04:00
Kibana Machine
03a4edb1f5
[App Search] Refactor out a shared MultiInputRows component (#96881) (#97193)
* Add new reusable MultiInputRows component

- basically the CurationQuery component, but with a generic values var & allows passing in custom text for every string

* Update CurationQueries with MultiInputRows

* Update MultiInputRows to support on change behavior

- for upcoming Relevance Tuning usage

* Update Relevance Tuning value boost form to use new component

- relevance_tuning_form.test.tsx fix: was getting test errors with mount(), so I switched to shallow()

* Change submitOnChange to onChange fn

- more flexible - allows for either an onSubmit or onChange, or even potentially both

* Convert MultiInputRowsLogic to keyed Kea logic

- so that we can have multiple instances on the same page - primarily the value boosts use case

* Update LogicMounter helper & tests to handle keyed logic w/ props

* [Misc] LogicMounter helper - fix typing, perf

- Use Kea's types instead of trying to rewrite my own LogicFile
- Add an early return for tests that pass `{}` to values as well for performance

* PR feedback: Change values prop to initialValues

+ bonus - add a fallback for initially empty components
+ add a test to check that the logic was mounted correctly

* PR feedback: Remove useRef/on mount onChange catch for now

- We don't currently need the extra catch for any live components, and it's confusing

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
2021-04-15 00:16:40 +00:00
Rashmi Kulkarni
34965c5b6a
unskip accessibility - dashboard_edit_panel tests (#96710) (#97192)
* unskip

* added render complete

* added render complete in couple other places

* minor corrections

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 20:16:24 -04:00
spalger
433e74b41b skip flaky suite (#97085)
(cherry picked from commit 82b7082459)
2021-04-14 16:41:47 -07:00
Kibana Machine
19a90b5bc8
[Security Solution] Converge detection engine on single schema representation (#96186) (#97152)
* Replace validation function in signal executor

* Remove more RuleTypeParams usage

* Add security solution rules migration to alerting plugin

* Handle and test null value in threshold.field

* Remove runtime normalization of threshold field

* Remove signalParamsSchema

Co-authored-by: Davis Plumlee <davis.plumlee@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>
Co-authored-by: Davis Plumlee <davis.plumlee@elastic.co>
2021-04-14 23:33:38 +00:00
Kibana Machine
87f2c1084b
Fixed relevance tuning (#97172) (#97186)
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
2021-04-14 18:54:16 -04:00
Kibana Machine
acd8ac72cd
[Workplace Search] Source row and Group Manager Modal bugfixes (#97166) (#97183)
* Add spacing to group manager modal

* Add error state to source row

This mimics the design pattern from the overview page

Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
2021-04-14 18:30:48 -04:00
Kibana Machine
5ba7fc1ec2
Discover: Limit document table rendering (#96765) (#97178)
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2021-04-14 21:12:13 +00:00
Kibana Machine
9b3499a779
chore(NA): moving @kbn/tinymath into bazel (#97022) (#97173)
* chore(NA): moving @kbn/tinymath into bazel

* chore(NA): fixed jest tests

* chore(NA): simplified tsconfig file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
2021-04-14 17:00:16 -04:00
Kibana Machine
219096e23e
[Workplace Search] Bypass UnsavedChangesPrompt for tab changes in Display Settings (#97062) (#97160)
* Move redirect logic into logic file

* Add logic to prevent prompt from triggering when changing tabs

The idea here is to set a boolean flag that sends false for unsavedChanges when switching between tabs and then sets it back after a successful tab change

* Keep sidebar nav item active for both tabs

* Add tests

Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
2021-04-14 15:34:46 -04:00