Currently we instantiate the Workplace Search app with server props passed in from the server on initial page load. This data includes the organization name. In our settings section, we poll the server to get update information, but once the data is change, the global state does not get updated on a route change. This is only a problem in the case where a user has changed their org name and returns to the overview page before reloading the page. When this happens, the onboarding step asking the user to change thier org name is still visible.
* Cherry-picking 7.12 find total fix
* Starting fix for total bug in master with new field
* Adding feature flag for sub cases
* Disabling case as a connector in security solution
* Adding additional tests for pagination
* Removing other api integration tests
* Fixing up problems from merge
* Fixing sub case tests and type errors
* Renaming comment tag for case connector
* Added sync_master file for tracking/triggering PRs for merging master into feature branch
* removed unnecessary (temporary) markdown file
* Trusted apps by policy api (#88025)
* Initial version of API for trusted apps per policy.
* Fixed compilation errors because of missing new property.
* Mapping from tags to policies and back. (No testing)
* Fixed compilation error after pulling in main.
* Fixed failing tests.
* Separated out the prefix in tag for policy reference into constant.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [SECURITY_SOLUTION][ENDPOINT] Ability to create a Trusted App as either Global or Policy Specific (#88707)
* Create form supports selecting policies or making Trusted app global
* New component `EffectedPolicySelect` - for selecting policies
* Enhanced `waitForAction()` test utility to provide a `validate()` option
* [SECURITY SOLUTION][ENDPOINT] UI for editing Trusted Application items (#89479)
* Add Edit button to TA card UI
* Support additional url params (`show`, `id`)
* Refactor TrustedAppForm to support Editing of an existing entry
* [SECURITY SOLUTION][ENDPOINT] API (`PUT`) for Trusted Apps Edit flow (#90333)
* New API route for Update (`PUT`)
* Connect UI to Update (PUT) API
* Add `version` to TrustedApp type and return it on the API responses
* Refactor - moved some public/server shared modules to top-level `common/*`
* [SECURITY SOLUTION][ENDPOINT] Trusted Apps API to retrieve a single Trusted App item (#90842)
* Get One Trusted App API - route, service, handler
* Adjust UI to call GET api to retrieve trusted app for edit
* Deleted ununsed trusted app types file
* Add UI handling of non-existing TA for edit or when id is missing in url
* [Security Solution][Endpoint] Multiple misc. updates/fixes for Edit Trusted Apps (#91656)
* correct trusted app schema to ensure `version` is not exposed on TS type for POST
* Added updated_by, updated_on properties to TrustedApp
* Refactored TA List view to fix bug where card was not updated on a successful edit
* Test cases for card interaction from the TA List view
* Change title of policy selection to `Assignment`
* Selectable Policy CSS adjustments based on UX feedback
* Fix failing server tests
* [Security Solution][Endpoint] Trusted Apps list API KQL filtering support (#92611)
* Fix bad merge from master
* Fix trusted apps generator
* Add `kuery` to the GET (list) Trusted Apps api
* Refactor schema with Put method after merging changes with master
* WIP: allow effectScope only when feature flag is enabled
* Fixes errors with non declared logger
* Uses experimental features module to allow or not effectScope on create/update trusted app schema
* Set default value for effectScope when feature flag is disabled
* Adds experimentals into redux store. Also creates hook to retrieve a feature flag value from state
* Hides effectPolicy when feature flag is not enabled
* Fixes unit test mocking hook and adds new test case
* Changes file extension for custom hook
* Adds new unit test for custom hook
* Hides horizontal bar with feature flag
* Compress text area depending on feature flag
* Fixes failing test because feature flag
* Fixes wrong import and unit test
* Thwrows error if invalid feature flag check
* Adds snapshoot checks with feature flag enabled/disabled
* Test snapshots
* Changes type name
* Add experimentalFeatures in app context
* Fixes type checks due AppContext changes
* Fixes test due changes on custom hook
Co-authored-by: Paul Tavares <paul.tavares@elastic.co>
Co-authored-by: Bohdan Tsymbala <bohdan.tsymbala@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
* [Maps] split out DrawFilterControl and DrawControl
* clean up
* update i18n id
* give 'global_index_pattern_management_all' permission to functional test because new check blocks access without it
* revert last change
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Maps] do not track total hits for elasticsearch search requests
* set track_total_hits for es_search_source tooltip fetch
* tslint
* searchSource doc updates, set track_total_hits in MVT requests
* revert changes made to searchsourcefields docs
* tslint
* review feedback
* tslint
* remove Hits (Total) from functional tests
* remove sleep in functional test
* tslint
* fix method name
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* updates the data used in the test
* adds matches test
* adds enrichment test
* improves speed and adds missing files
* fixes type check issue
* adds 'data-test-subj' for the json view tab
* refactor
* fixes typecheck issue
* updates tests with latest master changes
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Adding feature flag for sub cases
* Disabling case as a connector in security solution
* Fix connector test
* Switching feature flag to global variable
* Removing this.config use
* Fixing circular import and renaming flag
* Fix typo
This was mis-copied from ent-search
* No longer store preContentSourceId in query param
In ent-search, we had the Rails server redirect with this param. Now, it is contained in the server response as JSON and is persisted in the logic file
* Pass query params to SourceAdded component
The entire state is stored in query params now and must be passed when doing a manual redirect
* Redirect to config view if config needed
* Don’t redirect if the config has already been completed
This was really tricky and could use a refactor in the future, perhaps. The issue is that the persisted query params will contain the `preContentSourceId` even after the config has been completed. This caused the UI to attempt to navigate back to the config screen after it had been completed. This sets a prop once that has been completed and bypasses the redirect.
* Use correct key to determine if config needed
* Update tests
* Use client from branch
* Get type checking working in core
* Fix types in other plugins
* Update client types + remove type errors from core
* migrate Task Manager Elasticsearch typing from legacy library to client library
* use SortOrder instead o string in alerts
* Update client types + fix core type issues
* fix maps ts errors
* Update Lens types
* Convert Search Profiler body from a string to an object to conform to SearchRequest type.
* Fix SOT types
* Fix/mute Security/Spaces plugins type errors.
* Fix bootstrap types
* Fix painless_lab
* corrected es typing in Event Log
* Use new types from client for inferred search responses
* Latest type defs
* Integrate latest type defs for APM/UX
* fix core errors
* fix telemetry errors
* fix canvas errors
* fix data_enhanced errors
* fix event_log errors
* mute lens errors
* fix or mute maps errors
* fix reporting errors
* fix security errors
* mute errors in task_manager
* fix errors in telemetry_collection_xpack
* fix errors in data plugins
* fix errors in alerts
* mute errors in index_management
* fix task_manager errors
* mute or fix lens errors
* fix upgrade_assistant errors
* fix or mute errors in index_lifecycle_management
* fix discover errors
* fix core tests
* ML changes
* fix core type errors
* mute error in kbn-es-archiver
* fix error in data plugin
* fix error in telemetry plugin
* fix error in discover
* fix discover errors
* fix errors in task_manager
* fix security errors
* fix wrong conflict resolution
* address errors with upstream code
* update deps to the last commit
* remove outdated comments
* fix core errors
* fix errors after update
* adding more expect errors to ML
* pull the lastest changes
* fix core errors
* fix errors in infra plugin
* fix errors in uptime plugin
* fix errors in ml
* fix errors in xpack telemetry
* fix or mute errors in transform
* fix errors in upgrade assistant
* fix or mute fleet errors
* start fixing apm errors
* fix errors in osquery
* fix telemetry tests
* core cleanup
* fix asMutableArray imports
* cleanup
* data_enhanced cleanup
* cleanup events_log
* cleaup
* fix error in kbn-es-archiver
* fix errors in kbn-es-archiver
* fix errors in kbn-es-archiver
* fix ES typings for Hit
* fix SO
* fix actions plugin
* fix fleet
* fix maps
* fix stack_alerts
* fix eslint problems
* fix event_log unit tests
* fix failures in data_enhanced tests
* fix test failure in kbn-es-archiver
* fix test failures in index_pattern_management
* fixing ML test
* remove outdated comment in kbn-es-archiver
* fix error type in ml
* fix eslint errors in osquery plugin
* fix runtime error in infra plugin
* revert changes to event_log cluser exist check
* fix eslint error in osquery
* fixing ML endpoint argument types
* fx types
* Update api-extractor docs
* attempt fix for ese test
* Fix lint error
* Fix types for ts refs
* Fix data_enhanced unit test
* fix lens types
* generate docs
* Fix a number of type issues in monitoring and ml
* fix triggers_actions_ui
* Fix ILM functional test
* Put search.d.ts typings back
* fix data plugin
* Update typings in typings/elasticsearch
* Update snapshots
* mute errors in task_manager
* mute fleet errors
* lens. remove unnecessary ts-expect-errors
* fix errors in stack_alerts
* mute errors in osquery
* fix errors in security_solution
* fix errors in lists
* fix errors in cases
* mute errors in search_examples
* use KibanaClient to enforce promise-based API
* fix errors in test/ folder
* update comment
* fix errors in x-pack/test folder
* fix errors in ml plugin
* fix optional fields in ml api_integartoon tests
* fix another casting problem in ml tests
* fix another ml test failure
* fix fleet problem after conflict resolution
* rollback changes in security_solution. trying to fix test
* Update type for discover rows
* uncomment runtime_mappings as its outdated
* address comments from Wylie
* remove eslint error due to any
* mute error due to incompatibility
* Apply suggestions from code review
Co-authored-by: John Schulz <github.com@jfsiii.org>
* fix type error in lens tests
* Update x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts
Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
* Update x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.test.ts
Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
* update deps
* fix errors in core types
* fix errors for the new elastic/elasticsearch version
* remove unused type
* remove unnecessary manual type cast and put optional chaining back
* ML: mute Datafeed is missing indices_options
* Apply suggestions from code review
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
* use canary pacakge instead of git commit
Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Co-authored-by: Gidi Meir Morris <github@gidi.io>
Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
Co-authored-by: restrry <restrry@gmail.com>
Co-authored-by: James Gowdy <jgowdy@elastic.co>
Co-authored-by: John Schulz <github.com@jfsiii.org>
Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
* LogRetentionCallout - add ability check to API call
- on non-admin users, we're otherwise getting a forbidden error
- remove now-unnecessary canManageLogSettings wrapping check around the link CTA, since the entire callout is now essentially gated behind the check
* LogRententionTooltip - add ability check to API call
- on non-admin users, we're otherwise getting a forbidden error
- tests now require a ...values spread for myRole
* [MISC] Refactor previous isLogRetentionUpdating check in favor of a Kea breakpoint
- both dedupe calls for the commented use case, but breakpoint feels simpler & more Kea-y
* PR feedback: Increase breakpoint speed
* [Misc] Update trash icon color
- should be danger/red to match other tables in Kibana
* Engine table - fix incorrect conditional around when users can delete engines
- The check for that should be around Dev/Editor/Analyst roles, not around whether the account has a platinum license
- Tests - DRY out reset mock
- ideally would be in a beforeEach, but mount/beforeAll perf makes that difficult
* Create engine button - wrap with canManageEngines check
- prevents Dev/Editor/Analyst roles from hitting a 404 page
- test cleanup - use describe blocks to convey conditional branching, combine 2 tests into 1
* Empty engines prompt - add canManageEngines check
+ switch from FormattedMessage to i18n (this view was created a long time ago before we settled on generally preferring i18n)
+ provide a more helpful body text when the user cannot create engines
* Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/engines_overview.test.tsx
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
* Add force option to DELETE package endpoint.
* Add integration test.
* Adjust openapi spec.
* Run EPM tests before fleet setup tests.
* Run package delete tests first in EPM tests
* Pass filterQuery instead of filterQueryText to invertory alerts preview chart
* Add test to verify that filterQuery is sent to the expression chart
* Improve test description
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [ML] Adding additional runtime mapping checks
* adding functional test for datafeed preview
* renaming findFieldsInAgg
* updating query check
* always use runtime mappings if present in agg field exists check
* changes based on review
* updating tests based on review
* fixing permission check on endpoint and test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Move source added route to top-level index component
* Use state passed back from oAuth app to determine context
The previous tests weren’t actually using this state so they have been updated with actual state data for proper testing
* Remove validaition of ID property in route body
The ID is inferred from the param in the URL. This was fixed in the logic file but the server route was never updated
* Add RoleMappings component
- ROLE_MAPPINGS_TITLE was moved to a shared constant in an earlier PR
- Also removing redundant exports of interface
* Add RoleMapping component
- Also removing redundant export of interface from AppLogic
* Add RoleMappingsRouter
ROLE_MAPPINGS_TITLE was moved to a shared constant in an earlier PR
# Conflicts:
# x-pack/plugins/enterprise_search/public/applications/app_search/components/role_mappings/index.ts
* Add route and update link in navigation
* Remove unused translations
* Change casing
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Change casing
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Change casing
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Add ability test
* Refactor conditional constants
* Refactor role type constants
* Remove EuiPageContent
* Refactor action mocks
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Add data plugin to server app context
* First attempt at switching to indexPatternService for EPM index pattern creation & deletion, instead of interacting directly with index pattern SOs
* Simplify bulk install package, remove upgradePackage() method in favor of consolidating with installPackage(), use installPackage() for bulk install instead
* Update tests
* Change cache logging of objects to trace level
* Install index patterns as a post-package installation operation, for bulk package installation, install index pattern only if one or more packages are actually new installs, add debug logging
* Allow getAsSavedObjectBody to return non-scripted fields when allowNoIndex is true
* Allow `getFieldsForWildcard` to return fields saved on index pattern when allowNoIndices is true
* Bring back passing custom ID for index pattern SO
* Fix tests
* Revert "Merge branch 'index-pattern/allow-no-index' into epm/missing-index-patterns"
This reverts commit 8e712e9c00, reversing
changes made to af0fb0eaa8.
* Allow getAsSavedObjectBody to return non-scripted fields when allowNoIndex is true
(cherry picked from commit 69b93da180)
* Update API docs
* Run post-install ops for install by upload too
* Remove allowedInstallTypes param
* Adjust force install conditions
* Revert "Update API docs"
This reverts commit b9770fdc56.
* Revert "Allow getAsSavedObjectBody to return non-scripted fields when allowNoIndex is true"
This reverts commit afc91ce32f.
* Go back to using SO client for index patterns :(
* Stringify attributes again for SO client saving
* Fix condition for reinstall same pkg version
* Remove unused type
* Adjust comment
* Update snapshot
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Add anomalies table to flyout
* Fix type
* Update i18n
* use anomalyThreshold from configuration
* use EuiBasicTable and format date
* add actions menu
* update text
* change host/k8s toggle to EuiComboBox
* add open in inventory to actions
* add search functionality back
* debounce api call
* loading messaging
* change types, cleanup
* query with partition field instead of influencers to prevent long query ES server errors
* show text when no jobs enabled
* adjust date
* close flyout after clicking show in inventory
* fix callout
Co-authored-by: neptunian <sandra.gonzales@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Associate timeline filter/query/dataprovider to top-n for alerts events
* fix pinned view when opening details panel
* fix top-n to bring the right raw/all indices
* review + do not add filter/query/dataprovider on Correlation/Pinned tab for topN
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
A recent refactor of content source jobs models unintentionally
changed this API. This change restores the functionality of the
re-authentication "Fix" link.
* [TSVB] Integrates the color service
* Fix i18n failure
* Sync colors :)
* Fix unit tests
* Apply the multiple colors also for gauge
* Fix
* More unit tests
* Cleanup
* Be backwards compatible
* Fetch palettesService on vis renderer
* Fix eslint
* Fix jest test
* Fix color mapping for empty labels
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Adds hash validation on UI. Display as many error messages as they are instead of displaying just the first one on entry fields. Updates related unit test
* Fixes failing test and added new test case
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Added new setting (enableExperimental) to plugin configuration
* Remove plugin config setting `fleetServerEnabled` and use instead `enableExperimental`
* WIP: Use schema.conditional instead of schema.oneOf to ensure the right schema validation from an specific field type
* Adds some comments on new schema definition
* Use validate functions to set custom messages
* Fixes type issue after schema changes. An overwrite of the schema inferred type is needed to match with the NewTrustedApp custom type
* Updates schema test after schema changes
* Changes error key by type. Updates related unit test
* WIP: Parse BE message into an user friendly one. Waiting for final texts
* Updates text messages for create trusted app errors
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [ml] migrate file_data_visualizer/analyze_file to file_upload plugin
* tslint
* give analyze route access to ml user
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Set up curation search server route
- not really sure which API endpoint to use, hedging my bets
* Set up AddResultLogic
- fairly simple, mostly concerned with flyout behavior & search query
- could likely be reused (or replaced with??) query tester logic in the future
* Add main AddResultFlyout component
- with custom isPromoted / isHidden logic & actions
* Update AddResultButton to open flyout
* Update Curation page to render the flyout
* PR feedback: reset search query on flyout re-open
