Commit graph

20983 commits

Author SHA1 Message Date
Spencer 59206ec096
[kbn/es] add context to error message (#24664)
This just tweaks the kbn-es error message to provide more context than just `Not Found`
2018-10-26 16:57:08 -07:00
Catherine Liu 5df9747f5a
Fixed label position on progress elements (#24623) 2018-10-26 13:24:50 -07:00
Josh Dover b093fddee8
Don't throw errors in optimizer (#24660) 2018-10-26 14:02:32 -05:00
Jason Rhodes 3a2db6e38f
Polish 6.5 (#24556)
* Updates waterfall item design for timeline rows

* Adjusts span and tx flyouts and updates tooltips to EUI

* Heading size fixes and clean up

* Updates tooltip snapshots

* Review tweaks and snapshot updates

* Revert experiment :)

Co-Authored-By: jasonrhodes <jason.matthew.rhodes@gmail.com>

* Fixes bug with v1 waterfall state

* Fixes bug with timeline bar height

* Updates snapshot tests

* Updated test so it doesn't mount and rely on EUI makeId() which is non-deterministic per test run
2018-10-26 14:56:20 -04:00
Joe Fleming b8b0229fd6
Feat/expression threading (#24598)
Replaces https://github.com/elastic/kibana/pull/23301
Closes https://github.com/elastic/kibana/issues/23080

---

This is a minimal threading implementation for Canvas. There's still a lot to be done to make this concept great, but this is a start. 

What it does:
- Creates a server side abstraction on top of the interpreter
- Determines where to send the expression by checking the first function to be run
- Loads common functions in a separate worker thread on the server. 
- Routes to a single forked worker (thread), the main thread (server), or the browser (browser), in that order
- Defers back to the router when a function isn't found. Fails if the function isn't found in any of the above 3 environments
- Times out the worker if it takes too long, and respawns it as needed.
- Simplifies the error dialog to remove the stack. 

What is does not.:
- Round robin a pool of workers
- Queue. If one expression in the threaded env fails then anything sent to it in the meantime will fail. The upstream environment handles managing timeouts. I think this would only make sense todo with a pool.
- Client side. This doesn't implement web workers, but we could use roughly the same architecture. 
- Implement a specific, pluggable `worker` environment on the server. Right now it's just common functions, so plugin authors will always end up in a thread if they put their function in the common directory.

What I don't like:
- The socketProvider code. This was reused across the server & browser, but now that it's only used in the browser there's no good reason for the abstraction
- The serialize/deserialize stuff feels messy. Do we really need serialization?
2018-10-26 09:49:46 -07:00
Chris Roberson a0543b1aec
Skip this test until snapshots are updated (#24650) 2018-10-26 11:32:50 -04:00
spalger 214ccfcf5f [dev/build] fix invalid assertion 2018-10-26 08:22:40 -07:00
Court Ewing 6737725c18 [backport] add back earlier 6.x minor versions
We still backport to these branches, primarily for doc changes.
2018-10-26 11:05:30 -04:00
tibmt 039ced34f0 Translate global navigation bar component (#23993)
Translate global navigation bar component
2018-10-26 17:03:30 +03:00
Leanid Shutau a39238568a
[Tools] Forbid i18n filter usage outside of interpolation expressions (#23982)
* [I18n] Forbid i18n filter usage outside of interpolation expressions

* Add tests

* Add usage examples to JSDoc
2018-10-26 15:54:53 +03:00
Pete Harverson afbc9d7476
[ML] Hides File Data Vizualizer field name overrides if empty list (#24576) 2018-10-26 12:08:24 +01:00
Leanid Shutau 074556f79e
[I18n] Update locale objects format (#23917)
* Update output file format for i18n_check tool

* Update i18n engine to work with new format

* Update tests

* Fix UI bootstrap test

* Update loader tests and fix getTranslationsByLocale function

* Fix messages passing to IntlProvider

* Update messages interface

* Resolve comments

* Resolve comment
2018-10-26 13:35:48 +03:00
Aleh Zasypkin c8a09e3c65
TypeScriptify src/utils. (#23962) 2018-10-26 12:29:27 +02:00
Leanid Shutau 2534700e54
[I18n] Add pseudo-localization to i18n engine (#24130)
* [I18n] Add pseudo-localization to i18n engine

* Add pseudo-localization to React

* Remove lookbehind from regex

* Resolve comments

* Add comment
2018-10-26 12:25:45 +03:00
James Gowdy 47fb27f0a8
[ML] Fixing results for unknown fields (#24577)
* [Ml] Fixing results for known fields

* renaming known-type to unknown

* correcting comments

* tiny refactor
2018-10-26 11:13:26 +02:00
Maryia Lapata 41eabaa750
Remove unnecessary path in i18n config (#24476) 2018-10-26 09:35:29 +03:00
Maryia Lapata b7242ac8ff
[i18n] Fix typos in translations ids and messages (#24480)
* Fix typos in translations ids and messages

* Fix typos
2018-10-26 09:30:59 +03:00
Sébastien Loix 89d88553cf
typescript: convert utils/key_map (#23941) 2018-10-26 06:57:15 +02:00
Spencer 63d765e3a0
[backport] remove early 6.x minor versions 2018-10-25 15:10:05 -07:00
Spencer 52dae6be52
[uiSettings] only try to autoCreateOrUpgrade once (#24605)
## Summary

When tests override the `savedObjectsClient.get()` call to always return a 404 an out of memory error is triggered in the tests that's caused because `uiSettings._read()` is constantly trying to recover by running `createOrUpgradeSavedConfig()` and then retrying the `_read()`. Instead we should behave like `_write()` and only try to auto-recover on the first request, then call read with `_read({ ...options, autoCreateOrUpgradeIfMissing: false })` which will prevent the auto-recovery the second time and avoid the OOM.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2018-10-25 15:08:59 -07:00
Andrew Cholakian 133be4b16d
Fix windows instructions for uptime add data UI (#24587)
* Fix windows instructions for uptime add data

The windows instructions had three separate issues:

1. Redundant/unclear instruction to edit ES output settings removed
2. Incorrect invocation of the heartbeat binary without .\ prefix
3. Incorrect verbiage for modifying the `heartbeat.yml` file
2018-10-25 16:51:11 -05:00
Spencer 8f0bda74fd
[backport] add 6.5 branch 2018-10-25 14:33:42 -07:00
Clint Andrew Hall 795ee7e5d8
Update js_style_guide.md
We need to explicitly rule out using double-quotes to escape single quotes.  Consider looking into our lint/prettier ruleset for enforcement.
2018-10-25 16:27:36 -05:00
Catherine Liu 3b0cc4e886
Upgrades Tinymath (#24457)
* Bumped tinymath to v1.0.0

* Bumped tinymath version to 1.1.0
2018-10-25 14:18:15 -07:00
Catherine Liu f3dc3b6198
Fix: select field updates on change (#24288)
* Replace defaultValue with value

Added default value for size in text_style_picker

Made page_config select compressed

Added default values for props in appearance_form

Switched select to superselect in border_form

Refactored datacolumn

refactored simple_math_function

Fixed page_config

* Added an euispacer to border form
2018-10-25 14:12:14 -07:00
Josh Dover 27e5406d7a
Upgrade Hapi in legacy platform to v17 (#21707)
* Disable even-better monitoring

* Upgrade to Hapi v15

* Upgrade to Hapi v16

* Handle optional req params correctly

* Update http and kbnServer

* Get mocha tests passing

* Convert `reply` usages [wip]

* Fix Joi and Plugin incompatibilities

* Get server up and running

* Get basic logging working

* Fix optimizer

* Fix recent route handlers

* Various fixes

* Fix recent routes

* Upgrade wreck for async/await

* Fix mocha tests

* Fix joi issues

* Fix xpack jest tests

* Fix recent routes

* Fix tests

* Fix index setup

* Decouple monitoring stats collection from good plugin

* Update reload logging test to work

* Reimplement logging with updated good plugin

* Fix unit tests

* Fix getConnections back

* Make LegacyLoggingServer compatible with Hapi v17

* Update joi types

* Fix x-pack unit tests

* Remove stray debugger

* Remove hapi-compat

* Fix API integrations

* Upgrade boom

* Fix security plugin

* Misc fixes

* bump

* Fix licensePreRoutingFactory

* Fix failing integration tests

* Remove unnecessary test change

* Remove hapi-latest package

* fx

* Various cleanup

* Fix race condition in oppsy events

* Use elastic/good fork

* Fix boom.wrap and hapi-latest changes

* Simplify LegacyLoggingServer updates

* package.json cleanup + test fix

* yarn.lock cleanup

* Change good tag

* Fixes

* Change return err -> throw err in routes

* Fix await returns

* Fix new load_data test

* Make cookie security flags consistent

* tmp doc

* Fix types

* Fix tests

* Upgrade canvas plugin

* Move good package to published @elastic/good one

* Fix SO test

* Fix logging reloading

* Update APM apis

* Fix error logging

* Fix logging test

* Convert spaces plugin

* Add validation error shim

* Remove 7.0 release notes

* Await renderApp

* Fix ccr routes

* Prevent header popovers from scrolling with page content (#23850)

* Fix spaces test

* new yarn.lock-s

* Fix spaces tests

* Remove h2o2-latest

* Fix @types/hapi

* Upgrade InfraOps plugin

* Fix package.json

* Add back isSameSite: false

* Upgrade beats_management plugin

* Update snapshot

* Fix InfraOps

* Upgrade kql_telemetry

* Merge upstream/master

* Upgrade apm and ml

* Put snapshot test back

* Fx beats

* Upgrade rollups

* Update boom usages in new plugins
2018-10-25 16:01:12 -05:00
Alex Seriachenko ab776d4577 Fixes #23641 (#24197) 2018-10-25 12:44:38 -04:00
Chris Roberson af3e62131d
[Monitoring] Rename ccr fields based on changes in ES (#24519)
* Rename ccr fields based on changes in ES

* More renames

* Update archive data

* Update snapshot

* Skip the api integration tests for now
2018-10-25 12:30:58 -04:00
Lisa Cawley 62e92a223e
[DOCS] Fixes broken links to Stack Overview (#24592) 2018-10-25 09:16:40 -07:00
Lisa Cawley 055aa0a73e
[DOCS] Adds security for monitoring steps (#24052) 2018-10-25 08:12:03 -07:00
Felix Stürmer d3e61e6380
[InfraOps] Remove broken links to APM (#24568)
This removes the links from the waffle map to APM, which did not pass the correct filter in most cases.

fixes #24565 for now
2018-10-25 15:28:14 +02:00
Leanid Shutau 71d284469b
[Tools] Add "values" property validation (#22538)
* [Tools] Add "values" property validation

* Fix values validation

* Fix typo in values regex

* Fix whitespaces handling

* Fix curly braces in regex

* Fix missing/unused values differentiation

* Use intl-messageformat-parser for parsing values from defaultMessage
2018-10-25 14:09:23 +03:00
Luke Elmers 40c232b111 Preserve nested tables in table vis (#24377)
* Add legacy response handler for table vis.

The new legacy response handler introduced a regression in how nested
tables were handled within table vis. This adds a new table-specific
response handler to ensure splitting is preserved.

This is a short term solution and will be removed once we are able to
update table splitting to be consistent with other vis types.

* Ensure formatted dates are preserved in table titles.

* Update legacy table response handler based on feedback.

* Ensure AggConfigResult.rawData is preserved in legacy table response handler.

* Move legacy table response handler to core_plugins.

* Legacy table response handler - style cleanup.

* Remove unneeded aggConfigResult.rawData from legacy table response handler.

* Add basic unit tests for legacy table response handler.

* In table vis, exclude split columns when showing metrics at all levels.

* Add functional tests
2018-10-25 12:49:47 +02:00
Catherine Liu 567576a724 Fixes loading element icon color (#24551)
* Fixed loading element icon color

* Fixed package.json

* Fixed loading component test

* Revert "Fixed package.json"

This reverts commit 033fc8477d.
2018-10-25 12:00:40 +02:00
CJ Cenizal f74f633920
[Rollups] Rollup support in Kibana, phase 1 (#21117)
Enabled:
- View/Manage/Create rollup jobs

Disabled:
- Create a rollup index pattern
- Create rollup visualizations
- Add rollup visualizations to dashboards
- View raw rollup documents in Discover
2018-10-24 17:41:45 -07:00
Caroline Horn 75e283b8a1
Added temporary hotfix for flyouts not in portals (#24515)
…when the K7 header is turned on
2018-10-24 20:22:44 -04:00
Catherine Liu fb5b2291ba
Enable canvas functional tests (#24450) 2018-10-24 15:59:49 -07:00
Catherine Liu 3ce182c33c
Fixes shape element with NaN viewBox (#24470)
* Fixes shape viewbox calculations

* Fixed border

* Cleaned up viewbox calculations
2018-10-24 15:59:08 -07:00
Pete Harverson d9ffa07547
[ML] Edits to the text on the Data Visualizer landing pages (#24518) 2018-10-24 23:45:34 +01:00
Jake Landis a8f8ad246f console: update documentation links for ingest node (#24535) 2018-10-24 18:38:38 -04:00
Matt Bargar c5dd537ec6
Introduce query bar update button with dirty checking (#24529)
Reintroduced submit button removed in the react migration of the query bar. Added dirty state indications.
2018-10-24 18:05:40 -04:00
Josh Dover 3af1b2109f
Disable unused beats_management tests (#24543) 2018-10-24 16:57:14 -05:00
Catherine Liu 35c325230b
Switches to dashed border style (#24538) 2018-10-24 13:49:02 -07:00
Matt Bargar e690991861
Suggestion text needs to be a string (#24526)
* suggestion text needs to be a string

* deduplicate after calling toUser since a string and object version of
the same query could both exist in the persisted log, resulting in
identical strings after toUser runs

* don't put empty strings in the recent search history
2018-10-24 16:47:32 -04:00
Catherine Liu 21d8ec4b45
Clears timeout for done handler (#24471) 2018-10-24 13:14:35 -07:00
James Gowdy 3fed832c8e
[ML] Fix semi structured text last line issue (#24520) 2018-10-24 21:14:20 +01:00
Ryan Keairns 03d7294c47
[WIP] Adds 'upload data from file' to Kibana home page (#24226)
* adds upload file and functionbeat to home

* removes functionbeat, adds ml file upload href

* remove functionbeat callout, add ml file url

* fix tests for basepath

* less caveman sounding

* update code editor snapshot

* make link conditional, copy changes

* update ml link

* move mlEnabled to ml plugin

* copy edits
2018-10-24 14:10:57 -05:00
Tim Roes e94bf57899
Fix courier issues causing showMetricsOnAllLevels to break (#24488)
* Fix courier tabify caching issue

* Better code style

* Change to named lodash import

* Fix missing DSL parameters on hierarchical query

* Add functional test for hierarchical agg configs
2018-10-24 20:44:41 +02:00
Felix Stürmer 4077a1b8a4
[InfraOps] Add button to check again for log message if previously exhausted (#24500)
This PR adds a "load again" button to the exhaustion message in the log view.

fixes #23869
2018-10-24 19:22:11 +02:00
Caroline Horn d114a85d24
Remove wrapper around manage spaces button in menu (#24506)
Fixes #23544
2018-10-24 13:20:58 -04:00