Commit graph

34486 commits

Author SHA1 Message Date
Rudolf Meijering 59d3096e55
Test that savedObjectsTable exists AND isn't loading (#71207)
* Wait until savedObjectsTable exists AND isn't loading

* Use :not css selector

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 15:56:20 +02:00
Andrew Cholakian 5085b62c9c
[Uptime] Remove Scripted Metric Query (#69229)
Resolves #68096 , removing unnecessary scripted metric query from overview page and unifying the Check and Ping types.

This simplifies the types in a number of ways, and reduces the total quantity of code to execute the queries for the overview page. It also fixes the Tls and related types which were inconsistent and presented a problem here since they are used by this JS. There are now three stages where before there were four:

    Find potential matches: where we determine which monitor IDs are eligible for the overview page
    Refine potential matches: where we determine which ones actually match and return the summary documents for each location to build the MonitorSummary object
    Get monitor histograms: where we calculate the histograms for each monitor. In the future we might make this a separate API call.

This improves the overall code structure, and leaves the test coverage about the same depending on how you look at it. I think we can do more to improve the quality of code / tests here, but this seemed like a good initial place to draw the line for now.

In perfunctory testing on our internal observability clusters I saw perf improve from 2.5s to 1.1s on the Uptime homepage with no filters. So, it looks like there are potentially perf improvements (no real benchmarking was done).

Previously, this returned all pings from the latest check group. This was not actually used anywhere, only the summary pings are required for the current UI, so we now only return those from the list API as this saves a query.
2020-07-09 08:51:55 -05:00
Alison Goryachev d37b053f28
[Index Management] Fix broken app links (#71007) 2020-07-09 09:41:11 -04:00
Tim Roes cfbdf1f55e
Unskip data table non timebased test (#71049)
* Unskip data table non timebased test

* Fix test to use new label

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 15:08:51 +02:00
Nicolas Chaulet c8e675492b
[Ingest Manager] Fix and improve agent status (#71009) 2020-07-09 09:05:25 -04:00
Tiago Costa 237b2f66ed
skip flaky suite (#71216) 2020-07-09 13:59:00 +01:00
Matthias Wilhelm 216ef477ce
[Discover] Improve Discover histogram time range tests (#71056)
* Improve Discover histogram tests

* Use includes function to find a string

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 14:42:06 +02:00
Matthias Wilhelm d499b91a9b
[Discover] Improve saved queries reload functional test (#70957) 2020-07-09 14:41:29 +02:00
Oliver Gupte b302565567
[APM] Service maps anomaly detection integration by environment (#70932)
* Closes #69480 & #70419.
- Adds anomaly detection integration to service maps backed by apm ML jobs per environment
- Loads transaction stats and anomalies for each transaction types
- Renders a selector in the popop to choose a transaction type to view stats

* - implements original anomaly detection integration design for service maps popover
- only aggregates transaction KPIs and anomaly scores for transaction.type = "request" or "page-load"
- supports environment filter 'All' option to display data from all APM anomaly detection jobs
- handle case where popover metrics don't exist for services outside the current environment filter

* fixes some CI errors

* Simplified messaging for service popop with not data in the current environment

* PR feedback, renamed max anomalies -> service anomalies including the file name

* - defines custom_settings.job_tags.apm_ml_version in ML job creation,
  then filters for it when returing valid APM ML jobs

* changes shape of of service anomalies from an array to a object keyed by serviceName

* removes the url encoding from ML job link href to how it was previously.

* PR feedback

* Popover no data state simplified:
- renders the "no data" message as plain text instead of in a callout
- hides the 'Anomaly detection' section if there is not anomaly data.

* Fixes filtering bug when user selects 'Environment: Not defined'. Now
filters properly by filtering for docs where service.environment does
not exist

* filters jobs fetched in the settings page by `job.custom_settings.job_tags.apm_ml_version`

* Fixed bad import from last upstream merge

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 05:22:34 -07:00
Rudolf Meijering 77a97fc892
Disable fields added from unknown saved object types (#70951)
* Allow disabled: false SO field mappings

* Disable fields for unknown SO types

* Update everyone else's docs ;)

* Address review comments

* Add unit tests for disableUnknownTypeMappingFields()
2020-07-09 13:45:11 +02:00
Joe Reuter 269c62adef
mitigate kql bug (#70712)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 12:47:00 +02:00
Tiago Costa d9e84b6a3f
skip flaky suite (#71220) 2020-07-09 11:45:57 +01:00
Tiago Costa 101f8b1b6c
Merge remote-tracking branch 'upstream/master' 2020-07-09 11:38:50 +01:00
Thomas Heymann a285ede95a
Clone role button going to edit page (#70768)
* Clone role button going to edit page

* Added unit tests

* Fixed types
2020-07-09 10:13:35 +01:00
Marco Liberati dcb38201a5
Improve failure reporting output for functional tests (#70954)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 11:00:27 +02:00
Liza Katz 52b42a81fa
Allow creating filters from fields with null values in discover (#70936)
* Fix bug #7189

* typo

* Test adjustments

* wait for load complete

* Fine tune test

* Update src/plugins/data/public/query/filter_manager/lib/generate_filters.ts

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>

* Fix filtering by an array of nulls
Allow filtering by a non existing field in the doc
simplify flatten hit logic

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 11:58:22 +03:00
patrykkopycinski 822e6cf046
Fix path after renaming alerts to detections (#71202) 2020-07-09 10:37:08 +02:00
Uladzislau Lasitsa 6a8fdaa937
Migrated vislib tests to the NP (#70309)
* Migrated vislib tests to the NP

* fixed tests

* Fixed tests

* Fixed test
2020-07-09 11:23:14 +03:00
Søren Louv-Jansen 58cdbf0fe6
[APM] Add warning to notify user about legacy ML jobs (#71030) 2020-07-09 08:45:13 +02:00
MadameSheema 716d56e4d0
updates consumer to siem (#71117) 2020-07-09 07:45:10 +02:00
Matthew Kime 9a38b7ceef
Index pattern creation flow - fix spelling (#71192) 2020-07-09 00:04:48 -05:00
Madison Caldwell c3622e3d64
[Security Solution][Endpoint] User Manifest Cleanup + Artifact Compression (#70759)
* Stateless exception list translation with improved runtime checks

* use flatMap and reduce to simplify logic

* Update to new manifest format

* Fix test fixture SO data type

* Fix another test fixture data type

* Fix sha256 reference in artifact_client

* Refactor to remove usages of 'then' and tidy up a bit

* Zlib compression

* prefer byteLength to length

* Make ingestManager optional for security-solution startup

* Fix download functionality

* Use eql for deep equality check

* Fix base64 download bug

* Add test for artifact download

* Add more tests to ensure cached versions of artifacts are correct

* Convert to new format

* Deflate

* missed some refs

* partial fix to wrapper format

* update fixtures and integration test

* Fixing unit tests

* small bug fixes

* artifact and manifest versioning changes

* Remove access tag from download endpoint

* Adding decompression to integration test

* Removing tag from route

* add try/catch in ingest callback handler

* Fixing

* Removing last expect from unit test for tag

* type fixes

* Add compression type to manifest

* Reverting ingestManager back to being required for now

Co-authored-by: Alex Kahan <alexander.kahan@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 00:43:58 -04:00
Xavier Mouligneau f43f8b785b
[SECURITY] Rearrange rule name's column in Alert Table (#71020)
* Fix bug when you move columns rule name

* reference.url and event.url will be render as an anchor

* no need to fake index just return null
2020-07-09 00:00:33 -04:00
Xavier Mouligneau d5558cd4bf
[SECURITY] Alerts back to Detections (#71142)
* part I to rename alerts back to detections

* part 2 to rename alerts to detections

* update imports

* fix layout container event type

* Detection Alerts

* fix type/UT/cypress
2020-07-08 23:33:56 -04:00
Yara Tercero 8ad5ecef03
[Security Solution][Exceptions Builder] - Fixes operator selection bug (#71178)
### Summary

This PR fixes two bugs in the exceptions builder. The first was that it was not allowing you to select any of the "excluded" operators. The second was that it was not adding the "and" badge when it should on initial render. It also adds unit tests for the EntryItemComponent.
2020-07-08 22:30:35 -04:00
Frank Hassanabad 3863921616
[SIEM][Detection Engine] Speeds up value list imports by enabling streaming of files.
## Summary

* Changes the value list imports to use a streaming in model
* Adds a custom light hand spun multi-part parser for the incoming text
* Adds a buffer pause and resume which continues to buffer the incoming data if an async event such as creating a list from the attachment file needs to happen but does not emit the lines until the resume continues.
* Adds a data slicing if the buffer becomes larger than the maximum so that if we begin buffering too quickly within memory we don't blow up the limit of Elastic Search.
* Adds unit tests
 
### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-07-08 20:15:18 -06:00
Nathan L Smith 1f5a1fe66c
[APM] Update ML job ID in data telemetry tasks (#71044)
* [APM] Update ML job ID in data telemetry tasks

Use "apm-*" to match the new job IDs added in #70560.

* additional fix

* Remove unused import
2020-07-08 19:59:53 -05:00
Robert Austin a0b47cae85
[Resolver] Remove currentPanelView selector (#71154)
The `currentPanelView` selector returns a value that's out of sync
with the component that uses it.
2020-07-08 19:21:40 -04:00
Sandra Gonzales a8aee2cb8a
add meta.managed to index templates (#71135) 2020-07-08 18:49:38 -04:00
Lisa Cawley de6bb03855
Clarify trial subscription levels (#70900) 2020-07-08 15:15:55 -07:00
Robert Austin 17454e2227
[Security Solution] fix panel links (#71148)
panel.tsx was relying on `useHistory` to cause a rerender but it
doesn't. `useLocation` does.
2020-07-08 18:15:05 -04:00
spalger 43c6fbfddd skip flaky suite (#69632) 2020-07-08 14:50:23 -07:00
spalger aa1c0fe45e skip suite failing ES Promotion (#71018) 2020-07-08 14:43:09 -07:00
Melissa Alvarez b3bd7b1eb9
[ML] DF Analytics: add results field to wizard and show regression stats (#70893)
* add results_field input in form. handle in cloning and editor

* update regression evaluate metrics

* add additional reg evaluation stats to expanded row and result panel

* update jest test

* resultsField: check for only spaces string in editor and form

* update getValuesFromResult to be less repetitive

* update types

* fix type name typo
2020-07-08 17:34:16 -04:00
Angela Chuang 4cdb74f6fb
[SIEM] update wordings (#71119)
* update wordings

* remove redundant wordings
2020-07-08 22:29:39 +01:00
Candace Park 9b312b2ae6
[SECURITY SOLUTION] Rename to hosts and administration (#70913)
Security solution text changes to admin and hosts
2020-07-08 17:27:52 -04:00
Walter Rafelsberger 91377b2df8
[ML] Improvements for urlState hook. (#70576)
Makes two improvements to the urlState hook (also known as appState in some places):

- There was always a risk to run into a race condition because setUrlState could refer to a stale version of the state to act upon, for example if two calls were done in parallel. This is now fixed by using a local state copy of what we get from useLocation(). This allows us to use the callback version of useState's set function so we can make sure we always modify the latest state.
- Calls to history.push() are now gated by a check if the change actually referred to the corresponding instance of urlState (either _g or _a), this should reduce the updates resulting re-renders.

The two changes should make the use of setUrlState more safe against the pitfalls (race conditions/stale updates/lots of rerenders) we previously faced.
2020-07-08 22:58:46 +02:00
EamonnTP d431f93945
Removing uptime guide (#71124) 2020-07-08 21:20:51 +01:00
Spencer b6a06dfb61
Revert #64011 and subsequent fixes (#71137)
* Revert "temporarily disable firefox functional tests in PRs (#71116)"

This reverts commit 54bd07f81b.

* Revert "[savedObjects field count] run in baseline job (#70999)"

This reverts commit 53ee7a762d.

* Revert "[CI] Add pipeline task queue framework and merge workers into one (#64011)"

This reverts commit 465ed21194.

* Revert revert of change to jenkins_xpack_visual_regression.sh

Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-07-08 13:05:12 -07:00
Cauê Marcondes 203fde92ac
Observability overview page (#69141)
* creating overview page and menu

* styling the home page

* adjusting breadcrumb

* renaming isnt working

* renaming isnt working

* renaming isnt working

* fixing import

* fixing scroll when resize window

* fixing eslint errors

* prepending links

* adding target option

* refactoring

* adding dark mode support

* fixing prettier format

* fixing i18n

* reverting some unnecessary changes

* addressing PR comments

* fixing functional tests

* ordering observability menu

* fixing tests

* addressing PR comments

* fixing scroll

* addressing pr comments

* addressing pr comments

* creating overview page

* mocking data

* mocking data

* refactoring

* crearting apm chart

* adding overview page

* adding metric charts

* adding charts

* changing mock data location

* adding mock registry

* adding date picker

* adding route validation

* adding io-ts

* adding io-ts

* adding io-ts support

* fixing imports and mock data

* adding app folder

* creating a section for each plugin

* adding stats

* adding domain min max

* refactoring xcoordinaters

* fixing route

* adding bucket size

* adding group property on logs

* adding home page

* dont break page if location  state is undefined

* each component fetches its own data

* Refactoring

* adding loading indicator to chart

* fixing uptime chart

* adding brush functionality to charts

* fixing refresh button and auto refresh function

* adding horizontal line to accordion section

* adding emptySection to dashboard page

* adding add data button

* adding resources section

* removing margins from horizontal rule

* changing min interval to 60s

* fixing empty section

* removing unnecessary code

* adding unit tests

* fixing imports

* adding initial story book for observability

* removeing uptime mock data

* fixing xDomain to show correct data on x-axis

* fixing empty state alignment

* adding story book and other improvements

* adding news component

* adding support to custom colors on EuiProgress and EuiStats

* removing infra mock data

* adding error message when api throwns an error

* adding alert section

* Adding alerts

* adding alert api call

* addressing PR comments

* adding storybook

* adding feedback button

* addressing PR comments

* chamging plugins return data

* fixing kibana app navigation

* fixing unit test

* fixing ts issues

* addressing PR comments

* using lodash truncate

* adding comment

* updating public documentation

* fixing alerts request

* fixing unit test

* fixing unit test

* aligin beta badge to the center

* adding moment duration to get the units as seconds

* addressing PR comments

* addressing PR comments
2020-07-08 21:52:16 +02:00
Nicolas Chaulet 595e9c2d8d
[Ingest Manager] Fix agent config out of date display (#71103) 2020-07-08 14:08:53 -04:00
Jen Huang 90fb7a6c2d
[Ingest Manager] Show experimental packages by default (#70997)
* Add beta and experimental badges to epm list and detail pages; clean up some epm components

* Clean up styled warnings

* Fix types

* Allow experimental query param to be passed through to registry /search

* Allow experimental query param to be passed through to registry /categories endpoint

* Fix buggy categories count (#64981)

* Always enable experimental packages and categories

* Handle long package names nicely; misc layout tweaks

* Move experimental=true flag to client side

* Prevent layout jumps even more

* Adjust beta/experimental badge tooltip copy
2020-07-08 11:06:49 -07:00
Tre 43302bd0b6
[QA] stack integration tests (not run in ci) (#70904)
## Summary

Migrate tests from integration-test repo.

The integration-test repo's purpose is to smoke test the build artifacts of all the main products in the stack (the .deb, .rpm, .tar.gz, .zip files).  
Currently Vagrant and VirtualBox are used to create VMs of the OSs appropriate for installing those build artifacts.  These scripts are in the integration-test repo.
After the VMs are installed and running the stack, a small number of UI tests are run against Kibana to verify we have beats data, logstash data, etc.
Kibana-QA team also uses the various VMs for manual testing since manually setting up security across the full stack can be time consuming.

The new tests in this PR under x-pack/test/stack_functional_integration/ are NOT executed as part of Kibana CI process.  They run from other periodic Jenkins jobs.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: LeeDr <lee.drengenberg@elastic.co>
2020-07-08 11:54:03 -06:00
Spencer 54bd07f81b
temporarily disable firefox functional tests in PRs (#71116)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-07-08 10:41:09 -07:00
Dave Snider c815c96937
Multi-line kql bar (#70140)
* Multiline kql bar

* fix id

* use visibility rather than display to hide stuff, cross fingers for tests

* another vis trick for tests

* quasi fix tests, still some failures

* caroline feedback

* fun!

* fix for mouse

* fix test

* check api

* fix unit test on query_string_input

* Fix cypress test

* handle the resize of the height of the textarea when the window have been resize

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Liza K <liza.katz@elastic.co>
2020-07-08 13:01:00 -04:00
Alejandro Fernández Haro 93ac059cac
[Usage Collector] Fix schema types to allow arrays (#70988)
* [Usage Collector] Fix schema types to allow arrays

* More and better tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-08 17:30:58 +01:00
Melissa Alvarez 5326d2c614
[ML] DF Analytics functional tests: re-enable regression, classification, and outlier creation (#71006)
* update mml test. re-enable reg, class, and outlier creation tests

* remove unnecessary second argument
2020-07-08 12:14:42 -04:00
Pierre Gayvallet f044856038
Add new elasticsearch client (#69905)
* add "@elastic/elasticsearch" to dependencies

* first POC of new client

* add logging

* add generation script for client facade API and implementation

* add back keepAlive

* add exports from client

* add new client mocks

* add some doc

* fix API usages

* rename legacy client to legacy in service

* rename currently unused config/client observable

* wire new client to service & update mocks

* fix mock type

* export client types

* add transport.request

* more doc

* migrate version_check to new client

* fix default port logic

* rename legacy client mocks

* move legacy client mocks to legacy folder

* start adding tests

* add configure_client tests

* add get_client_facade tests

* bump client to 7.8

* add cluster_client tests

* expose new client on internal contract only

* revert using the new client for es version check

* add service level test for new client

* update generated API

* Revert "rename legacy client mocks"

This reverts commit e48f3ad6

* address some review comments

* revert ts-expect-error from unowned files

* move response mocks to mocks.ts

* Remove generated facade, use ES Client directly

* log queries even in case of error

* nits

* use direct properties instead of accessors

* handle async closing of client

* review nits

* ElasticSearchClient -> ElasticsearchClient

* add test for encoded querystring

* adapt test file
2020-07-08 17:21:00 +02:00
James Gowdy a86110488b
[ML] Fixing missing daily_model_snapshot_retention_after_days in job update schema (#71086) 2020-07-08 16:19:12 +01:00
Matthew Kime ea7012ebb1
Index Patterns Management - use /_resolve endpoint for data streams support (#70271)
* Index Patterns Management - use `/_resolve` endpoint for data streams support
2020-07-08 09:58:32 -05:00